dajac commented on a change in pull request #11170:
URL: https://github.com/apache/kafka/pull/11170#discussion_r692162163
##########
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##########
@@ -1755,6 +1765,78 @@ class ReplicaManager(val config: KafkaConfig,
partitionsToMakeFollower
}
+ private def updateTopicIdForFollowers(controllerId: Int,
Review comment:
Right. Reusing `makeFollowers` would not work out of the box.
I am not sure to follow your point regarding the possibility of overriding a
pending isr state. I thought that only the leader updates the isr state and the
followers only updates it via `updateAssignmentAndIsr` based on the controller
state. I might be missing something.
I am not against having `updateTopicIdForFollowers` but I wanted to ensure
that we have thought about all the options.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
