[GitHub] [kafka] showuon commented on pull request #10838: MINOR: small fix and clean up for DynamicConfigManager

showuon commented on pull request #10838: URL: https://github.com/apache/kafka/pull/10838#issuecomment-861238094 @fpj @Parth-Brahmbhatt @ijuma , please help review this small change PR. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [kafka] jlprat commented on pull request #10840: KAFKA-12849: KIP-744 TaskMetadata ThreadMetadata StreamsMetadata as API

jlprat commented on pull request #10840: URL: https://github.com/apache/kafka/pull/10840#issuecomment-861246389 Following Konstantine's recommendation on the mailing list in regards of the dates for the release of Kafka 3.0.0, I'm pinging again potential reviewers for this KIP's implementa

[GitHub] [kafka] dajac commented on a change in pull request #10858: KAFKA-12926: ConsumerGroupCommand's java.lang.NullPointerException at negative offsets while running kafka-consumer-groups.sh

dajac commented on a change in pull request #10858: URL: https://github.com/apache/kafka/pull/10858#discussion_r651515816 ## File path: core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala ## @@ -580,7 +581,8 @@ object ConsumerGroupCommand extends Logging { g

[GitHub] [kafka] showuon opened a new pull request #10884: MINOR: replace deprecated exactly_once_beta into exactly_once_v2

showuon opened a new pull request #10884: URL: https://github.com/apache/kafka/pull/10884 Follow up for https://github.com/apache/kafka/pull/10870, found out there are still some system tests using the deprecated `exactly_once_beta`. Update them. ### Committer Checklist (excluded fr

[GitHub] [kafka] showuon commented on a change in pull request #10884: MINOR: replace deprecated exactly_once_beta into exactly_once_v2

showuon commented on a change in pull request #10884: URL: https://github.com/apache/kafka/pull/10884#discussion_r651521106 ## File path: tests/kafkatest/tests/streams/streams_broker_compatibility_test.py ## @@ -114,23 +114,22 @@ def test_compatible_brokers_eos_alpha_enabled(se

[GitHub] [kafka] showuon commented on pull request #10884: MINOR: replace deprecated exactly_once_beta into exactly_once_v2

showuon commented on pull request #10884: URL: https://github.com/apache/kafka/pull/10884#issuecomment-861255370 @vvcephei , please help review this PR. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Assigned] (KAFKA-7302) Remove Java7 examples from Streams Docs

[ https://issues.apache.org/jira/browse/KAFKA-7302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-7302: -- Assignee: Vijay > Remove Java7 examples from Streams Docs > --

[jira] [Commented] (KAFKA-7302) Remove Java7 examples from Streams Docs

[ https://issues.apache.org/jira/browse/KAFKA-7302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363432#comment-17363432 ] Matthias J. Sax commented on KAFKA-7302: Add you to the list of contributors. You

[GitHub] [kafka] mjsax commented on a change in pull request #10877: KAFKA-12925: adding presfixScan operation for missed implementations

mjsax commented on a change in pull request #10877: URL: https://github.com/apache/kafka/pull/10877#discussion_r651526170 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/InMemoryKeyValueStore.java ## @@ -106,6 +108,8 @@ public void putAll(final Lis

[GitHub] [kafka] mjsax commented on a change in pull request #10877: KAFKA-12925: adding presfixScan operation for missed implementations

mjsax commented on a change in pull request #10877: URL: https://github.com/apache/kafka/pull/10877#discussion_r651526827 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/MemoryNavigableLRUCache.java ## @@ -66,6 +68,22 @@ public MemoryNavigableLRUCa

[GitHub] [kafka] mjsax commented on a change in pull request #10877: KAFKA-12925: adding presfixScan operation for missed implementations

mjsax commented on a change in pull request #10877: URL: https://github.com/apache/kafka/pull/10877#discussion_r651526827 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/MemoryNavigableLRUCache.java ## @@ -66,6 +68,22 @@ public MemoryNavigableLRUCa

[GitHub] [kafka] kowshik commented on a change in pull request #10733: KAFKA-12816 Added tiered storage related configs including remote log manager configs.

kowshik commented on a change in pull request #10733: URL: https://github.com/apache/kafka/pull/10733#discussion_r651532102 ## File path: core/src/main/scala/kafka/log/LogConfig.scala ## @@ -301,6 +350,16 @@ object LogConfig { FollowerReplicationThrottledReplicasDoc,

[GitHub] [kafka] kowshik commented on a change in pull request #10733: KAFKA-12816 Added tiered storage related configs including remote log manager configs.

kowshik commented on a change in pull request #10733: URL: https://github.com/apache/kafka/pull/10733#discussion_r651522821 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java ## @@ -0,0 +1,350 @@ +/* + * Licensed to the A

[GitHub] [kafka] dajac commented on pull request #10879: MINOR: Fix unsafe access to `AbstractCoordinator.state`

dajac commented on pull request #10879: URL: https://github.com/apache/kafka/pull/10879#issuecomment-861269486 @ableegoldman Good point. I have fixed those as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Updated] (KAFKA-12943) Bug in Kafka Streams Documentation (Aggregating)

[ https://issues.apache.org/jira/browse/KAFKA-12943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-12943: Component/s: streams documentation > Bug in Kafka Streams Documentation (

[jira] [Commented] (KAFKA-12943) Bug in Kafka Streams Documentation (Aggregating)

[ https://issues.apache.org/jira/browse/KAFKA-12943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363441#comment-17363441 ] Josep Prat commented on KAFKA-12943: There is a PR for this already: https://github.

[jira] [Assigned] (KAFKA-12943) Bug in Kafka Streams Documentation (Aggregating)

[ https://issues.apache.org/jira/browse/KAFKA-12943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josep Prat reassigned KAFKA-12943: -- Assignee: Josep Prat Submitted a patch a while ago: https://github.com/apache/kafka/pull/1076

[jira] [Issue Comment Deleted] (KAFKA-12943) Bug in Kafka Streams Documentation (Aggregating)

[ https://issues.apache.org/jira/browse/KAFKA-12943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josep Prat updated KAFKA-12943: --- Comment: was deleted (was: There is a PR for this already: https://github.com/apache/kafka/pull/107

[jira] [Assigned] (KAFKA-12943) Bug in Kafka Streams Documentation (Aggregating)

[ https://issues.apache.org/jira/browse/KAFKA-12943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josep Prat reassigned KAFKA-12943: -- Assignee: (was: Josep Prat) > Bug in Kafka Streams Documentation (Aggregating) >

[GitHub] [kafka] mjsax merged pull request #10846: KAFKA-12914: StreamSourceNode should return `null` topic name for pattern subscription

mjsax merged pull request #10846: URL: https://github.com/apache/kafka/pull/10846 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[GitHub] [kafka] erdody commented on a change in pull request #10822: KAFKA-4793: Connect API to restart connector and tasks (KIP-745)

erdody commented on a change in pull request #10822: URL: https://github.com/apache/kafka/pull/10822#discussion_r651509086 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java ## @@ -193,8 +194,8 @@ private short

[GitHub] [kafka] mjsax commented on pull request #10846: KAFKA-12914: StreamSourceNode should return `null` topic name for pattern subscription

mjsax commented on pull request #10846: URL: https://github.com/apache/kafka/pull/10846#issuecomment-861288799 Merged to `trunk` and cherry-picked to `2.8` branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [kafka] rajinisivaram commented on pull request #10882: KAFKA-12948: Remove node from ClusterConnectionStates.connectingNodes when node is removed

rajinisivaram commented on pull request #10882: URL: https://github.com/apache/kafka/pull/10882#issuecomment-861288998 @dajac Thanks for the review. Test failures not related, merging to trunk, 2.8 and 2.7. -- This is an automated message from the Apache Git Service. To respond to the me

[jira] [Updated] (KAFKA-12914) StreamSourceNode.toString() throws with StreamsBuilder.stream(Pattern) ctor

[ https://issues.apache.org/jira/browse/KAFKA-12914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-12914: Fix Version/s: 2.8.1 > StreamSourceNode.toString() throws with StreamsBuilder.stream(Patte

[GitHub] [kafka] rajinisivaram merged pull request #10882: KAFKA-12948: Remove node from ClusterConnectionStates.connectingNodes when node is removed

rajinisivaram merged pull request #10882: URL: https://github.com/apache/kafka/pull/10882 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Created] (KAFKA-12950) Replace EasyMock and PowerMock with Mockito for KafkaStreamsTest

Josep Prat created KAFKA-12950: -- Summary: Replace EasyMock and PowerMock with Mockito for KafkaStreamsTest Key: KAFKA-12950 URL: https://issues.apache.org/jira/browse/KAFKA-12950 Project: Kafka

[jira] [Assigned] (KAFKA-12950) Replace EasyMock and PowerMock with Mockito for KafkaStreamsTest

[ https://issues.apache.org/jira/browse/KAFKA-12950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josep Prat reassigned KAFKA-12950: -- Assignee: Josep Prat > Replace EasyMock and PowerMock with Mockito for KafkaStreamsTest > ---

[GitHub] [kafka] satishd commented on a change in pull request #10733: KAFKA-12816 Added tiered storage related configs including remote log manager configs.

satishd commented on a change in pull request #10733: URL: https://github.com/apache/kafka/pull/10733#discussion_r651575550 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java ## @@ -0,0 +1,350 @@ +/* + * Licensed to the A

[GitHub] [kafka] satishd commented on a change in pull request #10733: KAFKA-12816 Added tiered storage related configs including remote log manager configs.

satishd commented on a change in pull request #10733: URL: https://github.com/apache/kafka/pull/10733#discussion_r651576585 ## File path: core/src/main/scala/kafka/log/LogConfig.scala ## @@ -301,6 +350,16 @@ object LogConfig { FollowerReplicationThrottledReplicasDoc,

[jira] [Commented] (KAFKA-12914) StreamSourceNode.toString() throws with StreamsBuilder.stream(Pattern) ctor

[ https://issues.apache.org/jira/browse/KAFKA-12914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363489#comment-17363489 ] Will Bartlett commented on KAFKA-12914: --- Thanks for the quick turnaround! > Strea

[jira] [Resolved] (KAFKA-12948) NetworkClient.close(node) with node in connecting state makes NetworkClient unusable

[ https://issues.apache.org/jira/browse/KAFKA-12948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajini Sivaram resolved KAFKA-12948. Fix Version/s: 3.0.0 Reviewer: David Jacot Resolution: Fixed > NetworkClie

[jira] [Commented] (KAFKA-12948) NetworkClient.close(node) with node in connecting state makes NetworkClient unusable

[ https://issues.apache.org/jira/browse/KAFKA-12948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363490#comment-17363490 ] Rajini Sivaram commented on KAFKA-12948: Yes, it was due to the changes from [h

[jira] [Commented] (KAFKA-12946) __consumer_offsets topic with very big partitions

[ https://issues.apache.org/jira/browse/KAFKA-12946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363496#comment-17363496 ] Ron Dagostino commented on KAFKA-12946: --- I mean if you take a look at the size on

[jira] [Commented] (KAFKA-12635) Mirrormaker 2 offset sync is incorrect if the target partition is empty

[ https://issues.apache.org/jira/browse/KAFKA-12635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363502#comment-17363502 ] Alexis Polyzos commented on KAFKA-12635: [~ryannedolan] [~mimaison] Hey there, s

[jira] [Commented] (KAFKA-12635) Mirrormaker 2 offset sync is incorrect if the target partition is empty

[ https://issues.apache.org/jira/browse/KAFKA-12635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363515#comment-17363515 ] Mickael Maison commented on KAFKA-12635: [~dragotic] Sorry for the delay. I've p

[jira] [Commented] (KAFKA-12635) Mirrormaker 2 offset sync is incorrect if the target partition is empty

[ https://issues.apache.org/jira/browse/KAFKA-12635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363520#comment-17363520 ] Alexis Polyzos commented on KAFKA-12635: [~mimaison] No worries, I can totally u

[jira] [Commented] (KAFKA-12946) __consumer_offsets topic with very big partitions

[ https://issues.apache.org/jira/browse/KAFKA-12946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363522#comment-17363522 ] Emi commented on KAFKA-12946: - [~rndgstn] Interesting, it could be a solution that I am goin

[jira] [Comment Edited] (KAFKA-12946) __consumer_offsets topic with very big partitions

[ https://issues.apache.org/jira/browse/KAFKA-12946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363522#comment-17363522 ] Emi edited comment on KAFKA-12946 at 6/15/21, 10:21 AM: [~rndgst

[jira] [Commented] (KAFKA-12946) __consumer_offsets topic with very big partitions

[ https://issues.apache.org/jira/browse/KAFKA-12946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363584#comment-17363584 ] Ron Dagostino commented on KAFKA-12946: --- Yeah, there are bugs. The KIP I referred

[GitHub] [kafka] dajac commented on a change in pull request #10863: KAFKA-12890; Consumer group stuck in `CompletingRebalance`

dajac commented on a change in pull request #10863: URL: https://github.com/apache/kafka/pull/10863#discussion_r651728393 ## File path: core/src/main/scala/kafka/coordinator/group/DelayedSync.scala ## @@ -0,0 +1,48 @@ +/** + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [kafka] dajac commented on a change in pull request #10863: KAFKA-12890; Consumer group stuck in `CompletingRebalance`

dajac commented on a change in pull request #10863: URL: https://github.com/apache/kafka/pull/10863#discussion_r651729938 ## File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala ## @@ -1450,12 +1457,89 @@ class GroupCoordinator(val brokerId: Int,

[jira] [Assigned] (KAFKA-12950) Replace EasyMock and PowerMock with Mockito for KafkaStreamsTest

[ https://issues.apache.org/jira/browse/KAFKA-12950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josep Prat reassigned KAFKA-12950: -- Assignee: (was: Josep Prat) > Replace EasyMock and PowerMock with Mockito for KafkaStream

[jira] [Commented] (KAFKA-12950) Replace EasyMock and PowerMock with Mockito for KafkaStreamsTest

[ https://issues.apache.org/jira/browse/KAFKA-12950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363609#comment-17363609 ] Josep Prat commented on KAFKA-12950: I took a look at this for a while. Unfortunatel

[GitHub] [kafka] ijuma commented on a change in pull request #10838: MINOR: small fix and clean up for DynamicConfigManager

ijuma commented on a change in pull request #10838: URL: https://github.com/apache/kafka/pull/10838#discussion_r651760535 ## File path: core/src/main/scala/kafka/server/DynamicConfigManager.scala ## @@ -154,7 +156,7 @@ class DynamicConfigManager(private val zkClient: KafkaZkCl

[GitHub] [kafka] ijuma commented on pull request #10881: KAFKA-12947 Replace EasyMock and PowerMock with Mockito for StreamsMe…

ijuma commented on pull request #10881: URL: https://github.com/apache/kafka/pull/10881#issuecomment-861474114 Thanks for the PR. Can we please update https://github.com/apache/kafka/blob/trunk/build.gradle#L374 as well? -- This is an automated message from the Apache Git Service. To res

[GitHub] [kafka] dajac commented on a change in pull request #10863: KAFKA-12890; Consumer group stuck in `CompletingRebalance`

dajac commented on a change in pull request #10863: URL: https://github.com/apache/kafka/pull/10863#discussion_r651765967 ## File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala ## @@ -1450,12 +1457,89 @@ class GroupCoordinator(val brokerId: Int,

[jira] [Commented] (KAFKA-12946) __consumer_offsets topic with very big partitions

[ https://issues.apache.org/jira/browse/KAFKA-12946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363622#comment-17363622 ] Emi commented on KAFKA-12946: - Ok :) I found other possible solutions, for example: - increa

[GitHub] [kafka] IgnacioAcunaF commented on a change in pull request #10858: KAFKA-12926: ConsumerGroupCommand's java.lang.NullPointerException at negative offsets while running kafka-consumer-groups.

IgnacioAcunaF commented on a change in pull request #10858: URL: https://github.com/apache/kafka/pull/10858#discussion_r651770604 ## File path: core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala ## @@ -580,7 +581,8 @@ object ConsumerGroupCommand extends Logging {

[GitHub] [kafka] IgnacioAcunaF commented on a change in pull request #10858: KAFKA-12926: ConsumerGroupCommand's java.lang.NullPointerException at negative offsets while running kafka-consumer-groups.

IgnacioAcunaF commented on a change in pull request #10858: URL: https://github.com/apache/kafka/pull/10858#discussion_r651772882 ## File path: core/src/test/scala/unit/kafka/admin/ConsumerGroupServiceTest.scala ## @@ -106,7 +106,8 @@ class ConsumerGroupServiceTest { }

[GitHub] [kafka] ijuma merged pull request #10584: KAFKA-12701: NPE in MetadataRequest when using topic IDs

ijuma merged pull request #10584: URL: https://github.com/apache/kafka/pull/10584 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[GitHub] [kafka] dajac commented on pull request #10878: KAFKA-12898; Owned partitions in the subscription must be sorted

dajac commented on pull request #10878: URL: https://github.com/apache/kafka/pull/10878#issuecomment-861490213 @ableegoldman Thanks for your comments. I have updated the PR and fixed the tests. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] ijuma commented on pull request #10584: KAFKA-12701: NPE in MetadataRequest when using topic IDs

ijuma commented on pull request #10584: URL: https://github.com/apache/kafka/pull/10584#issuecomment-861498743 @jolshan The test needs to be adjusted for 2.8. Can you please look into that? I started on it, but it also needs to handle the fact that an exception is thrown from the handleTop

[GitHub] [kafka] IgnacioAcunaF commented on pull request #10858: KAFKA-12926: ConsumerGroupCommand's java.lang.NullPointerException at negative offsets while running kafka-consumer-groups.sh

IgnacioAcunaF commented on pull request #10858: URL: https://github.com/apache/kafka/pull/10858#issuecomment-861504636 Thanks @dajac for your review and comments. Just pushed an update with them on consideration. What do you think? Agree, there could be more potentially cases leadi

[GitHub] [kafka] showuon commented on a change in pull request #10838: MINOR: small fix and clean up for DynamicConfigManager

showuon commented on a change in pull request #10838: URL: https://github.com/apache/kafka/pull/10838#discussion_r651801212 ## File path: core/src/main/scala/kafka/server/DynamicConfigManager.scala ## @@ -154,7 +156,7 @@ class DynamicConfigManager(private val zkClient: KafkaZk

[GitHub] [kafka] ijuma commented on a change in pull request #10872: KAFKA-12945: Remove port, host.name and related configs in 3.0

ijuma commented on a change in pull request #10872: URL: https://github.com/apache/kafka/pull/10872#discussion_r651803100 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/utils/EmbeddedKafkaCluster.java ## @@ -88,20 +88,20 @@ public void start() throws

[GitHub] [kafka] ijuma commented on pull request #10811: KAFKA-12598: remove zookeeper support on configCommand except security config

ijuma commented on pull request #10811: URL: https://github.com/apache/kafka/pull/10811#issuecomment-861513235 @showuon I'll take a look this week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [kafka] lbradstreet commented on a change in pull request #10754: KAFKA-12835: Topic IDs can mismatch on brokers (after interbroker protocol version update)

lbradstreet commented on a change in pull request #10754: URL: https://github.com/apache/kafka/pull/10754#discussion_r651818541 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -1658,10 +1658,21 @@ class KafkaController(val config: KafkaConfig,

[GitHub] [kafka] lbradstreet commented on a change in pull request #10754: KAFKA-12835: Topic IDs can mismatch on brokers (after interbroker protocol version update)

lbradstreet commented on a change in pull request #10754: URL: https://github.com/apache/kafka/pull/10754#discussion_r651822091 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -337,6 +337,9 @@ class Log(@volatile private var _dir: File, } } else if (ke

[jira] [Resolved] (KAFKA-12266) KIP-500: Add the Broker Lifecycle Manager

[ https://issues.apache.org/jira/browse/KAFKA-12266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe resolved KAFKA-12266. -- Fix Version/s: 2.8.0 Resolution: Fixed We did this in 2.8. > KIP-500: Add the Broker L

[jira] [Assigned] (KAFKA-12439) When in KIP-500 mode, we should be able to assign new partitions to nodes that are fenced

[ https://issues.apache.org/jira/browse/KAFKA-12439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe reassigned KAFKA-12439: Assignee: Colin McCabe > When in KIP-500 mode, we should be able to assign new partitions

[jira] [Resolved] (KAFKA-12439) When in KIP-500 mode, we should be able to assign new partitions to nodes that are fenced

[ https://issues.apache.org/jira/browse/KAFKA-12439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe resolved KAFKA-12439. -- Fix Version/s: 3.0.0 Resolution: Fixed Implemented in 3.0. > When in KIP-500 mode, we

[jira] [Resolved] (KAFKA-6598) Kafka to support using ETCD beside Zookeeper

[ https://issues.apache.org/jira/browse/KAFKA-6598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe resolved KAFKA-6598. - Resolution: Won't Fix We're moving to self-managed metadata, so etcd will not be needed. > Kafka

[jira] [Commented] (KAFKA-10206) Admin can transiently return incorrect results about topics

[ https://issues.apache.org/jira/browse/KAFKA-10206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363675#comment-17363675 ] Colin McCabe commented on KAFKA-10206: -- This is fixed in KRaft mode, since the brok

[jira] [Commented] (KAFKA-12423) Consider which log configs should be overridable for the metadata topic

[ https://issues.apache.org/jira/browse/KAFKA-12423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363676#comment-17363676 ] Colin McCabe commented on KAFKA-12423: -- cc [~mumrah] > Consider which log configs

[jira] [Assigned] (KAFKA-12423) Consider which log configs should be overridable for the metadata topic

[ https://issues.apache.org/jira/browse/KAFKA-12423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe reassigned KAFKA-12423: Assignee: David Arthur > Consider which log configs should be overridable for the metadat

[GitHub] [kafka] cmccabe commented on pull request #9809: KAFKA-10898: Support snakeCaseName in JsonConverterGenerator

cmccabe commented on pull request #9809: URL: https://github.com/apache/kafka/pull/9809#issuecomment-861545466 Hmm... Isn't it better just to standardize on one thing? Camel case seems fine for the message format JSON files. -- This is an automated message from the Apache Git Service. To

[jira] [Commented] (KAFKA-10898) Support snakeCaseName/camelCaseName JSON field name in JsonConverterGenerator

[ https://issues.apache.org/jira/browse/KAFKA-10898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363678#comment-17363678 ] Colin McCabe commented on KAFKA-10898: -- Hmm... Isn't it better just to standardize

[jira] [Resolved] (KAFKA-12349) Follow up on PartitionEpoch in KIP-500

[ https://issues.apache.org/jira/browse/KAFKA-12349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe resolved KAFKA-12349. -- Fix Version/s: 3.0.0 Assignee: Jose Armando Garcia Sancio (was: Jason Gustafson)

[jira] [Commented] (KAFKA-12355) Consider inter-broker authentication error handling

[ https://issues.apache.org/jira/browse/KAFKA-12355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363679#comment-17363679 ] Colin McCabe commented on KAFKA-12355: -- If the KRaft broker can't register itself w

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10822: KAFKA-4793: Connect API to restart connector and tasks (KIP-745)

kpatelatwork commented on a change in pull request #10822: URL: https://github.com/apache/kafka/pull/10822#discussion_r651852657 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java ## @@ -193,8 +194,8 @@ private

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10822: KAFKA-4793: Connect API to restart connector and tasks (KIP-745)

kpatelatwork commented on a change in pull request #10822: URL: https://github.com/apache/kafka/pull/10822#discussion_r651854001 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java ## @@ -1063,6 +1076,104 @@ public in

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10822: KAFKA-4793: Connect API to restart connector and tasks (KIP-745)

kpatelatwork commented on a change in pull request #10822: URL: https://github.com/apache/kafka/pull/10822#discussion_r651854001 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java ## @@ -1063,6 +1076,104 @@ public in

[GitHub] [kafka] dajac commented on a change in pull request #10760: KAFKA-12541 Extend ListOffset to fetch offset with max timestamp

dajac commented on a change in pull request #10760: URL: https://github.com/apache/kafka/pull/10760#discussion_r651831839 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -4298,6 +4314,18 @@ void handleFailure(Throwable throwable)

[jira] [Created] (KAFKA-12951) Infinite loop while restoring a GlobalKTable

Damien Gasparina created KAFKA-12951: Summary: Infinite loop while restoring a GlobalKTable Key: KAFKA-12951 URL: https://issues.apache.org/jira/browse/KAFKA-12951 Project: Kafka Issue Ty

[jira] [Updated] (KAFKA-12951) Infinite loop while restoring a GlobalKTable

[ https://issues.apache.org/jira/browse/KAFKA-12951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Damien Gasparina updated KAFKA-12951: - Description: We encountered an issue a few time in some of our Kafka Streams application

[GitHub] [kafka] dajac commented on pull request #10863: KAFKA-12890; Consumer group stuck in `CompletingRebalance`

dajac commented on pull request #10863: URL: https://github.com/apache/kafka/pull/10863#issuecomment-861594180 @hachikuji Thanks for your comments. I have addressed them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [kafka] dajac commented on a change in pull request #10858: KAFKA-12926: ConsumerGroupCommand's java.lang.NullPointerException at negative offsets while running kafka-consumer-groups.sh

dajac commented on a change in pull request #10858: URL: https://github.com/apache/kafka/pull/10858#discussion_r651903223 ## File path: core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala ## @@ -560,14 +560,16 @@ object ConsumerGroupCommand extends Logging { val g

[jira] [Updated] (KAFKA-12951) Infinite loop while restoring a GlobalKTable

[ https://issues.apache.org/jira/browse/KAFKA-12951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Damien Gasparina updated KAFKA-12951: - Description: We encountered an issue a few time in some of our Kafka Streams application

[GitHub] [kafka] jsancio commented on a change in pull request #10883: KAFKA-12949: TestRaftServer's scala.MatchError: null on test-kraft-server-start.sh

jsancio commented on a change in pull request #10883: URL: https://github.com/apache/kafka/pull/10883#discussion_r651929028 ## File path: core/src/main/scala/kafka/tools/TestRaftServer.scala ## @@ -238,6 +238,8 @@ class TestRaftServer( reader.close() case

[GitHub] [kafka] wycccccc commented on pull request #10881: KAFKA-12947 Replace EasyMock and PowerMock with Mockito for StreamsMe…

wycc commented on pull request #10881: URL: https://github.com/apache/kafka/pull/10881#issuecomment-861635281 @ijuma Thanks for the hint，have updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka] junrao commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

junrao commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r651939380 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -239,12 +245,22 @@ class FetchSession(val id: Int, // Update the cached partition

[GitHub] [kafka] dajac commented on pull request #10872: KAFKA-12945: Remove port, host.name and related configs in 3.0

dajac commented on pull request #10872: URL: https://github.com/apache/kafka/pull/10872#issuecomment-861653253 @ijuma Overall, the PR LGTM. There are few connect related failed tests in the last Jenkins run. This is suspicious... I haven't had the time to really investigate them though.

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r651969184 ## File path: core/src/main/scala/kafka/server/ReplicaFetcherThread.scala ## @@ -216,12 +217,21 @@ class ReplicaFetcherThread(name: String, try {

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r651970044 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -239,12 +245,22 @@ class FetchSession(val id: Int, // Update the cached partition

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r651971564 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -73,6 +77,22 @@ public FetchSessionHandler(LogContext logContex

[jira] [Created] (KAFKA-12952) Metadata Snapshot File Header

Niket Goel created KAFKA-12952: -- Summary: Metadata Snapshot File Header Key: KAFKA-12952 URL: https://issues.apache.org/jira/browse/KAFKA-12952 Project: Kafka Issue Type: Sub-task Comp

[GitHub] [kafka] junrao commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

junrao commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r651976677 ## File path: clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java ## @@ -73,6 +77,22 @@ public FetchSessionHandler(LogContext logContext

[GitHub] [kafka] junrao commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

junrao commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r651977071 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -239,12 +245,22 @@ class FetchSession(val id: Int, // Update the cached partition

[GitHub] [kafka] ijuma commented on pull request #10872: KAFKA-12945: Remove port, host.name and related configs in 3.0

ijuma commented on pull request #10872: URL: https://github.com/apache/kafka/pull/10872#issuecomment-861667531 @dajac Most of them pass locally, I am re-running and will investigate more the ones that are not flaky. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] jolshan opened a new pull request #10885: KAFKA-12701: NPE in MetadataRequest when using topic IDs

jolshan opened a new pull request #10885: URL: https://github.com/apache/kafka/pull/10885 cherry-pick of c16711cb8e0d1c03f123e3e9d7e3d810796bf315 Updated KafkaApisTest to use 2.8 code. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation

[GitHub] [kafka] jolshan commented on pull request #10584: KAFKA-12701: NPE in MetadataRequest when using topic IDs

jolshan commented on pull request #10584: URL: https://github.com/apache/kafka/pull/10584#issuecomment-861667736 I didn't see a branch or PR with the 2.8 version, so I opened my own here: https://github.com/apache/kafka/pull/10885 -- This is an automated message from the Apache Git S

[GitHub] [kafka] guozhangwang commented on a change in pull request #10861: KAFKA-12909: disable spurious left/outer stream-stream join fix for old JoinWindows API

guozhangwang commented on a change in pull request #10861: URL: https://github.com/apache/kafka/pull/10861#discussion_r651983648 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java ## @@ -82,20 +87,23 @@ private class K

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r651985270 ## File path: core/src/main/scala/kafka/server/FetchSession.scala ## @@ -70,6 +71,7 @@ object FetchSession { * localLogStartOffset is the log start offse

[jira] [Updated] (KAFKA-12952) Metadata Snapshot File Header

[ https://issues.apache.org/jira/browse/KAFKA-12952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niket Goel updated KAFKA-12952: --- Description: Create a new Control Record that will serve as the header for a Metadata Snapshot File

[GitHub] [kafka] rondagostino opened a new pull request #10886: MINOR: TestSecurityRollingUpgrade system test fixes

rondagostino opened a new pull request #10886: URL: https://github.com/apache/kafka/pull/10886 The `TestSecurityRollingUpgrade. test_disable_separate_interbroker_listener()` system test had a design flaw: it was migrating inter-broker communication from a SASL_SSL listener to an SSL liste

[GitHub] [kafka] IgnacioAcunaF commented on a change in pull request #10883: KAFKA-12949: TestRaftServer's scala.MatchError: null on test-kraft-server-start.sh

IgnacioAcunaF commented on a change in pull request #10883: URL: https://github.com/apache/kafka/pull/10883#discussion_r651993936 ## File path: core/src/main/scala/kafka/tools/TestRaftServer.scala ## @@ -238,6 +238,8 @@ class TestRaftServer( reader.close()

[GitHub] [kafka] rondagostino commented on pull request #10886: MINOR: TestSecurityRollingUpgrade system test fixes

rondagostino commented on pull request #10886: URL: https://github.com/apache/kafka/pull/10886#issuecomment-861682744 I've kicked off system tests for the affected file and will post results here when it completes. -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [kafka] mumrah commented on a change in pull request #10867: KAFKA-12931: KIP-746: Revise KRaft Metadata Records

mumrah commented on a change in pull request #10867: URL: https://github.com/apache/kafka/pull/10867#discussion_r651991734 ## File path: metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java ## @@ -236,20 +239,11 @@ public void replay(RegisterBrokerReco

[GitHub] [kafka] IgnacioAcunaF commented on a change in pull request #10883: KAFKA-12949: TestRaftServer's scala.MatchError: null on test-kraft-server-start.sh

IgnacioAcunaF commented on a change in pull request #10883: URL: https://github.com/apache/kafka/pull/10883#discussion_r651993936 ## File path: core/src/main/scala/kafka/tools/TestRaftServer.scala ## @@ -238,6 +238,8 @@ class TestRaftServer( reader.close()

[GitHub] [kafka] IgnacioAcunaF commented on a change in pull request #10883: KAFKA-12949: TestRaftServer's scala.MatchError: null on test-kraft-server-start.sh

IgnacioAcunaF commented on a change in pull request #10883: URL: https://github.com/apache/kafka/pull/10883#discussion_r651993936 ## File path: core/src/main/scala/kafka/tools/TestRaftServer.scala ## @@ -238,6 +238,8 @@ class TestRaftServer( reader.close()

  1   2   >