satishd commented on a change in pull request #10733:
URL: https://github.com/apache/kafka/pull/10733#discussion_r651576585
##########
File path: core/src/main/scala/kafka/log/LogConfig.scala
##########
@@ -301,6 +350,16 @@ object LogConfig {
FollowerReplicationThrottledReplicasDoc,
FollowerReplicationThrottledReplicasProp)
.define(MessageDownConversionEnableProp, BOOLEAN,
Defaults.MessageDownConversionEnable, LOW,
MessageDownConversionEnableDoc,
KafkaConfig.LogMessageDownConversionEnableProp)
+
+ // RemoteLogStorageEnableProp, LocalLogRetentionMsProp,
LocalLogRetentionBytesProp do not have server default
+ // config names.
+ logConfigDef
+ // This define method is not overridden in LogConfig as these configs do
not have server defaults yet.
+ .define(RemoteLogStorageEnableProp, BOOLEAN,
Defaults.RemoteLogStorageEnable, MEDIUM, RemoteLogStorageEnableDoc)
Review comment:
I wanted to expose these configs at topic level in the initial release
and we can add them at the cluster level in the later versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
