mjsax commented on a change in pull request #10877: URL: https://github.com/apache/kafka/pull/10877#discussion_r651526170
########## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/InMemoryKeyValueStore.java ########## @@ -106,6 +108,8 @@ public void putAll(final List<KeyValue<Bytes, byte[]>> entries) { @Override public <PS extends Serializer<P>, P> KeyValueIterator<Bytes, byte[]> prefixScan(final P prefix, final PS prefixKeySerializer) { + Objects.requireNonNull(prefix); + Objects.requireNonNull(prefixKeySerializer); Review comment: Should we not check for `null` in the outer `MeteredXxxStore`? Should be redundant to check here for a second time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org