cmccabe merged pull request #10865:
URL: https://github.com/apache/kafka/pull/10865
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
dengziming commented on a change in pull request #10852:
URL: https://github.com/apache/kafka/pull/10852#discussion_r649629620
##
File path:
log4j-appender/src/test/java/org/apache/kafka/log4jappender/KafkaLog4jAppenderTest.java
##
@@ -158,18 +160,18 @@ public void
testRealPr
showuon edited a comment on pull request #10855:
URL: https://github.com/apache/kafka/pull/10855#issuecomment-859952969
@jlprat , you can merge with trunk branch to trigger jenkins build again if
you want. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to
soarez commented on pull request #10820:
URL: https://github.com/apache/kafka/pull/10820#issuecomment-859643949
Filed [KAFKA-12938 Fix and reenable
testChrootExistsAndRootIsLocked](https://issues.apache.org/jira/browse/KAFKA-12938
).
--
This is an automated message from the Apache Git S
tombentley commented on a change in pull request #10649:
URL: https://github.com/apache/kafka/pull/10649#discussion_r649793995
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##
@@ -536,7 +544,9 @@ static KafkaAdminClient createInternal
dongjinleekr commented on pull request #10847:
URL: https://github.com/apache/kafka/pull/10847#issuecomment-859370741
@ijuma @dchristle I am now evaluating Zstandard's long window mode. For
details, please check [the updated
KIP-390](https://cwiki.apache.org/confluence/display/KAFKA/KIP-39
omkreddy merged pull request #10820:
URL: https://github.com/apache/kafka/pull/10820
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, pleas
wenbingshen commented on pull request #10383:
URL: https://github.com/apache/kafka/pull/10383#issuecomment-859699508
@chia7712 This pr has been in the past for a long time, can you help
integrate it into the trunk? Sort the topic query results by topicName, which
is convenient for users to
omkreddy opened a new pull request #10866:
URL: https://github.com/apache/kafka/pull/10866
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgr
jolshan commented on pull request #10584:
URL: https://github.com/apache/kafka/pull/10584#issuecomment-859744693
Ok. This should fix the build. But now it will be a little bit extra work to
cherry-pick to 2.8.x 😅
--
This is an automated message from the Apache Git Service.
To respond to
IgnacioAcunaF commented on pull request #10858:
URL: https://github.com/apache/kafka/pull/10858#issuecomment-859209484
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For q
ijuma commented on pull request #10850:
URL: https://github.com/apache/kafka/pull/10850#issuecomment-859697426
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries a
vvcephei commented on a change in pull request #10869:
URL: https://github.com/apache/kafka/pull/10869#discussion_r650236596
##
File path: streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java
##
@@ -3173,12 +3173,13 @@ void to(final TopicNameExtractor topicExtrac
tombentley commented on a change in pull request #10743:
URL: https://github.com/apache/kafka/pull/10743#discussion_r649872433
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
##
@@ -858,6 +885,12 @@ public void onSuccess
showuon commented on pull request #10855:
URL: https://github.com/apache/kafka/pull/10855#issuecomment-859952969
@jlprat , you can merge with trunk branch to trigger jenkins build again.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
jlprat commented on pull request #10855:
URL: https://github.com/apache/kafka/pull/10855#issuecomment-859551630
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries
ijuma commented on a change in pull request #10852:
URL: https://github.com/apache/kafka/pull/10852#discussion_r650040685
##
File path:
log4j-appender/src/test/java/org/apache/kafka/log4jappender/KafkaLog4jAppenderTest.java
##
@@ -158,18 +160,18 @@ public void
testRealProduce
dengziming commented on a change in pull request #10852:
URL: https://github.com/apache/kafka/pull/10852#discussion_r650319455
##
File path:
log4j-appender/src/test/java/org/apache/kafka/log4jappender/KafkaLog4jAppenderTest.java
##
@@ -158,18 +160,18 @@ public void
testRealPr
cmccabe opened a new pull request #10867:
URL: https://github.com/apache/kafka/pull/10867
Implement the metadata records changes described in KIP-746.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
dajac commented on pull request #10760:
URL: https://github.com/apache/kafka/pull/10760#issuecomment-859299406
@thomaskwscott Thanks for the update. I will review it next week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
vvcephei opened a new pull request #10869:
URL: https://github.com/apache/kafka/pull/10869
* Deprecate the old Processor API
* Suppress warnings on all internal usages of the old API
(which will be migrated in other child tickets of KAFKA-8410)
* Add new KStream#process methods, s
mjsax commented on pull request #10846:
URL: https://github.com/apache/kafka/pull/10846#issuecomment-859236418
Update the PR to change the return type to Optional. If no objections are
raised and Jenkins passed, I plan to merge this next week.
--
This is an automated message from the Apa
IgnacioAcunaF edited a comment on pull request #10858:
URL: https://github.com/apache/kafka/pull/10858#issuecomment-859209484
Regarding tests:
- JDK 15 and Scala 2.13:
Successful
_[2021-06-11T00:23:47.258Z] 196 actionable tasks: 105 executed, 91
up-to-date_
- JDK 11 and
satishd commented on pull request #10733:
URL: https://github.com/apache/kafka/pull/10733#issuecomment-859342272
Thanks @junrao for the review, addressed them with the latest commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
iamgd67 commented on pull request #10818:
URL: https://github.com/apache/kafka/pull/10818#issuecomment-859384975
@junrao could you please review this, failed tests seems unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
vvcephei commented on pull request #10869:
URL: https://github.com/apache/kafka/pull/10869#issuecomment-859901571
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For querie
mdedetrich commented on a change in pull request #10839:
URL: https://github.com/apache/kafka/pull/10839#discussion_r649850434
##
File path: core/src/main/scala/kafka/tools/TestRaftServer.scala
##
@@ -466,3 +459,10 @@ object TestRaftServer extends Logging {
}
}
+
+private
chia7712 opened a new pull request #10868:
URL: https://github.com/apache/kafka/pull/10868
The `alterAclsPurgatory` can get closed by kafka broker so Kraft should
close it as well.
related to #10550
### Committer Checklist (excluded from commit message)
- [ ] Verify design
Emi created KAFKA-12946:
---
Summary: __consumer_offsets topic with very big partitions
Key: KAFKA-12946
URL: https://issues.apache.org/jira/browse/KAFKA-12946
Project: Kafka
Issue Type: Bug
Com
ijuma commented on pull request #10820:
URL: https://github.com/apache/kafka/pull/10820#issuecomment-859633079
Can we file a JIRA to re-enable this test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
[
https://issues.apache.org/jira/browse/KAFKA-12946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Emi updated KAFKA-12946:
Description:
I am using Kafka 2.0.0 with java 8u191
There is a partitions of the __consumer_offsets topic that is
ijuma commented on pull request #10702:
URL: https://github.com/apache/kafka/pull/10702#issuecomment-859948779
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries a
[
https://issues.apache.org/jira/browse/KAFKA-12946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Emi updated KAFKA-12946:
Description:
I am using Kafka 2.0.0 with java 8u191
There is a partitions of the __consumer_offsets topic that is
satishd commented on pull request #10848:
URL: https://github.com/apache/kafka/pull/10848#issuecomment-859319774
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries
dengziming edited a comment on pull request #10701:
URL: https://github.com/apache/kafka/pull/10701#issuecomment-858337829
Hello @mjsax , I mean the TDDO at
https://github.com/apache/kafka/blob/6de37e536ac76ef13530d49dc7320110332cd1ee/streams/examples/src/test/java/org/apache/kafka/stre
dengziming commented on pull request #10584:
URL: https://github.com/apache/kafka/pull/10584#issuecomment-859970177
> Ok. This should fix the build. But now it will be a little bit extra work
to cherry-pick to 2.8.x 😅
@jolshan you can open another PR target for 2.8.x if it's difficul
ijuma commented on pull request #10584:
URL: https://github.com/apache/kafka/pull/10584#issuecomment-859246823
I think you need to merge master to this branch or rebase this branch on
master. Jenkins is failing due to:
> [2021-06-10T21:42:48.226Z] [Error]
/home/jenkins/jenkins-agent
wycc commented on pull request #10850:
URL: https://github.com/apache/kafka/pull/10850#issuecomment-859328616
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For querie
showuon commented on a change in pull request #10863:
URL: https://github.com/apache/kafka/pull/10863#discussion_r649931726
##
File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala
##
@@ -1450,12 +1463,67 @@ class GroupCoordinator(val brokerId: Int,
dajac commented on pull request #10858:
URL: https://github.com/apache/kafka/pull/10858#issuecomment-859545300
@IgnacioAcunaF Thanks for the PR! I am a bit on the fence with regarding to
modifying the admin api here. Users might expect 'null' in this case.
Did you consider handling t
satishd commented on a change in pull request #10733:
URL: https://github.com/apache/kafka/pull/10733#discussion_r649741237
##
File path:
storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java
##
@@ -0,0 +1,351 @@
+/*
+ * Licensed to the A
satishd commented on pull request #10579:
URL: https://github.com/apache/kafka/pull/10579#issuecomment-859400725
Thanks @junrao @kowshik for the review comments. Addressed them with the
latest commits.
--
This is an automated message from the Apache Git Service.
To respond to the messag
jlprat commented on a change in pull request #10839:
URL: https://github.com/apache/kafka/pull/10839#discussion_r649848669
##
File path:
core/src/test/scala/unit/kafka/security/authorizer/AclAuthorizerWithZkSaslTest.scala
##
@@ -178,9 +177,3 @@ class TestableDigestLoginModule
vijaykriishna opened a new pull request #10873:
URL: https://github.com/apache/kafka/pull/10873
Fixed code snippet in documentation to make it syntactically correct.
Ref.
https://kafka.apache.org/20/documentation/streams/developer-guide/processor-api.html#accessing-processor-context
socutes commented on pull request #10875:
URL: https://github.com/apache/kafka/pull/10875#issuecomment-860169780
@ableegoldman please help to review this patch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
iakunin commented on pull request #10775:
URL: https://github.com/apache/kafka/pull/10775#issuecomment-860042763
@mdedetrich, many thanks for your feedback!
`MockScheduler` has no any background threads to deal with. It executes all
the tasks in the main thread.
As far as we
socutes opened a new pull request #10875:
URL: https://github.com/apache/kafka/pull/10875
See KIP-740 – for the TaskId class, we need to remove the following
deprecated APIs:
The public partition and topicGroupId fields should be "removed", ie made
private (can also now rename topic
feyman2016 edited a comment on pull request #10593:
URL: https://github.com/apache/kafka/pull/10593#issuecomment-860066550
> I have been working on a PR related to this if you want to take a look:
#10786. It would be nice to get your PR merged before my PR.
@jsancio Thanks for the re
vvcephei opened a new pull request #10870:
URL: https://github.com/apache/kafka/pull/10870
This IT has been failing on trunk recently. Enabling EOS during the
integration test
makes it easier to be sure that the test's assumptions are really true
during verification
and should make t
ijuma commented on a change in pull request #10872:
URL: https://github.com/apache/kafka/pull/10872#discussion_r650636358
##
File path: core/src/main/scala/kafka/server/KafkaServer.scala
##
@@ -480,7 +480,8 @@ class KafkaServer(
endpoint
)
-val jmxPort = Sys
socutes opened a new pull request #10874:
URL: https://github.com/apache/kafka/pull/10874
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, pl
showuon opened a new pull request #10871:
URL: https://github.com/apache/kafka/pull/10871
While there might still be some issue about the test as described
[here](https://issues.apache.org/jira/browse/KAFKA-8940?focusedCommentId=17214850&page=com.atlassian.jira.plugin.system.issuetabpanels%
dongjinleekr commented on pull request #10862:
URL: https://github.com/apache/kafka/pull/10862#issuecomment-860418131
@ableegoldman @showuon Here it is, with rebasing onto the latest trunk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
IgnacioAcunaF commented on a change in pull request #10858:
URL: https://github.com/apache/kafka/pull/10858#discussion_r650434257
##
File path: core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala
##
@@ -559,7 +559,7 @@ object ConsumerGroupCommand extends Logging {
ijuma commented on a change in pull request #10437:
URL: https://github.com/apache/kafka/pull/10437#discussion_r650629480
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/utils/EmbeddedKafkaCluster.java
##
@@ -101,7 +101,7 @@ public void start() throws
showuon commented on a change in pull request #10872:
URL: https://github.com/apache/kafka/pull/10872#discussion_r650627746
##
File path: docs/upgrade.html
##
@@ -25,6 +25,8 @@ Notable changes in 3
A number of implementation dependency jars are https://github.com/apache/ka
dongjinleekr commented on pull request #10827:
URL: https://github.com/apache/kafka/pull/10827#issuecomment-860330217
@guozhangwang Yes, I am currently working on it. And could you kindly have a
look at [the voting
thread](https://lists.apache.org/thread.html/rebd427d5fd34acf5b378d7a904af2
vamossagar12 opened a new pull request #10877:
URL: https://github.com/apache/kafka/pull/10877
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of te
guozhangwang commented on a change in pull request #10861:
URL: https://github.com/apache/kafka/pull/10861#discussion_r650448957
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/JoinWindows.java
##
@@ -76,18 +76,37 @@
private final long graceMs;
+
showuon commented on pull request #10437:
URL: https://github.com/apache/kafka/pull/10437#issuecomment-860334061
Also, the jenkins build didn't complete last time. Please remember to
trigger it again. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the
vvcephei merged pull request #10870:
URL: https://github.com/apache/kafka/pull/10870
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, pleas
guozhangwang commented on pull request #10871:
URL: https://github.com/apache/kafka/pull/10871#issuecomment-860151191
I can merge this PR after the test
https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-10871/1/pipeline
completes.
--
This is an au
satishd commented on a change in pull request #10579:
URL: https://github.com/apache/kafka/pull/10579#discussion_r650456266
##
File path:
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManager.java
##
@@ -0,0 +1,335 @@
+/*
ijuma merged pull request #10847:
URL: https://github.com/apache/kafka/pull/10847
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please c
dejan2609 commented on pull request #10698:
URL: https://github.com/apache/kafka/pull/10698#issuecomment-860043870
@ijuma update: I already gather two approvals (made by fellow-contributors)
for this PR, but I still need some maintainer to have his say.
--
This is an automated message
[
https://issues.apache.org/jira/browse/KAFKA-12946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Emi updated KAFKA-12946:
Description:
I am using Kafka 2.0.0 with java 8u191
There is a partitions of the __consumer_offsets topic that is
feyman2016 commented on pull request #10593:
URL: https://github.com/apache/kafka/pull/10593#issuecomment-860066550
> I have been working on a PR related to this if you want to take a look:
#10786. It would be nice to get your PR merged before my PR.
Thanks for the reply, now I under
showuon commented on pull request #10871:
URL: https://github.com/apache/kafka/pull/10871#issuecomment-860145613
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries
socutes opened a new pull request #10876:
URL: https://github.com/apache/kafka/pull/10876
See KIP-740 – for the TaskMetadata class, we need to:
Deprecate the TaskMetadata#getTaskId method
"Remove" the deprecated TaskMetadata#taskId method, then re-add a taskId()
API that returns a
chia7712 commented on a change in pull request #10702:
URL: https://github.com/apache/kafka/pull/10702#discussion_r650504081
##
File path: build.gradle
##
@@ -353,6 +355,27 @@ subprojects {
}
}
+ // The suites are for running sets of tests in IDEs.
+ // Gradle will
ijuma commented on pull request #10847:
URL: https://github.com/apache/kafka/pull/10847#issuecomment-860235280
Unrelated flaky failures:
> Build / JDK 11 and Scala 2.13 /
org.apache.kafka.streams.integration.SmokeTestDriverIntegrationTest.shouldWorkWithRebalance
> Build / JDK 8 an
showuon edited a comment on pull request #10871:
URL: https://github.com/apache/kafka/pull/10871#issuecomment-860167664
All tests passed! YA!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
chia7712 merged pull request #10855:
URL: https://github.com/apache/kafka/pull/10855
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, pleas
abbccdda commented on a change in pull request #10814:
URL: https://github.com/apache/kafka/pull/10814#discussion_r650433865
##
File path: tools/src/main/java/org/apache/kafka/tools/TransactionsCommand.java
##
@@ -0,0 +1,622 @@
+/*
+ * Licensed to the Apache Software Foundation
vvcephei commented on pull request #10870:
URL: https://github.com/apache/kafka/pull/10870#issuecomment-860326717
Thanks for the review, @abbccdda !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
guozhangwang commented on a change in pull request #10869:
URL: https://github.com/apache/kafka/pull/10869#discussion_r650470473
##
File path: streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java
##
@@ -4615,7 +4732,110 @@ void to(final TopicNameExtractor topicEx
guozhangwang commented on pull request #10827:
URL: https://github.com/apache/kafka/pull/10827#issuecomment-860247789
Looks good to me. Will wait for the unit test to be added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
showuon commented on pull request #10820:
URL: https://github.com/apache/kafka/pull/10820#issuecomment-859979334
Thanks @omkreddy @ijuma @soarez , finally see the `trunk` build back to
yellow light!

showuon commented on a change in pull request #10862:
URL: https://github.com/apache/kafka/pull/10862#discussion_r650651936
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java
##
@@ -126,7 +126,7 @@ public StateDirectory(final S
[
https://issues.apache.org/jira/browse/KAFKA-12847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17362811#comment-17362811
]
Abhijit Mane edited comment on KAFKA-12847 at 6/14/21, 8:17 AM:
--
Dragotic commented on pull request #10644:
URL: https://github.com/apache/kafka/pull/10644#issuecomment-860509704
Hello team!
@ning2008wisc thank you very much for the bug fix, any update on when we can
expect this to be merged to the upstream and released?
--
This is an automate
1 - 100 of 229 matches
Mail list logo