[GitHub] [kafka] cmccabe merged pull request #10865: KAFKA-12934: Move some controller classes to the metadata package

2021-06-14 Thread GitBox
cmccabe merged pull request #10865: URL: https://github.com/apache/kafka/pull/10865 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [kafka] dengziming commented on a change in pull request #10852: MINOR: Replace easymock with mockito in log4j-appender

2021-06-14 Thread GitBox
dengziming commented on a change in pull request #10852: URL: https://github.com/apache/kafka/pull/10852#discussion_r649629620 ## File path: log4j-appender/src/test/java/org/apache/kafka/log4jappender/KafkaLog4jAppenderTest.java ## @@ -158,18 +160,18 @@ public void testRealPr

[GitHub] [kafka] showuon edited a comment on pull request #10855: MINOR: clean up unneeded `@SuppressWarnings` on Streams module

2021-06-14 Thread GitBox
showuon edited a comment on pull request #10855: URL: https://github.com/apache/kafka/pull/10855#issuecomment-859952969 @jlprat , you can merge with trunk branch to trigger jenkins build again if you want. Thanks. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] soarez commented on pull request #10820: KAFKA-12892: disable testChrootExistsAndRootIsLocked

2021-06-14 Thread GitBox
soarez commented on pull request #10820: URL: https://github.com/apache/kafka/pull/10820#issuecomment-859643949 Filed [KAFKA-12938 Fix and reenable testChrootExistsAndRootIsLocked](https://issues.apache.org/jira/browse/KAFKA-12938 ). -- This is an automated message from the Apache Git S

[GitHub] [kafka] tombentley commented on a change in pull request #10649: KAFKA-12762: Use connection timeout when polling the network for new …

2021-06-14 Thread GitBox
tombentley commented on a change in pull request #10649: URL: https://github.com/apache/kafka/pull/10649#discussion_r649793995 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -536,7 +544,9 @@ static KafkaAdminClient createInternal

[GitHub] [kafka] dongjinleekr commented on pull request #10847: KAFKA-12921: Upgrade ZSTD JNI from 1.4.9-1 to 1.5.0-1

2021-06-14 Thread GitBox
dongjinleekr commented on pull request #10847: URL: https://github.com/apache/kafka/pull/10847#issuecomment-859370741 @ijuma @dchristle I am now evaluating Zstandard's long window mode. For details, please check [the updated KIP-390](https://cwiki.apache.org/confluence/display/KAFKA/KIP-39

[GitHub] [kafka] omkreddy merged pull request #10820: KAFKA-12892: disable testChrootExistsAndRootIsLocked

2021-06-14 Thread GitBox
omkreddy merged pull request #10820: URL: https://github.com/apache/kafka/pull/10820 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pleas

[GitHub] [kafka] wenbingshen commented on pull request #10383: MINOR: Query topic describe and sort output by topic name when using adminClient

2021-06-14 Thread GitBox
wenbingshen commented on pull request #10383: URL: https://github.com/apache/kafka/pull/10383#issuecomment-859699508 @chia7712 This pr has been in the past for a long time, can you help integrate it into the trunk? Sort the topic query results by topicName, which is convenient for users to

[GitHub] [kafka] omkreddy opened a new pull request #10866: [Test ] debug zk acl errors

2021-06-14 Thread GitBox
omkreddy opened a new pull request #10866: URL: https://github.com/apache/kafka/pull/10866 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgr

[GitHub] [kafka] jolshan commented on pull request #10584: KAFKA-12701: NPE in MetadataRequest when using topic IDs

2021-06-14 Thread GitBox
jolshan commented on pull request #10584: URL: https://github.com/apache/kafka/pull/10584#issuecomment-859744693 Ok. This should fix the build. But now it will be a little bit extra work to cherry-pick to 2.8.x 😅 -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] IgnacioAcunaF commented on pull request #10858: KAFKA-12926: ConsumerGroupCommand's java.lang.NullPointerException at negative offsets while running kafka-consumer-groups.sh

2021-06-14 Thread GitBox
IgnacioAcunaF commented on pull request #10858: URL: https://github.com/apache/kafka/pull/10858#issuecomment-859209484 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For q

[GitHub] [kafka] ijuma commented on pull request #10850: KAFKA-12924 Replace EasyMock and PowerMock with Mockito in streams (metrics)

2021-06-14 Thread GitBox
ijuma commented on pull request #10850: URL: https://github.com/apache/kafka/pull/10850#issuecomment-859697426 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries a

[GitHub] [kafka] vvcephei commented on a change in pull request #10869: KAFKA-10546: Deprecate old PAPI

2021-06-14 Thread GitBox
vvcephei commented on a change in pull request #10869: URL: https://github.com/apache/kafka/pull/10869#discussion_r650236596 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java ## @@ -3173,12 +3173,13 @@ void to(final TopicNameExtractor topicExtrac

[GitHub] [kafka] tombentley commented on a change in pull request #10743: KIP-699: Update FindCoordinator to resolve multiple Coordinators at a time

2021-06-14 Thread GitBox
tombentley commented on a change in pull request #10743: URL: https://github.com/apache/kafka/pull/10743#discussion_r649872433 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java ## @@ -858,6 +885,12 @@ public void onSuccess

[GitHub] [kafka] showuon commented on pull request #10855: MINOR: clean up unneeded `@SuppressWarnings` on Streams module

2021-06-14 Thread GitBox
showuon commented on pull request #10855: URL: https://github.com/apache/kafka/pull/10855#issuecomment-859952969 @jlprat , you can merge with trunk branch to trigger jenkins build again. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [kafka] jlprat commented on pull request #10855: MINOR: clean up unneeded `@SuppressWarnings` on Streams module

2021-06-14 Thread GitBox
jlprat commented on pull request #10855: URL: https://github.com/apache/kafka/pull/10855#issuecomment-859551630 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries

[GitHub] [kafka] ijuma commented on a change in pull request #10852: MINOR: Replace easymock with mockito in log4j-appender

2021-06-14 Thread GitBox
ijuma commented on a change in pull request #10852: URL: https://github.com/apache/kafka/pull/10852#discussion_r650040685 ## File path: log4j-appender/src/test/java/org/apache/kafka/log4jappender/KafkaLog4jAppenderTest.java ## @@ -158,18 +160,18 @@ public void testRealProduce

[GitHub] [kafka] dengziming commented on a change in pull request #10852: MINOR: Replace easymock with mockito in log4j-appender

2021-06-14 Thread GitBox
dengziming commented on a change in pull request #10852: URL: https://github.com/apache/kafka/pull/10852#discussion_r650319455 ## File path: log4j-appender/src/test/java/org/apache/kafka/log4jappender/KafkaLog4jAppenderTest.java ## @@ -158,18 +160,18 @@ public void testRealPr

[GitHub] [kafka] cmccabe opened a new pull request #10867: KAFKA-12931: KIP-746: Revise KRaft Metadata Records

2021-06-14 Thread GitBox
cmccabe opened a new pull request #10867: URL: https://github.com/apache/kafka/pull/10867 Implement the metadata records changes described in KIP-746. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [kafka] dajac commented on pull request #10760: KAFKA-12541 Extend ListOffset to fetch offset with max timestamp

2021-06-14 Thread GitBox
dajac commented on pull request #10760: URL: https://github.com/apache/kafka/pull/10760#issuecomment-859299406 @thomaskwscott Thanks for the update. I will review it next week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] vvcephei opened a new pull request #10869: KAFKA-10546: Deprecate old PAPI

2021-06-14 Thread GitBox
vvcephei opened a new pull request #10869: URL: https://github.com/apache/kafka/pull/10869 * Deprecate the old Processor API * Suppress warnings on all internal usages of the old API (which will be migrated in other child tickets of KAFKA-8410) * Add new KStream#process methods, s

[GitHub] [kafka] mjsax commented on pull request #10846: KAFKA-12914: StreamSourceNode should return `null` topic name for pattern subscription

2021-06-14 Thread GitBox
mjsax commented on pull request #10846: URL: https://github.com/apache/kafka/pull/10846#issuecomment-859236418 Update the PR to change the return type to Optional. If no objections are raised and Jenkins passed, I plan to merge this next week. -- This is an automated message from the Apa

[GitHub] [kafka] IgnacioAcunaF edited a comment on pull request #10858: KAFKA-12926: ConsumerGroupCommand's java.lang.NullPointerException at negative offsets while running kafka-consumer-groups.sh

2021-06-14 Thread GitBox
IgnacioAcunaF edited a comment on pull request #10858: URL: https://github.com/apache/kafka/pull/10858#issuecomment-859209484 Regarding tests: - JDK 15 and Scala 2.13: Successful _[2021-06-11T00:23:47.258Z] 196 actionable tasks: 105 executed, 91 up-to-date_ - JDK 11 and

[GitHub] [kafka] satishd commented on pull request #10733: KAFKA-12816 Added tiered storage related configs including remote log manager configs.

2021-06-14 Thread GitBox
satishd commented on pull request #10733: URL: https://github.com/apache/kafka/pull/10733#issuecomment-859342272 Thanks @junrao for the review, addressed them with the latest commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] iamgd67 commented on pull request #10818: KAFKA-12889: log clean relative index range check of group consider empty log segment to avoid too many empty log segment left

2021-06-14 Thread GitBox
iamgd67 commented on pull request #10818: URL: https://github.com/apache/kafka/pull/10818#issuecomment-859384975 @junrao could you please review this, failed tests seems unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [kafka] vvcephei commented on pull request #10869: KAFKA-10546: Deprecate old PAPI

2021-06-14 Thread GitBox
vvcephei commented on pull request #10869: URL: https://github.com/apache/kafka/pull/10869#issuecomment-859901571 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For querie

[GitHub] [kafka] mdedetrich commented on a change in pull request #10839: KAFKA-12913: Make case class's final

2021-06-14 Thread GitBox
mdedetrich commented on a change in pull request #10839: URL: https://github.com/apache/kafka/pull/10839#discussion_r649850434 ## File path: core/src/main/scala/kafka/tools/TestRaftServer.scala ## @@ -466,3 +459,10 @@ object TestRaftServer extends Logging { } } + +private

[GitHub] [kafka] chia7712 opened a new pull request #10868: MINOR: make sure alterAclsPurgatory is closed when controller server …

2021-06-14 Thread GitBox
chia7712 opened a new pull request #10868: URL: https://github.com/apache/kafka/pull/10868 The `alterAclsPurgatory` can get closed by kafka broker so Kraft should close it as well. related to #10550 ### Committer Checklist (excluded from commit message) - [ ] Verify design

[jira] [Created] (KAFKA-12946) __consumer_offsets topic with very big partitions

2021-06-14 Thread Emi (Jira)
Emi created KAFKA-12946: --- Summary: __consumer_offsets topic with very big partitions Key: KAFKA-12946 URL: https://issues.apache.org/jira/browse/KAFKA-12946 Project: Kafka Issue Type: Bug Com

[GitHub] [kafka] ijuma commented on pull request #10820: KAFKA-12892: disable testChrootExistsAndRootIsLocked

2021-06-14 Thread GitBox
ijuma commented on pull request #10820: URL: https://github.com/apache/kafka/pull/10820#issuecomment-859633079 Can we file a JIRA to re-enable this test? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[jira] [Updated] (KAFKA-12946) __consumer_offsets topic with very big partitions

2021-06-14 Thread Emi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Emi updated KAFKA-12946: Description: I am using Kafka 2.0.0 with java 8u191 There is a partitions of the __consumer_offsets topic that is

[GitHub] [kafka] ijuma commented on pull request #10702: KAFKA-12940: Enable JDK 16 builds in Jenkins

2021-06-14 Thread GitBox
ijuma commented on pull request #10702: URL: https://github.com/apache/kafka/pull/10702#issuecomment-859948779 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries a

[jira] [Updated] (KAFKA-12946) __consumer_offsets topic with very big partitions

2021-06-14 Thread Emi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Emi updated KAFKA-12946: Description: I am using Kafka 2.0.0 with java 8u191 There is a partitions of the __consumer_offsets topic that is

[GitHub] [kafka] satishd commented on pull request #10848: MINOR Updated transaction index as optional in LogSegmentData.

2021-06-14 Thread GitBox
satishd commented on pull request #10848: URL: https://github.com/apache/kafka/pull/10848#issuecomment-859319774 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries

[GitHub] [kafka] dengziming edited a comment on pull request #10701: KAFKA-10437; Fix omitted TODO of KIP-478

2021-06-14 Thread GitBox
dengziming edited a comment on pull request #10701: URL: https://github.com/apache/kafka/pull/10701#issuecomment-858337829 Hello @mjsax , I mean the TDDO at https://github.com/apache/kafka/blob/6de37e536ac76ef13530d49dc7320110332cd1ee/streams/examples/src/test/java/org/apache/kafka/stre

[GitHub] [kafka] dengziming commented on pull request #10584: KAFKA-12701: NPE in MetadataRequest when using topic IDs

2021-06-14 Thread GitBox
dengziming commented on pull request #10584: URL: https://github.com/apache/kafka/pull/10584#issuecomment-859970177 > Ok. This should fix the build. But now it will be a little bit extra work to cherry-pick to 2.8.x 😅 @jolshan you can open another PR target for 2.8.x if it's difficul

[GitHub] [kafka] ijuma commented on pull request #10584: KAFKA-12701: NPE in MetadataRequest when using topic IDs

2021-06-14 Thread GitBox
ijuma commented on pull request #10584: URL: https://github.com/apache/kafka/pull/10584#issuecomment-859246823 I think you need to merge master to this branch or rebase this branch on master. Jenkins is failing due to: > [2021-06-10T21:42:48.226Z] [Error] /home/jenkins/jenkins-agent

[GitHub] [kafka] wycccccc commented on pull request #10850: KAFKA-12924 Replace EasyMock and PowerMock with Mockito in streams (metrics)

2021-06-14 Thread GitBox
wycc commented on pull request #10850: URL: https://github.com/apache/kafka/pull/10850#issuecomment-859328616 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For querie

[GitHub] [kafka] showuon commented on a change in pull request #10863: KAFKA-12890; Consumer group stuck in `CompletingRebalance`

2021-06-14 Thread GitBox
showuon commented on a change in pull request #10863: URL: https://github.com/apache/kafka/pull/10863#discussion_r649931726 ## File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala ## @@ -1450,12 +1463,67 @@ class GroupCoordinator(val brokerId: Int,

[GitHub] [kafka] dajac commented on pull request #10858: KAFKA-12926: ConsumerGroupCommand's java.lang.NullPointerException at negative offsets while running kafka-consumer-groups.sh

2021-06-14 Thread GitBox
dajac commented on pull request #10858: URL: https://github.com/apache/kafka/pull/10858#issuecomment-859545300 @IgnacioAcunaF Thanks for the PR! I am a bit on the fence with regarding to modifying the admin api here. Users might expect 'null' in this case. Did you consider handling t

[GitHub] [kafka] satishd commented on a change in pull request #10733: KAFKA-12816 Added tiered storage related configs including remote log manager configs.

2021-06-14 Thread GitBox
satishd commented on a change in pull request #10733: URL: https://github.com/apache/kafka/pull/10733#discussion_r649741237 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java ## @@ -0,0 +1,351 @@ +/* + * Licensed to the A

[GitHub] [kafka] satishd commented on pull request #10579: KAFKA-9555 Added default RLMM implementation based on internal topic storage.

2021-06-14 Thread GitBox
satishd commented on pull request #10579: URL: https://github.com/apache/kafka/pull/10579#issuecomment-859400725 Thanks @junrao @kowshik for the review comments. Addressed them with the latest commits. -- This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [kafka] jlprat commented on a change in pull request #10839: KAFKA-12913: Make case class's final

2021-06-14 Thread GitBox
jlprat commented on a change in pull request #10839: URL: https://github.com/apache/kafka/pull/10839#discussion_r649848669 ## File path: core/src/test/scala/unit/kafka/security/authorizer/AclAuthorizerWithZkSaslTest.scala ## @@ -178,9 +177,3 @@ class TestableDigestLoginModule

[GitHub] [kafka] vijaykriishna opened a new pull request #10873: KAFKA-7360 Fixed code snippet

2021-06-14 Thread GitBox
vijaykriishna opened a new pull request #10873: URL: https://github.com/apache/kafka/pull/10873 Fixed code snippet in documentation to make it syntactically correct. Ref. https://kafka.apache.org/20/documentation/streams/developer-guide/processor-api.html#accessing-processor-context

[GitHub] [kafka] socutes commented on pull request #10875: KAFKA-12844: KIP-740 follow up: clean up TaskId

2021-06-14 Thread GitBox
socutes commented on pull request #10875: URL: https://github.com/apache/kafka/pull/10875#issuecomment-860169780 @ableegoldman please help to review this patch! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] iakunin commented on pull request #10775: KAFKA-12668: Making MockScheduler.schedule safe to use in concurrent code

2021-06-14 Thread GitBox
iakunin commented on pull request #10775: URL: https://github.com/apache/kafka/pull/10775#issuecomment-860042763 @mdedetrich, many thanks for your feedback! `MockScheduler` has no any background threads to deal with. It executes all the tasks in the main thread. As far as we

[GitHub] [kafka] socutes opened a new pull request #10875: KAFKA-12844: KIP-740 follow up: clean up TaskId

2021-06-14 Thread GitBox
socutes opened a new pull request #10875: URL: https://github.com/apache/kafka/pull/10875 See KIP-740 – for the TaskId class, we need to remove the following deprecated APIs: The public partition and topicGroupId fields should be "removed", ie made private (can also now rename topic

[GitHub] [kafka] feyman2016 edited a comment on pull request #10593: KAFKA-10800 Validate the snapshot id when the state machine creates a snapshot

2021-06-14 Thread GitBox
feyman2016 edited a comment on pull request #10593: URL: https://github.com/apache/kafka/pull/10593#issuecomment-860066550 > I have been working on a PR related to this if you want to take a look: #10786. It would be nice to get your PR merged before my PR. @jsancio Thanks for the re

[GitHub] [kafka] vvcephei opened a new pull request #10870: MINOR: enable EOS during smoke test IT

2021-06-14 Thread GitBox
vvcephei opened a new pull request #10870: URL: https://github.com/apache/kafka/pull/10870 This IT has been failing on trunk recently. Enabling EOS during the integration test makes it easier to be sure that the test's assumptions are really true during verification and should make t

[GitHub] [kafka] ijuma commented on a change in pull request #10872: KAFKA-12945: Remove port, host.name and related configs in 3.0

2021-06-14 Thread GitBox
ijuma commented on a change in pull request #10872: URL: https://github.com/apache/kafka/pull/10872#discussion_r650636358 ## File path: core/src/main/scala/kafka/server/KafkaServer.scala ## @@ -480,7 +480,8 @@ class KafkaServer( endpoint ) -val jmxPort = Sys

[GitHub] [kafka] socutes opened a new pull request #10874: KIP-740: follow up: clean up TaskId

2021-06-14 Thread GitBox
socutes opened a new pull request #10874: URL: https://github.com/apache/kafka/pull/10874 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pl

[GitHub] [kafka] showuon opened a new pull request #10871: KAFKA-8940: decrease session timeout to make test faster and reliable

2021-06-14 Thread GitBox
showuon opened a new pull request #10871: URL: https://github.com/apache/kafka/pull/10871 While there might still be some issue about the test as described [here](https://issues.apache.org/jira/browse/KAFKA-8940?focusedCommentId=17214850&page=com.atlassian.jira.plugin.system.issuetabpanels%

[GitHub] [kafka] dongjinleekr commented on pull request #10862: KAFKA-12928: Add a check whether the Task's statestore is actually a directory

2021-06-14 Thread GitBox
dongjinleekr commented on pull request #10862: URL: https://github.com/apache/kafka/pull/10862#issuecomment-860418131 @ableegoldman @showuon Here it is, with rebasing onto the latest trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] IgnacioAcunaF commented on a change in pull request #10858: KAFKA-12926: ConsumerGroupCommand's java.lang.NullPointerException at negative offsets while running kafka-consumer-groups.

2021-06-14 Thread GitBox
IgnacioAcunaF commented on a change in pull request #10858: URL: https://github.com/apache/kafka/pull/10858#discussion_r650434257 ## File path: core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala ## @@ -559,7 +559,7 @@ object ConsumerGroupCommand extends Logging {

[GitHub] [kafka] ijuma commented on a change in pull request #10437: MINOR: Remove deprecated `host.name`, `advertised.host.name`, `port` and `advertised.port` for 3.0

2021-06-14 Thread GitBox
ijuma commented on a change in pull request #10437: URL: https://github.com/apache/kafka/pull/10437#discussion_r650629480 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/utils/EmbeddedKafkaCluster.java ## @@ -101,7 +101,7 @@ public void start() throws

[GitHub] [kafka] showuon commented on a change in pull request #10872: KAFKA-12945: Remove port, host.name and related configs in 3.0

2021-06-14 Thread GitBox
showuon commented on a change in pull request #10872: URL: https://github.com/apache/kafka/pull/10872#discussion_r650627746 ## File path: docs/upgrade.html ## @@ -25,6 +25,8 @@ Notable changes in 3 A number of implementation dependency jars are https://github.com/apache/ka

[GitHub] [kafka] dongjinleekr commented on pull request #10827: KAFKA-12899: Support --bootstrap-server in ReplicaVerificationTool

2021-06-14 Thread GitBox
dongjinleekr commented on pull request #10827: URL: https://github.com/apache/kafka/pull/10827#issuecomment-860330217 @guozhangwang Yes, I am currently working on it. And could you kindly have a look at [the voting thread](https://lists.apache.org/thread.html/rebd427d5fd34acf5b378d7a904af2

[GitHub] [kafka] vamossagar12 opened a new pull request #10877: KAFKA-12925: adding presfixScan operation for missed implementations

2021-06-14 Thread GitBox
vamossagar12 opened a new pull request #10877: URL: https://github.com/apache/kafka/pull/10877 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of te

[GitHub] [kafka] guozhangwang commented on a change in pull request #10861: KAFKA-12909: disable spurious left/outer stream-stream join fix for old JoinWindows API

2021-06-14 Thread GitBox
guozhangwang commented on a change in pull request #10861: URL: https://github.com/apache/kafka/pull/10861#discussion_r650448957 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/JoinWindows.java ## @@ -76,18 +76,37 @@ private final long graceMs; +

[GitHub] [kafka] showuon commented on pull request #10437: MINOR: Remove deprecated `host.name`, `advertised.host.name`, `port` and `advertised.port` for 3.0

2021-06-14 Thread GitBox
showuon commented on pull request #10437: URL: https://github.com/apache/kafka/pull/10437#issuecomment-860334061 Also, the jenkins build didn't complete last time. Please remember to trigger it again. Thanks. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] vvcephei merged pull request #10870: MINOR: enable EOS during smoke test IT

2021-06-14 Thread GitBox
vvcephei merged pull request #10870: URL: https://github.com/apache/kafka/pull/10870 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pleas

[GitHub] [kafka] guozhangwang commented on pull request #10871: KAFKA-8940: decrease session timeout to make test faster and reliable

2021-06-14 Thread GitBox
guozhangwang commented on pull request #10871: URL: https://github.com/apache/kafka/pull/10871#issuecomment-860151191 I can merge this PR after the test https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-10871/1/pipeline completes. -- This is an au

[GitHub] [kafka] satishd commented on a change in pull request #10579: KAFKA-9555 Added default RLMM implementation based on internal topic storage.

2021-06-14 Thread GitBox
satishd commented on a change in pull request #10579: URL: https://github.com/apache/kafka/pull/10579#discussion_r650456266 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManager.java ## @@ -0,0 +1,335 @@ +/*

[GitHub] [kafka] ijuma merged pull request #10847: KAFKA-12921: Upgrade ZSTD JNI to 1.5.0-2

2021-06-14 Thread GitBox
ijuma merged pull request #10847: URL: https://github.com/apache/kafka/pull/10847 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[GitHub] [kafka] dejan2609 commented on pull request #10698: KAFKA-12770: introduce `checkstyleVersion` build option (for overriding CheckStyle project-defined dependency version)

2021-06-14 Thread GitBox
dejan2609 commented on pull request #10698: URL: https://github.com/apache/kafka/pull/10698#issuecomment-860043870 @ijuma update: I already gather two approvals (made by fellow-contributors) for this PR, but I still need some maintainer to have his say. -- This is an automated message

[jira] [Updated] (KAFKA-12946) __consumer_offsets topic with very big partitions

2021-06-14 Thread Emi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Emi updated KAFKA-12946: Description: I am using Kafka 2.0.0 with java 8u191 There is a partitions of the __consumer_offsets topic that is

[GitHub] [kafka] feyman2016 commented on pull request #10593: KAFKA-10800 Validate the snapshot id when the state machine creates a snapshot

2021-06-14 Thread GitBox
feyman2016 commented on pull request #10593: URL: https://github.com/apache/kafka/pull/10593#issuecomment-860066550 > I have been working on a PR related to this if you want to take a look: #10786. It would be nice to get your PR merged before my PR. Thanks for the reply, now I under

[GitHub] [kafka] showuon commented on pull request #10871: KAFKA-8940: decrease session timeout to make test faster and reliable

2021-06-14 Thread GitBox
showuon commented on pull request #10871: URL: https://github.com/apache/kafka/pull/10871#issuecomment-860145613 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries

[GitHub] [kafka] socutes opened a new pull request #10876: KAFKA-12843: KIP-740 follow up: clean up TaskMetadata

2021-06-14 Thread GitBox
socutes opened a new pull request #10876: URL: https://github.com/apache/kafka/pull/10876 See KIP-740 – for the TaskMetadata class, we need to: Deprecate the TaskMetadata#getTaskId method "Remove" the deprecated TaskMetadata#taskId method, then re-add a taskId() API that returns a

[GitHub] [kafka] chia7712 commented on a change in pull request #10702: KAFKA-12940: Enable JDK 16 builds in Jenkins

2021-06-14 Thread GitBox
chia7712 commented on a change in pull request #10702: URL: https://github.com/apache/kafka/pull/10702#discussion_r650504081 ## File path: build.gradle ## @@ -353,6 +355,27 @@ subprojects { } } + // The suites are for running sets of tests in IDEs. + // Gradle will

[GitHub] [kafka] ijuma commented on pull request #10847: KAFKA-12921: Upgrade ZSTD JNI to 1.5.0-2

2021-06-14 Thread GitBox
ijuma commented on pull request #10847: URL: https://github.com/apache/kafka/pull/10847#issuecomment-860235280 Unrelated flaky failures: > Build / JDK 11 and Scala 2.13 / org.apache.kafka.streams.integration.SmokeTestDriverIntegrationTest.shouldWorkWithRebalance > Build / JDK 8 an

[GitHub] [kafka] showuon edited a comment on pull request #10871: KAFKA-8940: decrease session timeout to make test faster and reliable

2021-06-14 Thread GitBox
showuon edited a comment on pull request #10871: URL: https://github.com/apache/kafka/pull/10871#issuecomment-860167664 All tests passed! YA! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] chia7712 merged pull request #10855: MINOR: clean up unneeded `@SuppressWarnings` on Streams module

2021-06-14 Thread GitBox
chia7712 merged pull request #10855: URL: https://github.com/apache/kafka/pull/10855 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pleas

[GitHub] [kafka] abbccdda commented on a change in pull request #10814: KAFKA-12888; Add transaction tool from KIP-664

2021-06-14 Thread GitBox
abbccdda commented on a change in pull request #10814: URL: https://github.com/apache/kafka/pull/10814#discussion_r650433865 ## File path: tools/src/main/java/org/apache/kafka/tools/TransactionsCommand.java ## @@ -0,0 +1,622 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] vvcephei commented on pull request #10870: MINOR: enable EOS during smoke test IT

2021-06-14 Thread GitBox
vvcephei commented on pull request #10870: URL: https://github.com/apache/kafka/pull/10870#issuecomment-860326717 Thanks for the review, @abbccdda ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] guozhangwang commented on a change in pull request #10869: KAFKA-10546: Deprecate old PAPI

2021-06-14 Thread GitBox
guozhangwang commented on a change in pull request #10869: URL: https://github.com/apache/kafka/pull/10869#discussion_r650470473 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java ## @@ -4615,7 +4732,110 @@ void to(final TopicNameExtractor topicEx

[GitHub] [kafka] guozhangwang commented on pull request #10827: KAFKA-12899: Support --bootstrap-server in ReplicaVerificationTool

2021-06-14 Thread GitBox
guozhangwang commented on pull request #10827: URL: https://github.com/apache/kafka/pull/10827#issuecomment-860247789 Looks good to me. Will wait for the unit test to be added. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] showuon commented on pull request #10820: KAFKA-12892: disable testChrootExistsAndRootIsLocked

2021-06-14 Thread GitBox
showuon commented on pull request #10820: URL: https://github.com/apache/kafka/pull/10820#issuecomment-859979334 Thanks @omkreddy @ijuma @soarez , finally see the `trunk` build back to yellow light! ![image](https://user-images.githubusercontent.com/43372967/121761512-d4103e80-cb62-11eb

[GitHub] [kafka] socutes commented on pull request #10874: KIP-740: follow up: clean up TaskId

2021-06-14 Thread GitBox
socutes commented on pull request #10874: URL: https://github.com/apache/kafka/pull/10874#issuecomment-860167751 @ableegoldman please help to review this patch! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] showuon commented on pull request #10811: KAFKA-12598: remove zookeeper support on configCommand except security config

2021-06-14 Thread GitBox
showuon commented on pull request #10811: URL: https://github.com/apache/kafka/pull/10811#issuecomment-860173898 @ijuma , please help review. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] jlprat commented on pull request #10876: KAFKA-12843: KIP-740 follow up: clean up TaskMetadata

2021-06-14 Thread GitBox
jlprat commented on pull request #10876: URL: https://github.com/apache/kafka/pull/10876#issuecomment-860180512 Hi @socutes, thanks for the PR. However, I would say it comes a bit early. Version 3.0.0 is not yet released, actually we are currently working towards that release. So any PR me

[GitHub] [kafka] dajac commented on pull request #10872: KAFKA-12945: Remove port, host.name and related configs in 3.0

2021-06-14 Thread GitBox
dajac commented on pull request #10872: URL: https://github.com/apache/kafka/pull/10872#issuecomment-860169526 Thanks @ijuma. I have started to work on this a while ago but I haven't had the time to finish it yet: https://github.com/apache/kafka/pull/10437. I will close it and review yours

[GitHub] [kafka] socutes closed pull request #10874: KAFKA-12844: KIP-740 follow up: clean up TaskId

2021-06-14 Thread GitBox
socutes closed pull request #10874: URL: https://github.com/apache/kafka/pull/10874 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [kafka] chia7712 commented on pull request #10868: MINOR: make sure alterAclsPurgatory is closed when controller server …

2021-06-14 Thread GitBox
chia7712 commented on pull request #10868: URL: https://github.com/apache/kafka/pull/10868#issuecomment-860194115 @rondagostino FYI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [kafka] jlprat commented on pull request #10875: KAFKA-12844: KIP-740 follow up: clean up TaskId

2021-06-14 Thread GitBox
jlprat commented on pull request #10875: URL: https://github.com/apache/kafka/pull/10875#issuecomment-860180625 Hi @socutes, thanks for the PR. However, I would say it comes a bit early. Version 3.0.0 is not yet released, actually we are currently working towards that release. So any PR me

[GitHub] [kafka] guozhangwang merged pull request #10871: KAFKA-8940: decrease session timeout to make test faster and reliable

2021-06-14 Thread GitBox
guozhangwang merged pull request #10871: URL: https://github.com/apache/kafka/pull/10871 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, p

[GitHub] [kafka] iakunin edited a comment on pull request #10775: KAFKA-12668: Making MockScheduler.schedule safe to use in concurrent code

2021-06-14 Thread GitBox
iakunin edited a comment on pull request #10775: URL: https://github.com/apache/kafka/pull/10775#issuecomment-860042763 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [kafka] chia7712 commented on a change in pull request #10852: MINOR: Replace easymock with mockito in log4j-appender

2021-06-14 Thread GitBox
chia7712 commented on a change in pull request #10852: URL: https://github.com/apache/kafka/pull/10852#discussion_r650510053 ## File path: log4j-appender/src/test/java/org/apache/kafka/log4jappender/KafkaLog4jAppenderTest.java ## @@ -159,17 +161,18 @@ public void testRealProd

[GitHub] [kafka] ijuma commented on pull request #10872: KAFKA-12945: Remove port, host.name and related configs in 3.0

2021-06-14 Thread GitBox
ijuma commented on pull request #10872: URL: https://github.com/apache/kafka/pull/10872#issuecomment-860227370 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries a

[GitHub] [kafka] feyman2016 commented on pull request #10377: KAFKA-12515 ApiVersionManager should create response based on request version

2021-06-14 Thread GitBox
feyman2016 commented on pull request #10377: URL: https://github.com/apache/kafka/pull/10377#issuecomment-860202376 @rajinisivaram Sorry for the late reply, I tried to set the `FinalizedFeatures` and `SupportedFeatures` to `"ignorable": true` and modified the `BrokerFeatures.createDefault(

[jira] [Resolved] (KAFKA-12847) Dockerfile needed for kafka system tests needs changes

2021-06-14 Thread Abhijit Mane (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhijit Mane resolved KAFKA-12847. -- Reviewer: Chia-Ping Tsai Resolution: Won't Fix This issue is valid if SysTests are run a

[GitHub] [kafka] ijuma merged pull request #10702: KAFKA-12940: Enable JDK 16 builds in Jenkins

2021-06-14 Thread GitBox
ijuma merged pull request #10702: URL: https://github.com/apache/kafka/pull/10702 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[GitHub] [kafka] showuon commented on a change in pull request #10437: MINOR: Remove deprecated `host.name`, `advertised.host.name`, `port` and `advertised.port` for 3.0

2021-06-14 Thread GitBox
showuon commented on a change in pull request #10437: URL: https://github.com/apache/kafka/pull/10437#discussion_r650625978 ## File path: core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala ## @@ -143,73 +143,6 @@ class KafkaConfigTest { } - @Test - def testAdv

[GitHub] [kafka] socutes commented on pull request #10876: KAFKA-12843: KIP-740 follow up: clean up TaskMetadata

2021-06-14 Thread GitBox
socutes commented on pull request #10876: URL: https://github.com/apache/kafka/pull/10876#issuecomment-860171343 @ableegoldman please help to review this patch! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] dajac commented on a change in pull request #10858: KAFKA-12926: ConsumerGroupCommand's java.lang.NullPointerException at negative offsets while running kafka-consumer-groups.sh

2021-06-14 Thread GitBox
dajac commented on a change in pull request #10858: URL: https://github.com/apache/kafka/pull/10858#discussion_r650349885 ## File path: core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala ## @@ -559,7 +559,7 @@ object ConsumerGroupCommand extends Logging { val g

[GitHub] [kafka] ijuma opened a new pull request #10872: KAFKA-12945: Remove port, host.name and related configs in 3.0

2021-06-14 Thread GitBox
ijuma opened a new pull request #10872: URL: https://github.com/apache/kafka/pull/10872 They have been deprecated since 0.10.0. Full list of removes configs: * port * host.name * advertised.port * advertised.host.name Also adjust tests to take the removals into account.

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

2021-06-14 Thread GitBox
jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r650612574 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java ## @@ -254,8 +255,14 @@ public synchronized int sendFetches()

[GitHub] [kafka] showuon commented on a change in pull request #10862: KAFKA-12928: Add a check whether the Task's statestore is actually a directory

2021-06-14 Thread GitBox
showuon commented on a change in pull request #10862: URL: https://github.com/apache/kafka/pull/10862#discussion_r650651936 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java ## @@ -126,7 +126,7 @@ public StateDirectory(final S

[jira] [Comment Edited] (KAFKA-12847) Dockerfile needed for kafka system tests needs changes

2021-06-14 Thread Abhijit Mane (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17362811#comment-17362811 ] Abhijit Mane edited comment on KAFKA-12847 at 6/14/21, 8:17 AM: --

[GitHub] [kafka] Dragotic commented on pull request #10644: [KAFKA-12635] auto sync consumer offset 0 when translated offset larger than partition end offset

2021-06-14 Thread GitBox
Dragotic commented on pull request #10644: URL: https://github.com/apache/kafka/pull/10644#issuecomment-860509704 Hello team! @ning2008wisc thank you very much for the bug fix, any update on when we can expect this to be merged to the upstream and released? -- This is an automate

  1   2   3   >