feyman2016 edited a comment on pull request #10593:
URL: https://github.com/apache/kafka/pull/10593#issuecomment-860066550


   > I have been working on a PR related to this if you want to take a look: 
#10786. It would be nice to get your PR merged before my PR.
   
   @jsancio Thanks for the reply, now I understand the background. I think the 
optional validation for when `createSnapshot` is called has been covered in 
this PR, while the case for `onSnapshotFrozen` has not been covered yet.  
Looking at the code,  `onSnapshotFrozen` is called 
by`FileRawSnapshotWriter#freeze` which may be called by `KafkaRaftClient ` or 
`SnapshotWriter`, if we want to do the optional validation, I assume a KIP is 
needed for tweaking `RawSnapshotWriter#freeze()` as sth like 
`RawSnapshotWriter#freeze(Origin origin)`, based on the origin, it can decide 
whether validation is needed. But since this is PR is preferable to be merged 
before #10786  , would it take too much time to go through the KIP and contain 
the change in this PR? Or may be we can make a seperate PR to handle the 
validation for `onSnapshotFrozen`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to