mdedetrich commented on a change in pull request #10839:
URL: https://github.com/apache/kafka/pull/10839#discussion_r649850434
##########
File path: core/src/main/scala/kafka/tools/TestRaftServer.scala
##########
@@ -466,3 +459,10 @@ object TestRaftServer extends Logging {
}
}
+
+private[tools] sealed trait RaftEvent
+private[tools] final case class HandleClaim(epoch: Int) extends RaftEvent
+private[tools] case object HandleResign extends RaftEvent
+private[tools] final case class HandleCommit(reader: BatchReader[Array[Byte]])
extends RaftEvent
+private[tools] final case class HandleSnapshot(reader:
SnapshotReader[Array[Byte]]) extends RaftEvent
+private[tools] case object Shutdown extends RaftEvent
Review comment:
Yes, I had to move the case classes either into an `object` or as a top
level class because otherwise the Scala compiler warns about an unambigious
reference (which fails to build in Kafka since Kafka doesn't allow warnings to
come through).
##########
File path:
core/src/test/scala/unit/kafka/security/authorizer/AclAuthorizerWithZkSaslTest.scala
##########
@@ -178,9 +177,3 @@ class TestableDigestLoginModule extends DigestLoginModule {
}
}
}
-
-class TestableJaasSection(contextName: String, modules: Seq[JaasModule])
extends JaasSection(contextName, modules) {
Review comment:
There is a change which you commented on where `new TestableJaasSection`
was changed to `JassSection`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
