[GitHub] [kafka] dongjinleekr commented on a change in pull request #10507: KAFKA-8410: Migrating stateful operators to new Processor API

dongjinleekr commented on a change in pull request #10507: URL: https://github.com/apache/kafka/pull/10507#discussion_r644545454 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/AbstractStream.java ## @@ -16,6 +16,10 @@ */ package org.apache.ka

[GitHub] [kafka] dongjinleekr commented on a change in pull request #10507: KAFKA-8410: Migrating stateful operators to new Processor API

dongjinleekr commented on a change in pull request #10507: URL: https://github.com/apache/kafka/pull/10507#discussion_r644546368 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/AbstractStream.java ## @@ -16,6 +16,10 @@ */ package org.apache.ka

[GitHub] [kafka] cadonna commented on a change in pull request #10798: KAFKA-9168: Adding direct byte buffer support to rocksdb state store

cadonna commented on a change in pull request #10798: URL: https://github.com/apache/kafka/pull/10798#discussion_r644552319 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java ## @@ -505,6 +506,14 @@ private void closeOpenIterators()

[GitHub] [kafka] showuon commented on a change in pull request #10471: KAFKA-12597: remove deprecated zookeeper option in ReassignPartitionsCommand

showuon commented on a change in pull request #10471: URL: https://github.com/apache/kafka/pull/10471#discussion_r644562533 ## File path: core/src/test/scala/integration/kafka/admin/ReassignPartitionsIntegrationTest.scala ## @@ -151,7 +148,7 @@ class ReassignPartitionsIntegrat

[jira] [Assigned] (KAFKA-9220) TimeoutException when using kafka-preferred-replica-election

[ https://issues.apache.org/jira/browse/KAFKA-9220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] loboxu reassigned KAFKA-9220: - Assignee: (was: loboxu) > TimeoutException when using kafka-preferred-replica-election > ---

[GitHub] [kafka] showuon commented on a change in pull request #10471: KAFKA-12597: remove deprecated zookeeper option in ReassignPartitionsCommand

showuon commented on a change in pull request #10471: URL: https://github.com/apache/kafka/pull/10471#discussion_r644564429 ## File path: core/src/test/scala/integration/kafka/admin/ReassignPartitionsIntegrationTest.scala ## @@ -128,11 +126,10 @@ class ReassignPartitionsIntegr

[GitHub] [kafka] showuon commented on a change in pull request #10471: KAFKA-12597: remove deprecated zookeeper option in ReassignPartitionsCommand

showuon commented on a change in pull request #10471: URL: https://github.com/apache/kafka/pull/10471#discussion_r644564429 ## File path: core/src/test/scala/integration/kafka/admin/ReassignPartitionsIntegrationTest.scala ## @@ -128,11 +126,10 @@ class ReassignPartitionsIntegr

[GitHub] [kafka] showuon commented on a change in pull request #10471: KAFKA-12597: remove deprecated zookeeper option in ReassignPartitionsCommand

showuon commented on a change in pull request #10471: URL: https://github.com/apache/kafka/pull/10471#discussion_r644564429 ## File path: core/src/test/scala/integration/kafka/admin/ReassignPartitionsIntegrationTest.scala ## @@ -128,11 +126,10 @@ class ReassignPartitionsIntegr

[GitHub] [kafka] cadonna commented on a change in pull request #10798: KAFKA-9168: Adding direct byte buffer support to rocksdb state store

cadonna commented on a change in pull request #10798: URL: https://github.com/apache/kafka/pull/10798#discussion_r644566174 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java ## @@ -505,6 +506,14 @@ private void closeOpenIterators()

[jira] [Comment Edited] (KAFKA-9220) TimeoutException when using kafka-preferred-replica-election

[ https://issues.apache.org/jira/browse/KAFKA-9220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17356061#comment-17356061 ] loboxu edited comment on KAFKA-9220 at 6/3/21, 7:49 AM: [~mark606

[GitHub] [kafka] mdedetrich edited a comment on pull request #10648: KAFKA-9726: Add IdentityReplicationPolicy for MM2

mdedetrich edited a comment on pull request #10648: URL: https://github.com/apache/kafka/pull/10648#issuecomment-835180661 @mimaison I have just renamed `LegacyReplicationPolicy` to `IdentityReplicationPolicy` and forced pushed the branch. @ryannedolan I will have a look at https://

[jira] [Created] (KAFKA-12884) Remove "--zookeeper" in system tests

Luke Chen created KAFKA-12884: - Summary: Remove "--zookeeper" in system tests Key: KAFKA-12884 URL: https://issues.apache.org/jira/browse/KAFKA-12884 Project: Kafka Issue Type: Sub-task

[jira] [Updated] (KAFKA-12884) Remove "--zookeeper" in system tests

[ https://issues.apache.org/jira/browse/KAFKA-12884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-12884: -- Description: Have a quick scan, found currently, we did use "–zookeeper" option for some cases. Need

[GitHub] [kafka] mdedetrich commented on pull request #10652: KAFKA-9726 IdentityReplicationPolicy

mdedetrich commented on pull request #10652: URL: https://github.com/apache/kafka/pull/10652#issuecomment-853663746 @mimaison As my PR at https://github.com/apache/kafka/pull/10648 has been superseded by this one, would it be possible to do a quick review of it? Afaik its ready and @ryanne

[GitHub] [kafka] showuon commented on pull request #10471: KAFKA-12597: remove deprecated zookeeper option in ReassignPartitionsCommand

showuon commented on pull request #10471: URL: https://github.com/apache/kafka/pull/10471#issuecomment-853665420 @ijuma , thanks for your comments. I've addressed them and add a note in upgrade.html in this commit: https://github.com/apache/kafka/pull/10471/commits/92157779ce7fa347337916b0

[GitHub] [kafka] tombentley commented on a change in pull request #9441: KAFKA-10614: Ensure group state (un)load is executed in the submitted order

tombentley commented on a change in pull request #9441: URL: https://github.com/apache/kafka/pull/9441#discussion_r644571665 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -279,30 +279,33 @@ class KafkaApis(val requestChannel: RequestChannel, new

[jira] [Commented] (KAFKA-9168) Integrate JNI direct buffer support to RocksDBStore

[ https://issues.apache.org/jira/browse/KAFKA-9168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17356273#comment-17356273 ] Bruno Cadonna commented on KAFKA-9168: -- Hi [~sagarrao], our internal benchmark did n

[jira] [Created] (KAFKA-12885) Add the --timeout property to kafka-leader-election.sh

loboxu created KAFKA-12885: -- Summary: Add the --timeout property to kafka-leader-election.sh Key: KAFKA-12885 URL: https://issues.apache.org/jira/browse/KAFKA-12885 Project: Kafka Issue Type: Improv

[jira] [Commented] (KAFKA-12885) Add the --timeout property to kafka-leader-election.sh

[ https://issues.apache.org/jira/browse/KAFKA-12885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17356286#comment-17356286 ] loboxu commented on KAFKA-12885: [~showuon]  [~jagsancio] Can you help me check it? Is i

[jira] [Commented] (KAFKA-9168) Integrate JNI direct buffer support to RocksDBStore

[ https://issues.apache.org/jira/browse/KAFKA-9168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17356292#comment-17356292 ] Sagar Rao commented on KAFKA-9168: -- hi [~cadonna], Thanks for the feedback. Actually, wh

[GitHub] [kafka] vamossagar12 commented on a change in pull request #10798: KAFKA-9168: Adding direct byte buffer support to rocksdb state store

vamossagar12 commented on a change in pull request #10798: URL: https://github.com/apache/kafka/pull/10798#discussion_r644616944 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java ## @@ -505,6 +506,14 @@ private void closeOpenIterato

[GitHub] [kafka] cadonna commented on a change in pull request #10798: KAFKA-9168: Adding direct byte buffer support to rocksdb state store

cadonna commented on a change in pull request #10798: URL: https://github.com/apache/kafka/pull/10798#discussion_r644633213 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java ## @@ -505,6 +506,14 @@ private void closeOpenIterators()

[GitHub] [kafka] dongjinleekr commented on pull request #10698: KAFKA-12770: introduce `checkstyleVersion` build option (for overriding CheckStyle project-defined dependency version)

dongjinleekr commented on pull request #10698: URL: https://github.com/apache/kafka/pull/10698#issuecomment-853729405 Cool. Working Like a charm. `./gradlew checkstyleMain checkstyleTest`: ![1](https://user-images.githubusercontent.com/2375128/120622109-7bbdaa80-c499-11eb-97ea-11c

[GitHub] [kafka] cadonna commented on a change in pull request #10664: KAFKA-12749: Changelog topic config on suppressed KTable lost

cadonna commented on a change in pull request #10664: URL: https://github.com/apache/kafka/pull/10664#discussion_r644644247 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/suppress/EagerBufferConfigImpl.java ## @@ -28,13 +28,7 @@ private fin

[GitHub] [kafka] cadonna commented on pull request #10664: KAFKA-12749: Changelog topic config on suppressed KTable lost

cadonna commented on pull request #10664: URL: https://github.com/apache/kafka/pull/10664#issuecomment-853748677 @vichu I took the liberty to commit the fix to the nit directly. I hope that is fine with you. -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [kafka] cadonna commented on pull request #10664: KAFKA-12749: Changelog topic config on suppressed KTable lost

cadonna commented on pull request #10664: URL: https://github.com/apache/kafka/pull/10664#issuecomment-853748989 I will merge as soon as the checks are done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [kafka] vamossagar12 commented on a change in pull request #10798: KAFKA-9168: Adding direct byte buffer support to rocksdb state store

vamossagar12 commented on a change in pull request #10798: URL: https://github.com/apache/kafka/pull/10798#discussion_r644672950 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java ## @@ -505,6 +506,14 @@ private void closeOpenIterato

[GitHub] [kafka] showuon commented on pull request #10794: KAFKA-12677: parse envelope response to check if not_controller error existed

showuon commented on pull request #10794: URL: https://github.com/apache/kafka/pull/10794#issuecomment-853761494 @hachikuji @mumrah @abbccdda @cmccabe , call for review. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [kafka] cadonna commented on a change in pull request #10798: KAFKA-9168: Adding direct byte buffer support to rocksdb state store

cadonna commented on a change in pull request #10798: URL: https://github.com/apache/kafka/pull/10798#discussion_r644699017 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java ## @@ -505,6 +506,14 @@ private void closeOpenIterators()

[GitHub] [kafka] cadonna commented on a change in pull request #10798: KAFKA-9168: Adding direct byte buffer support to rocksdb state store

cadonna commented on a change in pull request #10798: URL: https://github.com/apache/kafka/pull/10798#discussion_r644699017 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java ## @@ -505,6 +506,14 @@ private void closeOpenIterators()

[GitHub] [kafka] cadonna commented on a change in pull request #10428: KAFKA-12572: Add import ordering checkstyle rule and configure an automatic formatter

cadonna commented on a change in pull request #10428: URL: https://github.com/apache/kafka/pull/10428#discussion_r644711679 ## File path: core/src/main/java/kafka/metrics/FilteringJmxReporter.java ## @@ -51,7 +50,7 @@ public void updatePredicate(Predicate predicate) {

[GitHub] [kafka] dongjinleekr commented on pull request #10428: KAFKA-12572: Add import ordering checkstyle rule and configure an automatic formatter

dongjinleekr commented on pull request #10428: URL: https://github.com/apache/kafka/pull/10428#issuecomment-853821984 @cadonna Here it is, with the following: 1. making server-common to ignore import orders. 2. rebasing onto the latest trunk. +1. It seems like we can make the eclipse

[GitHub] [kafka] showuon opened a new pull request #10811: KAFKA-12598: remove zookeeper support on configCommand except security config

showuon opened a new pull request #10811: URL: https://github.com/apache/kafka/pull/10811 Checked the documentation, we must use `--zookeeper` option in 2 places: 1. [config SCRAM Credentials](https://kafka.apache.org/documentation/#security_sasl_scram_credentials) 2. [Update password

[GitHub] [kafka] showuon commented on pull request #10811: KAFKA-12598: remove zookeeper support on configCommand except security config

showuon commented on pull request #10811: URL: https://github.com/apache/kafka/pull/10811#issuecomment-853823700 @ijuma , please help review this PR. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [kafka] showuon commented on a change in pull request #10811: KAFKA-12598: remove zookeeper support on configCommand except security config

showuon commented on a change in pull request #10811: URL: https://github.com/apache/kafka/pull/10811#discussion_r644741927 ## File path: core/src/main/scala/kafka/admin/ConfigCommand.scala ## @@ -731,10 +731,11 @@ object ConfigCommand extends Config { class ConfigCommandOpt

[GitHub] [kafka] showuon commented on a change in pull request #10811: KAFKA-12598: remove zookeeper support on configCommand except security config

showuon commented on a change in pull request #10811: URL: https://github.com/apache/kafka/pull/10811#discussion_r644742376 ## File path: core/src/main/scala/kafka/admin/ConfigCommand.scala ## @@ -876,6 +877,10 @@ object ConfigCommand extends Config { throw new Illegal

[GitHub] [kafka] showuon edited a comment on pull request #10794: KAFKA-12677: parse envelope response to check if not_controller error existed

showuon edited a comment on pull request #10794: URL: https://github.com/apache/kafka/pull/10794#issuecomment-853761494 @hachikuji @mumrah @abbccdda @cmccabe , call for review since the tests keep failing. Thank you. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] dongjinleekr commented on pull request #10678: TRIVIAL: Fix type inconsistencies, unthrown exceptions, etc

dongjinleekr commented on pull request #10678: URL: https://github.com/apache/kafka/pull/10678#issuecomment-853838170 @ableegoldman Could you have a look? :pray: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] ijuma commented on a change in pull request #10471: KAFKA-12597: remove deprecated zookeeper option in ReassignPartitionsCommand

ijuma commented on a change in pull request #10471: URL: https://github.com/apache/kafka/pull/10471#discussion_r644793036 ## File path: core/src/test/scala/integration/kafka/admin/ReassignPartitionsIntegrationTest.scala ## @@ -128,11 +126,10 @@ class ReassignPartitionsIntegrat

[GitHub] [kafka] showuon commented on a change in pull request #10471: KAFKA-12597: remove deprecated zookeeper option in ReassignPartitionsCommand

showuon commented on a change in pull request #10471: URL: https://github.com/apache/kafka/pull/10471#discussion_r644803207 ## File path: docs/upgrade.html ## @@ -43,7 +43,8 @@ Notable changes in 3 AclBindingFilter. The Admin.electedPreferredLeaders() meth

[GitHub] [kafka] dengziming commented on pull request #10793: KAFKA-12338: Remove useless MetadataParser

dengziming commented on pull request #10793: URL: https://github.com/apache/kafka/pull/10793#issuecomment-853911013 @hachikuji Thanks for the remindings, I think the validations in `read` are useful and I copied them to `MetadataRecordSerde`, but not sure whether the `DEFAULT_FRAME_VERSION

[jira] [Updated] (KAFKA-12482) Remove deprecated rest.host.name and rest.port Connect worker configs

[ https://issues.apache.org/jira/browse/KAFKA-12482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch updated KAFKA-12482: -- Summary: Remove deprecated rest.host.name and rest.port Connect worker configs (was: Remove d

[jira] [Updated] (KAFKA-12482) Remove deprecated rest.host.name and rest.port Connect worker configs

[ https://issues.apache.org/jira/browse/KAFKA-12482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch updated KAFKA-12482: -- Issue Type: Task (was: Improvement) > Remove deprecated rest.host.name and rest.port Connect

[jira] [Updated] (KAFKA-12717) Remove internal converter config properties

[ https://issues.apache.org/jira/browse/KAFKA-12717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch updated KAFKA-12717: -- Fix Version/s: 3.0.0 > Remove internal converter config properties > -

[jira] [Updated] (KAFKA-12717) Remove internal converter config properties

[ https://issues.apache.org/jira/browse/KAFKA-12717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch updated KAFKA-12717: -- Issue Type: Task (was: Bug) > Remove internal converter config properties > -

[jira] [Updated] (KAFKA-12482) Remove deprecated rest.host.name and rest.port Connect worker configs

[ https://issues.apache.org/jira/browse/KAFKA-12482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch updated KAFKA-12482: -- Description: The following Connect worker configuration properties were deprecated and should

[jira] [Commented] (KAFKA-12482) Remove deprecated rest.host.name and rest.port Connect worker configs

[ https://issues.apache.org/jira/browse/KAFKA-12482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17356530#comment-17356530 ] Randall Hauch commented on KAFKA-12482: --- Update: it's time to remove these -- it's

[jira] [Assigned] (KAFKA-12482) Remove deprecated rest.host.name and rest.port Connect worker configs

[ https://issues.apache.org/jira/browse/KAFKA-12482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch reassigned KAFKA-12482: - Assignee: Kalpesh Patel > Remove deprecated rest.host.name and rest.port Connect worker

[jira] [Commented] (KAFKA-12482) Remove deprecated rest.host.name and rest.port Connect worker configs

[ https://issues.apache.org/jira/browse/KAFKA-12482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17356532#comment-17356532 ] Kalpesh Patel commented on KAFKA-12482: --- Thanks, I plan to take care of this in th

[GitHub] [kafka] jsancio opened a new pull request #10812: KAFKA-12863: Configure controller snapshot generation

jsancio opened a new pull request #10812: URL: https://github.com/apache/kafka/pull/10812 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing

[GitHub] [kafka] cadonna commented on pull request #10664: KAFKA-12749: Changelog topic config on suppressed KTable lost

cadonna commented on pull request #10664: URL: https://github.com/apache/kafka/pull/10664#issuecomment-854068049 The 7th build was green on the same commit. I do not know why a 8th build was started. https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-1066

[GitHub] [kafka] cadonna merged pull request #10664: KAFKA-12749: Changelog topic config on suppressed KTable lost

cadonna merged pull request #10664: URL: https://github.com/apache/kafka/pull/10664 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [kafka] vvcephei commented on a change in pull request #10731: KAFKA-12815: Update JavaDocs of ValueTransformerWithKey

vvcephei commented on a change in pull request #10731: URL: https://github.com/apache/kafka/pull/10731#discussion_r645017943 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableTransformValues.java ## @@ -158,7 +158,11 @@ public void init(final

[GitHub] [kafka] vvcephei commented on a change in pull request #10731: KAFKA-12815: Update JavaDocs of ValueTransformerWithKey

vvcephei commented on a change in pull request #10731: URL: https://github.com/apache/kafka/pull/10731#discussion_r645018450 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/ValueTransformerWithKey.java ## @@ -75,14 +75,21 @@ void init(final ProcessorC

[GitHub] [kafka] vvcephei commented on a change in pull request #10810: MINOR: Improve Kafka Streams JavaDocs with regard to record metadata

vvcephei commented on a change in pull request #10810: URL: https://github.com/apache/kafka/pull/10810#discussion_r645023265 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/ProcessorContext.java ## @@ -158,32 +165,52 @@ Cancellable schedule(final Duratio

[GitHub] [kafka] vvcephei commented on a change in pull request #10810: MINOR: Improve Kafka Streams JavaDocs with regard to record metadata

vvcephei commented on a change in pull request #10810: URL: https://github.com/apache/kafka/pull/10810#discussion_r645023666 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorRecordContext.java ## @@ -43,12 +43,11 @@ public ProcessorReco

[GitHub] [kafka] vvcephei commented on a change in pull request #10810: MINOR: Improve Kafka Streams JavaDocs with regard to record metadata

vvcephei commented on a change in pull request #10810: URL: https://github.com/apache/kafka/pull/10810#discussion_r645024604 ## File path: streams/test-utils/src/main/java/org/apache/kafka/streams/processor/MockProcessorContext.java ## @@ -319,7 +321,7 @@ public void setRecord

[GitHub] [kafka] jlprat commented on pull request #10784: KAFKA-12862: Update Scala fmt library and apply fixes

jlprat commented on pull request #10784: URL: https://github.com/apache/kafka/pull/10784#issuecomment-854078089 Any chance any of you has time to check this? cc @mjsax @vvcephei @guozhangwang Thanks! -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [kafka] hachikuji commented on pull request #10804: KAFKA-12877: fix KRPC files with missing flexibleVersions annotations

hachikuji commented on pull request #10804: URL: https://github.com/apache/kafka/pull/10804#issuecomment-854102079 The patch makes sense to me. One alternative to consider is to invert the flexible version specification. Basically get rid of "flexibleVersions" and instead add a "legacyVers

[GitHub] [kafka] hachikuji edited a comment on pull request #10804: KAFKA-12877: fix KRPC files with missing flexibleVersions annotations

hachikuji edited a comment on pull request #10804: URL: https://github.com/apache/kafka/pull/10804#issuecomment-854102079 The patch makes sense to me. One alternative to consider is to inverting the flexible version specification. Basically get rid of "flexibleVersions" and instead add a "

[GitHub] [kafka] cadonna commented on a change in pull request #10428: KAFKA-12572: Add import ordering checkstyle rule and configure an automatic formatter

cadonna commented on a change in pull request #10428: URL: https://github.com/apache/kafka/pull/10428#discussion_r645056431 ## File path: core/src/test/java/kafka/test/MockController.java ## @@ -250,20 +238,18 @@ private ApiError incrementalAlterResource(ConfigResource resourc

[GitHub] [kafka] hachikuji commented on a change in pull request #10793: KAFKA-12338: Remove useless MetadataParser

hachikuji commented on a change in pull request #10793: URL: https://github.com/apache/kafka/pull/10793#discussion_r645084226 ## File path: server-common/src/main/java/org/apache/kafka/server/common/serialization/AbstractApiMessageSerde.java ## @@ -69,16 +76,42 @@ public void

[jira] [Created] (KAFKA-12886) Enable request forwarding by default in 3.0

Jason Gustafson created KAFKA-12886: --- Summary: Enable request forwarding by default in 3.0 Key: KAFKA-12886 URL: https://issues.apache.org/jira/browse/KAFKA-12886 Project: Kafka Issue Type:

[jira] [Updated] (KAFKA-12886) Enable request forwarding by default in 3.0

[ https://issues.apache.org/jira/browse/KAFKA-12886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-12886: Fix Version/s: 3.0.0 > Enable request forwarding by default in 3.0 > -

[GitHub] [kafka] ryannedolan commented on pull request #10652: KAFKA-9726 IdentityReplicationPolicy

ryannedolan commented on pull request #10652: URL: https://github.com/apache/kafka/pull/10652#issuecomment-854215843 None of the failing tests are related. Ready to merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[jira] [Assigned] (KAFKA-12886) Enable request forwarding by default in 3.0

[ https://issues.apache.org/jira/browse/KAFKA-12886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Dielhenn reassigned KAFKA-12886: - Assignee: Ryan Dielhenn (was: Jason Gustafson) > Enable request forwarding by default

[GitHub] [kafka] lct45 opened a new pull request #10813: KAFKA-9559: Change default serde to be `null`

lct45 opened a new pull request #10813: URL: https://github.com/apache/kafka/pull/10813 Implementation of [KIP-741](https://cwiki.apache.org/confluence/display/KAFKA/KIP-741%3A+Change+default+serde+to+be+null) per [KAFKA-9559](https://issues.apache.org/jira/browse/KAFKA-9559). Changes the

[GitHub] [kafka] cmccabe merged pull request #10752: KAFKA-12620 Allocate Producer IDs in KRaft controller

cmccabe merged pull request #10752: URL: https://github.com/apache/kafka/pull/10752 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[jira] [Created] (KAFKA-12887) Do not trigger user-customized ExceptionalHandler for RTE

Guozhang Wang created KAFKA-12887: - Summary: Do not trigger user-customized ExceptionalHandler for RTE Key: KAFKA-12887 URL: https://issues.apache.org/jira/browse/KAFKA-12887 Project: Kafka I

[GitHub] [kafka] junrao commented on a change in pull request #10753: KAFKA-12803: Support reassigning partitions when in KRaft mode

junrao commented on a change in pull request #10753: URL: https://github.com/apache/kafka/pull/10753#discussion_r644352228 ## File path: metadata/src/main/java/org/apache/kafka/controller/RemovingAndAddingReplicas.java ## @@ -0,0 +1,214 @@ +/* + * Licensed to the Apache Softwa

[GitHub] [kafka] guozhangwang commented on pull request #10646: KAFKA-8897 Follow-up: Consolidate the global state stores

guozhangwang commented on pull request #10646: URL: https://github.com/apache/kafka/pull/10646#issuecomment-854262242 @cadonna 1. Filed a ticket for KStreams to enforce shutdown on illegal-X exceptions as a future work. 2. Let the global state mgr to do closing before throwing il

[GitHub] [kafka] dengziming commented on a change in pull request #10793: KAFKA-12338: Remove useless MetadataParser

dengziming commented on a change in pull request #10793: URL: https://github.com/apache/kafka/pull/10793#discussion_r645205625 ## File path: server-common/src/main/java/org/apache/kafka/server/common/serialization/AbstractApiMessageSerde.java ## @@ -69,16 +76,42 @@ public void

[GitHub] [kafka] dengziming commented on a change in pull request #10793: KAFKA-12338: Remove useless MetadataParser

dengziming commented on a change in pull request #10793: URL: https://github.com/apache/kafka/pull/10793#discussion_r645206278 ## File path: server-common/src/main/java/org/apache/kafka/server/common/serialization/AbstractApiMessageSerde.java ## @@ -69,16 +76,42 @@ public void

[jira] [Created] (KAFKA-12888) Add transaction tool

Jason Gustafson created KAFKA-12888: --- Summary: Add transaction tool Key: KAFKA-12888 URL: https://issues.apache.org/jira/browse/KAFKA-12888 Project: Kafka Issue Type: Sub-task R

[GitHub] [kafka] hachikuji opened a new pull request #10814: KAFKA-12888; Add transaction tool from KIP-664

hachikuji opened a new pull request #10814: URL: https://github.com/apache/kafka/pull/10814 This patch adds the transaction tool specified in KIP-664: https://cwiki.apache.org/confluence/display/KAFKA/KIP-664%3A+Provide+tooling+to+detect+and+abort+hanging+transactions. This includes all of

[jira] [Updated] (KAFKA-12885) Add the --timeout property to kafka-leader-election.sh

[ https://issues.apache.org/jira/browse/KAFKA-12885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] loboxu updated KAFKA-12885: --- Description: https://issues.apache.org/jira/browse/KAFKA-9220 mentions kafka-preferred-replica-election.sh

[GitHub] [kafka] socutes opened a new pull request #10815: KAFKA-12885: Add the --timeout property to kafka-leader-election.sh

socutes opened a new pull request #10815: URL: https://github.com/apache/kafka/pull/10815 https://issues.apache.org/jira/browse/KAFKA-9220 mentions kafka-preferred-replica-election.sh script hard-coded timeout problems. I see a similar problem with kafka-leader-election.sh. I would

[GitHub] [kafka] abbccdda merged pull request #10809: MINOR: Style fixes to KafkaRaftClient

abbccdda merged pull request #10809: URL: https://github.com/apache/kafka/pull/10809 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pleas

[jira] [Assigned] (KAFKA-9726) LegacyReplicationPolicy for MM2 to mimic MM1

[ https://issues.apache.org/jira/browse/KAFKA-9726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryanne Dolan reassigned KAFKA-9726: --- Assignee: Ryanne Dolan (was: Matthew de Detrich) > LegacyReplicationPolicy for MM2 to mimic

[jira] [Updated] (KAFKA-9726) IdentityReplicationPolicy for MM2 to mimic MM1

[ https://issues.apache.org/jira/browse/KAFKA-9726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryanne Dolan updated KAFKA-9726: Summary: IdentityReplicationPolicy for MM2 to mimic MM1 (was: LegacyReplicationPolicy for MM2 to m

[jira] [Commented] (KAFKA-9726) IdentityReplicationPolicy for MM2 to mimic MM1

[ https://issues.apache.org/jira/browse/KAFKA-9726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17357014#comment-17357014 ] Ryanne Dolan commented on KAFKA-9726: - PR ready for merge. > IdentityReplicationPoli

[jira] [Updated] (KAFKA-9726) LegacyReplicationPolicy for MM2 to mimic MM1

[ https://issues.apache.org/jira/browse/KAFKA-9726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryanne Dolan updated KAFKA-9726: Priority: Major (was: Minor) > LegacyReplicationPolicy for MM2 to mimic MM1 >

[jira] [Updated] (KAFKA-9726) LegacyReplicationPolicy for MM2 to mimic MM1

[ https://issues.apache.org/jira/browse/KAFKA-9726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryanne Dolan updated KAFKA-9726: Fix Version/s: 3.0.0 > LegacyReplicationPolicy for MM2 to mimic MM1 > -

[GitHub] [kafka] showuon closed pull request #9672: MINOR: work in progress for Eos test(don't review)

showuon closed pull request #9672: URL: https://github.com/apache/kafka/pull/9672 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[GitHub] [kafka] showuon opened a new pull request #10816: [WIP] MINOR: acl tests

showuon opened a new pull request #10816: URL: https://github.com/apache/kafka/pull/10816 test ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including u

[GitHub] [kafka] mjsax commented on a change in pull request #10813: KAFKA-9559: Change default serde to be `null`

mjsax commented on a change in pull request #10813: URL: https://github.com/apache/kafka/pull/10813#discussion_r645299252 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/ChangedSerializer.java ## @@ -40,7 +40,10 @@ public ChangedSerializer(final

[GitHub] [kafka] mjsax commented on a change in pull request #10813: KAFKA-9559: Change default serde to be `null`

mjsax commented on a change in pull request #10813: URL: https://github.com/apache/kafka/pull/10813#discussion_r645306551 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/SinkNode.java ## @@ -60,8 +60,8 @@ public void init(final InternalProcesso

[GitHub] [kafka] mjsax commented on pull request #10813: KAFKA-9559: Change default serde to be `null`

mjsax commented on pull request #10813: URL: https://github.com/apache/kafka/pull/10813#issuecomment-854379331 How confident are we, that we covered most cases to avoid NPE and throw ConfigException? Seems it's still many places that we need to cover, and I am wondering if we follow the ri

[GitHub] [kafka] ijuma commented on pull request #10809: MINOR: Style fixes to KafkaRaftClient

ijuma commented on pull request #10809: URL: https://github.com/apache/kafka/pull/10809#issuecomment-854385011 @abbccdda Committer approval is required for PRs to be merged. I don't see that here. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [kafka] ijuma commented on a change in pull request #10805: KAFKA-12436 KIP-720 Deprecate MirrorMaker v1

ijuma commented on a change in pull request #10805: URL: https://github.com/apache/kafka/pull/10805#discussion_r645317670 ## File path: core/src/main/scala/kafka/tools/MirrorMaker.scala ## @@ -58,7 +58,10 @@ import scala.util.{Failure, Success, Try} *enable.auto.c

[GitHub] [kafka] socutes commented on pull request #10815: KAFKA-12885: Add the --timeout property to kafka-leader-election.sh

socutes commented on pull request #10815: URL: https://github.com/apache/kafka/pull/10815#issuecomment-854395260 @showuon , please help review this PR. Thanks！ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [kafka] ijuma commented on a change in pull request #10794: KAFKA-12677: parse envelope response to check if not_controller error existed

ijuma commented on a change in pull request #10794: URL: https://github.com/apache/kafka/pull/10794#discussion_r645318499 ## File path: build.gradle ## @@ -829,6 +829,7 @@ project(':core') { testImplementation(libs.jfreechart) { exclude group: 'junit', module: 'juni

[GitHub] [kafka] ijuma commented on pull request #9302: KAFKA-10149: Allow auto preferred leader election when partitions are reassigning

ijuma commented on pull request #9302: URL: https://github.com/apache/kafka/pull/9302#issuecomment-854395748 Is this still relevant? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] ijuma commented on pull request #10471: KAFKA-12597: remove deprecated zookeeper option in ReassignPartitionsCommand

ijuma commented on pull request #10471: URL: https://github.com/apache/kafka/pull/10471#issuecomment-854399316 Unrelated test failures: > Build / JDK 11 and Scala 2.13 / kafka.server.RaftClusterTest.testCreateClusterAndCreateListDeleteTopic() | 16 sec | 1 > -- | -- | -- > Buil

[GitHub] [kafka] ijuma edited a comment on pull request #10471: KAFKA-12597: remove deprecated zookeeper option in ReassignPartitionsCommand

ijuma edited a comment on pull request #10471: URL: https://github.com/apache/kafka/pull/10471#issuecomment-854399316 Unrelated test failures: > Build / JDK 11 and Scala 2.13 / kafka.server.RaftClusterTest.testCreateClusterAndCreateListDeleteTopic() > Build / JDK 11 and Scala 2.13

[GitHub] [kafka] showuon commented on a change in pull request #10794: KAFKA-12677: parse envelope response to check if not_controller error existed

showuon commented on a change in pull request #10794: URL: https://github.com/apache/kafka/pull/10794#discussion_r645321936 ## File path: build.gradle ## @@ -829,6 +829,7 @@ project(':core') { testImplementation(libs.jfreechart) { exclude group: 'junit', module: 'ju

[GitHub] [kafka] ijuma merged pull request #10471: KAFKA-12597: remove deprecated zookeeper option in ReassignPartitionsCommand

ijuma merged pull request #10471: URL: https://github.com/apache/kafka/pull/10471 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[GitHub] [kafka] showuon commented on pull request #10471: KAFKA-12597: remove deprecated zookeeper option in ReassignPartitionsCommand

showuon commented on pull request #10471: URL: https://github.com/apache/kafka/pull/10471#issuecomment-854401341 Thanks @ijuma , I should have listed all failed tests and verify they are all un-related failure to reduce your review task. Thank you. :) -- This is an automated message from

[GitHub] [kafka] abbccdda commented on pull request #10809: MINOR: Style fixes to KafkaRaftClient

abbccdda commented on pull request #10809: URL: https://github.com/apache/kafka/pull/10809#issuecomment-854402436 @ijuma That's a good call, should I revert it? It was just a styling change PR. -- This is an automated message from the Apache Git Service. To respond to the message, please