vamossagar12 commented on a change in pull request #10798:
URL: https://github.com/apache/kafka/pull/10798#discussion_r644672950



##########
File path: 
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java
##########
@@ -505,6 +506,14 @@ private void closeOpenIterators() {
         }
     }
 
+    private ByteBuffer createDirectByteBufferAndPut(byte[] bytes) {
+        ByteBuffer directBuffer = ByteBuffer.allocateDirect(bytes.length);

Review comment:
       ok. That makes sense. High concurrency is one of the cases where this 
might be useful. Having said that, on the PR, there are benchmarking numbers 
for a large number of put operations in a single threaded manner. As per the 
numbers direct byte buffer was 37% faster and with 0 GC cycles. 
   
   Here is the comment: 
https://github.com/facebook/rocksdb/pull/2283#issuecomment-561563037
   
   The users of kafka streams might call put() in this manner where in they 
loop through a bunch of records and use put() to insert. From the state store 
side, either we create 1 DirectByteBuffer object for put() and keep reusing it- 
subject to testing. But that might not always be the case. 
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to