[GitHub] [kafka] cadonna commented on a change in pull request #10798: KAFKA-9168: Adding direct byte buffer support to rocksdb state store

[GitBox]

cadonna commented on a change in pull request #10798:
URL: https://github.com/apache/kafka/pull/10798#discussion_r644699017



##########
File path: 
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java
##########
@@ -505,6 +506,14 @@ private void closeOpenIterators() {
         }
     }
 
+    private ByteBuffer createDirectByteBufferAndPut(byte[] bytes) {
+        ByteBuffer directBuffer = ByteBuffer.allocateDirect(bytes.length);

Review comment:
       Yes, I think you should try to benchmarks 
putAll()/range/reverseRange/prefixSeek operations as you proposed with a simple 
Kafka Streams app. That would be great to better understand the potential of 
direct buffers for Kafka Streams. Maybe experiment also with different key and 
value sizes.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org