[GitHub] [kafka] dajac commented on a change in pull request #9526: KAFKA-10525: Emit JSONs with new auto-generated schema

dajac commented on a change in pull request #9526: URL: https://github.com/apache/kafka/pull/9526#discussion_r520340843 ## File path: clients/src/test/java/org/apache/kafka/common/message/SimpleExampleMessageTest.java ## @@ -394,7 +394,7 @@ private void testRoundTrip(SimpleExa

[jira] [Commented] (KAFKA-10683) Consumer.position() Ignores Transaction Marker with read_uncommitted

[ https://issues.apache.org/jira/browse/KAFKA-10683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17229072#comment-17229072 ] Ruslan Gryn commented on KAFKA-10683: - The issue with max.poll.record is not only re

[GitHub] [kafka] showuon commented on a change in pull request #9576: KAFKA-10685: strictly parsing the date/time format

showuon commented on a change in pull request #9576: URL: https://github.com/apache/kafka/pull/9576#discussion_r520397896 ## File path: clients/src/main/java/org/apache/kafka/common/utils/Utils.java ## @@ -1281,30 +1281,36 @@ private static byte checkRange(final byte i) {

[GitHub] [kafka] tombentley commented on pull request #9433: KAFKA-10607: Consistent behaviour for response errorCounts()

tombentley commented on pull request #9433: URL: https://github.com/apache/kafka/pull/9433#issuecomment-724572562 > Personally, the implementations of `errorCounts` are almost same. Maybe it should be implemented > by auto-generated protocol so the consistency (code style and behavior)

[jira] [Assigned] (KAFKA-10547) Add topic IDs to MetadataResponse

[ https://issues.apache.org/jira/browse/KAFKA-10547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dengziming reassigned KAFKA-10547: -- Assignee: dengziming > Add topic IDs to MetadataResponse > -

[GitHub] [kafka] chia7712 commented on pull request #9433: KAFKA-10607: Consistent behaviour for response errorCounts()

chia7712 commented on pull request #9433: URL: https://github.com/apache/kafka/pull/9433#issuecomment-724592314 @tombentley Thanks for your sharing. It inspires me to think about the possible solution. The following comment is not related to this PR. just discussion 😃 > That's a goo

[GitHub] [kafka] chia7712 edited a comment on pull request #9433: KAFKA-10607: Consistent behaviour for response errorCounts()

chia7712 edited a comment on pull request #9433: URL: https://github.com/apache/kafka/pull/9433#issuecomment-724592314 @tombentley Thanks for your sharing. It inspires me to think about the possible solution. The following comment is not related to this PR. just discussion 😃 > That'

[GitHub] [kafka] chia7712 commented on a change in pull request #9204: KAFKA-6181 Examining log messages with {{--deep-iteration}} should show superset of fields

chia7712 commented on a change in pull request #9204: URL: https://github.com/apache/kafka/pull/9204#discussion_r520431846 ## File path: core/src/main/scala/kafka/tools/DumpLogSegments.scala ## @@ -257,8 +257,12 @@ object DumpLogSegments { } lastOffset

[GitHub] [kafka] rajinisivaram commented on pull request #9578: MINOR: Log resource pattern of ACL updates at INFO level

rajinisivaram commented on pull request #9578: URL: https://github.com/apache/kafka/pull/9578#issuecomment-724623526 @omkreddy Thanks for the review, merging to trunk This is an automated message from the Apache Git Service.

[GitHub] [kafka] rajinisivaram merged pull request #9578: MINOR: Log resource pattern of ACL updates at INFO level

rajinisivaram merged pull request #9578: URL: https://github.com/apache/kafka/pull/9578 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] urbandan commented on pull request #9430: KAFKA-5235: GetOffsetShell: support for multiple topics and consumer configuration override

urbandan commented on pull request #9430: URL: https://github.com/apache/kafka/pull/9430#issuecomment-724629025 @dajac Thanks for the reminder, pushed a bunch of unit tests covering the GetOffsetShell tool. This is an automa

[GitHub] [kafka] rajinisivaram commented on a change in pull request #9560: KAFKA-10345: Add ZK-notification based update for trust/key store paths

rajinisivaram commented on a change in pull request #9560: URL: https://github.com/apache/kafka/pull/9560#discussion_r520474354 ## File path: core/src/main/scala/kafka/server/DynamicBrokerConfig.scala ## @@ -331,6 +334,50 @@ class DynamicBrokerConfig(private val kafkaConfig: K

[GitHub] [kafka] iprithv commented on a change in pull request #9204: KAFKA-6181 Examining log messages with {{--deep-iteration}} should show superset of fields

iprithv commented on a change in pull request #9204: URL: https://github.com/apache/kafka/pull/9204#discussion_r520491160 ## File path: core/src/main/scala/kafka/tools/DumpLogSegments.scala ## @@ -257,8 +257,12 @@ object DumpLogSegments { } lastOffset

[GitHub] [kafka] cadonna commented on a change in pull request #9572: KAFKA-10500: Thread Cache Resizes

cadonna commented on a change in pull request #9572: URL: https://github.com/apache/kafka/pull/9572#discussion_r520445787 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -155,6 +155,7 @@ private final StreamsMetricsImpl streamsMetrics;

[GitHub] [kafka] tombentley commented on pull request #9433: KAFKA-10607: Consistent behaviour for response errorCounts()

tombentley commented on pull request #9433: URL: https://github.com/apache/kafka/pull/9433#issuecomment-724662509 @chia7712 For this PR I've added a test. It revealed a few places where responses had error fields which weren't included in the count. This will affect the metrics for those R

[GitHub] [kafka] dajac commented on a change in pull request #7498: KAFKA-9023: Log request destination when the Producer gets disconnected

dajac commented on a change in pull request #7498: URL: https://github.com/apache/kafka/pull/7498#discussion_r520520725 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java ## @@ -639,8 +644,9 @@ else if (error == Errors.CLUSTER_AUTHORIZA

[GitHub] [kafka] dajac commented on a change in pull request #7498: KAFKA-9023: Log request destination when the Producer gets disconnected

dajac commented on a change in pull request #7498: URL: https://github.com/apache/kafka/pull/7498#discussion_r520522778 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java ## @@ -588,17 +589,20 @@ private void handleProduceResponse(Clien

[GitHub] [kafka] chia7712 commented on a change in pull request #9433: KAFKA-10607: Consistent behaviour for response errorCounts()

chia7712 commented on a change in pull request #9433: URL: https://github.com/apache/kafka/pull/9433#discussion_r520518339 ## File path: clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java ## @@ -1921,7 +1929,7 @@ private CreateAclsResponse createCr

[GitHub] [kafka] tombentley commented on a change in pull request #9433: KAFKA-10607: Consistent behaviour for response errorCounts()

tombentley commented on a change in pull request #9433: URL: https://github.com/apache/kafka/pull/9433#discussion_r520532036 ## File path: clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java ## @@ -1921,7 +1929,7 @@ private CreateAclsResponse create

[GitHub] [kafka] chia7712 commented on a change in pull request #9563: KAFKA-10684; Avoid additional envelope copies during network transmission

chia7712 commented on a change in pull request #9563: URL: https://github.com/apache/kafka/pull/9563#discussion_r520530228 ## File path: generator/src/main/java/org/apache/kafka/message/MessageDataGenerator.java ## @@ -1529,37 +1516,37 @@ private void generateVariableLengthFie

[jira] [Created] (KAFKA-10704) Mirror maker with TLS at target

Tushar Bhasme created KAFKA-10704: - Summary: Mirror maker with TLS at target Key: KAFKA-10704 URL: https://issues.apache.org/jira/browse/KAFKA-10704 Project: Kafka Issue Type: Bug C

[GitHub] [kafka] yuzawa-san commented on pull request #9499: KAFKA-10470: Zstd upgrade and buffering

yuzawa-san commented on pull request #9499: URL: https://github.com/apache/kafka/pull/9499#issuecomment-724718123 There is a newer zstd-jni version, so I'm going to push the newer one shortly after my local checks pass. This

[GitHub] [kafka] ijuma commented on pull request #9519: KAFKA-10650: Use Murmur3 instead of MD5 in SkimpyOffsetMap

ijuma commented on pull request #9519: URL: https://github.com/apache/kafka/pull/9519#issuecomment-724723348 This looks interesting. Did we consider https://github.com/Cyan4973/xxHash instead of murmur3? This is an automated

[GitHub] [kafka] dongjinleekr commented on pull request #9414: KAFKA-10585: Kafka Streams should clean up the state store directory from cleanup

dongjinleekr commented on pull request #9414: URL: https://github.com/apache/kafka/pull/9414#issuecomment-724725724 Hi @vvcephei, Here is the fix. The reason for the broken integration tests was: `KafkaStreams#cleanUp` can be called regardless of the `StreamThread`s are terminated.

[GitHub] [kafka] ijuma commented on pull request #9266: KAFKA-10469: Resolve logger levels hierarchically

ijuma commented on pull request #9266: URL: https://github.com/apache/kafka/pull/9266#issuecomment-724734814 I have reapplied the change https://github.com/apache/kafka/commit/960e64072592bc1ad939518b58dbdfb17068680d This is

[jira] [Resolved] (KAFKA-10469) Respect logging hierarchy (KIP-676)

[ https://issues.apache.org/jira/browse/KAFKA-10469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-10469. - Fix Version/s: 2.8.0 Resolution: Fixed > Respect logging hierarchy (KIP-676) > --

[jira] [Updated] (KAFKA-10469) Respect logging hierarchy (KIP-676)

[ https://issues.apache.org/jira/browse/KAFKA-10469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-10469: Summary: Respect logging hierarchy (KIP-676) (was: describeConfigs() for broker loggers returns i

[GitHub] [kafka] tombentley commented on pull request #9266: KAFKA-10469: Resolve logger levels hierarchically

tombentley commented on pull request #9266: URL: https://github.com/apache/kafka/pull/9266#issuecomment-724744145 Thanks Ismael. This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Commented] (KAFKA-10216) Loosen permission for listing reassignments

[ https://issues.apache.org/jira/browse/KAFKA-10216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17229270#comment-17229270 ] David Jacot commented on KAFKA-10216: - Small KIP to address this: https://cwiki.apa

[jira] [Commented] (KAFKA-10652) Raft leader should flush accumulated writes after a min size is reached

[ https://issues.apache.org/jira/browse/KAFKA-10652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17229273#comment-17229273 ] Sagar Rao commented on KAFKA-10652: --- hi [~hachikuji], while the PR for 10634 is gettin

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9572: KAFKA-10500: Thread Cache Resizes

wcarlson5 commented on a change in pull request #9572: URL: https://github.com/apache/kafka/pull/9572#discussion_r520686307 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -806,6 +803,21 @@ private KafkaStreams(final InternalTopologyBuilder

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9572: KAFKA-10500: Thread Cache Resizes

wcarlson5 commented on a change in pull request #9572: URL: https://github.com/apache/kafka/pull/9572#discussion_r520686495 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -155,6 +155,7 @@ private final StreamsMetricsImpl streamsMetrics

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9572: KAFKA-10500: Thread Cache Resizes

wcarlson5 commented on a change in pull request #9572: URL: https://github.com/apache/kafka/pull/9572#discussion_r520693132 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/ThreadCache.java ## @@ -71,6 +71,16 @@ public long flushes() { retu

[GitHub] [kafka] lct45 opened a new pull request #9583: MINOR: Make state stores not readable by others

lct45 opened a new pull request #9583: URL: https://github.com/apache/kafka/pull/9583 Change permissions on the folders for the state store so they're no readable or writable by "others", but still accessible by owner and group members. ### Committer Checklist (excluded from commit m

[GitHub] [kafka] lct45 commented on pull request #9583: MINOR: Make state stores not readable by others

lct45 commented on pull request #9583: URL: https://github.com/apache/kafka/pull/9583#issuecomment-724813681 @wcarlson5 @cadonna @ableegoldman for review This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9572: KAFKA-10500: Thread Cache Resizes

wcarlson5 commented on a change in pull request #9572: URL: https://github.com/apache/kafka/pull/9572#discussion_r520699793 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -589,6 +589,10 @@ private void subscribeConsumer

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9583: MINOR: Make state stores not readable by others

wcarlson5 commented on a change in pull request #9583: URL: https://github.com/apache/kafka/pull/9583#discussion_r520710986 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java ## @@ -102,6 +107,13 @@ public StateDirectory(final

[GitHub] [kafka] lct45 commented on a change in pull request #9583: MINOR: Make state stores not readable by others

lct45 commented on a change in pull request #9583: URL: https://github.com/apache/kafka/pull/9583#discussion_r520719992 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java ## @@ -30,11 +30,16 @@ import java.nio.channels.FileCha

[GitHub] [kafka] lct45 commented on a change in pull request #9583: MINOR: Make state stores not readable by others

lct45 commented on a change in pull request #9583: URL: https://github.com/apache/kafka/pull/9583#discussion_r520723720 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java ## @@ -102,6 +107,13 @@ public StateDirectory(final Stre

[jira] [Commented] (KAFKA-10694) Implement zero copy for FetchSnapshot

[ https://issues.apache.org/jira/browse/KAFKA-10694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17229366#comment-17229366 ] Jose Armando Garcia Sancio commented on KAFKA-10694: Hey thanks for

[GitHub] [kafka] lct45 commented on a change in pull request #9583: MINOR: Make state stores not readable by others

lct45 commented on a change in pull request #9583: URL: https://github.com/apache/kafka/pull/9583#discussion_r520723720 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java ## @@ -102,6 +107,13 @@ public StateDirectory(final Stre

[jira] [Commented] (KAFKA-7329) Continuous warning message of LEADER_NOT_AVAILABLE

[ https://issues.apache.org/jira/browse/KAFKA-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17229373#comment-17229373 ] Tomislav Rajakovic commented on KAFKA-7329: --- Is there any reason why is this? R

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9583: MINOR: Make state stores not readable by others

wcarlson5 commented on a change in pull request #9583: URL: https://github.com/apache/kafka/pull/9583#discussion_r520733454 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java ## @@ -102,6 +107,13 @@ public StateDirectory(final

[GitHub] [kafka] abbccdda merged pull request #9558: KAFKA-10342: migrate remaining RPCs to forwarding

abbccdda merged pull request #9558: URL: https://github.com/apache/kafka/pull/9558 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] hachikuji commented on a change in pull request #9401: KAFKA-9628 Replace Produce request/response with automated protocol

hachikuji commented on a change in pull request #9401: URL: https://github.com/apache/kafka/pull/9401#discussion_r520740954 ## File path: clients/src/main/java/org/apache/kafka/common/requests/ProduceResponse.java ## @@ -204,118 +75,78 @@ public ProduceResponse(Map responses)

[GitHub] [kafka] stanislavkozlovski commented on a change in pull request #7641: MINOR: Add a unit test for GroupMetadataManager#offsetExpiredSensor

stanislavkozlovski commented on a change in pull request #7641: URL: https://github.com/apache/kafka/pull/7641#discussion_r520745548 ## File path: core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala ## @@ -791,52 +797,52 @@ class GroupMetadataManager(brokerI

[GitHub] [kafka] hachikuji commented on pull request #9401: KAFKA-9628 Replace Produce request/response with automated protocol

hachikuji commented on pull request #9401: URL: https://github.com/apache/kafka/pull/9401#issuecomment-724862848 For what it's worth, I think we'll get back whatever we lose here by taking `Struct` out of the serialization path. ---

[GitHub] [kafka] yuzawa-san commented on pull request #9499: KAFKA-10470: Zstd upgrade and buffering

yuzawa-san commented on pull request #9499: URL: https://github.com/apache/kafka/pull/9499#issuecomment-724882680 ok most recent version is pushed and checks pass now. This is an automated message from the Apache Git Service.

[jira] [Commented] (KAFKA-10575) StateRestoreListener#onRestoreEnd should always be triggered

[ https://issues.apache.org/jira/browse/KAFKA-10575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17229436#comment-17229436 ] Guozhang Wang commented on KAFKA-10575: --- Of course. You can take a look at the Sto

[GitHub] [kafka] anatasiavela commented on a change in pull request #9526: KAFKA-10525: Emit JSONs with new auto-generated schema

anatasiavela commented on a change in pull request #9526: URL: https://github.com/apache/kafka/pull/9526#discussion_r520807921 ## File path: generator/src/main/java/org/apache/kafka/message/JsonConverterGenerator.java ## @@ -375,13 +385,36 @@ private void generateVariableLengt

[GitHub] [kafka] hachikuji commented on a change in pull request #9563: KAFKA-10684; Avoid additional envelope copies during network transmission

hachikuji commented on a change in pull request #9563: URL: https://github.com/apache/kafka/pull/9563#discussion_r520849832 ## File path: clients/src/main/java/org/apache/kafka/common/protocol/SendBuilder.java ## @@ -0,0 +1,194 @@ +/* + * Licensed to the Apache Software Founda

[jira] [Updated] (KAFKA-10350) Add forwarding request monitoring metrics

[ https://issues.apache.org/jira/browse/KAFKA-10350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen updated KAFKA-10350: Summary: Add forwarding request monitoring metrics (was: Add redirect request monitoring metrics)

[GitHub] [kafka] mumrah commented on a change in pull request #9580: KAFKA-10350: add forwarding manager implementation with metrics

mumrah commented on a change in pull request #9580: URL: https://github.com/apache/kafka/pull/9580#discussion_r520851137 ## File path: core/src/main/scala/kafka/server/ForwardingManager.scala ## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] cadonna commented on a change in pull request #9583: MINOR: Make state stores not readable by others

cadonna commented on a change in pull request #9583: URL: https://github.com/apache/kafka/pull/9583#discussion_r520860033 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/StateDirectoryTest.java ## @@ -106,6 +110,27 @@ public void shouldCreateBa

[GitHub] [kafka] abbccdda commented on a change in pull request #9580: KAFKA-10350: add forwarding manager implementation with metrics

abbccdda commented on a change in pull request #9580: URL: https://github.com/apache/kafka/pull/9580#discussion_r520879347 ## File path: core/src/main/scala/kafka/server/ForwardingManager.scala ## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [kafka] abbccdda commented on a change in pull request #9580: KAFKA-10350: add forwarding manager implementation with metrics

abbccdda commented on a change in pull request #9580: URL: https://github.com/apache/kafka/pull/9580#discussion_r520881008 ## File path: core/src/main/scala/kafka/server/ForwardingManager.scala ## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [kafka] abbccdda commented on a change in pull request #9580: KAFKA-10350: add forwarding manager implementation with metrics

abbccdda commented on a change in pull request #9580: URL: https://github.com/apache/kafka/pull/9580#discussion_r520881459 ## File path: core/src/main/scala/kafka/server/ForwardingManager.scala ## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [kafka] abbccdda commented on a change in pull request #9580: KAFKA-10350: add forwarding manager implementation with metrics

abbccdda commented on a change in pull request #9580: URL: https://github.com/apache/kafka/pull/9580#discussion_r520882950 ## File path: core/src/main/scala/kafka/server/ForwardingManager.scala ## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [kafka] wcarlson5 commented on pull request #9583: MINOR: Make state stores not readable by others

wcarlson5 commented on pull request #9583: URL: https://github.com/apache/kafka/pull/9583#issuecomment-724976610 retest this please This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [kafka] wcarlson5 removed a comment on pull request #9583: MINOR: Make state stores not readable by others

wcarlson5 removed a comment on pull request #9583: URL: https://github.com/apache/kafka/pull/9583#issuecomment-724976610 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] mumrah commented on a change in pull request #9580: KAFKA-10350: add forwarding manager implementation with metrics

mumrah commented on a change in pull request #9580: URL: https://github.com/apache/kafka/pull/9580#discussion_r520903132 ## File path: core/src/main/scala/kafka/server/ForwardingManager.scala ## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] mumrah commented on a change in pull request #9580: KAFKA-10350: add forwarding manager implementation with metrics

mumrah commented on a change in pull request #9580: URL: https://github.com/apache/kafka/pull/9580#discussion_r520909641 ## File path: core/src/main/scala/kafka/server/ForwardingManager.scala ## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] mumrah commented on a change in pull request #9580: KAFKA-10350: add forwarding manager implementation with metrics

mumrah commented on a change in pull request #9580: URL: https://github.com/apache/kafka/pull/9580#discussion_r520910732 ## File path: core/src/main/scala/kafka/network/RequestChannel.scala ## @@ -279,6 +279,7 @@ object RequestChannel extends Logging { .append(",prin

[jira] [Created] (KAFKA-10705) Avoid World Readable RocksDB

Walker Carlson created KAFKA-10705: -- Summary: Avoid World Readable RocksDB Key: KAFKA-10705 URL: https://issues.apache.org/jira/browse/KAFKA-10705 Project: Kafka Issue Type: Bug

[jira] [Updated] (KAFKA-10705) Avoid World Readable RocksDB

[ https://issues.apache.org/jira/browse/KAFKA-10705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Walker Carlson updated KAFKA-10705: --- Labels: streams (was: ) > Avoid World Readable RocksDB > > >

[GitHub] [kafka] brianwyka opened a new pull request #9584: Add group-id to metrics for KafkaConsumer

brianwyka opened a new pull request #9584: URL: https://github.com/apache/kafka/pull/9584 Add the "group-id" to the metrics created curing instantiation of the `KafkaConsumer` ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] V

[jira] [Assigned] (KAFKA-10705) Avoid World Readable RocksDB

[ https://issues.apache.org/jira/browse/KAFKA-10705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Walker Carlson reassigned KAFKA-10705: -- Assignee: Leah Thomas > Avoid World Readable RocksDB > >

[GitHub] [kafka] guozhangwang commented on pull request #9569: KAFKA-10687: make ProduceRespone only returns INVALID_PRODUCER_EPOCH

guozhangwang commented on pull request #9569: URL: https://github.com/apache/kafka/pull/9569#issuecomment-725014616 Okay I think I need to rephrase my thoughts above in another way: right now when abort txns due to timeout, the txn coordinator would 1) first bump up the epoch, and 2) appen

[GitHub] [kafka] brianwyka commented on pull request #9584: Add group-id to metrics for KafkaConsumer

brianwyka commented on pull request #9584: URL: https://github.com/apache/kafka/pull/9584#issuecomment-725016649 I couldn't find any tests that are currently testing out the `client-id` tag for reference. Would appreciate a point in the right direction. --

[GitHub] [kafka] guozhangwang commented on a change in pull request #9569: KAFKA-10687: make ProduceRespone only returns INVALID_PRODUCER_EPOCH

guozhangwang commented on a change in pull request #9569: URL: https://github.com/apache/kafka/pull/9569#discussion_r520924649 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -609,6 +609,12 @@ class KafkaApis(val requestChannel: RequestChannel, mer

[GitHub] [kafka] guozhangwang edited a comment on pull request #9569: KAFKA-10687: make ProduceRespone only returns INVALID_PRODUCER_EPOCH

guozhangwang edited a comment on pull request #9569: URL: https://github.com/apache/kafka/pull/9569#issuecomment-725014616 Okay I think I need to rephrase my thoughts above in another way: right now when abort txns due to timeout, the txn coordinator would 1) first bump up the epoch, and 2

[jira] [Commented] (KAFKA-10643) Static membership - repetitive PreparingRebalance with updating metadata for member reason

[ https://issues.apache.org/jira/browse/KAFKA-10643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17229574#comment-17229574 ] A. Sophie Blee-Goldman commented on KAFKA-10643: Ok, it sounds like mayb

[GitHub] [kafka] ableegoldman commented on pull request #9582: KAFKA-6687: rewrite topology to allow creating multiple KStreams from the same topic

ableegoldman commented on pull request #9582: URL: https://github.com/apache/kafka/pull/9582#issuecomment-725045200 Call for review @mjsax @cadonna @lct45 This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] ableegoldman commented on pull request #9489: MINOR: demote "Committing task offsets" log to DEBUG

ableegoldman commented on pull request #9489: URL: https://github.com/apache/kafka/pull/9489#issuecomment-725045320 Thoughts? @wcarlson5 @vvcephei @abbccdda This is an automated message from the Apache Git Service. To respon

[GitHub] [kafka] abbccdda commented on a change in pull request #9489: MINOR: demote "Committing task offsets" log to DEBUG

abbccdda commented on a change in pull request #9489: URL: https://github.com/apache/kafka/pull/9489#discussion_r520959174 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -703,6 +703,14 @@ void runOnce() { /

[GitHub] [kafka] ableegoldman commented on a change in pull request #9582: KAFKA-6687: rewrite topology to allow creating multiple KStreams from the same topic

ableegoldman commented on a change in pull request #9582: URL: https://github.com/apache/kafka/pull/9582#discussion_r520959288 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java ## @@ -410,18 +410,6 @@ public final voi

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9489: MINOR: demote "Committing task offsets" log to DEBUG

wcarlson5 commented on a change in pull request #9489: URL: https://github.com/apache/kafka/pull/9489#discussion_r520961368 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -703,6 +703,14 @@ void runOnce() {

[GitHub] [kafka] ableegoldman commented on a change in pull request #9489: MINOR: demote "Committing task offsets" log to DEBUG

ableegoldman commented on a change in pull request #9489: URL: https://github.com/apache/kafka/pull/9489#discussion_r520970972 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -703,6 +703,14 @@ void runOnce() {

[jira] [Commented] (KAFKA-10694) Implement zero copy for FetchSnapshot

[ https://issues.apache.org/jira/browse/KAFKA-10694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17229630#comment-17229630 ] lqjacklee commented on KAFKA-10694: --- [~jagsancio] thanks a lot . > Implement zero cop

[GitHub] [kafka] chia7712 commented on a change in pull request #9563: KAFKA-10684; Avoid additional envelope copies during network transmission

chia7712 commented on a change in pull request #9563: URL: https://github.com/apache/kafka/pull/9563#discussion_r521020698 ## File path: clients/src/main/java/org/apache/kafka/common/protocol/SendBuilder.java ## @@ -0,0 +1,194 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [kafka] chia7712 merged pull request #9499: KAFKA-10470: Zstd upgrade and buffering

chia7712 merged pull request #9499: URL: https://github.com/apache/kafka/pull/9499 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[jira] [Resolved] (KAFKA-10470) zstd decompression with small batches is slow and causes excessive GC

[ https://issues.apache.org/jira/browse/KAFKA-10470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-10470. Fix Version/s: 2.8.0 Resolution: Fixed > zstd decompression with small batches is s

[GitHub] [kafka] junrao commented on pull request #9519: KAFKA-10650: Use Murmur3 instead of MD5 in SkimpyOffsetMap

junrao commented on pull request #9519: URL: https://github.com/apache/kafka/pull/9519#issuecomment-725090806 @viktorsomogyi : Thanks for the PR. We use crypto algorithms like MD5 as the unique representation for a corresponding key. murmur3 has the same length as MD5. Does it guarantee si

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9489: MINOR: demote "Committing task offsets" log to DEBUG

wcarlson5 commented on a change in pull request #9489: URL: https://github.com/apache/kafka/pull/9489#discussion_r521055615 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -703,6 +703,14 @@ void runOnce() {

[jira] [Assigned] (KAFKA-10550) Update AdminClient and kafka-topics.sh to support topic IDs

[ https://issues.apache.org/jira/browse/KAFKA-10550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dengziming reassigned KAFKA-10550: -- Assignee: dengziming > Update AdminClient and kafka-topics.sh to support topic IDs >

[GitHub] [kafka] splett2 commented on pull request #9386: KAFKA-10024: Add dynamic configuration and enforce quota for per-IP connection rate limits (KIP-612, part 2)

splett2 commented on pull request #9386: URL: https://github.com/apache/kafka/pull/9386#issuecomment-725198454 @dajac fixed compilation, please take a look when you get the chance. This is an automated message from the Ap

[jira] [Updated] (KAFKA-10706) Liveness bug in truncation protocol can lead to indefinite URP

[ https://issues.apache.org/jira/browse/KAFKA-10706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-10706: Description: We hit an interesting liveness condition in the truncation protocol. Broker A

[jira] [Created] (KAFKA-10706) Liveness bug in truncation protocol can lead to indefinite URP

Jason Gustafson created KAFKA-10706: --- Summary: Liveness bug in truncation protocol can lead to indefinite URP Key: KAFKA-10706 URL: https://issues.apache.org/jira/browse/KAFKA-10706 Project: Kafka