anatasiavela commented on a change in pull request #9526: URL: https://github.com/apache/kafka/pull/9526#discussion_r520807921
########## File path: generator/src/main/java/org/apache/kafka/message/JsonConverterGenerator.java ########## @@ -375,13 +385,36 @@ private void generateVariableLengthTargetToJson(Target target, Versions versions target.sourceVariable()))); } else { headerGenerator.addImport(MessageGenerator.ARRAYS_CLASS); + headerGenerator.addImport(MessageGenerator.INT_NODE_CLASS); + buffer.printf("if (_serializeRecords) {%n"); Review comment: Yea, this change is because ProduceRequest uses `bytes` type. It would be worthwhile if we waited until we migrated the produce request to the automated protocol so we wouldn't have to change this. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org