tombentley commented on pull request #9433: URL: https://github.com/apache/kafka/pull/9433#issuecomment-724662509
@chia7712 For this PR I've added a test. It revealed a few places where responses had error fields which weren't included in the count. This will affect the metrics for those RPCs, since they'll now be counting more error codes and potentially observing error code values which weren't observed before. I don't think this is a problem, but since it affects Fetch and Metadata requests, for example, I think it's worth calling out. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
