[jira] [Created] (KAFKA-10604) The StreamsConfig.STATE_DIR_CONFIG's default value does not reflect the JVM parameter or OS-specific settings

2020-10-13 Thread Dongjin Lee (Jira)
Dongjin Lee created KAFKA-10604: --- Summary: The StreamsConfig.STATE_DIR_CONFIG's default value does not reflect the JVM parameter or OS-specific settings Key: KAFKA-10604 URL: https://issues.apache.org/jira/browse/KA

[jira] [Commented] (KAFKA-10604) The StreamsConfig.STATE_DIR_CONFIG's default value does not reflect the JVM parameter or OS-specific settings

2020-10-13 Thread Dongjin Lee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17212913#comment-17212913 ] Dongjin Lee commented on KAFKA-10604: - [~mjsax] Perhaps we need a KIP discussion for

[GitHub] [kafka] dongjinleekr opened a new pull request #9420: KAFKA-10604: The StreamsConfig.STATE_DIR_CONFIG's default value does not reflect the JVM parameter or OS-specific settings

2020-10-13 Thread GitBox
dongjinleekr opened a new pull request #9420: URL: https://github.com/apache/kafka/pull/9420 Make the default state store directory location to follow OS-specific temporary directory settings or `java.io.tmpdir` JVM parameter, with `Utils#getTempDir`. ### Committer Checklist (exclud

[jira] [Assigned] (KAFKA-10602) DLQ Reporter throws NPE when reporting from different thread

2020-10-13 Thread Tom Bentley (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tom Bentley reassigned KAFKA-10602: --- Assignee: Tom Bentley > DLQ Reporter throws NPE when reporting from different thread >

[GitHub] [kafka] dongjinleekr opened a new pull request #9421: MINOR: Change deprecated 'scala.collection.JavaConverters' to 'scala.jdk.CollectionConverters'

2020-10-13 Thread GitBox
dongjinleekr opened a new pull request #9421: URL: https://github.com/apache/kafka/pull/9421 ... with fixing typo, removing redundant method parameters, unused Throwables, and unused test methods. ### Committer Checklist (excluded from commit message) - [ ] Verify design and imple

[GitHub] [kafka] xakassi commented on pull request #9211: KAFKA-10426: Deadlock on session key update.

2020-10-13 Thread GitBox
xakassi commented on pull request #9211: URL: https://github.com/apache/kafka/pull/9211#issuecomment-707596840 Hi @kkonstantine ! Any news about tests? Should I recreate a PR? This is an automated message from the Apache G

[GitHub] [kafka] tombentley opened a new pull request #9422: KAFKA-10602: Make RetryWithToleranceOperator thread safe

2020-10-13 Thread GitBox
tombentley opened a new pull request #9422: URL: https://github.com/apache/kafka/pull/9422 ErrantRecordReporter uses a RetryWithToleranceOperator instance, which is necessarily stateful, having a ProcessingContext of which there's supposed to be one per task. That ProcessingContext is

[GitHub] [kafka] tombentley commented on pull request #9422: KAFKA-10602: Make RetryWithToleranceOperator thread safe

2020-10-13 Thread GitBox
tombentley commented on pull request #9422: URL: https://github.com/apache/kafka/pull/9422#issuecomment-707621004 @aakashnshah @rhauch @kkonstantine please could one of you review? This is an automated message from the A

[GitHub] [kafka] big-andy-coates commented on pull request #9415: KAFKA-10494: eager handling of sending old values

2020-10-13 Thread GitBox
big-andy-coates commented on pull request #9415: URL: https://github.com/apache/kafka/pull/9415#issuecomment-707622107 @mjsax now targeting trunk This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [kafka] cadonna commented on a change in pull request #9416: MINOR: more log4j entry on elect / resignation of coordinators

2020-10-13 Thread GitBox
cadonna commented on a change in pull request #9416: URL: https://github.com/apache/kafka/pull/9416#discussion_r503732448 ## File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala ## @@ -917,6 +918,7 @@ class GroupCoordinator(val brokerId: Int, * @par

[GitHub] [kafka] marekgregor commented on pull request #4719: KAFKA-6351: Prevent copying javassist library to Kafka distribution from tools project

2020-10-13 Thread GitBox
marekgregor commented on pull request #4719: URL: https://github.com/apache/kafka/pull/4719#issuecomment-707766060 Hello @omkreddy issue reapears in the latest version 2.6.0: javassist-3.22.0-CR2.jar and javassist-3.26.0-GA.jar -

[GitHub] [kafka] chia7712 opened a new pull request #9423: KAFKA-9263 The new hw is added to incorrect log when ReplicaAlterLogD…

2020-10-13 Thread GitBox
chia7712 opened a new pull request #9423: URL: https://github.com/apache/kafka/pull/9423 The following actions results in this issue. 1. handle_1 gets the current log 2. ReplicaAlterLogDirsThread replaces current log by future log 3. handle_1 set the new hw to “current” log but

[GitHub] [kafka] vvcephei commented on pull request #9270: KAFKA-10284: Group membership update due to static member rejoin should be persisted

2020-10-13 Thread GitBox
vvcephei commented on pull request #9270: URL: https://github.com/apache/kafka/pull/9270#issuecomment-707819376 Hi @feyman2016 and @abbccdda , I hope you've both been well. I just wanted to check in on the status of this PR, since we still have a flaky test failure related to it.

[jira] [Commented] (KAFKA-10472) Consider migrating Topology methods to the Builder pattern

2020-10-13 Thread Huynh Quang Thao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17213182#comment-17213182 ] Huynh Quang Thao commented on KAFKA-10472: -- Hi [~mjsax], Thanks for this point

[GitHub] [kafka] vvcephei commented on a change in pull request #9414: KAFKA-10585: Kafka Streams should clean up the state store directory from cleanup

2020-10-13 Thread GitBox
vvcephei commented on a change in pull request #9414: URL: https://github.com/apache/kafka/pull/9414#discussion_r504054028 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/StateDirectoryTest.java ## @@ -602,6 +606,11 @@ public void shouldLogStat

[GitHub] [kafka] vvcephei commented on pull request #9222: KAFKA-10437: Implement test-utils and StateStore changes for KIP-478

2020-10-13 Thread GitBox
vvcephei commented on pull request #9222: URL: https://github.com/apache/kafka/pull/9222#issuecomment-707836238 This was superceded by other PRs. This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [kafka] vvcephei closed pull request #9222: KAFKA-10437: Implement test-utils and StateStore changes for KIP-478

2020-10-13 Thread GitBox
vvcephei closed pull request #9222: URL: https://github.com/apache/kafka/pull/9222 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[jira] [Resolved] (KAFKA-10533) Add log flush semantics to simulation test

2020-10-13 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-10533. - Resolution: Fixed > Add log flush semantics to simulation test > ---

[GitHub] [kafka] hachikuji merged pull request #9352: KAFKA-10533; KafkaRaftClient should flush log after appends

2020-10-13 Thread GitBox
hachikuji merged pull request #9352: URL: https://github.com/apache/kafka/pull/9352 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] vvcephei commented on a change in pull request #9396: KAFKA-10437: Implement new PAPI support for test-utils

2020-10-13 Thread GitBox
vvcephei commented on a change in pull request #9396: URL: https://github.com/apache/kafka/pull/9396#discussion_r504073110 ## File path: streams/test-utils/src/main/java/org/apache/kafka/streams/processor/api/MockProcessorContext.java ## @@ -0,0 +1,494 @@ +/* + * Licensed to t

[GitHub] [kafka] vvcephei commented on pull request #9396: KAFKA-10437: Implement new PAPI support for test-utils

2020-10-13 Thread GitBox
vvcephei commented on pull request #9396: URL: https://github.com/apache/kafka/pull/9396#issuecomment-707844037 The test failure was unrelated: `Build / JDK 11 / kafka.api.PlaintextAdminIntegrationTest.testAlterReplicaLogDirs` ---

[GitHub] [kafka] vvcephei merged pull request #9396: KAFKA-10437: Implement new PAPI support for test-utils

2020-10-13 Thread GitBox
vvcephei merged pull request #9396: URL: https://github.com/apache/kafka/pull/9396 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] lee9210 opened a new pull request #9424: 2.7

2020-10-13 Thread GitBox
lee9210 opened a new pull request #9424: URL: https://github.com/apache/kafka/pull/9424 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing s

[GitHub] [kafka] lee9210 closed pull request #9424: 2.7

2020-10-13 Thread GitBox
lee9210 closed pull request #9424: URL: https://github.com/apache/kafka/pull/9424 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[jira] [Resolved] (KAFKA-10437) KIP-478: Implement test-utils changes

2020-10-13 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler resolved KAFKA-10437. -- Resolution: Fixed > KIP-478: Implement test-utils changes > --

[jira] [Updated] (KAFKA-10562) KIP-478: Delegate the store wrappers to the new init method

2020-10-13 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10562: - Fix Version/s: 2.7.0 > KIP-478: Delegate the store wrappers to the new init method > ---

[jira] [Resolved] (KAFKA-10562) KIP-478: Delegate the store wrappers to the new init method

2020-10-13 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler resolved KAFKA-10562. -- Resolution: Fixed > KIP-478: Delegate the store wrappers to the new init method >

[jira] [Created] (KAFKA-10605) KIP-478: deprecate the replaced Processor API members

2020-10-13 Thread John Roesler (Jira)
John Roesler created KAFKA-10605: Summary: KIP-478: deprecate the replaced Processor API members Key: KAFKA-10605 URL: https://issues.apache.org/jira/browse/KAFKA-10605 Project: Kafka Issue T

[jira] [Updated] (KAFKA-10605) KIP-478: deprecate the replaced Processor API members

2020-10-13 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10605: - Component/s: streams > KIP-478: deprecate the replaced Processor API members > -

[jira] [Updated] (KAFKA-10546) KIP-478: Deprecate the old PAPI interfaces

2020-10-13 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10546: - Summary: KIP-478: Deprecate the old PAPI interfaces (was: KIP-478: Deprecate old PAPI) > KIP-4

[GitHub] [kafka] ableegoldman commented on a change in pull request #9383: KAFKA-10455: Ensure that probing rebalances always occur

2020-10-13 Thread GitBox
ableegoldman commented on a change in pull request #9383: URL: https://github.com/apache/kafka/pull/9383#discussion_r504108760 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignorTest.java ## @@ -483,7 +485,7 @@ public void

[GitHub] [kafka] ableegoldman commented on a change in pull request #9383: KAFKA-10455: Ensure that probing rebalances always occur

2020-10-13 Thread GitBox
ableegoldman commented on a change in pull request #9383: URL: https://github.com/apache/kafka/pull/9383#discussion_r504110656 ## File path: streams/src/test/java/org/apache/kafka/streams/tests/StreamsUpgradeTest.java ## @@ -158,7 +159,8 @@ public ByteBuffer subscriptionUserDa

[GitHub] [kafka] vvcephei commented on pull request #9396: KAFKA-10437: Implement new PAPI support for test-utils

2020-10-13 Thread GitBox
vvcephei commented on pull request #9396: URL: https://github.com/apache/kafka/pull/9396#issuecomment-707874181 Cherry-picked to 2.7 (cc @bbejeck ) This is an automated message from the Apache Git Service. To respond to the m

[jira] [Resolved] (KAFKA-10215) MockProcessorContext doesn't work with SessionStores

2020-10-13 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler resolved KAFKA-10215. -- Resolution: Fixed Fixed in the new processor API. > MockProcessorContext doesn't work with Se

[GitHub] [kafka] ableegoldman commented on a change in pull request #9383: KAFKA-10455: Ensure that probing rebalances always occur

2020-10-13 Thread GitBox
ableegoldman commented on a change in pull request #9383: URL: https://github.com/apache/kafka/pull/9383#discussion_r504111457 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignorTest.java ## @@ -483,7 +485,7 @@ public void

[GitHub] [kafka] kowshik commented on a change in pull request #9409: KAFKA-10599: Implement basic CLI tool for feature versioning system

2020-10-13 Thread GitBox
kowshik commented on a change in pull request #9409: URL: https://github.com/apache/kafka/pull/9409#discussion_r504113561 ## File path: core/src/main/scala/kafka/admin/FeatureCommand.scala ## @@ -0,0 +1,350 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] kowshik commented on a change in pull request #9409: KAFKA-10599: Implement basic CLI tool for feature versioning system

2020-10-13 Thread GitBox
kowshik commented on a change in pull request #9409: URL: https://github.com/apache/kafka/pull/9409#discussion_r504116128 ## File path: core/src/main/scala/kafka/admin/FeatureCommand.scala ## @@ -0,0 +1,350 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] kowshik commented on a change in pull request #9409: KAFKA-10599: Implement basic CLI tool for feature versioning system

2020-10-13 Thread GitBox
kowshik commented on a change in pull request #9409: URL: https://github.com/apache/kafka/pull/9409#discussion_r504118029 ## File path: core/src/main/scala/kafka/admin/FeatureCommand.scala ## @@ -0,0 +1,350 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] kowshik commented on a change in pull request #9409: KAFKA-10599: Implement basic CLI tool for feature versioning system

2020-10-13 Thread GitBox
kowshik commented on a change in pull request #9409: URL: https://github.com/apache/kafka/pull/9409#discussion_r504117818 ## File path: core/src/main/scala/kafka/admin/FeatureCommand.scala ## @@ -0,0 +1,350 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] kowshik commented on a change in pull request #9409: KAFKA-10599: Implement basic CLI tool for feature versioning system

2020-10-13 Thread GitBox
kowshik commented on a change in pull request #9409: URL: https://github.com/apache/kafka/pull/9409#discussion_r504118379 ## File path: core/src/main/scala/kafka/admin/FeatureCommand.scala ## @@ -0,0 +1,350 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] kowshik commented on a change in pull request #9409: KAFKA-10599: Implement basic CLI tool for feature versioning system

2020-10-13 Thread GitBox
kowshik commented on a change in pull request #9409: URL: https://github.com/apache/kafka/pull/9409#discussion_r504118829 ## File path: core/src/main/scala/kafka/admin/FeatureCommand.scala ## @@ -0,0 +1,350 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] kowshik commented on a change in pull request #9409: KAFKA-10599: Implement basic CLI tool for feature versioning system

2020-10-13 Thread GitBox
kowshik commented on a change in pull request #9409: URL: https://github.com/apache/kafka/pull/9409#discussion_r504121355 ## File path: core/src/main/scala/kafka/admin/FeatureCommand.scala ## @@ -0,0 +1,350 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] vvcephei commented on pull request #9338: Fixed KAFKA-10515: Serdes used within metered state stores will now be initialized with the default serdes if not already set.

2020-10-13 Thread GitBox
vvcephei commented on pull request #9338: URL: https://github.com/apache/kafka/pull/9338#issuecomment-707890589 Thanks for the feedback, @thake . Your perspective makes perfect sense. It would certainly simplify our internal code, and it would also help to organize the API a little more. T

[GitHub] [kafka] kowshik commented on a change in pull request #9409: KAFKA-10599: Implement basic CLI tool for feature versioning system

2020-10-13 Thread GitBox
kowshik commented on a change in pull request #9409: URL: https://github.com/apache/kafka/pull/9409#discussion_r504138505 ## File path: core/src/test/scala/unit/kafka/admin/FeatureCommandTest.scala ## @@ -0,0 +1,245 @@ +/** + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] [kafka] kowshik commented on a change in pull request #9409: KAFKA-10599: Implement basic CLI tool for feature versioning system

2020-10-13 Thread GitBox
kowshik commented on a change in pull request #9409: URL: https://github.com/apache/kafka/pull/9409#discussion_r504138505 ## File path: core/src/test/scala/unit/kafka/admin/FeatureCommandTest.scala ## @@ -0,0 +1,245 @@ +/** + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] [kafka] kowshik commented on a change in pull request #9409: KAFKA-10599: Implement basic CLI tool for feature versioning system

2020-10-13 Thread GitBox
kowshik commented on a change in pull request #9409: URL: https://github.com/apache/kafka/pull/9409#discussion_r504138505 ## File path: core/src/test/scala/unit/kafka/admin/FeatureCommandTest.scala ## @@ -0,0 +1,245 @@ +/** + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] [kafka] kowshik commented on a change in pull request #9409: KAFKA-10599: Implement basic CLI tool for feature versioning system

2020-10-13 Thread GitBox
kowshik commented on a change in pull request #9409: URL: https://github.com/apache/kafka/pull/9409#discussion_r504118029 ## File path: core/src/main/scala/kafka/admin/FeatureCommand.scala ## @@ -0,0 +1,350 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] vvcephei commented on a change in pull request #9384: MINOR: remove explicit passing of AdminClient into StreamsPartitionAssignor

2020-10-13 Thread GitBox
vvcephei commented on a change in pull request #9384: URL: https://github.com/apache/kafka/pull/9384#discussion_r504136735 ## File path: streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java ## @@ -900,9 +900,7 @@ // These are not settable in the main Str

[GitHub] [kafka] thake commented on pull request #9338: Fixed KAFKA-10515: Serdes used within metered state stores will now be initialized with the default serdes if not already set.

2020-10-13 Thread GitBox
thake commented on pull request #9338: URL: https://github.com/apache/kafka/pull/9338#issuecomment-707906748 Thank you very much for taking so much time to discuss the API change! This really shows a very good attitude towards new contributers and their feedback. Your arguments make

[GitHub] [kafka] thake commented on pull request #9338: Fixed KAFKA-10515: Serdes used within metered state stores will now be initialized with the default serdes if not already set.

2020-10-13 Thread GitBox
thake commented on pull request #9338: URL: https://github.com/apache/kafka/pull/9338#issuecomment-707907130 The code should now be ready for review. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] rhauch opened a new pull request #9425: KAFKA-10600: Connect should not add error to connector validation values for properties not in connector’s ConfigDef

2020-10-13 Thread GitBox
rhauch opened a new pull request #9425: URL: https://github.com/apache/kafka/pull/9425 By default the `Connector.validate(...)` will only include configuration values that are defined in the connector's `ConfigDef`, and validation is handled via `ConfigDef.Validator` objects. However, a co

[jira] [Updated] (KAFKA-10600) Connect adds error to property in validation result if connector does not define the property

2020-10-13 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch updated KAFKA-10600: -- Affects Version/s: 0.11.0.0 1.0.0 1.1.0

[GitHub] [kafka] abbccdda commented on a change in pull request #9409: KAFKA-10599: Implement basic CLI tool for feature versioning system

2020-10-13 Thread GitBox
abbccdda commented on a change in pull request #9409: URL: https://github.com/apache/kafka/pull/9409#discussion_r504152360 ## File path: core/src/main/scala/kafka/admin/FeatureCommand.scala ## @@ -0,0 +1,350 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] mjsax merged pull request #9415: KAFKA-10494: eager handling of sending old values

2020-10-13 Thread GitBox
mjsax merged pull request #9415: URL: https://github.com/apache/kafka/pull/9415 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] vvcephei opened a new pull request #9426: MINOR: Fix flaky shouldRejectNonExistentStoreName

2020-10-13 Thread GitBox
vvcephei opened a new pull request #9426: URL: https://github.com/apache/kafka/pull/9426 Fix flaky test by making sure Streams is running before making assertions about IQ. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Ve

[GitHub] [kafka] vvcephei commented on pull request #9426: MINOR: Fix flaky shouldRejectNonExistentStoreName

2020-10-13 Thread GitBox
vvcephei commented on pull request #9426: URL: https://github.com/apache/kafka/pull/9426#issuecomment-707925313 Hey @guozhangwang , I've seen this test fail on a PR branch since we merged the last change. Can you take a quick look at this? -

[jira] [Commented] (KAFKA-10604) The StreamsConfig.STATE_DIR_CONFIG's default value does not reflect the JVM parameter or OS-specific settings

2020-10-13 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17213303#comment-17213303 ] Matthias J. Sax commented on KAFKA-10604: - Not sure if we need a KIP. Our focus

[jira] [Assigned] (KAFKA-10472) Consider migrating Topology methods to the Builder pattern

2020-10-13 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-10472: --- Assignee: Huynh Quang Thao (was: Kalpitha Karamadi) > Consider migrating Topology

[jira] [Commented] (KAFKA-10472) Consider migrating Topology methods to the Builder pattern

2020-10-13 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17213308#comment-17213308 ] Matthias J. Sax commented on KAFKA-10472: - Sure. I added you to the list on cont

[GitHub] [kafka] mjsax commented on pull request #9415: KAFKA-10494: eager handling of sending old values

2020-10-13 Thread GitBox
mjsax commented on pull request #9415: URL: https://github.com/apache/kafka/pull/9415#issuecomment-707933791 Thanks for the fix @big-andy-coates! Merged to `trunk` and cherry-picked to `2.7` branch. This is an automate

[GitHub] [kafka] mjsax commented on a change in pull request #9384: MINOR: remove explicit passing of AdminClient into StreamsPartitionAssignor

2020-10-13 Thread GitBox
mjsax commented on a change in pull request #9384: URL: https://github.com/apache/kafka/pull/9384#discussion_r504183734 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java ## @@ -192,12 +191,11 @@ public String toStrin

[GitHub] [kafka] lkokhreidze commented on pull request #9237: KAFKA-10454 / Update copartitionSourceGroups when optimization algorithm is triggered

2020-10-13 Thread GitBox
lkokhreidze commented on pull request #9237: URL: https://github.com/apache/kafka/pull/9237#issuecomment-707945635 Hi @bbejeck @vvcephei Sorry for pinging again, but can this PR be merged? Would love to get it live for next releases. Thansks --

[GitHub] [kafka] lkokhreidze edited a comment on pull request #9237: KAFKA-10454 / Update copartitionSourceGroups when optimization algorithm is triggered

2020-10-13 Thread GitBox
lkokhreidze edited a comment on pull request #9237: URL: https://github.com/apache/kafka/pull/9237#issuecomment-707945635 Hi @bbejeck @vvcephei Sorry for pinging again, but can this PR be merged? Would love to get it live for next releases. Thanks

[GitHub] [kafka] mjsax commented on a change in pull request #9384: MINOR: remove explicit passing of AdminClient into StreamsPartitionAssignor

2020-10-13 Thread GitBox
mjsax commented on a change in pull request #9384: URL: https://github.com/apache/kafka/pull/9384#discussion_r504190638 ## File path: streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java ## @@ -900,9 +900,7 @@ // These are not settable in the main Stream

[GitHub] [kafka] bbejeck commented on pull request #9237: KAFKA-10454 / Update copartitionSourceGroups when optimization algorithm is triggered

2020-10-13 Thread GitBox
bbejeck commented on pull request #9237: URL: https://github.com/apache/kafka/pull/9237#issuecomment-707950572 @lkokhreidze I appreciate your patience. We need to get a green build but I'm confident we'll get this in. This i

[GitHub] [kafka] splett2 commented on a change in pull request #9386: KAFKA-10024: Add dynamic configuration and enforce quota for per-IP connection rate limits

2020-10-13 Thread GitBox
splett2 commented on a change in pull request #9386: URL: https://github.com/apache/kafka/pull/9386#discussion_r503665368 ## File path: core/src/test/scala/integration/kafka/network/DynamicConnectionQuotaTest.scala ## @@ -240,6 +256,16 @@ class DynamicConnectionQuotaTest exten

[GitHub] [kafka] gwenshap closed pull request #9367: KAFKA-10570 Rename JMXReporter configs for KIP-629

2020-10-13 Thread GitBox
gwenshap closed pull request #9367: URL: https://github.com/apache/kafka/pull/9367 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] mjsax commented on pull request #9384: MINOR: remove explicit passing of AdminClient into StreamsPartitionAssignor

2020-10-13 Thread GitBox
mjsax commented on pull request #9384: URL: https://github.com/apache/kafka/pull/9384#issuecomment-707963598 @vvcephei Updated this PR (including PR description). This is an automated message from the Apache Git Service. To r

[GitHub] [kafka] gwenshap closed pull request #9400: MINOR rename kafka.utils.Whitelist to IncludeList

2020-10-13 Thread GitBox
gwenshap closed pull request #9400: URL: https://github.com/apache/kafka/pull/9400 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[jira] [Commented] (KAFKA-10582) Mirror Maker 2 not replicating new topics until restart

2020-10-13 Thread Oleg Osipov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17213332#comment-17213332 ] Oleg Osipov commented on KAFKA-10582: - Which cluster do you specify to run MM2? Is i

[jira] [Resolved] (KAFKA-10570) Rename JMXReporter configs for KIP-629

2020-10-13 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-10570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xavier Léauté resolved KAFKA-10570. --- Fix Version/s: 2.7.0 Resolution: Fixed > Rename JMXReporter configs for KIP-629 > ---

[GitHub] [kafka] xvrl opened a new pull request #9427: backport KAFKA-10571

2020-10-13 Thread GitBox
xvrl opened a new pull request #9427: URL: https://github.com/apache/kafka/pull/9427 This change backports KAFKA-10571 (#9366) and #9398 to 2.7 for KIP-629 cc @gwenshap This is an automated message from the Apache Git

[GitHub] [kafka] xvrl commented on pull request #9403: KAFKA-10573 Update connect transforms configs for KIP-629

2020-10-13 Thread GitBox
xvrl commented on pull request #9403: URL: https://github.com/apache/kafka/pull/9403#issuecomment-707972896 @rhauch rebased on latest trunk now that #9367 has been merged This is an automated message from the Apache Git Servi

[GitHub] [kafka] splett2 commented on a change in pull request #9386: KAFKA-10024: Add dynamic configuration and enforce quota for per-IP connection rate limits

2020-10-13 Thread GitBox
splett2 commented on a change in pull request #9386: URL: https://github.com/apache/kafka/pull/9386#discussion_r504219669 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -1371,6 +1492,45 @@ class ConnectionQuotas(config: KafkaConfig, time: Time, metric

[jira] [Updated] (KAFKA-10571) Replace occurrences of blackout with backoff for KIP-629

2020-10-13 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xavier Léauté updated KAFKA-10571: -- Fix Version/s: 2.7.0 > Replace occurrences of blackout with backoff for KIP-629 >

[jira] [Updated] (KAFKA-10201) Update codebase to use more inclusive terms

2020-10-13 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-10201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xavier Léauté updated KAFKA-10201: -- Fix Version/s: 2.8.0 > Update codebase to use more inclusive terms > -

[GitHub] [kafka] hachikuji commented on pull request #9353: KAFKA-10521; Skip partition watch registration when `AlterIsr` is expected

2020-10-13 Thread GitBox
hachikuji commented on pull request #9353: URL: https://github.com/apache/kafka/pull/9353#issuecomment-707980589 @junrao Great catch. I had just assumed the check existed. I updated the code and added a partial upgrade integration test case. ---

[GitHub] [kafka] abbccdda commented on a change in pull request #9311: KAFKA-9910: Implement new transaction timed out error

2020-10-13 Thread GitBox
abbccdda commented on a change in pull request #9311: URL: https://github.com/apache/kafka/pull/9311#discussion_r504225780 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java ## @@ -1198,18 +1209,22 @@ boolean canBumpEpoch()

[GitHub] [kafka] junrao commented on a change in pull request #9353: KAFKA-10521; Skip partition watch registration when `AlterIsr` is expected

2020-10-13 Thread GitBox
junrao commented on a change in pull request #9353: URL: https://github.com/apache/kafka/pull/9353#discussion_r504239853 ## File path: core/src/test/scala/integration/kafka/admin/ReassignPartitionsIntegrationTest.scala ## @@ -60,13 +57,53 @@ class ReassignPartitionsIntegration

[jira] [Updated] (KAFKA-9126) Extend `StreamJoined` to allow more store configs

2020-10-13 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-9126: --- Labels: needs-kip newbie newbie++ (was: needs-kip) > Extend `StreamJoined` to allow

[jira] [Commented] (KAFKA-10582) Mirror Maker 2 not replicating new topics until restart

2020-10-13 Thread Robert Martin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17213427#comment-17213427 ] Robert Martin commented on KAFKA-10582: --- So we have one instance replicating one d

[jira] [Assigned] (KAFKA-10587) Rename kafka-mirror-maker CLI command line arguments for KIP-629

2020-10-13 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-10587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xavier Léauté reassigned KAFKA-10587: - Assignee: Xavier Léauté > Rename kafka-mirror-maker CLI command line arguments for KIP-

[GitHub] [kafka] vvcephei commented on a change in pull request #9338: Fixed KAFKA-10515: Serdes used within metered state stores will now be initialized with the default serdes if not already set.

2020-10-13 Thread GitBox
vvcephei commented on a change in pull request #9338: URL: https://github.com/apache/kafka/pull/9338#discussion_r504228659 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredWindowStore.java ## @@ -103,6 +104,13 @@ public void init(final StateS

[GitHub] [kafka] cmccabe opened a new pull request #9428: MINOR: fix a bug in removing elements from an ImplicitLinkedHashColle…

2020-10-13 Thread GitBox
cmccabe opened a new pull request #9428: URL: https://github.com/apache/kafka/pull/9428 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] gwenshap closed pull request #9405: MINOR internal KIP-629 changes to methods and variables

2020-10-13 Thread GitBox
gwenshap closed pull request #9405: URL: https://github.com/apache/kafka/pull/9405 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[jira] [Created] (KAFKA-10606) Auto create non-existent topics when fetching metadata for all topics

2020-10-13 Thread Lincong Li (Jira)
Lincong Li created KAFKA-10606: -- Summary: Auto create non-existent topics when fetching metadata for all topics Key: KAFKA-10606 URL: https://issues.apache.org/jira/browse/KAFKA-10606 Project: Kafka

[GitHub] [kafka] kowshik commented on a change in pull request #9409: KAFKA-10599: Implement basic CLI tool for feature versioning system

2020-10-13 Thread GitBox
kowshik commented on a change in pull request #9409: URL: https://github.com/apache/kafka/pull/9409#discussion_r504138505 ## File path: core/src/test/scala/unit/kafka/admin/FeatureCommandTest.scala ## @@ -0,0 +1,245 @@ +/** + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] [kafka] kowshik commented on a change in pull request #9409: KAFKA-10599: Implement basic CLI tool for feature versioning system

2020-10-13 Thread GitBox
kowshik commented on a change in pull request #9409: URL: https://github.com/apache/kafka/pull/9409#discussion_r504296681 ## File path: core/src/main/scala/kafka/admin/FeatureCommand.scala ## @@ -0,0 +1,350 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] hachikuji commented on a change in pull request #9103: KAFKA-10181: Use Envelope RPC to do redirection for (Incremental)AlterConfig, AlterClientQuota and CreateTopics

2020-10-13 Thread GitBox
hachikuji commented on a change in pull request #9103: URL: https://github.com/apache/kafka/pull/9103#discussion_r504286524 ## File path: clients/src/main/java/org/apache/kafka/common/requests/EnvelopeRequest.java ## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [kafka] xvrl opened a new pull request #9429: KAFKA-10572 mirror-maker config changes for KIP-629

2020-10-13 Thread GitBox
xvrl opened a new pull request #9429: URL: https://github.com/apache/kafka/pull/9429 This change implements the KIP-629 changes for mirror maker configuration with backwards compatibility. cc @rhauch This is an automated

[GitHub] [kafka] hachikuji commented on a change in pull request #9103: KAFKA-10181: Use Envelope RPC to do redirection for (Incremental)AlterConfig, AlterClientQuota and CreateTopics

2020-10-13 Thread GitBox
hachikuji commented on a change in pull request #9103: URL: https://github.com/apache/kafka/pull/9103#discussion_r504298663 ## File path: clients/src/main/java/org/apache/kafka/common/security/auth/KafkaPrincipalSerde.java ## @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Sof

[jira] [Assigned] (KAFKA-10572) Rename MirrorMaker 2 blacklist configs for KIP-629

2020-10-13 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-10572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xavier Léauté reassigned KAFKA-10572: - Assignee: Xavier Léauté > Rename MirrorMaker 2 blacklist configs for KIP-629 >

[jira] [Updated] (KAFKA-10201) Update codebase to use more inclusive terms

2020-10-13 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-10201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xavier Léauté updated KAFKA-10201: -- Fix Version/s: (was: 2.8.0) > Update codebase to use more inclusive terms > --

[GitHub] [kafka] efeg commented on pull request #9397: KAFKA-10583: Add documentation on the thread-safety of KafkaAdminClient.

2020-10-13 Thread GitBox
efeg commented on pull request #9397: URL: https://github.com/apache/kafka/pull/9397#issuecomment-708055229 @tombentley thanks for the feedback! > @efeg the javadoc for `KafkaAdminClient` says "Users should not refer to this class directly", so just adding the thread-safety note to

[GitHub] [kafka] rhauch merged pull request #9403: KAFKA-10573 Update connect transforms configs for KIP-629

2020-10-13 Thread GitBox
rhauch merged pull request #9403: URL: https://github.com/apache/kafka/pull/9403 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Updated] (KAFKA-10573) Rename connect transform configs for KIP-629

2020-10-13 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch updated KAFKA-10573: -- Fix Version/s: 2.8.0 > Rename connect transform configs for KIP-629 >

[jira] [Updated] (KAFKA-10573) Rename connect transform configs for KIP-629

2020-10-13 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch updated KAFKA-10573: -- Fix Version/s: 2.7.0 > Rename connect transform configs for KIP-629 >

[jira] [Updated] (KAFKA-10573) Rename connect transform configs for KIP-629

2020-10-13 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch updated KAFKA-10573: -- Labels: needs-kip (was: ) > Rename connect transform configs for KIP-629 > --

[jira] [Updated] (KAFKA-10573) Rename connect transform configs for KIP-629

2020-10-13 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch updated KAFKA-10573: -- Description: Part of the implementation for [KIP-629|https://cwiki.apache.org/confluence/displ

[jira] [Resolved] (KAFKA-10573) Rename connect transform configs for KIP-629

2020-10-13 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-10573. --- Fix Version/s: (was: 2.8.0) Reviewer: Randall Hauch Resolution: Fixed Me

  1   2   >