cadonna commented on a change in pull request #9416:
URL: https://github.com/apache/kafka/pull/9416#discussion_r503732448
##########
File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala
##########
@@ -917,6 +918,7 @@ class GroupCoordinator(val brokerId: Int,
* @param offsetTopicPartitionId The partition we are no longer leading
*/
def onResignation(offsetTopicPartitionId: Int): Unit = {
+ info(s"Resigning the group coordinator for partition
$offsetTopicPartitionId")
Review comment:
Shouldn't this be `Resigning as the group coordinator` or `Resigning as
group coordinator`?
##########
File path:
core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala
##########
@@ -329,6 +330,7 @@ class TransactionCoordinator(brokerId: Int,
* are resigning after receiving a StopReplica
request from the controller
*/
def onResignation(txnTopicPartitionId: Int, coordinatorEpoch: Option[Int]):
Unit = {
+ info(s"Resigning the txn coordinator for partition $txnTopicPartitionId at
epoch $coordinatorEpoch")
Review comment:
Same as above.
##########
File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala
##########
@@ -908,6 +908,7 @@ class GroupCoordinator(val brokerId: Int,
* @param offsetTopicPartitionId The partition we are now leading
*/
def onElection(offsetTopicPartitionId: Int): Unit = {
+ info(s"Becoming the group coordinator for partition
$offsetTopicPartitionId")
Review comment:
It would also be nice to have the groups that are coordinated in the log
message. I guess that is hardly possible, isn't it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
