[GitHub] [kafka] jonathansantilli commented on pull request #7877: KAFKA-9312: Wait for splitted batches to be processed after a KafkaProducer#flush()

2020-09-21 Thread GitBox
jonathansantilli commented on pull request #7877: URL: https://github.com/apache/kafka/pull/7877#issuecomment-695958093 Hi there @d8tltanc sorry about the delay with my reply. I would like to continue working on this PR. There was some consensus at the beginning about a possible solu

[jira] [Assigned] (KAFKA-10496) Create an in-memory DNS server for ClientUtilsTest and ClusterConnectionStatesTest

2020-09-21 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-10496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Rżysko reassigned KAFKA-10496: Assignee: Piotr Rżysko > Create an in-memory DNS server for ClientUtilsTest and > Cluste

[jira] [Commented] (KAFKA-8803) Stream will not start due to TimeoutException: Timeout expired after 60000milliseconds while awaiting InitProducerId

2020-09-21 Thread Michael Silbermann (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17199235#comment-17199235 ] Michael Silbermann commented on KAFKA-8803: --- [~guozhang] thanks, we will try to

[GitHub] [kafka] cadonna commented on a change in pull request #9262: MINOR: Fix log message when tasks directory is cleaned manually

2020-09-21 Thread GitBox
cadonna commented on a change in pull request #9262: URL: https://github.com/apache/kafka/pull/9262#discussion_r491864886 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java ## @@ -306,59 +305,69 @@ public synchronized void clea

[jira] [Assigned] (KAFKA-10505) [SystemTests] streams_static_membership.py and streams_upgradet_test.py fails

2020-09-21 Thread Nikolay Izhikov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nikolay Izhikov reassigned KAFKA-10505: --- Assignee: Nikolay Izhikov > [SystemTests] streams_static_membership.py and streams_

[jira] [Created] (KAFKA-10505) [SystemTests] streams_static_membership.py and streams_upgradet_test.py fails

2020-09-21 Thread Nikolay Izhikov (Jira)
Nikolay Izhikov created KAFKA-10505: --- Summary: [SystemTests] streams_static_membership.py and streams_upgradet_test.py fails Key: KAFKA-10505 URL: https://issues.apache.org/jira/browse/KAFKA-10505 P

[GitHub] [kafka] nizhikov opened a new pull request #9312: KAFKA-10505: Fix parsing of generation log string.

2020-09-21 Thread GitBox
nizhikov opened a new pull request #9312: URL: https://github.com/apache/kafka/pull/9312 Two tests fails with the same reason: ``` File "/opt/kafka-dev/tests/kafkatest/tests/streams/streams_upgrade_test.py", line 533, in extract_highest_generation return int(found_generation

[GitHub] [kafka] cadonna commented on a change in pull request #9262: MINOR: Fix log message when tasks directory is cleaned manually

2020-09-21 Thread GitBox
cadonna commented on a change in pull request #9262: URL: https://github.com/apache/kafka/pull/9262#discussion_r491866714 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java ## @@ -306,59 +305,69 @@ public synchronized void clea

[GitHub] [kafka] cadonna commented on a change in pull request #9262: MINOR: Fix log message when tasks directory is cleaned manually

2020-09-21 Thread GitBox
cadonna commented on a change in pull request #9262: URL: https://github.com/apache/kafka/pull/9262#discussion_r491880515 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java ## @@ -306,59 +305,69 @@ public synchronized void clea

[GitHub] [kafka] nizhikov commented on pull request #9312: KAFKA-10505: Fix parsing of generation log string.

2020-09-21 Thread GitBox
nizhikov commented on pull request #9312: URL: https://github.com/apache/kafka/pull/9312#issuecomment-695991209 Hello, @mjsax @ableegoldman 2 system tests for streams are fails because of an unexpected string format. I fixed it. Please, take a look at my PR. -

[GitHub] [kafka] cadonna commented on a change in pull request #9262: MINOR: Fix log message when tasks directory is cleaned manually

2020-09-21 Thread GitBox
cadonna commented on a change in pull request #9262: URL: https://github.com/apache/kafka/pull/9262#discussion_r49183 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java ## @@ -306,59 +305,69 @@ public synchronized void clea

[GitHub] [kafka] nizhikov commented on pull request #9196: [DO NOT MERGE] KAFKA-10402: Upgrade system tests to python3

2020-09-21 Thread GitBox
nizhikov commented on pull request #9196: URL: https://github.com/apache/kafka/pull/9196#issuecomment-695992855 Hello, @guozhangwang 2 tests that fails in this branch fails in the trunk too. I fixed them in #9312 Please, take a look. ``` File "/opt/kafka-dev/t

[jira] [Commented] (KAFKA-10482) Fix flaky testDynamicListenerConnectionCreationRateQuota

2020-09-21 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17199280#comment-17199280 ] Luke Chen commented on KAFKA-10482: --- [https://ci-builds.apache.org/blue/rest/organizat

[GitHub] [kafka] showuon commented on a change in pull request #9202: KAFKA-10401: Fix the currentStateTimeStamp doesn't get set correctly

2020-09-21 Thread GitBox
showuon commented on a change in pull request #9202: URL: https://github.com/apache/kafka/pull/9202#discussion_r491908542 ## File path: core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala ## @@ -1402,23 +1403,18 @@ object GroupMetadataManager { val va

[GitHub] [kafka] showuon commented on a change in pull request #9202: KAFKA-10401: Fix the currentStateTimeStamp doesn't get set correctly

2020-09-21 Thread GitBox
showuon commented on a change in pull request #9202: URL: https://github.com/apache/kafka/pull/9202#discussion_r491908542 ## File path: core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala ## @@ -1402,23 +1403,18 @@ object GroupMetadataManager { val va

[GitHub] [kafka] showuon commented on a change in pull request #9202: KAFKA-10401: Fix the currentStateTimeStamp doesn't get set correctly

2020-09-21 Thread GitBox
showuon commented on a change in pull request #9202: URL: https://github.com/apache/kafka/pull/9202#discussion_r491908542 ## File path: core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala ## @@ -1402,23 +1403,18 @@ object GroupMetadataManager { val va

[GitHub] [kafka] showuon commented on a change in pull request #9202: KAFKA-10401: Fix the currentStateTimeStamp doesn't get set correctly

2020-09-21 Thread GitBox
showuon commented on a change in pull request #9202: URL: https://github.com/apache/kafka/pull/9202#discussion_r491908542 ## File path: core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala ## @@ -1402,23 +1403,18 @@ object GroupMetadataManager { val va

[GitHub] [kafka] showuon commented on a change in pull request #9149: KAFKA-10340: improve the logging to help user know what is going on

2020-09-21 Thread GitBox
showuon commented on a change in pull request #9149: URL: https://github.com/apache/kafka/pull/9149#discussion_r491912872 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java ## @@ -363,6 +363,7 @@ private boolean sendRecords() {

[jira] [Created] (KAFKA-10506) Ssl connectors and tasks have incorrect statuses

2020-09-21 Thread Lobashin Denis (Jira)
Lobashin Denis created KAFKA-10506: -- Summary: Ssl connectors and tasks have incorrect statuses Key: KAFKA-10506 URL: https://issues.apache.org/jira/browse/KAFKA-10506 Project: Kafka Issue Ty

[GitHub] [kafka] showuon commented on a change in pull request #9149: KAFKA-10340: improve the logging to help user know what is going on

2020-09-21 Thread GitBox
showuon commented on a change in pull request #9149: URL: https://github.com/apache/kafka/pull/9149#discussion_r491916604 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java ## @@ -409,6 +410,9 @@ private boolean sendRecords() {

[GitHub] [kafka] showuon commented on a change in pull request #9149: KAFKA-10340: improve the logging to help user know what is going on

2020-09-21 Thread GitBox
showuon commented on a change in pull request #9149: URL: https://github.com/apache/kafka/pull/9149#discussion_r491916604 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java ## @@ -409,6 +410,9 @@ private boolean sendRecords() {

[GitHub] [kafka] chia7712 commented on pull request #9284: KAFKA-10479 Throw exception if users try to update configs of existen…

2020-09-21 Thread GitBox
chia7712 commented on pull request #9284: URL: https://github.com/apache/kafka/pull/9284#issuecomment-696082528 ``` Build / JDK 11 / kafka.api.ConsumerBounceTest.testRollingBrokerRestartsWithSmallerMaxGroupSizeConfigDisruptsBigGroup ``` only jdk 11 get failed test. It is unrela

[GitHub] [kafka] chia7712 commented on pull request #9223: KAFKA-10438 Lazy initialization of record header to reduce memory usa…

2020-09-21 Thread GitBox
chia7712 commented on pull request #9223: URL: https://github.com/apache/kafka/pull/9223#issuecomment-696083029 ``` Build / JDK 8 / org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta[true] ``` only jdk 8 gets failure. This flak

[GitHub] [kafka] chia7712 commented on pull request #9102: KAFKA-10326 Both serializer and deserializer should be able to see th…

2020-09-21 Thread GitBox
chia7712 commented on pull request #9102: URL: https://github.com/apache/kafka/pull/9102#issuecomment-696083619 @abbccdda ping~ This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [kafka] viktorsomogyi commented on pull request #4090: [KAFKA-6084] Propagate JSON parsing errors in ReassignPartitionsCommand

2020-09-21 Thread GitBox
viktorsomogyi commented on pull request #4090: URL: https://github.com/apache/kafka/pull/4090#issuecomment-696097321 @ijuma can we get this merged please or do you have any more comments? This is an automated message from the

[GitHub] [kafka] chia7712 commented on a change in pull request #9299: MINOR: Use `Map.foreachKv` to avoid tuple allocation in Scala 2.13

2020-09-21 Thread GitBox
chia7712 commented on a change in pull request #9299: URL: https://github.com/apache/kafka/pull/9299#discussion_r492025863 ## File path: core/src/main/scala/kafka/admin/ZkSecurityMigrator.scala ## @@ -128,7 +129,7 @@ object ZkSecurityMigrator extends Logging { // Now overr

[GitHub] [kafka] shaikzakiriitm commented on pull request #9306: KAFKA-10477: Enabling the same behavior of NULL JsonNodeType to MISSI…

2020-09-21 Thread GitBox
shaikzakiriitm commented on pull request #9306: URL: https://github.com/apache/kafka/pull/9306#issuecomment-696107218 Failures are in ConnectionQuotasTest, and ConsumerBounceTest test classes, and appear unrelated to the change in this PR.

[jira] [Commented] (KAFKA-10484) Reduce Metrics Exposed by Streams

2020-09-21 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17199387#comment-17199387 ] Bruno Cadonna commented on KAFKA-10484: --- I think, we should first try to find a go

[GitHub] [kafka] viktorsomogyi commented on a change in pull request #9281: KAFKA-KAFKA-10478: Allow duplicated ports in advertised.listeners

2020-09-21 Thread GitBox
viktorsomogyi commented on a change in pull request #9281: URL: https://github.com/apache/kafka/pull/9281#discussion_r492058687 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -1686,9 +1686,9 @@ class KafkaConfig(val props: java.util.Map[_, _], doLog: Bo

[jira] [Commented] (KAFKA-8360) Docs do not mention RequestQueueSize JMX metric

2020-09-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17199403#comment-17199403 ] ASF GitHub Bot commented on KAFKA-8360: --- viktorsomogyi commented on pull request #2

[jira] [Commented] (KAFKA-8360) Docs do not mention RequestQueueSize JMX metric

2020-09-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17199404#comment-17199404 ] ASF GitHub Bot commented on KAFKA-8360: --- viktorsomogyi edited a comment on pull req

[jira] [Commented] (KAFKA-8266) Improve `testRollingBrokerRestartsWithSmallerMaxGroupSizeConfigDisruptsBigGroup`

2020-09-21 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17199409#comment-17199409 ] Bruno Cadonna commented on KAFKA-8266: -- This test failed for me with: {code:java} or

[GitHub] [kafka] ijuma commented on a change in pull request #9299: MINOR: Use `Map.foreachKv` to avoid tuple allocation in Scala 2.13

2020-09-21 Thread GitBox
ijuma commented on a change in pull request #9299: URL: https://github.com/apache/kafka/pull/9299#discussion_r492077814 ## File path: core/src/main/scala/kafka/admin/ZkSecurityMigrator.scala ## @@ -128,7 +129,7 @@ object ZkSecurityMigrator extends Logging { // Now override

[GitHub] [kafka] ijuma commented on pull request #9298: MINOR: Replace Java 14 with Java 15 in the README

2020-09-21 Thread GitBox
ijuma commented on pull request #9298: URL: https://github.com/apache/kafka/pull/9298#issuecomment-696156076 Failures are unrelated since this only changes the Readme. This is an automated message from the Apache Git Service.

[GitHub] [kafka] ijuma merged pull request #9298: MINOR: Replace Java 14 with Java 15 in the README

2020-09-21 Thread GitBox
ijuma merged pull request #9298: URL: https://github.com/apache/kafka/pull/9298 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] ijuma commented on pull request #9266: KAFKA-10469: Resolve logger levels hierarchically

2020-09-21 Thread GitBox
ijuma commented on pull request #9266: URL: https://github.com/apache/kafka/pull/9266#issuecomment-696170285 Build timed out for some reason, started another one. This is an automated message from the Apache Git Service. To r

[GitHub] [kafka] ijuma commented on pull request #9223: KAFKA-10438 Lazy initialization of record header to reduce memory usa…

2020-09-21 Thread GitBox
ijuma commented on pull request #9223: URL: https://github.com/apache/kafka/pull/9223#issuecomment-696171172 Unrelated flaky failures: > Build / JDK 8 / org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta[true] > Build / JD

[GitHub] [kafka] scanterog opened a new pull request #9313: [mm2] Fix consumer/producer/admin properties override

2020-09-21 Thread GitBox
scanterog opened a new pull request #9313: URL: https://github.com/apache/kafka/pull/9313 Currently the producer/consumer properties override for the MirrorSourceTask and OffsetSyncStore do not work. This is due the props stored into MirrorConnectorConfig have a `target.cluster` or `source

[GitHub] [kafka] ijuma merged pull request #9223: KAFKA-10438 Lazy initialization of record header to reduce memory usa…

2020-09-21 Thread GitBox
ijuma merged pull request #9223: URL: https://github.com/apache/kafka/pull/9223 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (KAFKA-10339) MirrorMaker2 Exactly-once Semantics

2020-09-21 Thread Ning Zhang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17199443#comment-17199443 ] Ning Zhang commented on KAFKA-10339: [~mimaison] When possible, very appreciated if 

[GitHub] [kafka] ijuma commented on a change in pull request #4090: [KAFKA-6084] Propagate JSON parsing errors in ReassignPartitionsCommand

2020-09-21 Thread GitBox
ijuma commented on a change in pull request #4090: URL: https://github.com/apache/kafka/pull/4090#discussion_r492132729 ## File path: core/src/test/scala/unit/kafka/utils/JsonTest.scala ## @@ -40,25 +40,34 @@ class JsonTest { def testJsonParse(): Unit = { val jnf = Json

[GitHub] [kafka] ankit-kumar-25 opened a new pull request #9314: KAFKA-8360: Docs do not mention RequestQueueSize JMX metric

2020-09-21 Thread GitBox
ankit-kumar-25 opened a new pull request #9314: URL: https://github.com/apache/kafka/pull/9314 What? :: Mentioning "Request Queue Size" under the Monitoring tab. RequestQueueSize is an important metric to monitor the number of requests in the queue. As a crowded queue might face issue proc

[jira] [Commented] (KAFKA-8360) Docs do not mention RequestQueueSize JMX metric

2020-09-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17199447#comment-17199447 ] ASF GitHub Bot commented on KAFKA-8360: --- ankit-kumar-25 commented on pull request #

[GitHub] [kafka] cmccabe commented on pull request #9103: Add redirection for (Incremental)AlterConfig, AlterClientQuota and CreateTopics

2020-09-21 Thread GitBox
cmccabe commented on pull request #9103: URL: https://github.com/apache/kafka/pull/9103#issuecomment-696225206 Hi @abbccdda , Thanks for the PR! It looks good. I like the idea behind `ForwardRequestHandler`. Since this class doesn't have any internal state, I wonder if it wo

[jira] [Commented] (KAFKA-10339) MirrorMaker2 Exactly-once Semantics

2020-09-21 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17199492#comment-17199492 ] Mickael Maison commented on KAFKA-10339: Thanks [~yangguo1220]. I've seen your r

[GitHub] [kafka] hachikuji commented on a change in pull request #9202: KAFKA-10401: Fix the currentStateTimeStamp doesn't get set correctly

2020-09-21 Thread GitBox
hachikuji commented on a change in pull request #9202: URL: https://github.com/apache/kafka/pull/9202#discussion_r492203555 ## File path: core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala ## @@ -1402,23 +1403,18 @@ object GroupMetadataManager { val

[jira] [Commented] (KAFKA-10460) ReplicaListValidator format checking is incomplete

2020-09-21 Thread Ankit Kumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17199494#comment-17199494 ] Ankit Kumar commented on KAFKA-10460: - Hey [~robinp-tw], Are you working on this? I

[GitHub] [kafka] hachikuji commented on a change in pull request #9130: KAFKA-10492; Core Kafka Raft Implementation (KIP-595)

2020-09-21 Thread GitBox
hachikuji commented on a change in pull request #9130: URL: https://github.com/apache/kafka/pull/9130#discussion_r492211755 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -182,10 +182,13 @@ class KafkaApis(val requestChannel: RequestChannel, case

[GitHub] [kafka] scanterog commented on pull request #9313: [mm2] Fix consumer/producer/admin properties override

2020-09-21 Thread GitBox
scanterog commented on pull request #9313: URL: https://github.com/apache/kafka/pull/9313#issuecomment-696259251 Hello @ryannedolan @mimaison. Your review will be appreciated. I think the test failure is unrelated. Thanks! T

[jira] [Commented] (KAFKA-10339) MirrorMaker2 Exactly-once Semantics

2020-09-21 Thread Ning Zhang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17199546#comment-17199546 ] Ning Zhang commented on KAFKA-10339: Thanks [~mimaison], once the above PR 8730 is m

[GitHub] [kafka] scanterog commented on pull request #9313: [mm2] Fix consumer/producer/admin properties override

2020-09-21 Thread GitBox
scanterog commented on pull request #9313: URL: https://github.com/apache/kafka/pull/9313#issuecomment-696271853 Thanks @ryannedolan! what is the usual procedure to get this merged? This is an automated message from the Apach

[GitHub] [kafka] ryannedolan commented on pull request #9313: [mm2] Fix consumer/producer/admin properties override

2020-09-21 Thread GitBox
ryannedolan commented on pull request #9313: URL: https://github.com/apache/kafka/pull/9313#issuecomment-696275095 > Thanks @ryannedolan! what is the usual procedure to get this merged? A committer must approve and merge. -

[GitHub] [kafka] abbccdda commented on pull request #9103: Add redirection for (Incremental)AlterConfig, AlterClientQuota and CreateTopics

2020-09-21 Thread GitBox
abbccdda commented on pull request #9103: URL: https://github.com/apache/kafka/pull/9103#issuecomment-696281629 @cmccabe Sounds good to me to remove the customized error helper. This is an automated message from the Apache Gi

[GitHub] [kafka] piotrrzysko opened a new pull request #9315: KAFKA-10496: Removed relying on external DNS servers in tests

2020-09-21 Thread GitBox
piotrrzysko opened a new pull request #9315: URL: https://github.com/apache/kafka/pull/9315 As ticket suggested I’ve tried to introduce in-memory DNS server for testing purposes, but unfortunately capability to change default DNS provider has been removed in Java 9: https://bugs.openjdk.ja

[jira] [Updated] (KAFKA-10505) [SystemTests] streams_static_membership.py and streams_upgradet_test.py fails

2020-09-21 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-10505: Component/s: system tests streams > [SystemTests] streams_static_membersh

[GitHub] [kafka] hachikuji commented on pull request #9130: KAFKA-10492; Core Kafka Raft Implementation (KIP-595)

2020-09-21 Thread GitBox
hachikuji commented on pull request #9130: URL: https://github.com/apache/kafka/pull/9130#issuecomment-696301126 As long as there are no problems with the build, I am planning to merge this within the next couple days. For a history of the review comments, please see: https://github.com/co

[jira] [Commented] (KAFKA-9075) Extend documentation for usage of GlobalKTable vs KTable

2020-09-21 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17199589#comment-17199589 ] Matthias J. Sax commented on KAFKA-9075: [~high.lee] Are you still interested? Se

[jira] [Created] (KAFKA-10507) Limit the set of APIs returned in pre-authentication ApiVersions

2020-09-21 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-10507: --- Summary: Limit the set of APIs returned in pre-authentication ApiVersions Key: KAFKA-10507 URL: https://issues.apache.org/jira/browse/KAFKA-10507 Project: Kafk

[GitHub] [kafka] abbccdda commented on pull request #9270: [WIP] KAFKA-10284: Group membership update due to static member rejoin should be persisted

2020-09-21 Thread GitBox
abbccdda commented on pull request #9270: URL: https://github.com/apache/kafka/pull/9270#issuecomment-696308421 retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] ableegoldman commented on a change in pull request #9083: KAFKA-9450: Follow-up; Forbid process after closed

2020-09-21 Thread GitBox
ableegoldman commented on a change in pull request #9083: URL: https://github.com/apache/kafka/pull/9083#discussion_r492282511 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorContextImpl.java ## @@ -217,12 +217,12 @@ public StateStore

[GitHub] [kafka] abbccdda commented on pull request #9270: [WIP] KAFKA-10284: Group membership update due to static member rejoin should be persisted

2020-09-21 Thread GitBox
abbccdda commented on pull request #9270: URL: https://github.com/apache/kafka/pull/9270#issuecomment-696317720 test this This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] vvcephei commented on a change in pull request #8892: KAFKA-10068: verify assignment performance with large cluster

2020-09-21 Thread GitBox
vvcephei commented on a change in pull request #8892: URL: https://github.com/apache/kafka/pull/8892#discussion_r492302522 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientState.java ## @@ -288,17 +288,17 @@ public void computeT

[jira] [Commented] (KAFKA-10507) Limit the set of APIs returned in pre-authentication ApiVersions

2020-09-21 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17199628#comment-17199628 ] David Jacot commented on KAFKA-10507: - That would make sense for the Java client cau

[jira] [Assigned] (KAFKA-10507) Limit the set of APIs returned in pre-authentication ApiVersions

2020-09-21 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot reassigned KAFKA-10507: --- Assignee: David Jacot > Limit the set of APIs returned in pre-authentication ApiVersions >

[jira] [Commented] (KAFKA-10507) Limit the set of APIs returned in pre-authentication ApiVersions

2020-09-21 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17199639#comment-17199639 ] Jason Gustafson commented on KAFKA-10507: - [~dajac] Good point. If you can confi

[GitHub] [kafka] vvcephei commented on a change in pull request #8181: KAFKA-9584 Headers ConcurrentModificationException

2020-09-21 Thread GitBox
vvcephei commented on a change in pull request #8181: URL: https://github.com/apache/kafka/pull/8181#discussion_r492316319 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -581,8 +580,8 @@ public void punctuate(final Proces

[GitHub] [kafka] vvcephei opened a new pull request #9316: MINOR: clarify variables for skipping idempotent source updates

2020-09-21 Thread GitBox
vvcephei opened a new pull request #9316: URL: https://github.com/apache/kafka/pull/9316 Clarify some confusing variable and method names. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build statu

[jira] [Commented] (KAFKA-10493) Ktable out-of-order updates are not being ignored

2020-09-21 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17199651#comment-17199651 ] John Roesler commented on KAFKA-10493: -- Hi all, I took a look, and I think the cod

[GitHub] [kafka] hachikuji merged pull request #9202: KAFKA-10401: Fix the currentStateTimeStamp doesn't get set correctly

2020-09-21 Thread GitBox
hachikuji merged pull request #9202: URL: https://github.com/apache/kafka/pull/9202 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] big-andy-coates commented on pull request #9156: KAFKA-10077: Filter downstream of state-store results in spurious tombstones

2020-09-21 Thread GitBox
big-andy-coates commented on pull request #9156: URL: https://github.com/apache/kafka/pull/9156#issuecomment-696383217 retest this please This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [kafka] mjsax commented on a change in pull request #8181: KAFKA-9584 Headers ConcurrentModificationException

2020-09-21 Thread GitBox
mjsax commented on a change in pull request #8181: URL: https://github.com/apache/kafka/pull/8181#discussion_r492360815 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -581,8 +580,8 @@ public void punctuate(final Processor

[GitHub] [kafka] ijuma commented on a change in pull request #9299: MINOR: Use `Map.foreachKv` to avoid tuple allocation in Scala 2.13

2020-09-21 Thread GitBox
ijuma commented on a change in pull request #9299: URL: https://github.com/apache/kafka/pull/9299#discussion_r492361262 ## File path: core/src/main/scala/kafka/utils/Implicits.scala ## @@ -46,4 +47,21 @@ object Implicits { } + /** + * Exposes `foreachKv` which maps to

[jira] [Updated] (KAFKA-10181) Create redirection template for configuration change RPCs

2020-09-21 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen updated KAFKA-10181: Description: In the bridge release broker, AlterConfig/IncrementalAlterConfig/CreateTopics/AlterCl

[jira] [Updated] (KAFKA-10181) Create redirection template for configuration change RPCs

2020-09-21 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen updated KAFKA-10181: Summary: Create redirection template for configuration change RPCs (was: Redirect AlterConfig/Inc

[jira] [Assigned] (KAFKA-10350) Add redirect request monitoring metrics

2020-09-21 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen reassigned KAFKA-10350: --- Assignee: Boyang Chen > Add redirect request monitoring metrics > -

[jira] [Created] (KAFKA-10508) Consider moving ForwardRequestHandler to a separate class

2020-09-21 Thread Boyang Chen (Jira)
Boyang Chen created KAFKA-10508: --- Summary: Consider moving ForwardRequestHandler to a separate class Key: KAFKA-10508 URL: https://issues.apache.org/jira/browse/KAFKA-10508 Project: Kafka Issue

[jira] [Commented] (KAFKA-10493) Ktable out-of-order updates are not being ignored

2020-09-21 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17199688#comment-17199688 ] Guozhang Wang commented on KAFKA-10493: --- Thanks for double checking John! The PR l

[jira] [Updated] (KAFKA-10343) Remove 2.7 IBP for redirection enablement

2020-09-21 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen updated KAFKA-10343: Summary: Remove 2.7 IBP for redirection enablement (was: Redirect AlterClientQuotas to the contro

[jira] [Updated] (KAFKA-10343) Remove 2.7 IBP for redirection enablement

2020-09-21 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen updated KAFKA-10343: Description: The shipment of redirection could not be complete in 2.7. With that being said, we ne

[jira] [Updated] (KAFKA-10343) Remove 2.7 IBP for redirection enablement

2020-09-21 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen updated KAFKA-10343: Fix Version/s: 2.7.0 > Remove 2.7 IBP for redirection enablement > ---

[jira] [Commented] (KAFKA-10475) Using same key reports different count of records for groupBy() and groupByKey() in Kafka Streaming Application

2020-09-21 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17199689#comment-17199689 ] Boyang Chen commented on KAFKA-10475: - [~saad-rasool] [~guozhang]I don't think we ha

[GitHub] [kafka] ableegoldman commented on a change in pull request #8892: KAFKA-10068: verify assignment performance with large cluster

2020-09-21 Thread GitBox
ableegoldman commented on a change in pull request #8892: URL: https://github.com/apache/kafka/pull/8892#discussion_r492382332 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/AssignmentTestUtils.java ## @@ -77,13 +86,8 @@ public

[GitHub] [kafka] ableegoldman commented on a change in pull request #8892: KAFKA-10068: verify assignment performance with large cluster

2020-09-21 Thread GitBox
ableegoldman commented on a change in pull request #8892: URL: https://github.com/apache/kafka/pull/8892#discussion_r492383223 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientState.java ## @@ -288,17 +288,17 @@ public void comp

[GitHub] [kafka] ijuma merged pull request #9299: MINOR: Use `Map.forKeyValue` to avoid tuple allocation in Scala 2.13

2020-09-21 Thread GitBox
ijuma merged pull request #9299: URL: https://github.com/apache/kafka/pull/9299 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (KAFKA-10504) It will not work to skip to InitProducerId as lastError is always null

2020-09-21 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17199715#comment-17199715 ] Boyang Chen commented on KAFKA-10504: - Is this optimization necessary? > It will no

[GitHub] [kafka] abbccdda commented on a change in pull request #9311: KAFKA-9910: Implement new transaction timed out error

2020-09-21 Thread GitBox
abbccdda commented on a change in pull request #9311: URL: https://github.com/apache/kafka/pull/9311#discussion_r491655717 ## File path: clients/src/main/java/org/apache/kafka/common/errors/TransactionTimeoutException.java ## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Sof

[jira] [Commented] (KAFKA-10493) Ktable out-of-order updates are not being ignored

2020-09-21 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17199724#comment-17199724 ] Matthias J. Sax commented on KAFKA-10493: - I have concerns about making it optio

[GitHub] [kafka] mjsax commented on pull request #9312: KAFKA-10505: Fix parsing of generation log string.

2020-09-21 Thread GitBox
mjsax commented on pull request #9312: URL: https://github.com/apache/kafka/pull/9312#issuecomment-696464404 @nizhikov @ableegoldman Do we know when this broke? What was the old log line and what is the new one? Triggered system test run: https://jenkins.confluent.io/job/system-test

[GitHub] [kafka] mjsax commented on a change in pull request #9251: KAFKA-10459: Document IQ APIs where order does not hold between stores

2020-09-21 Thread GitBox
mjsax commented on a change in pull request #9251: URL: https://github.com/apache/kafka/pull/9251#discussion_r492434090 ## File path: streams/src/main/java/org/apache/kafka/streams/state/ReadOnlyWindowStore.java ## @@ -25,6 +25,11 @@ * A window store that only supports read

[GitHub] [kafka] mjsax commented on pull request #9251: KAFKA-10459: Document IQ APIs where order does not hold between stores

2020-09-21 Thread GitBox
mjsax commented on pull request #9251: URL: https://github.com/apache/kafka/pull/9251#issuecomment-696467547 Thanks for the PR @showuon! This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [kafka] mjsax merged pull request #9251: KAFKA-10459: Document IQ APIs where order does not hold between stores

2020-09-21 Thread GitBox
mjsax merged pull request #9251: URL: https://github.com/apache/kafka/pull/9251 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] showuon commented on pull request #9121: KAFKA-10351: add tests for IOExceptions for GlobalStateManagerImpl/OffsetCheckpoint

2020-09-21 Thread GitBox
showuon commented on pull request #9121: URL: https://github.com/apache/kafka/pull/9121#issuecomment-696467921 @mjsax , sorry, I found you're online now. So could you take a look again for the long pending PR? It's 2nd review, so it should be easier. Thanks. -

[jira] [Commented] (KAFKA-10493) Ktable out-of-order updates are not being ignored

2020-09-21 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17199734#comment-17199734 ] John Roesler commented on KAFKA-10493: -- Thanks, all. I do think it would be nice to

[GitHub] [kafka] vvcephei commented on a change in pull request #8892: KAFKA-10068: verify assignment performance with large cluster

2020-09-21 Thread GitBox
vvcephei commented on a change in pull request #8892: URL: https://github.com/apache/kafka/pull/8892#discussion_r492436680 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/AssignmentTestUtils.java ## @@ -77,13 +86,8 @@ public sta

[jira] [Assigned] (KAFKA-10458) Need a way to update quota for TokenBucket registered with Sensor

2020-09-21 Thread Anna Povzner (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anna Povzner reassigned KAFKA-10458: Assignee: David Jacot (was: Anna Povzner) > Need a way to update quota for TokenBucket r

[jira] [Commented] (KAFKA-10458) Need a way to update quota for TokenBucket registered with Sensor

2020-09-21 Thread Anna Povzner (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17199738#comment-17199738 ] Anna Povzner commented on KAFKA-10458: -- fixed with [https://github.com/apache/kafka

[jira] [Resolved] (KAFKA-10458) Need a way to update quota for TokenBucket registered with Sensor

2020-09-21 Thread Anna Povzner (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anna Povzner resolved KAFKA-10458. -- Resolution: Fixed > Need a way to update quota for TokenBucket registered with Sensor > --

[jira] [Created] (KAFKA-10509) Add metric to track throttle time due to hitting connection rate quota

2020-09-21 Thread Anna Povzner (Jira)
Anna Povzner created KAFKA-10509: Summary: Add metric to track throttle time due to hitting connection rate quota Key: KAFKA-10509 URL: https://issues.apache.org/jira/browse/KAFKA-10509 Project: Kafka

[GitHub] [kafka] ableegoldman commented on a change in pull request #8892: KAFKA-10068: verify assignment performance with large cluster

2020-09-21 Thread GitBox
ableegoldman commented on a change in pull request #8892: URL: https://github.com/apache/kafka/pull/8892#discussion_r492447041 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/AssignmentTestUtils.java ## @@ -77,13 +86,8 @@ public

[GitHub] [kafka] mjsax commented on a change in pull request #8181: KAFKA-9584 Headers ConcurrentModificationException

2020-09-21 Thread GitBox
mjsax commented on a change in pull request #8181: URL: https://github.com/apache/kafka/pull/8181#discussion_r492360815 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -581,8 +580,8 @@ public void punctuate(final Processor

  1   2   >