mjsax commented on a change in pull request #8181:
URL: https://github.com/apache/kafka/pull/8181#discussion_r492360815



##########
File path: 
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java
##########
@@ -581,8 +580,8 @@ public void punctuate(final ProcessorNode node, final long 
timestamp, final Punc
         if (processorContext.currentNode() != null) {
             throw new IllegalStateException(format("%sCurrent node is not 
null", logPrefix));
         }
-
-        updateProcessorContext(new StampedRecord(DUMMY_RECORD, timestamp), 
node);
+        
+        updateProcessorContext(new StampedRecord(new 
ConsumerRecord<>(ProcessorContextImpl.NONEXIST_TOPIC, -1, -1L, null, null), 
timestamp), node);

Review comment:
       From my understanding, neither the `ConsumerRecord` nor the 
`ProcessroRecordContext` are the issue, but the shared `Header` object -- it's 
just a "side effect" that creating a new `ConsumerRecord` creates an new 
`Header` object internally.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to