ableegoldman commented on a change in pull request #8892:
URL: https://github.com/apache/kafka/pull/8892#discussion_r492383223
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientState.java
##########
@@ -288,17 +288,17 @@ public void computeTaskLags(final UUID uuid, final
Map<TaskId, Long> allTaskEndO
final Long endOffsetSum = taskEntry.getValue();
final Long offsetSum = taskOffsetSums.getOrDefault(task, 0L);
- if (endOffsetSum < offsetSum) {
+ if (offsetSum == Task.LATEST_OFFSET) {
+ taskLagTotals.put(task, Task.LATEST_OFFSET);
+ } else if (offsetSum == UNKNOWN_OFFSET_SUM) {
+ taskLagTotals.put(task, UNKNOWN_OFFSET_SUM);
+ } else if (endOffsetSum < offsetSum) {
Review comment:
I don't know about fixing this before, but I found this while debugging
these tests and fixed it on the side in this PR. To be fair, it wasn't hurting
anything since we happen to put the right thing in the `taskLagTotals` map, but
the warning logged was definitely incorrect.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
