[jira] [Commented] (KAFKA-10467) kafka-topic --describe fails for topic created by "produce"

2020-09-08 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192037#comment-17192037 ] Luke Chen commented on KAFKA-10467: --- [~swayamraina] , your feed the wrong parameter in

[jira] [Comment Edited] (KAFKA-10467) kafka-topic --describe fails for topic created by "produce"

2020-09-08 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192037#comment-17192037 ] Luke Chen edited comment on KAFKA-10467 at 9/8/20, 8:34 AM:

[jira] [Commented] (KAFKA-8803) Stream will not start due to TimeoutException: Timeout expired after 60000milliseconds while awaiting InitProducerId

2020-09-08 Thread Volodymyr Korna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192086#comment-17192086 ] Volodymyr Korna commented on KAFKA-8803: Hi [~guozhang],   We have recently ena

[GitHub] [kafka] showuon removed a comment on pull request #9261: MINOR: Update source link in interactive query page

2020-09-08 Thread GitBox
showuon removed a comment on pull request #9261: URL: https://github.com/apache/kafka/pull/9261#issuecomment-688650169 @vvcephei , could you help review? Thanks. This is an automated message from the Apache Git Service. To re

[GitHub] [kafka] showuon commented on pull request #9261: MINOR: Update source link in interactive query page

2020-09-08 Thread GitBox
showuon commented on pull request #9261: URL: https://github.com/apache/kafka/pull/9261#issuecomment-688755615 @mimaison , could you help review this small PR? Thanks. This is an automated message from the Apache Git Service.

[jira] [Assigned] (KAFKA-10461) The config of closing heartbeat is invalid.

2020-09-08 Thread jiwei (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jiwei reassigned KAFKA-10461: - Assignee: jiwei > The config of closing heartbeat is invalid. > ---

[GitHub] [kafka] cadonna opened a new pull request #9262: MINOR: Fix log message when tasks directory is cleaned manually

2020-09-08 Thread GitBox
cadonna opened a new pull request #9262: URL: https://github.com/apache/kafka/pull/9262 Currently when a task directory is cleaned manually the message for the state dir cleaner is logged instead of the message for the manual cleanup. This is because the code checks the elapsed time

[GitHub] [kafka] cadonna commented on pull request #9262: MINOR: Fix log message when tasks directory is cleaned manually

2020-09-08 Thread GitBox
cadonna commented on pull request #9262: URL: https://github.com/apache/kafka/pull/9262#issuecomment-688768558 Call for review: @guozhangwang @ableegoldman @mjsax @vvcephei @wcarlson5 This is an automated message from the Ap

[GitHub] [kafka] cadonna commented on pull request #9258: MINOR: Add unit tests for StreamsRebalanceListener

2020-09-08 Thread GitBox
cadonna commented on pull request #9258: URL: https://github.com/apache/kafka/pull/9258#issuecomment-688768874 Retest this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] cadonna commented on pull request #9258: MINOR: Add unit tests for StreamsRebalanceListener

2020-09-08 Thread GitBox
cadonna commented on pull request #9258: URL: https://github.com/apache/kafka/pull/9258#issuecomment-688775571 The following tests failed for JDK 15: ``` kafka.network.ConnectionQuotasTest.testNoConnectionLimitsByDefault ``` The following tests failed for JDK 8: ``

[jira] [Commented] (KAFKA-10405) Flaky Test org.apache.kafka.streams.integration.PurgeRepartitionTopicIntegrationTest.shouldRestoreState

2020-09-08 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192122#comment-17192122 ] Bruno Cadonna commented on KAFKA-10405: --- Another failure: https://ci-builds.apach

[jira] [Commented] (KAFKA-9679) Mock consumer should behave consistent with actual consumer

2020-09-08 Thread Albert Lowis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192172#comment-17192172 ] Albert Lowis commented on KAFKA-9679: - Hello [~sujayopensource] and [~bchen225242] ,

[GitHub] [kafka] showuon edited a comment on pull request #9261: MINOR: Update source link in interactive query page

2020-09-08 Thread GitBox
showuon edited a comment on pull request #9261: URL: https://github.com/apache/kafka/pull/9261#issuecomment-688755615 @mimaison @vvcephei , could you help review this small PR? Thanks. This is an automated message from the Ap

[GitHub] [kafka] felipeazv commented on pull request #7288: KAFKA-7931 : [Proposal] Fix metadata fetch for ephemeral brokers behind a Virtual IP

2020-09-08 Thread GitBox
felipeazv commented on pull request #7288: URL: https://github.com/apache/kafka/pull/7288#issuecomment-688860769 Any updates in this PR? I am also facing this issue. This is an automated message from the Apache Git Service

[GitHub] [kafka] felipeazv edited a comment on pull request #7288: KAFKA-7931 : [Proposal] Fix metadata fetch for ephemeral brokers behind a Virtual IP

2020-09-08 Thread GitBox
felipeazv edited a comment on pull request #7288: URL: https://github.com/apache/kafka/pull/7288#issuecomment-688860769 Any updates in this PR? I am also facing this issue (client 2.5.0). This is an automated message from

[GitHub] [kafka] felipeazv removed a comment on pull request #7288: KAFKA-7931 : [Proposal] Fix metadata fetch for ephemeral brokers behind a Virtual IP

2020-09-08 Thread GitBox
felipeazv removed a comment on pull request #7288: URL: https://github.com/apache/kafka/pull/7288#issuecomment-688860769 Any updates in this PR? I am also facing this issue (client 2.5.0). This is an automated message from

[jira] [Created] (KAFKA-10468) Log4jController.getLoggers serialization

2020-09-08 Thread Tom Bentley (Jira)
Tom Bentley created KAFKA-10468: --- Summary: Log4jController.getLoggers serialization Key: KAFKA-10468 URL: https://issues.apache.org/jira/browse/KAFKA-10468 Project: Kafka Issue Type: Bug

[GitHub] [kafka] tombentley opened a new pull request #9263: KAFKA-10468: Fix CNFE on deserialization of Log4jController#getLoggers

2020-09-08 Thread GitBox
tombentley opened a new pull request #9263: URL: https://github.com/apache/kafka/pull/9263 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] tombentley commented on pull request #9263: KAFKA-10468: Fix CNFE on deserialization of Log4jController#getLoggers

2020-09-08 Thread GitBox
tombentley commented on pull request #9263: URL: https://github.com/apache/kafka/pull/9263#issuecomment-688900724 @mimaison this one is really trivial, grateful if you could take a look. This is an automated message from the

[GitHub] [kafka] ijuma merged pull request #9260: MINOR: Update scala default version in readme

2020-09-08 Thread GitBox
ijuma merged pull request #9260: URL: https://github.com/apache/kafka/pull/9260 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] lct45 opened a new pull request #9264: KAFKA-5636: Add Sliding Windows documentation

2020-09-08 Thread GitBox
lct45 opened a new pull request #9264: URL: https://github.com/apache/kafka/pull/9264 Add necessary documentation for [KIP-450](https://cwiki.apache.org/confluence/display/KAFKA/KIP-450%3A+Sliding+Window+Aggregations+in+the+DSL), adding sliding window aggregations to KStreams ### Co

[GitHub] [kafka] ijuma commented on pull request #9231: KAFKA-10447: Migrate tools module to JUnit 5 and mockito

2020-09-08 Thread GitBox
ijuma commented on pull request #9231: URL: https://github.com/apache/kafka/pull/9231#issuecomment-688912021 Unrelated flaky failures: ``` Build / JDK 15 / kafka.network.DynamicConnectionQuotaTest.testDynamicListenerConnectionCreationRateQuota Build / JDK 8 / kafka.api.Plaintex

[GitHub] [kafka] ijuma commented on pull request #9263: KAFKA-10468: Fix CNFE on deserialization of Log4jController#getLoggers

2020-09-08 Thread GitBox
ijuma commented on pull request #9263: URL: https://github.com/apache/kafka/pull/9263#issuecomment-688915561 This is a duplicate of https://github.com/apache/kafka/pull/9182 This is an automated message from the Apache Git Se

[GitHub] [kafka] ijuma commented on pull request #9182: KAFKA-10403 Replace scala collection by java collection in generating…

2020-09-08 Thread GitBox
ijuma commented on pull request #9182: URL: https://github.com/apache/kafka/pull/9182#issuecomment-688916053 The change looks good, can you please provide a test as well? This is an automated message from the Apache Git Servi

[GitHub] [kafka] chia7712 commented on pull request #9182: KAFKA-10403 Replace scala collection by java collection in generating…

2020-09-08 Thread GitBox
chia7712 commented on pull request #9182: URL: https://github.com/apache/kafka/pull/9182#issuecomment-688927747 > can you please provide a test as well? done! This is an automated message from the Apache Git Service. T

[GitHub] [kafka] ijuma commented on a change in pull request #9182: KAFKA-10403 Replace scala collection by java collection in generating…

2020-09-08 Thread GitBox
ijuma commented on a change in pull request #9182: URL: https://github.com/apache/kafka/pull/9182#discussion_r484981150 ## File path: core/src/main/scala/kafka/utils/Log4jController.scala ## @@ -87,9 +87,10 @@ object Log4jController { class Log4jController extends Log4jControl

[GitHub] [kafka] mmerdes opened a new pull request #9265: Fix typo in name of output topic

2020-09-08 Thread GitBox
mmerdes opened a new pull request #9265: URL: https://github.com/apache/kafka/pull/9265 This change fixes inconsistent naming for the output topic in the documentation. This is an automated message from the Apache Gi

[GitHub] [kafka] ijuma commented on pull request #9256: Fix some Gradle deprecation warnings

2020-09-08 Thread GitBox
ijuma commented on pull request #9256: URL: https://github.com/apache/kafka/pull/9256#issuecomment-688930298 Thanks for the PR. > Dependencies in the compile scope were moved to runtime. This seems like an issue, no? ---

[GitHub] [kafka] tombentley commented on pull request #9263: KAFKA-10468: Fix CNFE on deserialization of Log4jController#getLoggers

2020-09-08 Thread GitBox
tombentley commented on pull request #9263: URL: https://github.com/apache/kafka/pull/9263#issuecomment-688933062 Thanks @ijuma This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] tombentley closed pull request #9263: KAFKA-10468: Fix CNFE on deserialization of Log4jController#getLoggers

2020-09-08 Thread GitBox
tombentley closed pull request #9263: URL: https://github.com/apache/kafka/pull/9263 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (KAFKA-10467) kafka-topic --describe fails for topic created by "produce"

2020-09-08 Thread Swayam Raina (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192282#comment-17192282 ] Swayam Raina commented on KAFKA-10467: -- Hi [~showuon], I was using an internal lib

[jira] [Comment Edited] (KAFKA-10467) kafka-topic --describe fails for topic created by "produce"

2020-09-08 Thread Swayam Raina (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192282#comment-17192282 ] Swayam Raina edited comment on KAFKA-10467 at 9/8/20, 3:52 PM: ---

[GitHub] [kafka] junrao commented on a change in pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-09-08 Thread GitBox
junrao commented on a change in pull request #8657: URL: https://github.com/apache/kafka/pull/8657#discussion_r485026583 ## File path: core/src/main/scala/kafka/server/DelayedOperation.scala ## @@ -219,38 +203,38 @@ final class DelayedOperationPurgatory[T <: DelayedOperation](

[jira] [Created] (KAFKA-10469) describeConfigs() for broker loggers returns incorrect values

2020-09-08 Thread Tom Bentley (Jira)
Tom Bentley created KAFKA-10469: --- Summary: describeConfigs() for broker loggers returns incorrect values Key: KAFKA-10469 URL: https://issues.apache.org/jira/browse/KAFKA-10469 Project: Kafka

[GitHub] [kafka] tombentley commented on pull request #9266: KAFKA-10469: Resolve logger levels hierarchically

2020-09-08 Thread GitBox
tombentley commented on pull request #9266: URL: https://github.com/apache/kafka/pull/9266#issuecomment-688987558 @ijuma please could you take a look? This is an automated message from the Apache Git Service. To respond to th

[GitHub] [kafka] tombentley opened a new pull request #9266: KAFKA-10469: Resolve logger levels hierarchically

2020-09-08 Thread GitBox
tombentley opened a new pull request #9266: URL: https://github.com/apache/kafka/pull/9266 Previous to root logger level was used, ignoring intervening loggers with different levels. This is an automated message from the

[GitHub] [kafka] lct45 commented on a change in pull request #9157: Update for KIP-450 to handle early records

2020-09-08 Thread GitBox
lct45 commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r485053442 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -192,29 +213,125 @@ public void proce

[GitHub] [kafka] vvcephei opened a new pull request #9267: MINOR: Add debug logs for StreamThread

2020-09-08 Thread GitBox
vvcephei opened a new pull request #9267: URL: https://github.com/apache/kafka/pull/9267 Add debug logs to see when Streams calls poll, process, commit, etc. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverag

[jira] [Created] (KAFKA-10470) zstd decompression with small batches is slow and causes excessive GC

2020-09-08 Thread Robert Wagner (Jira)
Robert Wagner created KAFKA-10470: - Summary: zstd decompression with small batches is slow and causes excessive GC Key: KAFKA-10470 URL: https://issues.apache.org/jira/browse/KAFKA-10470 Project: Kafk

[GitHub] [kafka] ableegoldman commented on a change in pull request #9262: MINOR: Fix log message when tasks directory is cleaned manually

2020-09-08 Thread GitBox
ableegoldman commented on a change in pull request #9262: URL: https://github.com/apache/kafka/pull/9262#discussion_r485073167 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java ## @@ -328,15 +328,15 @@ private synchronized voi

[GitHub] [kafka] vvcephei commented on a change in pull request #9267: MINOR: Add debug logs for StreamThread

2020-09-08 Thread GitBox
vvcephei commented on a change in pull request #9267: URL: https://github.com/apache/kafka/pull/9267#discussion_r485062295 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -612,63 +612,18 @@ void runOnce() { fina

[GitHub] [kafka] tombentley commented on pull request #9266: KAFKA-10469: Resolve logger levels hierarchically

2020-09-08 Thread GitBox
tombentley commented on pull request #9266: URL: https://github.com/apache/kafka/pull/9266#issuecomment-689020104 @stanislavkozlovski I'm not sure how what you describe differs from the test implemented, though it's not identically the same because the tests have their own `log4j.propertie

[GitHub] [kafka] mjsax commented on a change in pull request #9186: KAFKA-10277: Allow null keys with non-null mappedKey in KStreamKGlobalTable join

2020-09-08 Thread GitBox
mjsax commented on a change in pull request #9186: URL: https://github.com/apache/kafka/pull/9186#discussion_r485095735 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKTableJoinProcessor.java ## @@ -58,22 +58,23 @@ public void init(final

[GitHub] [kafka] mjsax commented on a change in pull request #9186: KAFKA-10277: Allow null keys with non-null mappedKey in KStreamKGlobalTable join

2020-09-08 Thread GitBox
mjsax commented on a change in pull request #9186: URL: https://github.com/apache/kafka/pull/9186#discussion_r485096090 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKTableJoinProcessor.java ## @@ -58,22 +58,23 @@ public void init(final

[jira] [Commented] (KAFKA-10313) Out of range offset errors leading to offset reset

2020-09-08 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-10313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192358#comment-17192358 ] Michał Łukowicz commented on KAFKA-10313: - Hello Team! Same issue here - Kafka

[GitHub] [kafka] mjsax commented on a change in pull request #9186: KAFKA-10277: Allow null keys with non-null mappedKey in KStreamKGlobalTable join

2020-09-08 Thread GitBox
mjsax commented on a change in pull request #9186: URL: https://github.com/apache/kafka/pull/9186#discussion_r485096581 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKTableJoinProcessor.java ## @@ -58,22 +58,23 @@ public void init(final

[GitHub] [kafka] mjsax commented on a change in pull request #9186: KAFKA-10277: Allow null keys with non-null mappedKey in KStreamKGlobalTable join

2020-09-08 Thread GitBox
mjsax commented on a change in pull request #9186: URL: https://github.com/apache/kafka/pull/9186#discussion_r485096581 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKTableJoinProcessor.java ## @@ -58,22 +58,23 @@ public void init(final

[GitHub] [kafka] ableegoldman commented on a change in pull request #9186: KAFKA-10277: Allow null keys with non-null mappedKey in KStreamKGlobalTable join

2020-09-08 Thread GitBox
ableegoldman commented on a change in pull request #9186: URL: https://github.com/apache/kafka/pull/9186#discussion_r485097186 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKTableJoinProcessor.java ## @@ -58,23 +58,22 @@ public void init

[GitHub] [kafka] ableegoldman commented on a change in pull request #9186: KAFKA-10277: Allow null keys with non-null mappedKey in KStreamKGlobalTable join

2020-09-08 Thread GitBox
ableegoldman commented on a change in pull request #9186: URL: https://github.com/apache/kafka/pull/9186#discussion_r485097186 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKTableJoinProcessor.java ## @@ -58,23 +58,22 @@ public void init

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9267: MINOR: Add debug logs for StreamThread

2020-09-08 Thread GitBox
wcarlson5 commented on a change in pull request #9267: URL: https://github.com/apache/kafka/pull/9267#discussion_r485098403 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -752,6 +712,77 @@ void runOnce() { comm

[GitHub] [kafka] hachikuji opened a new pull request #9268: KAFKA-10442; Add transaction admin APIs for KIP-664

2020-09-08 Thread GitBox
hachikuji opened a new pull request #9268: URL: https://github.com/apache/kafka/pull/9268 This patch adds support for the new transactional APIs from KIP-664: https://cwiki.apache.org/confluence/display/KAFKA/KIP-664%3A+Provide+tooling+to+detect+and+abort+hanging+transactions#KIP664:Provide

[GitHub] [kafka] stanislavkozlovski commented on pull request #9266: KAFKA-10469: Resolve logger levels hierarchically

2020-09-08 Thread GitBox
stanislavkozlovski commented on pull request #9266: URL: https://github.com/apache/kafka/pull/9266#issuecomment-689043684 Sorry, I mistook `kafka` for the root logger. I agree it tests the same path This is an automated messa

[jira] [Commented] (KAFKA-10455) Probing rebalances are not guaranteed to be triggered by non-leader members

2020-09-08 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192371#comment-17192371 ] Guozhang Wang commented on KAFKA-10455: --- Thanks for the info [~ableegoldman]. I th

[GitHub] [kafka] JoelWee commented on a change in pull request #9186: KAFKA-10277: Allow null keys with non-null mappedKey in KStreamKGlobalTable join

2020-09-08 Thread GitBox
JoelWee commented on a change in pull request #9186: URL: https://github.com/apache/kafka/pull/9186#discussion_r485126654 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKTableJoinProcessor.java ## @@ -58,22 +58,23 @@ public void init(fina

[GitHub] [kafka] JoelWee commented on a change in pull request #9186: KAFKA-10277: Allow null keys with non-null mappedKey in KStreamKGlobalTable join

2020-09-08 Thread GitBox
JoelWee commented on a change in pull request #9186: URL: https://github.com/apache/kafka/pull/9186#discussion_r485130942 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKTableJoinProcessor.java ## @@ -58,23 +58,22 @@ public void init(fina

[GitHub] [kafka] jonhkr commented on pull request #9256: Fix some Gradle deprecation warnings

2020-09-08 Thread GitBox
jonhkr commented on pull request #9256: URL: https://github.com/apache/kafka/pull/9256#issuecomment-689072311 @ijuma Yes, it was. I've updated the code to use the `api` configuration provided by the `java-library` plugin. This configuration has the same behaviour of the `compile` that w

[GitHub] [kafka] guozhangwang commented on a change in pull request #9267: MINOR: Add debug logs for StreamThread

2020-09-08 Thread GitBox
guozhangwang commented on a change in pull request #9267: URL: https://github.com/apache/kafka/pull/9267#discussion_r485132348 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -706,13 +662,17 @@ void runOnce() {

[GitHub] [kafka] hachikuji merged pull request #9219: KAFKA-10432: LeaderEpochCache is incorrectly recovered for leader epoch 0

2020-09-08 Thread GitBox
hachikuji merged pull request #9219: URL: https://github.com/apache/kafka/pull/9219 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Resolved] (KAFKA-10432) LeaderEpochCache is incorrectly recovered on segment recovery for epoch 0

2020-09-08 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-10432. - Fix Version/s: 2.6.1 Resolution: Fixed > LeaderEpochCache is incorrectly recovere

[GitHub] [kafka] ableegoldman commented on pull request #9157: Update for KIP-450 to handle early records

2020-09-08 Thread GitBox
ableegoldman commented on pull request #9157: URL: https://github.com/apache/kafka/pull/9157#issuecomment-689114712 One unrelated test failure: `kafka.api.PlaintextAdminIntegrationTest.testAlterReplicaLogDirs` This is an aut

[GitHub] [kafka] lct45 commented on pull request #9264: KAFKA-5636: Add Sliding Windows documentation

2020-09-08 Thread GitBox
lct45 commented on pull request #9264: URL: https://github.com/apache/kafka/pull/9264#issuecomment-689115428 @ableegoldman for review This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] mjsax commented on a change in pull request #9157: Update for KIP-450 to handle early records

2020-09-08 Thread GitBox
mjsax commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r485129599 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -117,25 +117,44 @@ public void proces

[jira] [Created] (KAFKA-10471) TimeIndex handling may cause data loss in certain back to back failure

2020-09-08 Thread Rohit Shekhar (Jira)
Rohit Shekhar created KAFKA-10471: - Summary: TimeIndex handling may cause data loss in certain back to back failure Key: KAFKA-10471 URL: https://issues.apache.org/jira/browse/KAFKA-10471 Project: Kaf

[jira] [Updated] (KAFKA-10471) TimeIndex handling may cause data loss in certain back to back failure

2020-09-08 Thread Rohit Shekhar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Shekhar updated KAFKA-10471: -- Description: # Active segment for log A going clean shutdown - trim the time index to the lat

[jira] [Commented] (KAFKA-10448) Preserve Source Partition in Kafka Streams from context

2020-09-08 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192491#comment-17192491 ] Matthias J. Sax commented on KAFKA-10448: - Thanks, feel free to start a discussi

[jira] [Commented] (KAFKA-10471) TimeIndex handling may cause data loss in certain back to back failure

2020-09-08 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192492#comment-17192492 ] Jun Rao commented on KAFKA-10471: - [~rshekhar]: Thanks for reporting this. This is a ver

[jira] [Commented] (KAFKA-10471) TimeIndex handling may cause data loss in certain back to back failure

2020-09-08 Thread Dhruvil Shah (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192494#comment-17192494 ] Dhruvil Shah commented on KAFKA-10471: -- It may be nice to use the time index sanity

[GitHub] [kafka] ableegoldman commented on a change in pull request #9186: KAFKA-10277: Allow null keys with non-null mappedKey in KStreamKGlobalTable join

2020-09-08 Thread GitBox
ableegoldman commented on a change in pull request #9186: URL: https://github.com/apache/kafka/pull/9186#discussion_r485217278 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKTableJoinProcessor.java ## @@ -58,23 +58,22 @@ public void init

[GitHub] [kafka] ableegoldman commented on a change in pull request #9186: KAFKA-10277: Allow null keys with non-null mappedKey in KStreamKGlobalTable join

2020-09-08 Thread GitBox
ableegoldman commented on a change in pull request #9186: URL: https://github.com/apache/kafka/pull/9186#discussion_r485218625 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKTableJoinProcessor.java ## @@ -58,22 +58,23 @@ public void init

[GitHub] [kafka] ableegoldman commented on a change in pull request #9186: KAFKA-10277: Allow null keys with non-null mappedKey in KStreamKGlobalTable join

2020-09-08 Thread GitBox
ableegoldman commented on a change in pull request #9186: URL: https://github.com/apache/kafka/pull/9186#discussion_r485218625 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKTableJoinProcessor.java ## @@ -58,22 +58,23 @@ public void init

[jira] [Commented] (KAFKA-10471) TimeIndex handling may cause data loss in certain back to back failure

2020-09-08 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192503#comment-17192503 ] Jun Rao commented on KAFKA-10471: - [~dhruvilshah] : I agree that the sanity check in the

[GitHub] [kafka] ableegoldman commented on a change in pull request #9186: KAFKA-10277: Allow null keys with non-null mappedKey in KStreamKGlobalTable join

2020-09-08 Thread GitBox
ableegoldman commented on a change in pull request #9186: URL: https://github.com/apache/kafka/pull/9186#discussion_r485218625 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKTableJoinProcessor.java ## @@ -58,22 +58,23 @@ public void init

[jira] [Commented] (KAFKA-10471) TimeIndex handling may cause data loss in certain back to back failure

2020-09-08 Thread Rohit Shekhar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192504#comment-17192504 ] Rohit Shekhar commented on KAFKA-10471: --- +1 [~junrao] will detect unclean shutdown

[GitHub] [kafka] ableegoldman commented on a change in pull request #9157: Update for KIP-450 to handle early records

2020-09-08 Thread GitBox
ableegoldman commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r485221052 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -146,96 +165,203 @@ public voi

[GitHub] [kafka] ableegoldman commented on a change in pull request #9157: Update for KIP-450 to handle early records

2020-09-08 Thread GitBox
ableegoldman commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r485221931 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -146,96 +165,203 @@ public voi

[GitHub] [kafka] ableegoldman commented on a change in pull request #9157: Update for KIP-450 to handle early records

2020-09-08 Thread GitBox
ableegoldman commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r485222996 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -146,96 +165,203 @@ public voi

[jira] [Commented] (KAFKA-10134) High CPU issue during rebalance in Kafka consumer after upgrading to 2.5

2020-09-08 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192513#comment-17192513 ] Sophie Blee-Goldman commented on KAFKA-10134: - Hey [~davispw], It looks lik

[GitHub] [kafka] ableegoldman commented on pull request #9264: KAFKA-5636: Add Sliding Windows documentation

2020-09-08 Thread GitBox
ableegoldman commented on pull request #9264: URL: https://github.com/apache/kafka/pull/9264#issuecomment-689173489 cc @guozhangwang for secondary review & merge This is an automated message from the Apache Git Service. To re

[GitHub] [kafka] lct45 commented on a change in pull request #9157: Update for KIP-450 to handle early records

2020-09-08 Thread GitBox
lct45 commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r485235880 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregateTest.java ## @@ -439,6 +442,185 @@ public void te

[GitHub] [kafka] ableegoldman commented on a change in pull request #9157: Update for KIP-450 to handle early records

2020-09-08 Thread GitBox
ableegoldman commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r485239998 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregateTest.java ## @@ -439,6 +442,185 @@ public

[GitHub] [kafka] JoelWee commented on a change in pull request #9186: KAFKA-10277: Allow null keys with non-null mappedKey in KStreamKGlobalTable join

2020-09-08 Thread GitBox
JoelWee commented on a change in pull request #9186: URL: https://github.com/apache/kafka/pull/9186#discussion_r485244413 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKTableJoinProcessor.java ## @@ -58,22 +58,23 @@ public void init(fina

[GitHub] [kafka] lct45 commented on a change in pull request #9157: Update for KIP-450 to handle early records

2020-09-08 Thread GitBox
lct45 commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r485248486 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregateTest.java ## @@ -439,6 +442,185 @@ public void te

[GitHub] [kafka] ableegoldman commented on a change in pull request #9157: Update for KIP-450 to handle early records

2020-09-08 Thread GitBox
ableegoldman commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r485249087 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregateTest.java ## @@ -439,6 +442,185 @@ public

[jira] [Updated] (KAFKA-5636) Add Sliding-Window support for Aggregations

2020-09-08 Thread Leah Thomas (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-5636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leah Thomas updated KAFKA-5636: --- Fix Version/s: 2.7.0 > Add Sliding-Window support for Aggregations >

[jira] [Resolved] (KAFKA-5636) Add Sliding-Window support for Aggregations

2020-09-08 Thread Leah Thomas (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-5636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leah Thomas resolved KAFKA-5636. Resolution: Fixed > Add Sliding-Window support for Aggregations > -

[GitHub] [kafka] showuon commented on pull request #9121: KAFKA-10351: add tests for IOExceptions for GlobalStateManagerImpl/OffsetCheckpoint

2020-09-08 Thread GitBox
showuon commented on pull request #9121: URL: https://github.com/apache/kafka/pull/9121#issuecomment-689196185 @mjsax could you review this PR again? Thanks. This is an automated message from the Apache Git Service. To respon

[GitHub] [kafka] ableegoldman commented on a change in pull request #9239: Adding reverse iterator usage for sliding windows processing (extending KIP-450)

2020-09-08 Thread GitBox
ableegoldman commented on a change in pull request #9239: URL: https://github.com/apache/kafka/pull/9239#discussion_r485266653 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/SlidingWindowedCogroupedKStreamImplTest.java ## @@ -246,4 +238,31 @@ pr

[GitHub] [kafka] junrao commented on pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-09-08 Thread GitBox
junrao commented on pull request #8657: URL: https://github.com/apache/kafka/pull/8657#issuecomment-689241869 @ijuma @hachikuji @rajinisivaram : I think this PR is ready to be merged. Any further comments from you? This is a

[GitHub] [kafka] showuon commented on pull request #9202: KAFKA-10401: Fix the currentStateTimeStamp doesn't get set correctly

2020-09-08 Thread GitBox
showuon commented on pull request #9202: URL: https://github.com/apache/kafka/pull/9202#issuecomment-689244512 @ijuma , could you help review this PR again? Thanks. This is an automated message from the Apache Git Service. T

[GitHub] [kafka] showuon commented on pull request #9179: KAFKA-10390: Remove ignore case option when grep process info to be more specific

2020-09-08 Thread GitBox
showuon commented on pull request #9179: URL: https://github.com/apache/kafka/pull/9179#issuecomment-689244826 @cmccabe @lbradstreet , any other comments for this PR? Thank you. This is an automated message from the Apache

[GitHub] [kafka] showuon commented on pull request #9178: KAFKA-8362: fix the old checkpoint won't be removed after alter log dir

2020-09-08 Thread GitBox
showuon commented on pull request #9178: URL: https://github.com/apache/kafka/pull/9178#issuecomment-689247342 @tombentley @ijuma , could you help review this PR? Thank you. This is an automated message from the Apache Git Se

[GitHub] [kafka] showuon commented on pull request #9104: KAFKA-10266: Update the connector config header.converter

2020-09-08 Thread GitBox
showuon commented on pull request #9104: URL: https://github.com/apache/kafka/pull/9104#issuecomment-689247469 @kkonstantine , could you review this PR? Thanks. This is an automated message from the Apache Git Service. To re

[GitHub] [kafka] showuon commented on pull request #9062: KAFKA-8098: fix the flaky test by disabling the auto commit to avoid member rejoining

2020-09-08 Thread GitBox
showuon commented on pull request #9062: URL: https://github.com/apache/kafka/pull/9062#issuecomment-689247748 @omkreddy , any comment for this PR? Thanks. This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] chia7712 commented on pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-09-08 Thread GitBox
chia7712 commented on pull request #8657: URL: https://github.com/apache/kafka/pull/8657#issuecomment-689256048 ``` Build / JDK 15 / kafka.network.ConnectionQuotasTest.testNoConnectionLimitsByDefault Build / JDK 11 / kafka.network.DynamicConnectionQuotaTest.testDynamicListenerConnect

[GitHub] [kafka] chia7712 commented on pull request #9182: KAFKA-10403 Replace scala collection by java collection in generating…

2020-09-08 Thread GitBox
chia7712 commented on pull request #9182: URL: https://github.com/apache/kafka/pull/9182#issuecomment-689256679 ``` Execution failed for task ':connect:mirror:integrationTest'. 01:19:16 > Process 'Gradle Test Executor 48' finished with non-zero exit value 1 01:19:16This probl

[GitHub] [kafka] chia7712 commented on pull request #9257: KAFKA-10463 the necessary utilities in Dockerfile should include git

2020-09-08 Thread GitBox
chia7712 commented on pull request #9257: URL: https://github.com/apache/kafka/pull/9257#issuecomment-689265404 @ijuma Could you take a look? I want to run system test on different jdk. I configure ```jdk_version``` to change the os of kafka dockerfile. Without this patch, it is impossible

[jira] [Commented] (KAFKA-10467) kafka-topic --describe fails for topic created by "produce"

2020-09-08 Thread huxihx (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192585#comment-17192585 ] huxihx commented on KAFKA-10467: Seems the problem is caused by another issue since it s

[GitHub] [kafka] ableegoldman commented on pull request #9157: Update for KIP-450 to handle early records

2020-09-08 Thread GitBox
ableegoldman commented on pull request #9157: URL: https://github.com/apache/kafka/pull/9157#issuecomment-689272398 Looks like the three Java builds all passed, but the CI build failed due to ``` [2020-09-09T02:35:12.324Z] + mkdir test-streams-archetype [2020-09-09T02:35:12.324Z] mk

[GitHub] [kafka] ableegoldman commented on pull request #9157: Update for KIP-450 to handle early records

2020-09-08 Thread GitBox
ableegoldman commented on pull request #9157: URL: https://github.com/apache/kafka/pull/9157#issuecomment-689272607 Not sure what's the deal with that but I ran it locally myself and everything passed. Can we merge this @mjsax ?

[GitHub] [kafka] ableegoldman commented on pull request #9239: Adding reverse iterator usage for sliding windows processing (extending KIP-450)

2020-09-08 Thread GitBox
ableegoldman commented on pull request #9239: URL: https://github.com/apache/kafka/pull/9239#issuecomment-689272887 I think this is ready for @vvcephei to review, once the early records PR is merged and this one is rebased T

  1   2   >