JoelWee commented on a change in pull request #9186:
URL: https://github.com/apache/kafka/pull/9186#discussion_r485130942
##########
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKTableJoinProcessor.java
##########
@@ -58,23 +58,22 @@ public void init(final ProcessorContext context) {
@Override
public void process(final K1 key, final V1 value) {
- // we do join iff keys are equal, thus, if key is null we cannot join
and just ignore the record
- // If {@code keyMapper} returns {@code null} it implies there is no
match,
- // so ignore unless it is a left join
Review comment:
Right, thanks for the clarification! Wouldn't we still want the`
leftJoin` in that case though? When we reach the `leftJoin` in the
[code](https://github.com/apache/kafka/pull/9186/commits/e9616c64dfdc33481d0b831f80ecd0385801c761),
the `mappedKey` is never null but it might not exist in the GlobalKTable (and
so `value2` is null). If we're doing a `leftJoin`, then we'll want to allow
these null values? (If not, the `leftJoin` is just the same as the normal
`join`?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
