ableegoldman commented on a change in pull request #9186:
URL: https://github.com/apache/kafka/pull/9186#discussion_r485217278
##########
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKTableJoinProcessor.java
##########
@@ -58,23 +58,22 @@ public void init(final ProcessorContext context) {
@Override
public void process(final K1 key, final V1 value) {
- // we do join iff keys are equal, thus, if key is null we cannot join
and just ignore the record
- // If {@code keyMapper} returns {@code null} it implies there is no
match,
- // so ignore unless it is a left join
Review comment:
Ah yeah sorry, I'm getting things mixed up here...this comment is
referring to when the mappedKey is null while the condition I cited below now
only applies to when the value is null. Your reasoning sounds correct, we
should still process the record in that case if it's a left join. But we should
also remove this comment, since if the mappedKey is null then we drop it,
regardless of if its a left join or any other
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
