[jira] [Created] (KAFKA-10136) Make option threads of ConsumerPerformance work

2020-06-10 Thread jiamei xie (Jira)
jiamei xie created KAFKA-10136: -- Summary: Make option threads of ConsumerPerformance work Key: KAFKA-10136 URL: https://issues.apache.org/jira/browse/KAFKA-10136 Project: Kafka Issue Type: Bug

[jira] [Updated] (KAFKA-9848) Avoid triggering scheduled rebalance delay when task assignment fails but Connect workers remain in the group

2020-06-10 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-9848: -- Fix Version/s: 2.5.1 2.4.2 2.6.0

[jira] [Resolved] (KAFKA-9848) Avoid triggering scheduled rebalance delay when task assignment fails but Connect workers remain in the group

2020-06-10 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis resolved KAFKA-9848. --- Resolution: Fixed > Avoid triggering scheduled rebalance delay when task assi

[jira] [Updated] (KAFKA-9849) Fix issue with worker.unsync.backoff.ms creating zombie workers when incremental cooperative rebalancing is used

2020-06-10 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-9849: -- Fix Version/s: 2.5.1 2.4.2 2.6.0

[jira] [Resolved] (KAFKA-9849) Fix issue with worker.unsync.backoff.ms creating zombie workers when incremental cooperative rebalancing is used

2020-06-10 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis resolved KAFKA-9849. --- Resolution: Fixed > Fix issue with worker.unsync.backoff.ms creating zombie w

[GitHub] [kafka] chia7712 commented on a change in pull request #8841: KAFKA-10123 Fix incorrect value for AWAIT_RESET#hasPosition

2020-06-10 Thread GitBox
chia7712 commented on a change in pull request #8841: URL: https://github.com/apache/kafka/pull/8841#discussion_r437913208 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/SubscriptionState.java ## @@ -978,7 +1000,7 @@ public boolean hasValidPosi

[GitHub] [kafka] chia7712 commented on a change in pull request #8841: KAFKA-10123 Fix incorrect value for AWAIT_RESET#hasPosition

2020-06-10 Thread GitBox
chia7712 commented on a change in pull request #8841: URL: https://github.com/apache/kafka/pull/8841#discussion_r437918610 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/SubscriptionState.java ## @@ -799,6 +806,21 @@ private boolean maybeValid

[GitHub] [kafka] kkonstantine commented on a change in pull request #8069: KAFKA-9374: Make connector interactions asynchronous

2020-06-10 Thread GitBox
kkonstantine commented on a change in pull request #8069: URL: https://github.com/apache/kafka/pull/8069#discussion_r437912938 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java ## @@ -239,38 +243,59 @@ public void stop() { * @param

[GitHub] [kafka] jiameixie opened a new pull request #8845: KAFKA-10126:Warn unused ConsumerPerformance optons

2020-06-10 Thread GitBox
jiameixie opened a new pull request #8845: URL: https://github.com/apache/kafka/pull/8845 Option numThreadsOpt and numFetchersOpt are unused in ConsumerPerformance. According to comments from https://issues.apache.org/jira/browse/KAFKA-10126, add a warning when invoking these options w

[GitHub] [kafka] jiameixie commented on pull request #8845: KAFKA-10126:Add a warning message for ConsumerPerformance

2020-06-10 Thread GitBox
jiameixie commented on pull request #8845: URL: https://github.com/apache/kafka/pull/8845#issuecomment-641924051 @abbccdda @chia7712 @ijuma Call for review. Thanks. This is an automated message from the Apache Git Service. T

[GitHub] [kafka] Lucent-Wong commented on a change in pull request #8453: KAFKA-9841: Connector and Task duplicated when a worker join with old…

2020-06-10 Thread GitBox
Lucent-Wong commented on a change in pull request #8453: URL: https://github.com/apache/kafka/pull/8453#discussion_r438084512 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java ## @@ -229,6 +229,10 @@ pr

[GitHub] [kafka] Lucent-Wong commented on a change in pull request #8453: KAFKA-9841: Connector and Task duplicated when a worker join with old…

2020-06-10 Thread GitBox
Lucent-Wong commented on a change in pull request #8453: URL: https://github.com/apache/kafka/pull/8453#discussion_r438084512 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java ## @@ -229,6 +229,10 @@ pr

[jira] [Commented] (KAFKA-7888) kafka cluster not recovering - Shrinking ISR from 14,13 to 13 (kafka.cluster.Partition) continously

2020-06-10 Thread Youssef BOUZAIENNE (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17130623#comment-17130623 ] Youssef BOUZAIENNE commented on KAFKA-7888: --- [~junrao] any news on this issue i

[GitHub] [kafka] dajac commented on a change in pull request #8808: KAFKA-10109: Fix double AdminClient creation in AclCommand

2020-06-10 Thread GitBox
dajac commented on a change in pull request #8808: URL: https://github.com/apache/kafka/pull/8808#discussion_r438132457 ## File path: core/src/main/scala/kafka/admin/AclCommand.scala ## @@ -130,30 +130,34 @@ object AclCommand extends Logging { } } -

[GitHub] [kafka] dajac commented on pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

2020-06-10 Thread GitBox
dajac commented on pull request #8683: URL: https://github.com/apache/kafka/pull/8683#issuecomment-642024625 @d8tltanc Is this one ready for being reviewed? I can help doing it if it is. This is an automated message from the

[jira] [Created] (KAFKA-10137) Clean-up retain Duplicate logic in Window Stores

2020-06-10 Thread Bruno Cadonna (Jira)
Bruno Cadonna created KAFKA-10137: - Summary: Clean-up retain Duplicate logic in Window Stores Key: KAFKA-10137 URL: https://issues.apache.org/jira/browse/KAFKA-10137 Project: Kafka Issue Type

[GitHub] [kafka] vvcephei merged pull request #8775: KAFKA-10079: improve thread-level stickiness

2020-06-10 Thread GitBox
vvcephei merged pull request #8775: URL: https://github.com/apache/kafka/pull/8775 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[jira] [Commented] (KAFKA-8180) Deleting large number of topics can block the controller for the time it takes to delete all of them

2020-06-10 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17130763#comment-17130763 ] David Jacot commented on KAFKA-8180: I have improved the batching to be more aggressi

[jira] [Updated] (KAFKA-10079) Improve thread-level stickiness of stateful tasks

2020-06-10 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10079: - Fix Version/s: 2.7.0 > Improve thread-level stickiness of stateful tasks > -

[GitHub] [kafka] vvcephei commented on pull request #8775: KAFKA-10079: improve thread-level stickiness

2020-06-10 Thread GitBox
vvcephei commented on pull request #8775: URL: https://github.com/apache/kafka/pull/8775#issuecomment-642075119 Cherry picked to 2.6 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] mumrah commented on pull request #8841: KAFKA-10123 Fix incorrect value for AWAIT_RESET#hasPosition

2020-06-10 Thread GitBox
mumrah commented on pull request #8841: URL: https://github.com/apache/kafka/pull/8841#issuecomment-642098477 Added some null checks for `SubscriptionState#position` This is an automated message from the Apache Git Service. T

[jira] [Assigned] (KAFKA-9189) Shutdown is blocked if connection to Zookeeper is lost

2020-06-10 Thread David Mao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Mao reassigned KAFKA-9189: Assignee: David Mao > Shutdown is blocked if connection to Zookeeper is lost > ---

[GitHub] [kafka] mumrah commented on a change in pull request #8822: KAFKA-10113; Specify fetch offsets correctly in LogTruncationException

2020-06-10 Thread GitBox
mumrah commented on a change in pull request #8822: URL: https://github.com/apache/kafka/pull/8822#discussion_r438242115 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/SubscriptionState.java ## @@ -466,9 +466,9 @@ public synchronized boolean m

[GitHub] [kafka] chia7712 commented on a change in pull request #8845: KAFKA-10126:Add a warning message for ConsumerPerformance

2020-06-10 Thread GitBox
chia7712 commented on a change in pull request #8845: URL: https://github.com/apache/kafka/pull/8845#discussion_r438267308 ## File path: core/src/main/scala/kafka/tools/ConsumerPerformance.scala ## @@ -232,12 +232,12 @@ object ConsumerPerformance extends LazyLogging { .d

[GitHub] [kafka] abbccdda commented on a change in pull request #8833: KAFKA-9441: remove prepareClose() to simplify task management

2020-06-10 Thread GitBox
abbccdda commented on a change in pull request #8833: URL: https://github.com/apache/kafka/pull/8833#discussion_r437829555 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -247,82 +246,23 @@ public void completeRestoration(

[GitHub] [kafka] guozhangwang commented on a change in pull request #8843: KAFKA-9991: Fix flaky unit tests

2020-06-10 Thread GitBox
guozhangwang commented on a change in pull request #8843: URL: https://github.com/apache/kafka/pull/8843#discussion_r438269033 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/KTableSourceTopicRestartIntegrationTest.java ## @@ -236,11 +237,7 @@ public v

[GitHub] [kafka] guozhangwang commented on a change in pull request #8843: KAFKA-9991: Fix flaky unit tests

2020-06-10 Thread GitBox
guozhangwang commented on a change in pull request #8843: URL: https://github.com/apache/kafka/pull/8843#discussion_r438270138 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/KTableSourceTopicRestartIntegrationTest.java ## @@ -107,7 +109,6 @@ public vo

[GitHub] [kafka] guozhangwang commented on pull request #8836: KAFKA-10124:Wrong rebalance.time.ms

2020-06-10 Thread GitBox
guozhangwang commented on pull request #8836: URL: https://github.com/apache/kafka/pull/8836#issuecomment-642133435 test this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] ableegoldman commented on a change in pull request #8843: KAFKA-9991: Fix flaky unit tests

2020-06-10 Thread GitBox
ableegoldman commented on a change in pull request #8843: URL: https://github.com/apache/kafka/pull/8843#discussion_r438271927 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/KTableSourceTopicRestartIntegrationTest.java ## @@ -107,7 +109,6 @@ public vo

[GitHub] [kafka] d8tltanc commented on pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

2020-06-10 Thread GitBox
d8tltanc commented on pull request #8683: URL: https://github.com/apache/kafka/pull/8683#issuecomment-642135591 @dajac Hi David. Yes, this patch is ready for review. Thanks. This is an automated message from the Apache Git Se

[GitHub] [kafka] ableegoldman commented on a change in pull request #8843: KAFKA-9991: Fix flaky unit tests

2020-06-10 Thread GitBox
ableegoldman commented on a change in pull request #8843: URL: https://github.com/apache/kafka/pull/8843#discussion_r438272343 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/KTableSourceTopicRestartIntegrationTest.java ## @@ -52,30 +51,28 @@ import j

[GitHub] [kafka] abbccdda commented on a change in pull request #8832: KAFKA-9377: Refactor StreamsPartitionAssignor Repartition Count Logic

2020-06-10 Thread GitBox
abbccdda commented on a change in pull request #8832: URL: https://github.com/apache/kafka/pull/8832#discussion_r438274945 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java ## @@ -514,65 +554,81 @@ private boolean ch

[GitHub] [kafka] guozhangwang commented on a change in pull request #8836: KAFKA-10124:Wrong rebalance.time.ms

2020-06-10 Thread GitBox
guozhangwang commented on a change in pull request #8836: URL: https://github.com/apache/kafka/pull/8836#discussion_r438277970 ## File path: core/src/main/scala/kafka/tools/ConsumerPerformance.scala ## @@ -105,16 +105,14 @@ object ConsumerPerformance extends LazyLogging {

[GitHub] [kafka] guozhangwang commented on a change in pull request #8833: KAFKA-9441: remove prepareClose() to simplify task management

2020-06-10 Thread GitBox
guozhangwang commented on a change in pull request #8833: URL: https://github.com/apache/kafka/pull/8833#discussion_r438278835 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -378,42 +320,88 @@ public void prepareCommit()

[GitHub] [kafka] C0urante commented on a change in pull request #8069: KAFKA-9374: Make connector interactions asynchronous

2020-06-10 Thread GitBox
C0urante commented on a change in pull request #8069: URL: https://github.com/apache/kafka/pull/8069#discussion_r438279560 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/CloseableConnectorContext.java ## @@ -0,0 +1,32 @@ +/* + * Licensed to the Ap

[GitHub] [kafka] C0urante commented on a change in pull request #8069: KAFKA-9374: Make connector interactions asynchronous

2020-06-10 Thread GitBox
C0urante commented on a change in pull request #8069: URL: https://github.com/apache/kafka/pull/8069#discussion_r438279560 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/CloseableConnectorContext.java ## @@ -0,0 +1,32 @@ +/* + * Licensed to the Ap

[GitHub] [kafka] guozhangwang commented on a change in pull request #8833: KAFKA-9441: remove prepareClose() to simplify task management

2020-06-10 Thread GitBox
guozhangwang commented on a change in pull request #8833: URL: https://github.com/apache/kafka/pull/8833#discussion_r438282003 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -504,88 +438,66 @@ public void update(final Set

[GitHub] [kafka] C0urante commented on a change in pull request #8069: KAFKA-9374: Make connector interactions asynchronous

2020-06-10 Thread GitBox
C0urante commented on a change in pull request #8069: URL: https://github.com/apache/kafka/pull/8069#discussion_r438282599 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConnector.java ## @@ -266,31 +422,51 @@ public void close() {

[jira] [Created] (KAFKA-10138) Prefer --bootstrap-server for reassign_partitions command in ducktape tests

2020-06-10 Thread Vinoth Chandar (Jira)
Vinoth Chandar created KAFKA-10138: -- Summary: Prefer --bootstrap-server for reassign_partitions command in ducktape tests Key: KAFKA-10138 URL: https://issues.apache.org/jira/browse/KAFKA-10138 Proje

[GitHub] [kafka] guozhangwang commented on a change in pull request #8833: KAFKA-9441: remove prepareClose() to simplify task management

2020-06-10 Thread GitBox
guozhangwang commented on a change in pull request #8833: URL: https://github.com/apache/kafka/pull/8833#discussion_r438282752 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -378,42 +320,88 @@ public void prepareCommit()

[GitHub] [kafka] guozhangwang commented on pull request #8833: KAFKA-9441: remove prepareClose() to simplify task management

2020-06-10 Thread GitBox
guozhangwang commented on pull request #8833: URL: https://github.com/apache/kafka/pull/8833#issuecomment-642145232 LGTM. Please feel free to merge after addressed @abbccdda 's comments above. This is an automated message fro

[GitHub] [kafka] C0urante commented on a change in pull request #8069: KAFKA-9374: Make connector interactions asynchronous

2020-06-10 Thread GitBox
C0urante commented on a change in pull request #8069: URL: https://github.com/apache/kafka/pull/8069#discussion_r438284977 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java ## @@ -356,40 +390,96 @@ public boolean isSinkConnector(String co

[GitHub] [kafka] hachikuji commented on pull request #8680: KAFKA-10027: Implement read path for feature versioning system (KIP-584)

2020-06-10 Thread GitBox
hachikuji commented on pull request #8680: URL: https://github.com/apache/kafka/pull/8680#issuecomment-642155469 retest this please This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [kafka] rhauch commented on a change in pull request #8828: KAFKA-9216: Enforce that Connect’s internal topics use `compact` cleanup policy

2020-06-10 Thread GitBox
rhauch commented on a change in pull request #8828: URL: https://github.com/apache/kafka/pull/8828#discussion_r438292803 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractHerder.java ## @@ -94,6 +95,7 @@ protected final StatusBackingStor

[GitHub] [kafka] kkonstantine commented on a change in pull request #8069: KAFKA-9374: Make connector interactions asynchronous

2020-06-10 Thread GitBox
kkonstantine commented on a change in pull request #8069: URL: https://github.com/apache/kafka/pull/8069#discussion_r438297474 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConnector.java ## @@ -266,31 +422,51 @@ public void close() {

[GitHub] [kafka] hachikuji commented on pull request #8680: KAFKA-10027: Implement read path for feature versioning system (KIP-584)

2020-06-10 Thread GitBox
hachikuji commented on pull request #8680: URL: https://github.com/apache/kafka/pull/8680#issuecomment-642155244 retest this please This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [kafka] hachikuji commented on pull request #8680: KAFKA-10027: Implement read path for feature versioning system (KIP-584)

2020-06-10 Thread GitBox
hachikuji commented on pull request #8680: URL: https://github.com/apache/kafka/pull/8680#issuecomment-642155141 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] hachikuji commented on pull request #8680: KAFKA-10027: Implement read path for feature versioning system (KIP-584)

2020-06-10 Thread GitBox
hachikuji commented on pull request #8680: URL: https://github.com/apache/kafka/pull/8680#issuecomment-642155913 retest this please This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [kafka] C0urante commented on a change in pull request #8069: KAFKA-9374: Make connector interactions asynchronous

2020-06-10 Thread GitBox
C0urante commented on a change in pull request #8069: URL: https://github.com/apache/kafka/pull/8069#discussion_r438298392 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java ## @@ -486,6 +509,10 @@ private synchroniz

[GitHub] [kafka] kkonstantine commented on a change in pull request #8069: KAFKA-9374: Make connector interactions asynchronous

2020-06-10 Thread GitBox
kkonstantine commented on a change in pull request #8069: URL: https://github.com/apache/kafka/pull/8069#discussion_r438298969 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/CloseableConnectorContext.java ## @@ -0,0 +1,32 @@ +/* + * Licensed to th

[GitHub] [kafka] kkonstantine commented on a change in pull request #8069: KAFKA-9374: Make connector interactions asynchronous

2020-06-10 Thread GitBox
kkonstantine commented on a change in pull request #8069: URL: https://github.com/apache/kafka/pull/8069#discussion_r438298969 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/CloseableConnectorContext.java ## @@ -0,0 +1,32 @@ +/* + * Licensed to th

[GitHub] [kafka] kkonstantine commented on a change in pull request #8069: KAFKA-9374: Make connector interactions asynchronous

2020-06-10 Thread GitBox
kkonstantine commented on a change in pull request #8069: URL: https://github.com/apache/kafka/pull/8069#discussion_r438300937 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java ## @@ -356,40 +390,96 @@ public boolean isSinkConnector(Strin

[GitHub] [kafka] C0urante commented on a change in pull request #8828: KAFKA-9216: Enforce that Connect’s internal topics use `compact` cleanup policy

2020-06-10 Thread GitBox
C0urante commented on a change in pull request #8828: URL: https://github.com/apache/kafka/pull/8828#discussion_r438303698 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/util/TopicAdmin.java ## @@ -375,6 +383,152 @@ public boolean createTopic(NewTopic top

[GitHub] [kafka] C0urante commented on a change in pull request #8069: KAFKA-9374: Make connector interactions asynchronous

2020-06-10 Thread GitBox
C0urante commented on a change in pull request #8069: URL: https://github.com/apache/kafka/pull/8069#discussion_r438304591 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConnector.java ## @@ -266,31 +422,51 @@ public void close() {

[jira] [Created] (KAFKA-10139) Add operational guide for failure recovery

2020-06-10 Thread Boyang Chen (Jira)
Boyang Chen created KAFKA-10139: --- Summary: Add operational guide for failure recovery Key: KAFKA-10139 URL: https://issues.apache.org/jira/browse/KAFKA-10139 Project: Kafka Issue Type: Sub-task

[GitHub] [kafka] ableegoldman closed pull request #8821: [DO NOT MERGE] Reenable flaky EosBetaUpgradeIntegrationTest

2020-06-10 Thread GitBox
ableegoldman closed pull request #8821: URL: https://github.com/apache/kafka/pull/8821 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] C0urante commented on a change in pull request #8069: KAFKA-9374: Make connector interactions asynchronous

2020-06-10 Thread GitBox
C0urante commented on a change in pull request #8069: URL: https://github.com/apache/kafka/pull/8069#discussion_r438313670 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java ## @@ -1221,31 +1297,56 @@ public Void cal

[GitHub] [kafka] abbccdda commented on a change in pull request #8845: KAFKA-10126:Add a warning message for ConsumerPerformance

2020-06-10 Thread GitBox
abbccdda commented on a change in pull request #8845: URL: https://github.com/apache/kafka/pull/8845#discussion_r438320972 ## File path: core/src/main/scala/kafka/tools/ConsumerPerformance.scala ## @@ -232,12 +232,12 @@ object ConsumerPerformance extends LazyLogging { .d

[GitHub] [kafka] C0urante commented on a change in pull request #8069: KAFKA-9374: Make connector interactions asynchronous

2020-06-10 Thread GitBox
C0urante commented on a change in pull request #8069: URL: https://github.com/apache/kafka/pull/8069#discussion_r438323035 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java ## @@ -239,38 +243,59 @@ public void stop() { * @param ctx

[GitHub] [kafka] junrao commented on pull request #8680: KAFKA-10027: Implement read path for feature versioning system (KIP-584)

2020-06-10 Thread GitBox
junrao commented on pull request #8680: URL: https://github.com/apache/kafka/pull/8680#issuecomment-642180658 test this please This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] junrao commented on pull request #8680: KAFKA-10027: Implement read path for feature versioning system (KIP-584)

2020-06-10 Thread GitBox
junrao commented on pull request #8680: URL: https://github.com/apache/kafka/pull/8680#issuecomment-642180814 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Commented] (KAFKA-10105) Regression in group coordinator dealing with flaky clients joining while leaving

2020-06-10 Thread Brian McKelvey (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17132599#comment-17132599 ] Brian McKelvey commented on KAFKA-10105: Yes, this is a big problem in a few way

[jira] [Comment Edited] (KAFKA-10105) Regression in group coordinator dealing with flaky clients joining while leaving

2020-06-10 Thread Brian McKelvey (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17132599#comment-17132599 ] Brian McKelvey edited comment on KAFKA-10105 at 6/10/20, 6:25 PM:

[jira] [Created] (KAFKA-10140) Incremental config api excludes plugin config changes

2020-06-10 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-10140: --- Summary: Incremental config api excludes plugin config changes Key: KAFKA-10140 URL: https://issues.apache.org/jira/browse/KAFKA-10140 Project: Kafka I

[GitHub] [kafka] ijuma commented on a change in pull request #8841: KAFKA-10123 Fix incorrect value for AWAIT_RESET#hasPosition

2020-06-10 Thread GitBox
ijuma commented on a change in pull request #8841: URL: https://github.com/apache/kafka/pull/8841#discussion_r438346871 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/SubscriptionState.java ## @@ -978,7 +1000,7 @@ public boolean hasValidPositio

[GitHub] [kafka] ijuma commented on a change in pull request #8841: KAFKA-10123 Fix incorrect value for AWAIT_RESET#hasPosition

2020-06-10 Thread GitBox
ijuma commented on a change in pull request #8841: URL: https://github.com/apache/kafka/pull/8841#discussion_r438346871 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/SubscriptionState.java ## @@ -978,7 +1000,7 @@ public boolean hasValidPositio

[jira] [Commented] (KAFKA-10119) StreamsResetter fails with TimeoutException for older Brokers

2020-06-10 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17132649#comment-17132649 ] Sophie Blee-Goldman commented on KAFKA-10119: - I think this might be address

[GitHub] [kafka] hachikuji merged pull request #8685: KAFKA-10014 Always try to close all channels in Selector#close

2020-06-10 Thread GitBox
hachikuji merged pull request #8685: URL: https://github.com/apache/kafka/pull/8685 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Resolved] (KAFKA-10014) Always try to close all channels in Selector#close

2020-06-10 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-10014. - Resolution: Fixed > Always try to close all channels in Selector#close > ---

[jira] [Updated] (KAFKA-10014) Always try to close all channels in Selector#close

2020-06-10 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-10014: Fix Version/s: 2.7.0 > Always try to close all channels in Selector#close > --

[GitHub] [kafka] guozhangwang commented on a change in pull request #8646: KAFKA-9974: Fix flaky test by removing unneeded asserts

2020-06-10 Thread GitBox
guozhangwang commented on a change in pull request #8646: URL: https://github.com/apache/kafka/pull/8646#discussion_r438359000 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/OptimizedKTableIntegrationTest.java ## @@ -133,11 +133,6 @@ public void shoul

[GitHub] [kafka] kkonstantine commented on a change in pull request #8069: KAFKA-9374: Make connector interactions asynchronous

2020-06-10 Thread GitBox
kkonstantine commented on a change in pull request #8069: URL: https://github.com/apache/kafka/pull/8069#discussion_r438309573 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/DistributedHerderTest.java ## @@ -240,11 +243,19 @@ public vo

[GitHub] [kafka] mjsax commented on a change in pull request #8833: KAFKA-9441: remove prepareClose() to simplify task management

2020-06-10 Thread GitBox
mjsax commented on a change in pull request #8833: URL: https://github.com/apache/kafka/pull/8833#discussion_r438361083 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -247,82 +246,23 @@ public void completeRestoration() {

[GitHub] [kafka] brary commented on a change in pull request #8200: KAFKA-5876: IQ should throw different exceptions for different errors(part 1)

2020-06-10 Thread GitBox
brary commented on a change in pull request #8200: URL: https://github.com/apache/kafka/pull/8200#discussion_r438348449 ## File path: streams/src/main/java/org/apache/kafka/streams/errors/InvalidStateStoreException.java ## @@ -18,13 +18,11 @@ /** - * Indicates that there

[GitHub] [kafka] mjsax commented on a change in pull request #8833: KAFKA-9441: remove prepareClose() to simplify task management

2020-06-10 Thread GitBox
mjsax commented on a change in pull request #8833: URL: https://github.com/apache/kafka/pull/8833#discussion_r438364263 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -506,19 +455,18 @@ public void update(final Set topic

[GitHub] [kafka] C0urante commented on a change in pull request #8069: KAFKA-9374: Make connector interactions asynchronous

2020-06-10 Thread GitBox
C0urante commented on a change in pull request #8069: URL: https://github.com/apache/kafka/pull/8069#discussion_r438366431 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/DistributedHerderTest.java ## @@ -582,86 +658,41 @@ public void t

[GitHub] [kafka] C0urante commented on a change in pull request #8069: KAFKA-9374: Make connector interactions asynchronous

2020-06-10 Thread GitBox
C0urante commented on a change in pull request #8069: URL: https://github.com/apache/kafka/pull/8069#discussion_r438367687 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/DistributedHerderTest.java ## @@ -676,63 +707,38 @@ public void t

[GitHub] [kafka] C0urante commented on a change in pull request #8069: KAFKA-9374: Make connector interactions asynchronous

2020-06-10 Thread GitBox
C0urante commented on a change in pull request #8069: URL: https://github.com/apache/kafka/pull/8069#discussion_r438367687 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/DistributedHerderTest.java ## @@ -676,63 +707,38 @@ public void t

[GitHub] [kafka] mjsax commented on a change in pull request #8833: KAFKA-9441: remove prepareClose() to simplify task management

2020-06-10 Thread GitBox
mjsax commented on a change in pull request #8833: URL: https://github.com/apache/kafka/pull/8833#discussion_r438368027 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -813,6 +727,10 @@ private void updateProcessorContext(

[GitHub] [kafka] mjsax commented on a change in pull request #8833: KAFKA-9441: remove prepareClose() to simplify task management

2020-06-10 Thread GitBox
mjsax commented on a change in pull request #8833: URL: https://github.com/apache/kafka/pull/8833#discussion_r438369517 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -504,88 +438,66 @@ public void update(final Set topic

[GitHub] [kafka] mjsax commented on a change in pull request #8833: KAFKA-9441: remove prepareClose() to simplify task management

2020-06-10 Thread GitBox
mjsax commented on a change in pull request #8833: URL: https://github.com/apache/kafka/pull/8833#discussion_r438370089 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -378,42 +320,88 @@ public void prepareCommit() {

[jira] [Commented] (KAFKA-9896) Flaky Test StandbyTaskEOSIntegrationTest#surviveWithOneTaskAsStandby[exactly_once_beta]

2020-06-10 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17132674#comment-17132674 ] Sophie Blee-Goldman commented on KAFKA-9896: [~mjsax] I saw this fail locally

[GitHub] [kafka] hachikuji commented on a change in pull request #8841: KAFKA-10123 Fix incorrect value for AWAIT_RESET#hasPosition

2020-06-10 Thread GitBox
hachikuji commented on a change in pull request #8841: URL: https://github.com/apache/kafka/pull/8841#discussion_r438362895 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/SubscriptionState.java ## @@ -978,7 +1000,7 @@ public boolean hasValidPos

[jira] [Created] (KAFKA-10141) Add more detail to log segment deletion message

2020-06-10 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-10141: --- Summary: Add more detail to log segment deletion message Key: KAFKA-10141 URL: https://issues.apache.org/jira/browse/KAFKA-10141 Project: Kafka Issue T

[jira] [Resolved] (KAFKA-10119) StreamsResetter fails with TimeoutException for older Brokers

2020-06-10 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman resolved KAFKA-10119. - Resolution: Duplicate Closing this as a duplicate, the issue is tracked by KAFKA

[jira] [Commented] (KAFKA-10119) StreamsResetter fails with TimeoutException for older Brokers

2020-06-10 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17132680#comment-17132680 ] Ismael Juma commented on KAFKA-10119: - Was this issue in any released version? If no

[jira] [Updated] (KAFKA-10119) StreamsResetter fails with TimeoutException for older Brokers

2020-06-10 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-10119: Fix Version/s: 2.5.1 > StreamsResetter fails with TimeoutException for older Broke

[jira] [Commented] (KAFKA-10119) StreamsResetter fails with TimeoutException for older Brokers

2020-06-10 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17132677#comment-17132677 ] Sophie Blee-Goldman commented on KAFKA-10119: - Ok I pulled down that PR and

[jira] [Updated] (KAFKA-10119) StreamsResetter fails with TimeoutException for older Brokers

2020-06-10 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-10119: Affects Version/s: 2.5.1 > StreamsResetter fails with TimeoutException for older B

[GitHub] [kafka] d8tltanc closed pull request #8421: KAFKA-9800: [KIP-580] Admin Client Exponential Backoff Implementation

2020-06-10 Thread GitBox
d8tltanc closed pull request #8421: URL: https://github.com/apache/kafka/pull/8421 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] C0urante commented on a change in pull request #8069: KAFKA-9374: Make connector interactions asynchronous

2020-06-10 Thread GitBox
C0urante commented on a change in pull request #8069: URL: https://github.com/apache/kafka/pull/8069#discussion_r438378091 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/integration/BlockingConnectorTest.java ## @@ -0,0 +1,488 @@ +/* + * Licensed to the A

[GitHub] [kafka] d8tltanc opened a new pull request #8846: KAFKA-9800: [KIP-580] Client Exponential Backoff Implementation

2020-06-10 Thread GitBox
d8tltanc opened a new pull request #8846: URL: https://github.com/apache/kafka/pull/8846 Please refer to Jira for more details: https://issues.apache.org/jira/browse/KAFKA-9800 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [

[GitHub] [kafka] d8tltanc commented on pull request #8421: KAFKA-9800: [KIP-580] Admin Client Exponential Backoff Implementation

2020-06-10 Thread GitBox
d8tltanc commented on pull request #8421: URL: https://github.com/apache/kafka/pull/8421#issuecomment-642229019 Thanks all for reviewing the patch. As we agree on that the patch should implement backoff modules universal among all the clients, I'll close this patch and open a new one here:

[GitHub] [kafka] mumrah commented on a change in pull request #8841: KAFKA-10123 Fix incorrect value for AWAIT_RESET#hasPosition

2020-06-10 Thread GitBox
mumrah commented on a change in pull request #8841: URL: https://github.com/apache/kafka/pull/8841#discussion_r438379247 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java ## @@ -675,36 +676,41 @@ private ListOffsetResult fetchOffsets

[GitHub] [kafka] mjsax commented on a change in pull request #8752: KAFKA-10036 early check singleton ProcessorSupplier and improve docs

2020-06-10 Thread GitBox
mjsax commented on a change in pull request #8752: URL: https://github.com/apache/kafka/pull/8752#discussion_r438379682 ## File path: docs/streams/developer-guide/processor-api.html ## @@ -439,6 +439,11 @@ Connecting Processors and State StoresTopology code, accessing it in th

[GitHub] [kafka] C0urante commented on a change in pull request #8069: KAFKA-9374: Make connector interactions asynchronous

2020-06-10 Thread GitBox
C0urante commented on a change in pull request #8069: URL: https://github.com/apache/kafka/pull/8069#discussion_r438380494 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/integration/BlockingConnectorTest.java ## @@ -0,0 +1,488 @@ +/* + * Licensed to the A

[GitHub] [kafka] mjsax commented on a change in pull request #8752: KAFKA-10036 early check singleton ProcessorSupplier and improve docs

2020-06-10 Thread GitBox
mjsax commented on a change in pull request #8752: URL: https://github.com/apache/kafka/pull/8752#discussion_r438381511 ## File path: streams/src/main/java/org/apache/kafka/streams/Topology.java ## @@ -645,14 +645,17 @@ public synchronized Topology addSink(final String name,

[GitHub] [kafka] C0urante commented on a change in pull request #8069: KAFKA-9374: Make connector interactions asynchronous

2020-06-10 Thread GitBox
C0urante commented on a change in pull request #8069: URL: https://github.com/apache/kafka/pull/8069#discussion_r438381216 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/integration/BlockingConnectorTest.java ## @@ -0,0 +1,488 @@ +/* + * Licensed to the A

[GitHub] [kafka] mjsax commented on a change in pull request #8752: KAFKA-10036 early check singleton ProcessorSupplier and improve docs

2020-06-10 Thread GitBox
mjsax commented on a change in pull request #8752: URL: https://github.com/apache/kafka/pull/8752#discussion_r438384667 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java ## @@ -1421,6 +1422,7 @@ public void process(final ProcessorS

[jira] [Updated] (KAFKA-10119) StreamsResetter fails with TimeoutException for older Brokers

2020-06-10 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-10119: Affects Version/s: (was: 2.5.1) (was: 2.6.0) > Stre

  1   2   3   4   >