mjsax commented on a change in pull request #8752:
URL: https://github.com/apache/kafka/pull/8752#discussion_r438384667
##########
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java
##########
@@ -1421,6 +1422,7 @@ public void process(final ProcessorSupplier<? super K, ?
super V> processorSuppl
Objects.requireNonNull(processorSupplier, "processorSupplier can't be
null");
Objects.requireNonNull(named, "named can't be null");
Objects.requireNonNull(stateStoreNames, "stateStoreNames can't be a
null array");
+ TopologyUtil.checkProcessorSupplier(processorSupplier);
Review comment:
We should add a similar check for `TransformerSuppliers` -- This check
must be done in the DSL code though, as `Transformers` are a higher level
concept. I checked the code and all passed transformers through
https://github.com/apache/kafka/blob/trunk/streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java#L1251
-- so we can add the check there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
