[GitHub] [kafka] mjsax commented on a change in pull request #8752: KAFKA-10036 early check singleton ProcessorSupplier and improve docs

[GitBox]

mjsax commented on a change in pull request #8752:
URL: https://github.com/apache/kafka/pull/8752#discussion_r438379682



##########
File path: docs/streams/developer-guide/processor-api.html
##########
@@ -439,6 +439,11 @@ <h2><a class="toc-backref" href="#id8">Connecting 
Processors and State Stores</a
                 indicating that the state store cannot be found. If the state 
store is not associated with the processor
                 in the <code class="docutils literal"><span 
class="pre">Topology</span></code> code, accessing it in the processor&#8217;s 
<code class="docutils literal"><span class="pre">init()</span></code> method 
will also throw an exception at
                 runtime, indicating the state store is not accessible from 
this processor.</p>
+            <p>Note that the <code class="docutils literal"><span 
class="pre">Topology#addProcessor</span></code> function takes a <code 
class="docutils literal"><span class="pre">ProcessorSupplier</span></code> as 
argument, and that the supplier pattern requires that a new
+                <code class="docutils literal"><span 
class="pre">Processor</span></code> instance is return each time <code 
class="docutils literal"><span 
class="pre">ProcessorSupplier#get()</span></code> is called. Creating a single 
<code class="docutils literal"><span class="pre">Processor</span></code>

Review comment:
       ```suggestion
                   <code class="docutils literal"><span 
class="pre">Processor</span></code> instance is returned each time <code 
class="docutils literal"><span 
class="pre">ProcessorSupplier#get()</span></code> is called. Creating a single 
<code class="docutils literal"><span class="pre">Processor</span></code>
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org