[jira] [Created] (KAFKA-10126) Remove unused options in ConsumerPerformance

2020-06-09 Thread jiamei xie (Jira)
jiamei xie created KAFKA-10126: -- Summary: Remove unused options in ConsumerPerformance Key: KAFKA-10126 URL: https://issues.apache.org/jira/browse/KAFKA-10126 Project: Kafka Issue Type: Bug

[jira] [Commented] (KAFKA-7888) kafka cluster not recovering - Shrinking ISR from 14,13 to 13 (kafka.cluster.Partition) continously

2020-06-09 Thread Youssef BOUZAIENNE (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17129031#comment-17129031 ] Youssef BOUZAIENNE commented on KAFKA-7888: --- I'm facing the same issue on 2.4.1

[jira] [Issue Comment Deleted] (KAFKA-7500) MirrorMaker 2.0 (KIP-382)

2020-06-09 Thread Karthik (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karthik updated KAFKA-7500: --- Comment: was deleted (was: Hi All, Im unable to find a document for MM2, Any leads to the documentation woul

[jira] [Commented] (KAFKA-10126) Remove unused options in ConsumerPerformance

2020-06-09 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17129042#comment-17129042 ] Chia-Ping Tsai commented on KAFKA-10126: How about making numThreadsOpt work? ma

[jira] [Created] (KAFKA-10127) kafka cluster not recovering - Shrinking ISR continously

2020-06-09 Thread Youssef BOUZAIENNE (Jira)
Youssef BOUZAIENNE created KAFKA-10127: -- Summary: kafka cluster not recovering - Shrinking ISR continously Key: KAFKA-10127 URL: https://issues.apache.org/jira/browse/KAFKA-10127 Project: Kafka

[jira] [Commented] (KAFKA-10126) Remove unused options in ConsumerPerformance

2020-06-09 Thread jiamei xie (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17129056#comment-17129056 ] jiamei xie commented on KAFKA-10126: Ok. Thanks. I'll have a look at it. Use consume

[jira] [Commented] (KAFKA-10126) Remove unused options in ConsumerPerformance

2020-06-09 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17129067#comment-17129067 ] Chia-Ping Tsai commented on KAFKA-10126: > Use consumer group? yep. Should we e

[jira] [Commented] (KAFKA-10105) Regression in group coordinator dealing with flaky clients joining while leaving

2020-06-09 Thread William Reynolds (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17129070#comment-17129070 ] William Reynolds commented on KAFKA-10105: -- Hi James, that looks really similar

[jira] [Commented] (KAFKA-9935) Kafka not releasing member from Consumer Group

2020-06-09 Thread William Reynolds (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17129072#comment-17129072 ] William Reynolds commented on KAFKA-9935: - It does look related to me. Your repro

[jira] [Commented] (KAFKA-10107) Producer snapshots LSO used in certain situations which can lead to data loss on compacted topics as LSO breach occurs and early offsets cleaned

2020-06-09 Thread William Reynolds (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17129077#comment-17129077 ] William Reynolds commented on KAFKA-10107: -- Still working on getting the logs o

[jira] [Commented] (KAFKA-10126) Remove unused options in ConsumerPerformance

2020-06-09 Thread jiamei xie (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17129079#comment-17129079 ] jiamei xie commented on KAFKA-10126: Thanks. Got it. What's about numFetchersOpt? C

[jira] [Commented] (KAFKA-10126) Remove unused options in ConsumerPerformance

2020-06-09 Thread jiamei xie (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17129108#comment-17129108 ] jiamei xie commented on KAFKA-10126: > maybe add new argument to create topic with s

[jira] [Comment Edited] (KAFKA-10126) Remove unused options in ConsumerPerformance

2020-06-09 Thread jiamei xie (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17129108#comment-17129108 ] jiamei xie edited comment on KAFKA-10126 at 6/9/20, 10:11 AM:

[jira] [Comment Edited] (KAFKA-10126) Remove unused options in ConsumerPerformance

2020-06-09 Thread jiamei xie (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17129108#comment-17129108 ] jiamei xie edited comment on KAFKA-10126 at 6/9/20, 10:12 AM:

[jira] [Created] (KAFKA-10128) MM2 - Delete topics when config sync is enabled

2020-06-09 Thread Karthik (Jira)
Karthik created KAFKA-10128: --- Summary: MM2 - Delete topics when config sync is enabled Key: KAFKA-10128 URL: https://issues.apache.org/jira/browse/KAFKA-10128 Project: Kafka Issue Type: Bug

[jira] [Commented] (KAFKA-10128) MM2 - Delete topics when config sync is enabled

2020-06-09 Thread Karthik (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17129139#comment-17129139 ] Karthik commented on KAFKA-10128: - It also the other way around where even deleted mirro

[jira] [Comment Edited] (KAFKA-10128) MM2 - Delete topics when config sync is enabled

2020-06-09 Thread Karthik (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17129139#comment-17129139 ] Karthik edited comment on KAFKA-10128 at 6/9/20, 11:34 AM: --- It

[jira] [Updated] (KAFKA-10128) MM2 - Delete topics when config sync is enabled

2020-06-09 Thread Karthik (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karthik updated KAFKA-10128: Reviewer: Ryanne Dolan > MM2 - Delete topics when config sync is enabled > ---

[jira] [Updated] (KAFKA-9800) [KIP-580] Client Exponential Backoff Implementation

2020-06-09 Thread Cheng Tan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cheng Tan updated KAFKA-9800: - Description: Design: The main idea is to bookkeep the failed attempts. Making those class containing re

[jira] [Updated] (KAFKA-9800) [KIP-580] Client Exponential Backoff Implementation

2020-06-09 Thread Cheng Tan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cheng Tan updated KAFKA-9800: - Description: Design: The main idea is to bookkeep the failed attempt. Currently, the retry backoff has

[jira] [Updated] (KAFKA-9800) [KIP-580] Client Exponential Backoff Implementation

2020-06-09 Thread Cheng Tan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cheng Tan updated KAFKA-9800: - Description: Design: The main idea is to bookkeep the failed attempt. Currently, the retry backoff has

[jira] [Updated] (KAFKA-9800) [KIP-580] Client Exponential Backoff Implementation

2020-06-09 Thread Cheng Tan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cheng Tan updated KAFKA-9800: - Description: Design: The main idea is to bookkeep the failed attempt. Currently, the retry backoff has

[jira] [Resolved] (KAFKA-9724) Consumer wrongly ignores fetched records "since it no longer has valid position"

2020-06-09 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur resolved KAFKA-9724. - Fix Version/s: 2.6.0 Assignee: David Arthur Resolution: Fixed > Consumer wrongly

[jira] [Updated] (KAFKA-9724) Consumer wrongly ignores fetched records "since it no longer has valid position"

2020-06-09 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-9724: Fix Version/s: 2.5.1 > Consumer wrongly ignores fetched records "since it no longer has valid > po

[jira] [Updated] (KAFKA-9800) [KIP-580] Client Exponential Backoff Implementation

2020-06-09 Thread Cheng Tan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cheng Tan updated KAFKA-9800: - Description: Design: The main idea is to bookkeep the failed attempt. Currently, the retry backoff has

[jira] [Updated] (KAFKA-10127) kafka cluster not recovering - Shrinking ISR continously

2020-06-09 Thread Youssef BOUZAIENNE (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Youssef BOUZAIENNE updated KAFKA-10127: --- Description: We are actually facing issue from time to time where our kafka cluster

[jira] [Commented] (KAFKA-9747) No tasks created for a connector

2020-06-09 Thread Rodrigo (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17129374#comment-17129374 ] Rodrigo commented on KAFKA-9747: I have the same issue here... MongoDB (Atlas), MongoDB C

[jira] [Created] (KAFKA-10129) Fail the QA if there is javadoc error

2020-06-09 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-10129: -- Summary: Fail the QA if there is javadoc error Key: KAFKA-10129 URL: https://issues.apache.org/jira/browse/KAFKA-10129 Project: Kafka Issue Type: Improve

[jira] [Commented] (KAFKA-10129) Fail the QA if there is javadoc error

2020-06-09 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17129393#comment-17129393 ] Chia-Ping Tsai commented on KAFKA-10129: The javadoc is a part of public publica

[jira] [Updated] (KAFKA-9800) [KIP-580] Client Exponential Backoff Implementation

2020-06-09 Thread Cheng Tan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cheng Tan updated KAFKA-9800: - Description: Design: The main idea is to bookkeep the failed attempt. Currently, the retry backoff has

[jira] [Updated] (KAFKA-9800) [KIP-580] Client Exponential Backoff Implementation

2020-06-09 Thread Cheng Tan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cheng Tan updated KAFKA-9800: - Description: Design: The main idea is to bookkeep the failed attempt. Currently, the retry backoff has

[jira] [Updated] (KAFKA-9800) [KIP-580] Client Exponential Backoff Implementation

2020-06-09 Thread Cheng Tan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cheng Tan updated KAFKA-9800: - Description: Design: The main idea is to bookkeep the failed attempt. Currently, the retry backoff has

[GitHub] [kafka] hachikuji commented on pull request #8664: KAFKA-9716: Clarify meaning of compression rate metrics

2020-06-09 Thread GitBox
hachikuji commented on pull request #8664: URL: https://github.com/apache/kafka/pull/8664#issuecomment-640947926 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Updated] (KAFKA-10129) Fail QA if there are javadoc warnings

2020-06-09 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-10129: --- Summary: Fail QA if there are javadoc warnings (was: Fail the QA if there is javadoc error)

[GitHub] [kafka] guozhangwang merged pull request #8788: MINOR: Remove unused isSticky assert out from tests only do constrainedAssign

2020-06-09 Thread GitBox
guozhangwang merged pull request #8788: URL: https://github.com/apache/kafka/pull/8788 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] ableegoldman opened a new pull request #8835: MINOR: reduce sizeInBytes for percentiles metrics

2020-06-09 Thread GitBox
ableegoldman opened a new pull request #8835: URL: https://github.com/apache/kafka/pull/8835 The total amount of memory per Percentiles metric is actually the sizeInBytes * number of samples, where the default number of samples is 2. There are also at least 2 Percentiles metrics per task (

[GitHub] [kafka] mimaison commented on pull request #8312: KAFKA-9432 automated protocol for DescribeConfigs

2020-06-09 Thread GitBox
mimaison commented on pull request #8312: URL: https://github.com/apache/kafka/pull/8312#issuecomment-640882951 retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] C0urante commented on a change in pull request #8828: KAFKA-9216: Enforce that Connect’s internal topics use `compact` cleanup policy

2020-06-09 Thread GitBox
C0urante commented on a change in pull request #8828: URL: https://github.com/apache/kafka/pull/8828#discussion_r436881026 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/util/TopicAdmin.java ## @@ -375,6 +383,152 @@ public boolean createTopic(NewTopic top

[GitHub] [kafka] tombentley commented on pull request #8312: KAFKA-9432 automated protocol for DescribeConfigs

2020-06-09 Thread GitBox
tombentley commented on pull request #8312: URL: https://github.com/apache/kafka/pull/8312#issuecomment-640700423 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] ijuma commented on a change in pull request #8672: KAFKA-10002; Improve performances of StopReplicaRequest with large number of partitions to be deleted

2020-06-09 Thread GitBox
ijuma commented on a change in pull request #8672: URL: https://github.com/apache/kafka/pull/8672#discussion_r436791602 ## File path: core/src/main/scala/kafka/log/LogManager.scala ## @@ -878,8 +936,7 @@ class LogManager(logDirs: Seq[File], // Now that replica in sourc

[GitHub] [kafka] jiameixie commented on pull request #8836: KAFKA-10124:Wrong rebalance.time.ms

2020-06-09 Thread GitBox
jiameixie commented on pull request #8836: URL: https://github.com/apache/kafka/pull/8836#issuecomment-641125571 @ijuma @huxihx @guozhangwang Call for a review. Do you think there is a good place to update `joinStart `? Thanks. -

[GitHub] [kafka] guozhangwang merged pull request #8815: HOTFIX: fix validity check in sticky assignor tests

2020-06-09 Thread GitBox
guozhangwang merged pull request #8815: URL: https://github.com/apache/kafka/pull/8815 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] dajac commented on a change in pull request #8672: KAFKA-10002; Improve performances of StopReplicaRequest with large number of partitions to be deleted

2020-06-09 Thread GitBox
dajac commented on a change in pull request #8672: URL: https://github.com/apache/kafka/pull/8672#discussion_r436704800 ## File path: core/src/main/scala/kafka/log/LogCleanerManager.scala ## @@ -273,7 +272,7 @@ private[log] class LogCleanerManager(val logDirs: Seq[File], *

[GitHub] [kafka] bbejeck merged pull request #8823: MINOR: fix HTML markup

2020-06-09 Thread GitBox
bbejeck merged pull request #8823: URL: https://github.com/apache/kafka/pull/8823 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [kafka] chia7712 commented on a change in pull request #8836: KAFKA-10124:Wrong rebalance.time.ms

2020-06-09 Thread GitBox
chia7712 commented on a change in pull request #8836: URL: https://github.com/apache/kafka/pull/8836#discussion_r437177352 ## File path: core/src/main/scala/kafka/tools/ConsumerPerformance.scala ## @@ -105,16 +105,14 @@ object ConsumerPerformance extends LazyLogging { var

[GitHub] [kafka] kkonstantine commented on pull request #8805: KAFKA-9848: Avoid triggering scheduled rebalance delay when task assignment fails but Connect workers remain in the group

2020-06-09 Thread GitBox
kkonstantine commented on pull request #8805: URL: https://github.com/apache/kafka/pull/8805#issuecomment-640853227 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [kafka] dajac commented on pull request #8672: KAFKA-10002; Improve performances of StopReplicaRequest with large number of partitions to be deleted

2020-06-09 Thread GitBox
dajac commented on pull request #8672: URL: https://github.com/apache/kafka/pull/8672#issuecomment-641249326 @hachikuji I have made another pass on the PR based on your input. Could you please have a second look at it? I am especially interested by getting your view on the overall approach

[GitHub] [kafka] gardnervickers commented on pull request #7929: KAFKA-9393: DeleteRecords may cause extreme lock contention for large partition directories

2020-06-09 Thread GitBox
gardnervickers commented on pull request #7929: URL: https://github.com/apache/kafka/pull/7929#issuecomment-640691697 In 6152847, I changed the approach taken in this PR to move away from managing the producer state snapshot file as part of the segment lifecycle. This was done for two reas

[GitHub] [kafka] kowshik commented on a change in pull request #8680: KAFKA-10027: Implement read path for feature versioning system (KIP-584)

2020-06-09 Thread GitBox
kowshik commented on a change in pull request #8680: URL: https://github.com/apache/kafka/pull/8680#discussion_r437124061 ## File path: core/src/main/scala/kafka/zk/ZkData.scala ## @@ -81,17 +83,26 @@ object BrokerIdsZNode { object BrokerInfo { /** - * Create a broker i

[GitHub] [kafka] Lucent-Wong removed a comment on pull request #8453: KAFKA-9841: Connector and Task duplicated when a worker join with old…

2020-06-09 Thread GitBox
Lucent-Wong removed a comment on pull request #8453: URL: https://github.com/apache/kafka/pull/8453#issuecomment-641192433 retest this please This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [kafka] sneakyburro commented on a change in pull request #8752: KAFKA-10036 early check singleton ProcessorSupplier and improve docs

2020-06-09 Thread GitBox
sneakyburro commented on a change in pull request #8752: URL: https://github.com/apache/kafka/pull/8752#discussion_r437317697 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java ## @@ -842,7 +842,14 @@ public synchroniz

[GitHub] [kafka] kkonstantine commented on pull request #8453: KAFKA-9841: Connector and Task duplicated when a worker join with old…

2020-06-09 Thread GitBox
kkonstantine commented on pull request #8453: URL: https://github.com/apache/kafka/pull/8453#issuecomment-641102055 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] abbccdda commented on a change in pull request #8832: KAFKA-9377: Refactor StreamsPartitionAssignor Repartition Count Logic

2020-06-09 Thread GitBox
abbccdda commented on a change in pull request #8832: URL: https://github.com/apache/kafka/pull/8832#discussion_r436913810 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java ## @@ -147,6 +147,46 @@ public String toStr

[GitHub] [kafka] ijuma commented on pull request #8802: MINOR: Fix fetch session epoch comment in `FetchRequest.json`

2020-06-09 Thread GitBox
ijuma commented on pull request #8802: URL: https://github.com/apache/kafka/pull/8802#issuecomment-640721062 Request/response names are just labels for humans, so you can change them without affecting compatibility. This is

[GitHub] [kafka] mjsax commented on a change in pull request #8833: KAFKA-9441: remove prepareClose() to simplify task management

2020-06-09 Thread GitBox
mjsax commented on a change in pull request #8833: URL: https://github.com/apache/kafka/pull/8833#discussion_r436864561 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StandbyTask.java ## @@ -108,13 +107,20 @@ public void completeRestoration()

[GitHub] [kafka] guozhangwang commented on a change in pull request #8833: KAFKA-9441: remove prepareClose() to simplify task management

2020-06-09 Thread GitBox
guozhangwang commented on a change in pull request #8833: URL: https://github.com/apache/kafka/pull/8833#discussion_r437090376 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/Task.java ## @@ -125,40 +126,21 @@ public boolean isValidTransition(f

[GitHub] [kafka] vvcephei commented on a change in pull request #8676: KAFKA-10005: Decouple RestoreListener from RestoreCallback

2020-06-09 Thread GitBox
vvcephei commented on a change in pull request #8676: URL: https://github.com/apache/kafka/pull/8676#discussion_r436755332 ## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBStoreTest.java ## @@ -237,25 +236,6 @@ public void shouldNotRemoveSta

[GitHub] [kafka] guozhangwang commented on a change in pull request #8834: MINOR: Do not disable heartbeat during Rebalance

2020-06-09 Thread GitBox
guozhangwang commented on a change in pull request #8834: URL: https://github.com/apache/kafka/pull/8834#discussion_r437069073 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java ## @@ -528,7 +528,6 @@ public void onFailure(

[GitHub] [kafka] chia7712 commented on a change in pull request #8838: MINOR: fix flaky TopicCommandWithAdminClientTest.testDescribeUnderRep…

2020-06-09 Thread GitBox
chia7712 commented on a change in pull request #8838: URL: https://github.com/apache/kafka/pull/8838#discussion_r437289845 ## File path: core/src/test/scala/unit/kafka/admin/TopicCommandWithAdminClientTest.scala ## @@ -697,6 +697,10 @@ class TopicCommandWithAdminClientTest ext

[GitHub] [kafka] guozhangwang commented on pull request #8676: KAFKA-10005: Decouple RestoreListener from RestoreCallback

2020-06-09 Thread GitBox
guozhangwang commented on pull request #8676: URL: https://github.com/apache/kafka/pull/8676#issuecomment-640892231 Merged to trunk and cherry-picked to 2.6 This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] bellemare commented on pull request #8764: KAFKA-10049: Fixed FKJ bug where wrapped serdes are set incorrectly when using default StreamsConfig serdes

2020-06-09 Thread GitBox
bellemare commented on pull request #8764: URL: https://github.com/apache/kafka/pull/8764#issuecomment-640926702 I swear it ran checkstyle when I compiled it... bah! I guess not. I did run ./gradlew :streams:test it had one unrelated error (I think) so lets see how it does now. -

[GitHub] [kafka] tombentley commented on pull request #8839: KIP-585: Documentation

2020-06-09 Thread GitBox
tombentley commented on pull request #8839: URL: https://github.com/apache/kafka/pull/8839#issuecomment-641201269 @kkonstantine please could you review this, thanks This is an automated message from the Apache Git Service. To

[GitHub] [kafka] rhauch commented on a change in pull request #8805: KAFKA-9848: Avoid triggering scheduled rebalance delay when task assignment fails but Connect workers remain in the group

2020-06-09 Thread GitBox
rhauch commented on a change in pull request #8805: URL: https://github.com/apache/kafka/pull/8805#discussion_r436925315 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java ## @@ -159,6 +163,13 @@ private

[GitHub] [kafka] vvcephei commented on a change in pull request #8818: KAFKA-10086: Integration test for ensuring warmups are effective

2020-06-09 Thread GitBox
vvcephei commented on a change in pull request #8818: URL: https://github.com/apache/kafka/pull/8818#discussion_r436758351 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java ## @@ -1084,12 +1088,15 @@ private boolean

[GitHub] [kafka] guozhangwang commented on pull request #8816: MINOR: Print all removed dynamic members during join complete

2020-06-09 Thread GitBox
guozhangwang commented on pull request #8816: URL: https://github.com/apache/kafka/pull/8816#issuecomment-640934122 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [kafka] feyman2016 commented on a change in pull request #8832: KAFKA-9377: Refactor StreamsPartitionAssignor Repartition Count Logic

2020-06-09 Thread GitBox
feyman2016 commented on a change in pull request #8832: URL: https://github.com/apache/kafka/pull/8832#discussion_r437529829 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java ## @@ -147,6 +147,46 @@ public String toS

[GitHub] [kafka] xvrl commented on pull request #8800: MINOR: Fix incorrect GC log size with JDK9+

2020-06-09 Thread GitBox
xvrl commented on pull request #8800: URL: https://github.com/apache/kafka/pull/8800#issuecomment-640914664 @ijuma tested this change locally, broker starts up fine and gc logs show up. This is an automated message from the

[GitHub] [kafka] wicknicks commented on a change in pull request #8829: KAFKA-10115: Incorporate errors.tolerance with the Errant Record Reporter

2020-06-09 Thread GitBox
wicknicks commented on a change in pull request #8829: URL: https://github.com/apache/kafka/pull/8829#discussion_r436843713 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/errors/RetryWithToleranceOperator.java ## @@ -87,6 +87,12 @@ public RetryWit

[GitHub] [kafka] mjsax merged pull request #8803: KAFKA-10102: update ProcessorTopology instead of rebuilding it

2020-06-09 Thread GitBox
mjsax merged pull request #8803: URL: https://github.com/apache/kafka/pull/8803 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] bellemare commented on a change in pull request #8764: KAFKA-10049: Fixed FKJ bug where wrapped serdes are set incorrectly when using default StreamsConfig serdes

2020-06-09 Thread GitBox
bellemare commented on a change in pull request #8764: URL: https://github.com/apache/kafka/pull/8764#discussion_r436871862 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KTableKTableForeignKeyJoinScenarioTest.java ## @@ -243,17 +244,17 @@ priva

[GitHub] [kafka] abbccdda commented on a change in pull request #8822: KAFKA-10113; Specify fetch offsets correctly in LogTruncationException

2020-06-09 Thread GitBox
abbccdda commented on a change in pull request #8822: URL: https://github.com/apache/kafka/pull/8822#discussion_r436800666 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/SubscriptionState.java ## @@ -1050,4 +1062,43 @@ public String toString()

[GitHub] [kafka] msilb commented on pull request #1596: KAFKA-1543: Change replication factor during partition map generation

2020-06-09 Thread GitBox
msilb commented on pull request #1596: URL: https://github.com/apache/kafka/pull/1596#issuecomment-641312887 I see the parent issue has been open since 2014. Any idea when this finally is going to be implemented? This is an

[GitHub] [kafka] mjsax commented on pull request #8788: MINOR: Remove unused isSticky assert out from tests only do constrainedAssign

2020-06-09 Thread GitBox
mjsax commented on pull request #8788: URL: https://github.com/apache/kafka/pull/8788#issuecomment-640741662 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] kkonstantine commented on pull request #7384: KAFKA-8938 - Connect - Improve Allocations During Struct Validation

2020-06-09 Thread GitBox
kkonstantine commented on pull request #7384: URL: https://github.com/apache/kafka/pull/7384#issuecomment-641103428 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Updated] (KAFKA-9923) Join window store duplicates can be compacted in changelog

2020-06-09 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-9923: --- Fix Version/s: (was: 2.6.0) > Join window store duplicates can be compacted in ch

[jira] [Resolved] (KAFKA-9923) Join window store duplicates can be compacted in changelog

2020-06-09 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman resolved KAFKA-9923. Resolution: Not A Problem [~cadonna] pointed out that this actually ins't a problem

[GitHub] [kafka] mjsax commented on pull request #8803: KAFKA-10102: update ProcessorTopology instead of rebuilding it

2020-06-09 Thread GitBox
mjsax commented on pull request #8803: URL: https://github.com/apache/kafka/pull/8803#issuecomment-640934234 Merged to `trunk` and cherry-picked to `2.6` branch. This is an automated message from the Apache Git Service. To re

[GitHub] [kafka] ijuma commented on a change in pull request #7929: KAFKA-9393: DeleteRecords may cause extreme lock contention for large partition directories

2020-06-09 Thread GitBox
ijuma commented on a change in pull request #7929: URL: https://github.com/apache/kafka/pull/7929#discussion_r436792477 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -2237,7 +2209,11 @@ class Log(@volatile private var _dir: File, def deleteSegments(): Unit =

[GitHub] [kafka] junrao commented on a change in pull request #8680: KAFKA-10027: Implement read path for feature versioning system (KIP-584)

2020-06-09 Thread GitBox
junrao commented on a change in pull request #8680: URL: https://github.com/apache/kafka/pull/8680#discussion_r437049072 ## File path: core/src/main/scala/kafka/zk/ZkData.scala ## @@ -81,17 +83,26 @@ object BrokerIdsZNode { object BrokerInfo { /** - * Create a broker in

[GitHub] [kafka] chia7712 opened a new pull request #8837: KAFKA-10125 The partition which is removing should be considered to b…

2020-06-09 Thread GitBox
chia7712 opened a new pull request #8837: URL: https://github.com/apache/kafka/pull/8837 When a reassignment is still in progress, the replica which is either removing or adding should be considered to be under reassignment. However, TopicCommand still print the partition which is removing

[GitHub] [kafka] hachikuji merged pull request #8802: MINOR: Fix fetch session epoch comment in `FetchRequest.json`

2020-06-09 Thread GitBox
hachikuji merged pull request #8802: URL: https://github.com/apache/kafka/pull/8802 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] vvcephei commented on pull request #8764: KAFKA-10049: Fixed FKJ bug where wrapped serdes are set incorrectly when using default StreamsConfig serdes

2020-06-09 Thread GitBox
vvcephei commented on pull request #8764: URL: https://github.com/apache/kafka/pull/8764#issuecomment-640686536 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [kafka] Lucent-Wong commented on pull request #8453: KAFKA-9841: Connector and Task duplicated when a worker join with old…

2020-06-09 Thread GitBox
Lucent-Wong commented on pull request #8453: URL: https://github.com/apache/kafka/pull/8453#issuecomment-641192263 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [kafka] bbejeck commented on pull request #8823: MINOR: fix HTML markup

2020-06-09 Thread GitBox
bbejeck commented on pull request #8823: URL: https://github.com/apache/kafka/pull/8823#issuecomment-640729994 Merged #8823 into trunk. This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [kafka] sneakyburro commented on pull request #8752: KAFKA-10036 early check singleton ProcessorSupplier and improve docs

2020-06-09 Thread GitBox
sneakyburro commented on pull request #8752: URL: https://github.com/apache/kafka/pull/8752#issuecomment-640936812 > @sneakyburro -- Just a heads up: code freeze for 2.6 release in on Wednesday. If you want to get the PR into the release, please address the review comments soon. Otherwise,

[GitHub] [kafka] ableegoldman commented on a change in pull request #8818: KAFKA-10086: Integration test for ensuring warmups are effective

2020-06-09 Thread GitBox
ableegoldman commented on a change in pull request #8818: URL: https://github.com/apache/kafka/pull/8818#discussion_r436825265 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -86,7 +87,7 @@ private boolean rebalanceI

[GitHub] [kafka] mjsax commented on pull request #8752: KAFKA-10036 early check singleton ProcessorSupplier and improve docs

2020-06-09 Thread GitBox
mjsax commented on pull request #8752: URL: https://github.com/apache/kafka/pull/8752#issuecomment-640935840 @sneakyburro -- Just a heads up: code freeze for 2.6 release in on Wednesday. If you want to get the PR into the release, please address the review comments soon. Otherwise, this wi

[GitHub] [kafka] rgroothuijsen commented on a change in pull request #8664: KAFKA-9716: Clarify meaning of compression rate metrics

2020-06-09 Thread GitBox
rgroothuijsen commented on a change in pull request #8664: URL: https://github.com/apache/kafka/pull/8664#discussion_r436973523 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/internals/SenderMetricsRegistry.java ## @@ -84,7 +84,7 @@ public SenderMetricsR

[GitHub] [kafka] abbccdda commented on a change in pull request #8834: MINOR: Do not disable heartbeat during Rebalance

2020-06-09 Thread GitBox
abbccdda commented on a change in pull request #8834: URL: https://github.com/apache/kafka/pull/8834#discussion_r437110527 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinatorTest.java ## @@ -604,6 +605,25 @@ public void testSync

[GitHub] [kafka] chia7712 opened a new pull request #8838: MINOR: fix flaky TopicCommandWithAdminClientTest.testDescribeUnderRep…

2020-06-09 Thread GitBox
chia7712 opened a new pull request #8838: URL: https://github.com/apache/kafka/pull/8838 ```TopicCommandWithAdminClientTest.testDescribeUnderReplicatedPartitionsWhenReassignmentIsInProgress``` fails frequently on my local. ### Committer Checklist (excluded from commit message) -

[GitHub] [kafka] omkreddy merged pull request #8800: MINOR: Fix incorrect GC log size with JDK9+

2020-06-09 Thread GitBox
omkreddy merged pull request #8800: URL: https://github.com/apache/kafka/pull/8800 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] Lucent-Wong edited a comment on pull request #8453: KAFKA-9841: Connector and Task duplicated when a worker join with old…

2020-06-09 Thread GitBox
Lucent-Wong edited a comment on pull request #8453: URL: https://github.com/apache/kafka/pull/8453#issuecomment-641192263 Looks like the build failure is not related with my changes. > Task :streams:test-utils:integrationTest > Task :streams:upgrade-system-tests-0100:integr

[GitHub] [kafka] kkonstantine commented on a change in pull request #8805: KAFKA-9848: Avoid triggering scheduled rebalance delay when task assignment fails but Connect workers remain in the group

2020-06-09 Thread GitBox
kkonstantine commented on a change in pull request #8805: URL: https://github.com/apache/kafka/pull/8805#discussion_r436950305 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java ## @@ -159,6 +163,13 @@ p

[GitHub] [kafka] guozhangwang merged pull request #8676: KAFKA-10005: Decouple RestoreListener from RestoreCallback

2020-06-09 Thread GitBox
guozhangwang merged pull request #8676: URL: https://github.com/apache/kafka/pull/8676 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] hachikuji merged pull request #8783: KAFKA-10063 UnsupportedOperation when querying cleaner metrics after …

2020-06-09 Thread GitBox
hachikuji merged pull request #8783: URL: https://github.com/apache/kafka/pull/8783 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] ableegoldman commented on a change in pull request #8676: KAFKA-10005: Decouple RestoreListener from RestoreCallback

2020-06-09 Thread GitBox
ableegoldman commented on a change in pull request #8676: URL: https://github.com/apache/kafka/pull/8676#discussion_r436858916 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ChangelogRegister.java ## @@ -34,7 +34,6 @@ /** * Unregist

[GitHub] [kafka] mjsax commented on pull request #8821: [DO NOT MERGE] Reenable flaky EosBetaUpgradeIntegrationTest

2020-06-09 Thread GitBox
mjsax commented on pull request #8821: URL: https://github.com/apache/kafka/pull/8821#issuecomment-641022736 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] guozhangwang opened a new pull request #8834: MINOR: Do not disable heartbeat during Rebalance

2020-06-09 Thread GitBox
guozhangwang opened a new pull request #8834: URL: https://github.com/apache/kafka/pull/8834 1. Allow the heartbeat thread to send hb request during rebalance; in turn when handling responses if the state is not in STABLE ignore the error. 2. Piggy-backing a log4j improvement on the

[GitHub] [kafka] bob-barrett commented on a change in pull request #8239: KAFKA-9666: Don't increase transactional epoch when trying to fence if the log append fails

2020-06-09 Thread GitBox
bob-barrett commented on a change in pull request #8239: URL: https://github.com/apache/kafka/pull/8239#discussion_r437077452 ## File path: core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala ## @@ -487,6 +487,33 @@ class TransactionCoordinator(broke

[GitHub] [kafka] feyman2016 opened a new pull request #8832: KAFKA-9377: Refactor StreamsPartitionAssignor Repartition Count Logic

2020-06-09 Thread GitBox
feyman2016 opened a new pull request #8832: URL: https://github.com/apache/kafka/pull/8832 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade

  1   2   >