ableegoldman commented on a change in pull request #8676:
URL: https://github.com/apache/kafka/pull/8676#discussion_r436858916


##########
File path: 
streams/src/main/java/org/apache/kafka/streams/processor/internals/ChangelogRegister.java
##########
@@ -34,7 +34,6 @@
     /**
      * Unregisters and removes the passed in partitions from the set of 
changelogs
      * @param removedPartitions the set of partitions to remove
-     * @param triggerOnRestoreEnd whether to trigger the onRestoreEnd callback
      */
-    void unregister(final Collection<TopicPartition> removedPartitions, final 
boolean triggerOnRestoreEnd);
+    void unregister(final Collection<TopicPartition> removedPartitions);

Review comment:
       Nice, this was kind of an ugly hack to being with so I'm happy to see it 
go




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to