chia7712 opened a new pull request #8599:
URL: https://github.com/apache/kafka/pull/8599
this is a bug of scala 2.12
(https://github.com/scala/bug/issues/10418#issuecomment-524582693).
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
chia7712 commented on pull request #8599:
URL: https://github.com/apache/kafka/pull/8599#issuecomment-622284362
It seems to me it would be better to have a QA for java 11 + scala 2.12 if
the it is still supported by kafka community.
chia7712 edited a comment on pull request #8599:
URL: https://github.com/apache/kafka/pull/8599#issuecomment-622284362
It seems to me it would be better to have a QA for java 11 + scala 2.12 if
it is still supported by kafka community.
-
[
https://issues.apache.org/jira/browse/KAFKA-9825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dulvin Witharane reassigned KAFKA-9825:
---
Assignee: Dulvin Witharane
> Kafka protocol BNF format should have some way to displ
d8tltanc commented on pull request #8527:
URL: https://github.com/apache/kafka/pull/8527#issuecomment-622330041
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
feyman2016 commented on pull request #8589:
URL: https://github.com/apache/kafka/pull/8589#issuecomment-622372958
oh, sorry I didn't run the Checkstyle and spotbugs quality checks locally, I
will update shortly with these fixed
-
feyman2016 commented on pull request #8589:
URL: https://github.com/apache/kafka/pull/8589#issuecomment-622417550
Retest this please.
This is an automated message from the Apache Git Service.
To respond to the message, please
vvcephei commented on pull request #8597:
URL: https://github.com/apache/kafka/pull/8597#issuecomment-622421983
Failing test
org.apache.kafka.streams.integration.GlobalKTableIntegrationTest.shouldKStreamGlobalKTableLeftJoin
is already under investigation.
vvcephei commented on pull request #8595:
URL: https://github.com/apache/kafka/pull/8595#issuecomment-622422628
The only failing test this time was
org.apache.kafka.streams.integration.GlobalKTableIntegrationTest.shouldKStreamGlobalKTableLeftJoin,
which is already under investigation.
--
[
https://issues.apache.org/jira/browse/KAFKA-3184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097430#comment-17097430
]
Nikolay Izhikov commented on KAFKA-3184:
[~mjsax]
Can we use ".store" extension
Lucas Bradstreet created KAFKA-9946:
---
Summary: KAFKA-9539/StopReplicaRequest deletePartition changes may
cause premature topic deletion handling in controller
Key: KAFKA-9946
URL: https://issues.apache.org/jira/
[
https://issues.apache.org/jira/browse/KAFKA-9946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lucas Bradstreet reassigned KAFKA-9946:
---
Assignee: David Jacot
> KAFKA-9539/StopReplicaRequest deletePartition changes may ca
[
https://issues.apache.org/jira/browse/KAFKA-9543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097516#comment-17097516
]
Jason Gustafson commented on KAFKA-9543:
I am going to go ahead and close this is
[
https://issues.apache.org/jira/browse/KAFKA-9543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson updated KAFKA-9543:
---
Affects Version/s: 2.5.0
2.4.1
> Consumer offset reset after new segme
[
https://issues.apache.org/jira/browse/KAFKA-9543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson resolved KAFKA-9543.
Fix Version/s: 2.5.1
2.4.2
Resolution: Fixed
> Consumer offset re
[
https://issues.apache.org/jira/browse/KAFKA-8803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097539#comment-17097539
]
Guozhang Wang commented on KAFKA-8803:
--
[~waykarp] It's a bit tricky to reproduce si
hachikuji commented on pull request #8586:
URL: https://github.com/apache/kafka/pull/8586#issuecomment-622487766
@edoardocomar Thanks for the comment. I agree it is related. Left a comment
on #4204.
This is an automated mess
hachikuji commented on a change in pull request #4204:
URL: https://github.com/apache/kafka/pull/4204#discussion_r418652324
##
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##
@@ -1035,11 +1035,13 @@ class ReplicaManager(val config: KafkaConfig,
val pa
hachikuji commented on a change in pull request #8586:
URL: https://github.com/apache/kafka/pull/8586#discussion_r418653376
##
File path: core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala
##
@@ -1017,6 +1018,51 @@ class ReplicaManagerTest {
assertEquals(Errors
hachikuji commented on a change in pull request #8586:
URL: https://github.com/apache/kafka/pull/8586#discussion_r418655368
##
File path: core/src/test/scala/unit/kafka/server/SimpleFetchTest.scala
##
@@ -1,206 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) u
ConcurrencyPractitioner commented on pull request #7884:
URL: https://github.com/apache/kafka/pull/7884#issuecomment-622490343
@hachikuji Do you have time to review? Just give me a heads-up if there are
some comments left addressed.
ConcurrencyPractitioner edited a comment on pull request #7884:
URL: https://github.com/apache/kafka/pull/7884#issuecomment-622490343
@hachikuji Do you have time to review? Just give me a heads-up if there are
some comments left unaddressed.
---
[
https://issues.apache.org/jira/browse/KAFKA-9633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konstantine Karantasis updated KAFKA-9633:
--
Fix Version/s: 2.5.1
2.6.0
> ConfigProvider.close() not call
[
https://issues.apache.org/jira/browse/KAFKA-3184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097581#comment-17097581
]
Matthias J. Sax commented on KAFKA-3184:
Works for me. But we can also discuss on
mjsax commented on a change in pull request #8565:
URL: https://github.com/apache/kafka/pull/8565#discussion_r418678556
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/QueryableStateIntegrationTest.java
##
@@ -1262,6 +1266,7 @@ public void run() {
mjsax commented on a change in pull request #8565:
URL: https://github.com/apache/kafka/pull/8565#discussion_r418679194
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/QueryableStateIntegrationTest.java
##
@@ -631,7 +631,11 @@ public void shouldAllowCo
ijuma commented on a change in pull request #8586:
URL: https://github.com/apache/kafka/pull/8586#discussion_r418679953
##
File path: core/src/test/scala/unit/kafka/server/SimpleFetchTest.scala
##
@@ -1,206 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under
mjsax commented on a change in pull request #8540:
URL: https://github.com/apache/kafka/pull/8540#discussion_r418681001
##
File path: streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java
##
@@ -327,15 +331,15 @@ private void prepareStreamThread(final StreamThrea
ijuma commented on a change in pull request #4204:
URL: https://github.com/apache/kafka/pull/4204#discussion_r418680839
##
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##
@@ -1035,11 +1035,13 @@ class ReplicaManager(val config: KafkaConfig,
val partit
mjsax commented on pull request #8540:
URL: https://github.com/apache/kafka/pull/8540#issuecomment-622513778
@vvcephei Cherry-picking to 2.4 did not work? There might still be a 2.4.2
releae.
This is an automated message fro
mjsax edited a comment on pull request #8540:
URL: https://github.com/apache/kafka/pull/8540#issuecomment-622513778
@vvcephei Cherry-picking to 2.4 did not work? There might still be a 2.4.2
release? Or should we not back-port it to 2.4 because in 2.4 one can in fact
run an empty topology?
vvcephei commented on pull request #8595:
URL: https://github.com/apache/kafka/pull/8595#issuecomment-622527480
Thanks, @mjsax !
This is an automated message from the Apache Git Service.
To respond to the message, please log
hachikuji commented on a change in pull request #4204:
URL: https://github.com/apache/kafka/pull/4204#discussion_r418702601
##
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##
@@ -1035,11 +1035,13 @@ class ReplicaManager(val config: KafkaConfig,
val pa
hachikuji commented on a change in pull request #4204:
URL: https://github.com/apache/kafka/pull/4204#discussion_r418702601
##
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##
@@ -1035,11 +1035,13 @@ class ReplicaManager(val config: KafkaConfig,
val pa
hachikuji commented on a change in pull request #8586:
URL: https://github.com/apache/kafka/pull/8586#discussion_r418718645
##
File path: core/src/test/scala/unit/kafka/server/SimpleFetchTest.scala
##
@@ -1,206 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) u
mjsax commented on pull request #8496:
URL: https://github.com/apache/kafka/pull/8496#issuecomment-622557984
Java 8 passed.
Java 11:
`org.apache.kafka.streams.integration.GlobalKTableIntegrationTest.shouldKStreamGlobalKTableLeftJoin`
Java 14:
```
kafka.api.PlaintextConsumerTest.
[
https://issues.apache.org/jira/browse/KAFKA-8120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Wang reassigned KAFKA-8120:
---
Assignee: Jun Wang
> Getting NegativeArraySizeException when using Kafka Connect to send data to
>
hachikuji commented on pull request #8591:
URL: https://github.com/apache/kafka/pull/8591#issuecomment-622565563
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please l
vvcephei commented on a change in pull request #8593:
URL: https://github.com/apache/kafka/pull/8593#discussion_r418735906
##
File path: streams/src/test/java/org/apache/kafka/test/MockSourceNode.java
##
@@ -48,7 +48,7 @@ public void process(final K key, final V value) {
}
mjsax opened a new pull request #8600:
URL: https://github.com/apache/kafka/pull/8600
Most changes thus improve the error message output in case a test fails.
Potential fix: remove producer config `retries=1`
Call for review @guozhangwang
mjsax commented on a change in pull request #8600:
URL: https://github.com/apache/kafka/pull/8600#discussion_r418737835
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/GlobalKTableEOSIntegrationTest.java
##
@@ -304,59 +382,64 @@ private void startStrea
hachikuji commented on a change in pull request #8591:
URL: https://github.com/apache/kafka/pull/8591#discussion_r418741006
##
File path: core/src/test/scala/unit/kafka/security/authorizer/AclEntryTest.scala
##
@@ -23,27 +23,28 @@ import org.apache.kafka.common.acl.AclOperation
[
https://issues.apache.org/jira/browse/KAFKA-7224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097684#comment-17097684
]
John Roesler commented on KAFKA-7224:
-
Hi all,
Thanks for the good points all around
mjsax commented on pull request #8496:
URL: https://github.com/apache/kafka/pull/8496#issuecomment-622579708
Rebase this PR -- failed before, because the `ProcessorContext` "generics"
commit was reverted.
This is an automate
hachikuji commented on pull request #8577:
URL: https://github.com/apache/kafka/pull/8577#issuecomment-622580718
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please l
hachikuji commented on a change in pull request #8570:
URL: https://github.com/apache/kafka/pull/8570#discussion_r418756784
##
File path: clients/src/main/java/org/apache/kafka/clients/admin/ConfigEntry.java
##
@@ -99,7 +100,7 @@ public String name() {
/**
* Return t
hachikuji commented on a change in pull request #8551:
URL: https://github.com/apache/kafka/pull/8551#discussion_r418759371
##
File path:
clients/src/main/java/org/apache/kafka/common/security/ssl/SslFactory.java
##
@@ -230,6 +231,11 @@ public SslEngineFactory sslEngineFactory
[
https://issues.apache.org/jira/browse/KAFKA-8122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax reassigned KAFKA-8122:
--
Assignee: Matthias J. Sax
> Flaky Test EosIntegrationTest#shouldNotViolateEosIfOneTask
[
https://issues.apache.org/jira/browse/KAFKA-9896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax reassigned KAFKA-9896:
--
Assignee: Matthias J. Sax
> Flaky Test
> StandbyTaskEOSIntegrationTest#surviveWithOne
hachikuji commented on pull request #8551:
URL: https://github.com/apache/kafka/pull/8551#issuecomment-622590281
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please l
hachikuji commented on pull request #8586:
URL: https://github.com/apache/kafka/pull/8586#issuecomment-622593285
The 32 test failures on jdk11 were due to threads being left behind after a
failure in `TransactionsBounceTest`. I will submit a separate fix for this. The
other failure seems t
[
https://issues.apache.org/jira/browse/KAFKA-9939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson resolved KAFKA-9939.
Fix Version/s: 2.6.0
Resolution: Fixed
> Fetch request metrics are updated twice for
[
https://issues.apache.org/jira/browse/KAFKA-9939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson updated KAFKA-9939:
---
Affects Version/s: 2.5.0
> Fetch request metrics are updated twice for delayed fetches
>
ableegoldman edited a comment on pull request #8596:
URL: https://github.com/apache/kafka/pull/8596#issuecomment-622218685
Kicked off the version probing system test since I'm mucking around in the
rebalance triggering code and log messages, and I've broken it that way before
😅 : https://j
ijuma commented on a change in pull request #8591:
URL: https://github.com/apache/kafka/pull/8591#discussion_r418766141
##
File path: core/src/main/scala/kafka/utils/Json.scala
##
@@ -35,16 +35,7 @@ object Json {
*/
def parseFull(input: String): Option[JsonValue] =
Revi
vvcephei commented on a change in pull request #8248:
URL: https://github.com/apache/kafka/pull/8248#discussion_r414837565
##
File path: checkstyle/suppressions.xml
##
@@ -156,7 +156,7 @@
files="(TopologyBuilder|KafkaStreams|KStreamImpl|KTableImpl|StreamThread|S
vvcephei commented on a change in pull request #8248:
URL: https://github.com/apache/kafka/pull/8248#discussion_r418767753
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/StandbyTaskCreationIntegrationTest.java
##
@@ -148,6 +161,82 @@ public void
shou
vvcephei commented on a change in pull request #8588:
URL: https://github.com/apache/kafka/pull/8588#discussion_r418768140
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/TaskAssignorConvergenceTest.java
##
@@ -358,6 +369,57 @@ priva
guozhangwang commented on a change in pull request #8565:
URL: https://github.com/apache/kafka/pull/8565#discussion_r418768692
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/QueryableStateIntegrationTest.java
##
@@ -1262,6 +1266,7 @@ public void run()
guozhangwang commented on pull request #8565:
URL: https://github.com/apache/kafka/pull/8565#issuecomment-622602829
@mjsax thanks for the review! Addressed your comments.
This is an automated message from the Apache Git Servi
Jason Gustafson created KAFKA-9947:
--
Summary: TransactionsBounceTest may leave threads running
Key: KAFKA-9947
URL: https://issues.apache.org/jira/browse/KAFKA-9947
Project: Kafka
Issue Type
[
https://issues.apache.org/jira/browse/KAFKA-8122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097736#comment-17097736
]
Matthias J. Sax commented on KAFKA-8122:
Closing this test if favor of https://is
cmccabe commented on pull request #8527:
URL: https://github.com/apache/kafka/pull/8527#issuecomment-622610148
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
[
https://issues.apache.org/jira/browse/KAFKA-8122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax resolved KAFKA-8122.
Resolution: Fixed
> Flaky Test EosIntegrationTest#shouldNotViolateEosIfOneTaskFailsWithStat
ijuma commented on a change in pull request #8591:
URL: https://github.com/apache/kafka/pull/8591#discussion_r418778470
##
File path: core/src/main/scala/kafka/utils/Json.scala
##
@@ -35,16 +35,7 @@ object Json {
*/
def parseFull(input: String): Option[JsonValue] =
Revi
ijuma commented on a change in pull request #8591:
URL: https://github.com/apache/kafka/pull/8591#discussion_r418778603
##
File path: core/src/main/scala/kafka/utils/Json.scala
##
@@ -35,16 +35,7 @@ object Json {
*/
def parseFull(input: String): Option[JsonValue] =
Revi
cmccabe opened a new pull request #8601:
URL: https://github.com/apache/kafka/pull/8601
duplicate of https://github.com/apache/kafka/pull/8527 to get jenkins run
This is an automated message from the Apache Git Service.
To re
ableegoldman commented on a change in pull request #8248:
URL: https://github.com/apache/kafka/pull/8248#discussion_r418780240
##
File path: checkstyle/suppressions.xml
##
@@ -156,7 +156,7 @@
files="(TopologyBuilder|KafkaStreams|KStreamImpl|KTableImpl|StreamThre
ableegoldman commented on a change in pull request #8248:
URL: https://github.com/apache/kafka/pull/8248#discussion_r418780890
##
File path: checkstyle/suppressions.xml
##
@@ -156,7 +156,7 @@
files="(TopologyBuilder|KafkaStreams|KStreamImpl|KTableImpl|StreamThre
mjsax commented on a change in pull request #8248:
URL: https://github.com/apache/kafka/pull/8248#discussion_r418782542
##
File path: checkstyle/suppressions.xml
##
@@ -156,7 +156,7 @@
files="(TopologyBuilder|KafkaStreams|KStreamImpl|KTableImpl|StreamThread|Stre
mjsax commented on pull request #8589:
URL: https://github.com/apache/kafka/pull/8589#issuecomment-622614438
@feyman2016 Only committers can trigger Jenkins retesting...
Retest this please.
This is an automated message
mjsax commented on pull request #8020:
URL: https://github.com/apache/kafka/pull/8020#issuecomment-622615014
@feyman2016 closing this PR in favor of #8589 -- I assume it's a replacement.
This is an automated message from the
hachikuji opened a new pull request #8602:
URL: https://github.com/apache/kafka/pull/8602
This test case should ensure that clients and the bounce scheduler get
shutdown properly.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
-
mjsax commented on a change in pull request #8550:
URL: https://github.com/apache/kafka/pull/8550#discussion_r418784189
##
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamRepartitionTest.java
##
@@ -104,6 +114,54 @@ public void shouldInvokePa
ableegoldman commented on pull request #8596:
URL: https://github.com/apache/kafka/pull/8596#issuecomment-622628637
Also cc @mjsax for some feedback on making the rebalancing comprehensible in
system test logs
This is an aut
ableegoldman commented on a change in pull request #8596:
URL: https://github.com/apache/kafka/pull/8596#discussion_r418788022
##
File path: streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java
##
@@ -877,7 +877,7 @@
public static final String
STREAMS_MET
mjsax commented on pull request #8589:
URL: https://github.com/apache/kafka/pull/8589#issuecomment-622630109
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please log o
mjsax commented on pull request #8550:
URL: https://github.com/apache/kafka/pull/8550#issuecomment-622630031
Retest this please.
This is an automated message from the Apache Git Service.
To respond to the message, please log
ableegoldman commented on a change in pull request #8596:
URL: https://github.com/apache/kafka/pull/8596#discussion_r418791000
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##
@@ -556,14 +548,8 @@ void runLoop() {
w
ableegoldman commented on a change in pull request #8596:
URL: https://github.com/apache/kafka/pull/8596#discussion_r418792433
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java
##
@@ -907,6 +905,17 @@ private void po
ableegoldman commented on a change in pull request #8596:
URL: https://github.com/apache/kafka/pull/8596#discussion_r418793917
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java
##
@@ -1338,7 +1346,7 @@ public void on
ableegoldman commented on a change in pull request #8596:
URL: https://github.com/apache/kafka/pull/8596#discussion_r418793644
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java
##
@@ -1009,14 +1018,18 @@ private void
ableegoldman commented on a change in pull request #8596:
URL: https://github.com/apache/kafka/pull/8596#discussion_r418794862
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java
##
@@ -1423,22 +1434,44 @@ public void
mjsax commented on pull request #8596:
URL: https://github.com/apache/kafka/pull/8596#issuecomment-622632765
Retest this please.
This is an automated message from the Apache Git Service.
To respond to the message, please log
mjsax commented on a change in pull request #8483:
URL: https://github.com/apache/kafka/pull/8483#discussion_r418809026
##
File path:
streams/test-utils/src/test/java/org/apache/kafka/streams/TopologyTestDriverTest.java
##
@@ -450,6 +452,24 @@ public void shouldThrowForUnknown
mjsax commented on pull request #8483:
URL: https://github.com/apache/kafka/pull/8483#issuecomment-622648248
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please log o
mjsax commented on pull request #8555:
URL: https://github.com/apache/kafka/pull/8555#issuecomment-622648385
I am not familiar with this code. Maybe @mumrah or @cmccabe can help?
This is an automated message from the Apache G
mjsax edited a comment on pull request #8504:
URL: https://github.com/apache/kafka/pull/8504#issuecomment-618073161
> Ideally, the fix should be to generate a repartition topic name each time
to avoid such issues. But IMHO that ship has already sailed because by
introducing a new name gene
zhaohaidao commented on a change in pull request #8550:
URL: https://github.com/apache/kafka/pull/8550#discussion_r418813975
##
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamRepartitionTest.java
##
@@ -104,6 +114,54 @@ public void shouldInv
zhaohaidao commented on a change in pull request #8550:
URL: https://github.com/apache/kafka/pull/8550#discussion_r418814943
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java
##
@@ -633,6 +634,43 @@ public final void
zhaohaidao commented on a change in pull request #8550:
URL: https://github.com/apache/kafka/pull/8550#discussion_r418815217
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java
##
@@ -633,6 +634,43 @@ public final void
zhaohaidao commented on a change in pull request #8550:
URL: https://github.com/apache/kafka/pull/8550#discussion_r418815490
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java
##
@@ -633,6 +634,43 @@ public final void
zhaohaidao commented on a change in pull request #8550:
URL: https://github.com/apache/kafka/pull/8550#discussion_r418816470
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java
##
@@ -633,6 +634,43 @@ public final void
zhaohaidao commented on a change in pull request #8550:
URL: https://github.com/apache/kafka/pull/8550#discussion_r418817105
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java
##
@@ -633,6 +634,43 @@ public final void
mjsax commented on a change in pull request #8504:
URL: https://github.com/apache/kafka/pull/8504#discussion_r418818822
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java
##
@@ -989,16 +994,18 @@ private void to(final TopicNameExtra
zhaohaidao commented on a change in pull request #8550:
URL: https://github.com/apache/kafka/pull/8550#discussion_r418820500
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java
##
@@ -633,6 +634,43 @@ public final void
mjsax commented on pull request #8504:
URL: https://github.com/apache/kafka/pull/8504#issuecomment-622651059
> we should create two repartiton topics as that's what the user is
expecting.
Is she? I guess it's clearly document that the name is use for repartition
topics, too, but it
zhaohaidao commented on pull request #8550:
URL: https://github.com/apache/kafka/pull/8550#issuecomment-622651191
> Retest this please.
@mjsax I have modified the codes according to your suggestion and passed the
test. Could you continue to review it?
--
mjsax commented on pull request #8520:
URL: https://github.com/apache/kafka/pull/8520#issuecomment-622651340
Don't worry about it. Not a big deal.
This is an automated message from the Apache Git Service.
To respond to the me
mjsax edited a comment on pull request #8550:
URL: https://github.com/apache/kafka/pull/8550#issuecomment-622651723
Thanks for the update. I'll wait for Jenkins and do another pass afterwards.
This is an automated message fro
1 - 100 of 132 matches
Mail list logo
