ableegoldman commented on a change in pull request #8248:
URL: https://github.com/apache/kafka/pull/8248#discussion_r418780890
##########
File path: checkstyle/suppressions.xml
##########
@@ -156,7 +156,7 @@
files="(TopologyBuilder|KafkaStreams|KStreamImpl|KTableImpl|StreamThread|StreamTask).java"/>
<suppress checks="MethodLength"
- files="(KTableImpl|StreamsPartitionAssignor.java)"/>
+ files="(KTableImpl|StreamsPartitionAssignor|TaskManager).java"/>
Review comment:
Kidding aside, Guozhang keeps telling me that @mjsax is (or is about to
be) working on a PR to clean up the TaskManager. I wanted to keep the conflicts
to a minimum, and refactoring this into smaller methods that Matthias will just
have to pick apart in his PR (or mine, depending on who merges first) didn't
seem like a good use of anyone's time. Would you be satisfied if I made a
ticket for myself to loop back around once everyone's done mucking in the
TaskManager and do any remaining cleanup?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
