ableegoldman commented on a change in pull request #8248:
URL: https://github.com/apache/kafka/pull/8248#discussion_r418780240
##########
File path: checkstyle/suppressions.xml
##########
@@ -156,7 +156,7 @@
files="(TopologyBuilder|KafkaStreams|KStreamImpl|KTableImpl|StreamThread|StreamTask).java"/>
<suppress checks="MethodLength"
- files="(KTableImpl|StreamsPartitionAssignor.java)"/>
+ files="(KTableImpl|StreamsPartitionAssignor|TaskManager).java"/>
Review comment:
Man, this is like being the person to finish the tequila bottle and
having to eat the worm. Everyone's been adding to
`TaskManager#handleAssignment` a few lines at a time and I was the lucky one to
push it over the checkstyle edge 🍀
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
