Re: [PR] MINOR: Use readable interface to parse response [kafka]

jsancio merged PR #19353: URL: https://github.com/apache/kafka/pull/19353 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] MINOR: Use readable interface to parse response [kafka]

soondenana commented on code in PR #19353: URL: https://github.com/apache/kafka/pull/19353#discussion_r2056704680 ## clients/src/main/java/org/apache/kafka/common/protocol/Readable.java: ## @@ -38,6 +38,7 @@ public interface Readable { int readVarint(); long readVarlon

Re: [PR] MINOR: Use readable interface to parse response [kafka]

jsancio commented on code in PR #19353: URL: https://github.com/apache/kafka/pull/19353#discussion_r2056567679 ## clients/src/main/java/org/apache/kafka/common/requests/AbstractResponse.java: ## @@ -110,7 +111,7 @@ public static AbstractResponse parseResponse(ByteBuffer buffer,

Re: [PR] MINOR: Use readable interface to parse response [kafka]

jsancio commented on code in PR #19353: URL: https://github.com/apache/kafka/pull/19353#discussion_r2056561313 ## clients/src/main/java/org/apache/kafka/common/protocol/Readable.java: ## @@ -38,6 +38,7 @@ public interface Readable { int readVarint(); long readVarlong()

Re: [PR] MINOR: Use readable interface to parse response [kafka]

soondenana commented on code in PR #19353: URL: https://github.com/apache/kafka/pull/19353#discussion_r2052926304 ## clients/src/main/java/org/apache/kafka/common/requests/ApiVersionsResponse.java: ## @@ -152,19 +151,19 @@ public boolean zkMigrationReady() { return data

Re: [PR] MINOR: Use readable interface to parse response [kafka]

jsancio commented on code in PR #19353: URL: https://github.com/apache/kafka/pull/19353#discussion_r2052833219 ## clients/src/main/java/org/apache/kafka/common/requests/ApiVersionsResponse.java: ## @@ -152,19 +151,19 @@ public boolean zkMigrationReady() { return data.zk

Re: [PR] MINOR: Use readable interface to parse response [kafka]

jsancio commented on code in PR #19353: URL: https://github.com/apache/kafka/pull/19353#discussion_r2052834226 ## clients/src/main/java/org/apache/kafka/common/requests/AbstractResponse.java: ## @@ -106,189 +107,189 @@ public static AbstractResponse parseResponse(ByteBuffer buf

Re: [PR] MINOR: Use readable interface to parse response [kafka]

soondenana commented on PR #19353: URL: https://github.com/apache/kafka/pull/19353#issuecomment-2807429706 > Thanks for the change @soondenana . > > There are conflicts with the PR. The PR description doesn't match the code changes. For example, I cannot find this new ReadableBuf inte

Re: [PR] MINOR: Use readable interface to parse response [kafka]

jsancio commented on PR #19353: URL: https://github.com/apache/kafka/pull/19353#issuecomment-2806749061 Thanks for the change @soondenana . There are conflicts with the PR. The PR description doesn't match the code changes. For example, I cannot find this new ReadableBuf interface.

Re: [PR] MINOR: Use readable interface to parse response [kafka]

soondenana commented on code in PR #19353: URL: https://github.com/apache/kafka/pull/19353#discussion_r2029411205 ## clients/src/main/java/org/apache/kafka/common/protocol/ReadableBuf.java: ## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] MINOR: Use readable interface to parse response [kafka]

soondenana commented on code in PR #19353: URL: https://github.com/apache/kafka/pull/19353#discussion_r2029411205 ## clients/src/main/java/org/apache/kafka/common/protocol/ReadableBuf.java: ## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] MINOR: Use readable interface to parse response [kafka]

soondenana commented on code in PR #19353: URL: https://github.com/apache/kafka/pull/19353#discussion_r2029411205 ## clients/src/main/java/org/apache/kafka/common/protocol/ReadableBuf.java: ## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] MINOR: Use readable interface to parse response [kafka]

soondenana commented on code in PR #19353: URL: https://github.com/apache/kafka/pull/19353#discussion_r2029411205 ## clients/src/main/java/org/apache/kafka/common/protocol/ReadableBuf.java: ## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] MINOR: Use readable interface to parse response [kafka]

ditac commented on code in PR #19353: URL: https://github.com/apache/kafka/pull/19353#discussion_r2029310683 ## clients/src/main/java/org/apache/kafka/common/protocol/ReadableBuf.java: ## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] MINOR: Use readable interface to parse response [kafka]

soondenana commented on code in PR #19353: URL: https://github.com/apache/kafka/pull/19353#discussion_r2029166476 ## clients/src/main/java/org/apache/kafka/common/requests/AbstractResponse.java: ## @@ -51,8 +53,8 @@ final ByteBuffer serializeWithHeader(ResponseHeader header, sh

Re: [PR] MINOR: Use readable interface to parse response [kafka]

trnguyencflt commented on code in PR #19353: URL: https://github.com/apache/kafka/pull/19353#discussion_r2029055199 ## clients/src/main/java/org/apache/kafka/common/requests/AbstractResponse.java: ## @@ -51,8 +53,8 @@ final ByteBuffer serializeWithHeader(ResponseHeader header,

Re: [PR] MINOR: Use readable interface to parse response [kafka]

trnguyencflt commented on PR #19353: URL: https://github.com/apache/kafka/pull/19353#issuecomment-2779128261 [nit] Please remove this block "Delete this text " from the description of the PR. Otherwise, LGTM -- This is an automated message from the Apache Git Service. To respon