soondenana commented on PR #19353: URL: https://github.com/apache/kafka/pull/19353#issuecomment-2807429706
> Thanks for the change @soondenana . > > There are conflicts with the PR. The PR description doesn't match the code changes. For example, I cannot find this new ReadableBuf interface. Rebased, couple of parse methods (in FetchResponse and ShareFetchResponse) had comments added, which caused conflict. Also, updated the commit description. Original version of the commit I had tried to solve the issue by adding a new interface, but that does more than just "refactoring" so took that out and went with simpler approach. However, missed updating the comment in commit for that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
