Re: [PR] MINOR: update truncation test [kafka]

2025-02-24 Thread via GitHub
chia7712 commented on PR #18952: URL: https://github.com/apache/kafka/pull/18952#issuecomment-2679582515 I don't cherry-pick it to 4.0, as ELR is disabled by default in 4.0 (see #18954) -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [PR] MINOR: update truncation test [kafka]

2025-02-24 Thread via GitHub
chia7712 merged PR #18952: URL: https://github.com/apache/kafka/pull/18952 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] MINOR: update truncation test [kafka]

2025-02-24 Thread via GitHub
CalvinConfluent commented on code in PR #18952: URL: https://github.com/apache/kafka/pull/18952#discussion_r1968100708 ## tests/kafkatest/tests/client/truncation_test.py: ## @@ -112,7 +117,10 @@ def none_consumed(this, consumer): pre_truncation_pos = consumer.current_

Re: [PR] MINOR: update truncation test [kafka]

2025-02-22 Thread via GitHub
chia7712 commented on code in PR #18952: URL: https://github.com/apache/kafka/pull/18952#discussion_r197621 ## tests/kafkatest/tests/client/truncation_test.py: ## @@ -112,7 +117,10 @@ def none_consumed(this, consumer): pre_truncation_pos = consumer.current_positio

Re: [PR] MINOR: update truncation test [kafka]

2025-02-21 Thread via GitHub
CalvinConfluent commented on code in PR #18952: URL: https://github.com/apache/kafka/pull/18952#discussion_r1966276275 ## tests/kafkatest/tests/client/truncation_test.py: ## @@ -112,7 +117,10 @@ def none_consumed(this, consumer): pre_truncation_pos = consumer.current_

Re: [PR] MINOR: update truncation test [kafka]

2025-02-21 Thread via GitHub
cmccabe commented on PR #18952: URL: https://github.com/apache/kafka/pull/18952#issuecomment-2675559965 @CalvinConfluent Still one question left to answer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] MINOR: update truncation test [kafka]

2025-02-21 Thread via GitHub
cmccabe commented on code in PR #18952: URL: https://github.com/apache/kafka/pull/18952#discussion_r1966179174 ## tests/kafkatest/tests/client/truncation_test.py: ## @@ -112,7 +117,10 @@ def none_consumed(this, consumer): pre_truncation_pos = consumer.current_position

Re: [PR] MINOR: update truncation test [kafka]

2025-02-21 Thread via GitHub
CalvinConfluent commented on PR #18952: URL: https://github.com/apache/kafka/pull/18952#issuecomment-2675332313 @dajac @cmccabe Can you help take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] MINOR: update truncation test [kafka]

2025-02-20 Thread via GitHub
CalvinConfluent commented on PR #18952: URL: https://github.com/apache/kafka/pull/18952#issuecomment-2672189787 testBalancePartitionLeaders can pass in local. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] MINOR: update truncation test [kafka]

2025-02-19 Thread via GitHub
CalvinConfluent commented on code in PR #18952: URL: https://github.com/apache/kafka/pull/18952#discussion_r1962165856 ## tests/kafkatest/tests/client/truncation_test.py: ## @@ -112,7 +117,10 @@ def none_consumed(this, consumer): pre_truncation_pos = consumer.current_

Re: [PR] MINOR: update truncation test [kafka]

2025-02-19 Thread via GitHub
dajac commented on code in PR #18952: URL: https://github.com/apache/kafka/pull/18952#discussion_r1962052021 ## tests/kafkatest/tests/client/truncation_test.py: ## @@ -112,7 +117,10 @@ def none_consumed(this, consumer): pre_truncation_pos = consumer.current_position(t

[PR] Minor: update truncation test [kafka]

2025-02-18 Thread via GitHub
CalvinConfluent opened a new pull request, #18952: URL: https://github.com/apache/kafka/pull/18952 Adjust the behavior accordingly for the KIP-966 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to