CalvinConfluent commented on code in PR #18952:
URL: https://github.com/apache/kafka/pull/18952#discussion_r1962165856
##########
tests/kafkatest/tests/client/truncation_test.py:
##########
@@ -112,7 +117,10 @@ def none_consumed(this, consumer):
pre_truncation_pos = consumer.current_position(tp)
- self.kafka.set_unclean_leader_election(self.TOPIC)
Review Comment:
`set_unclean_leader_election` sets the `unclean.leader.election.enable`
config to true. It is the same if we set this config when creating the topic.
Creating the topic with the config so that the unclean election can trigger
by this
[event](https://github.com/apache/kafka/pull/18952/files#diff-6cfdf3acb5e73d7f00b0319316f4c22fda76f0e7b5fff4c6bfdd2e395dc08498R115).
In the old way, election happens
[here](https://github.com/apache/kafka/pull/18952/files#diff-6cfdf3acb5e73d7f00b0319316f4c22fda76f0e7b5fff4c6bfdd2e395dc08498R127)
which is no longer possible if use `wait_until` to wait for the unclean leader
election.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
