cmccabe commented on code in PR #18952:
URL: https://github.com/apache/kafka/pull/18952#discussion_r1966179174


##########
tests/kafkatest/tests/client/truncation_test.py:
##########
@@ -112,7 +117,10 @@ def none_consumed(this, consumer):
 
         pre_truncation_pos = consumer.current_position(tp)
 
-        self.kafka.set_unclean_leader_election(self.TOPIC)

Review Comment:
   Is the idea that it's simpler to create the topic with this configuration 
than set it later? If so then the answer is "we could still use this, but we 
don't want to"?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to