Re: [PR] MINOR: clean KafkaConsumer tests [kafka]

2025-06-05 Thread via GitHub
mjsax merged PR #19669: URL: https://github.com/apache/kafka/pull/19669 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] MINOR: clean KafkaConsumer tests [kafka]

2025-05-28 Thread via GitHub
m1a2st commented on code in PR #19669: URL: https://github.com/apache/kafka/pull/19669#discussion_r2112188223 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -913,16 +914,16 @@ public void verifyNoCoordinatorLookupForManualAssignmentWith

Re: [PR] MINOR: clean KafkaConsumer tests [kafka]

2025-05-28 Thread via GitHub
m1a2st commented on code in PR #19669: URL: https://github.com/apache/kafka/pull/19669#discussion_r2112188223 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -913,16 +914,16 @@ public void verifyNoCoordinatorLookupForManualAssignmentWith

Re: [PR] MINOR: clean KafkaConsumer tests [kafka]

2025-05-28 Thread via GitHub
mjsax commented on PR #19669: URL: https://github.com/apache/kafka/pull/19669#issuecomment-2916686542 @lianetm @FrankYang0529 -- could I get a final review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] MINOR: clean KafkaConsumer tests [kafka]

2025-05-16 Thread via GitHub
mjsax commented on code in PR #19669: URL: https://github.com/apache/kafka/pull/19669#discussion_r2093828163 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -1959,17 +1963,19 @@ public void testCloseShouldBeIdempotent(GroupProtocol group

Re: [PR] MINOR: clean KafkaConsumer tests [kafka]

2025-05-16 Thread via GitHub
lianetm commented on code in PR #19669: URL: https://github.com/apache/kafka/pull/19669#discussion_r2093503258 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -1842,12 +1845,12 @@ public void testOffsetOfPausedPartitions(GroupProtocol gr

Re: [PR] MINOR: clean KafkaConsumer tests [kafka]

2025-05-16 Thread via GitHub
lianetm commented on code in PR #19669: URL: https://github.com/apache/kafka/pull/19669#discussion_r2093503258 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -1842,12 +1845,12 @@ public void testOffsetOfPausedPartitions(GroupProtocol gr

Re: [PR] MINOR: clean KafkaConsumer tests [kafka]

2025-05-13 Thread via GitHub
m1a2st commented on code in PR #19669: URL: https://github.com/apache/kafka/pull/19669#discussion_r2086701640 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -913,16 +914,16 @@ public void verifyNoCoordinatorLookupForManualAssignmentWith

Re: [PR] MINOR: clean KafkaConsumer tests [kafka]

2025-05-10 Thread via GitHub
mjsax commented on PR #19669: URL: https://github.com/apache/kafka/pull/19669#issuecomment-2869374025 Thanks for the review. Updated the PR and left a few replies. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] MINOR: clean KafkaConsumer tests [kafka]

2025-05-10 Thread via GitHub
mjsax commented on code in PR #19669: URL: https://github.com/apache/kafka/pull/19669#discussion_r2083381608 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -3505,6 +3524,7 @@ public void testClientInstanceIdNoTelemetryReporterRegistered

Re: [PR] MINOR: clean KafkaConsumer tests [kafka]

2025-05-10 Thread via GitHub
mjsax commented on code in PR #19669: URL: https://github.com/apache/kafka/pull/19669#discussion_r2083381645 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -3513,6 +3533,7 @@ public void testEmptyGroupId(GroupProtocol groupProtocol) {

Re: [PR] MINOR: clean KafkaConsumer tests [kafka]

2025-05-10 Thread via GitHub
mjsax commented on code in PR #19669: URL: https://github.com/apache/kafka/pull/19669#discussion_r2083381315 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -2253,44 +2262,49 @@ public void testPollAuthenticationFailure(GroupProtocol gro

Re: [PR] MINOR: clean KafkaConsumer tests [kafka]

2025-05-10 Thread via GitHub
mjsax commented on code in PR #19669: URL: https://github.com/apache/kafka/pull/19669#discussion_r2083381191 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -2209,26 +2215,29 @@ public void testPartitionsForNonExistingTopic(GroupProtocol

Re: [PR] MINOR: clean KafkaConsumer tests [kafka]

2025-05-10 Thread via GitHub
mjsax commented on code in PR #19669: URL: https://github.com/apache/kafka/pull/19669#discussion_r208338 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -1959,17 +1963,19 @@ public void testCloseShouldBeIdempotent(GroupProtocol group

Re: [PR] MINOR: clean KafkaConsumer tests [kafka]

2025-05-10 Thread via GitHub
mjsax commented on code in PR #19669: URL: https://github.com/apache/kafka/pull/19669#discussion_r2083380718 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -404,11 +405,11 @@ public void testPollReturnsRecords(GroupProtocol groupProtoco

Re: [PR] MINOR: clean KafkaConsumer tests [kafka]

2025-05-10 Thread via GitHub
mjsax commented on code in PR #19669: URL: https://github.com/apache/kafka/pull/19669#discussion_r2083380270 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -404,11 +405,11 @@ public void testPollReturnsRecords(GroupProtocol groupProtoco

Re: [PR] MINOR: clean KafkaConsumer tests [kafka]

2025-05-10 Thread via GitHub
Yunyung commented on code in PR #19669: URL: https://github.com/apache/kafka/pull/19669#discussion_r2083239520 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -404,11 +405,11 @@ public void testPollReturnsRecords(GroupProtocol groupProto

Re: [PR] MINOR: clean KafkaConsumer tests [kafka]

2025-05-10 Thread via GitHub
FrankYang0529 commented on code in PR #19669: URL: https://github.com/apache/kafka/pull/19669#discussion_r2083217276 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -2253,44 +2262,49 @@ public void testPollAuthenticationFailure(GroupProto

Re: [PR] MINOR: clean KafkaConsumer tests [kafka]

2025-05-10 Thread via GitHub
FrankYang0529 commented on code in PR #19669: URL: https://github.com/apache/kafka/pull/19669#discussion_r2083214975 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -404,11 +405,11 @@ public void testPollReturnsRecords(GroupProtocol grou

Re: [PR] MINOR: clean KafkaConsumer tests [kafka]

2025-05-10 Thread via GitHub
m1a2st commented on code in PR #19669: URL: https://github.com/apache/kafka/pull/19669#discussion_r2083125691 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -2674,8 +2690,8 @@ public void testCurrentLag(GroupProtocol groupProtocol) thro

Re: [PR] MINOR: clean KafkaConsumer tests [kafka]

2025-05-09 Thread via GitHub
mjsax commented on code in PR #19669: URL: https://github.com/apache/kafka/pull/19669#discussion_r2082807506 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java: ## @@ -1647,7 +1648,7 @@ private Properties requiredConsumerConfigAndGro

Re: [PR] MINOR: clean KafkaConsumer tests [kafka]

2025-05-09 Thread via GitHub
mjsax commented on code in PR #19669: URL: https://github.com/apache/kafka/pull/19669#discussion_r2082807269 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -3445,6 +3463,7 @@ public void testBeginningOffsetsTimeout(GroupProtocol groupPr

Re: [PR] MINOR: clean KafkaConsumer tests [kafka]

2025-05-09 Thread via GitHub
mjsax commented on code in PR #19669: URL: https://github.com/apache/kafka/pull/19669#discussion_r2082807236 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -3425,6 +3441,7 @@ public void testAssignorNameConflict(GroupProtocol groupProto

[PR] MINOR: clean KafkaConsumer tests [kafka]

2025-05-09 Thread via GitHub
mjsax opened a new pull request, #19669: URL: https://github.com/apache/kafka/pull/19669 - Moving off deprecated methods - Fixing argument order for assertEquals(...) - Few other minor cleanups -- This is an automated message from the Apache Git Service. To respond to the message, pl