m1a2st commented on code in PR #19669:
URL: https://github.com/apache/kafka/pull/19669#discussion_r2083125691
##########
clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java:
##########
@@ -2674,8 +2690,8 @@ public void testCurrentLag(GroupProtocol groupProtocol)
throws InterruptedExcept
final ConsumerRecords<String, String> records =
(ConsumerRecords<String, String>) consumer.poll(Duration.ofMillis(1));
assertEquals(5, records.count());
assertEquals(55L, consumer.position(tp0));
- assertEquals(records.nextOffsets().size(), 1);
- assertEquals(records.nextOffsets().get(tp0), new
OffsetAndMetadata(55L, Optional.empty(), ""));
+ assertEquals(1, records.nextOffsets().size());
+ assertEquals(new OffsetAndMetadata(55L, Optional.empty(), ""),
records.nextOffsets().get(tp0));
// correct lag result
assertEquals(OptionalLong.of(45L), consumer.currentLag(tp0));
Review Comment:
Could you also fix the indentation at line 3277?
##########
clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java:
##########
@@ -3725,7 +3746,7 @@ void testMonitorablePlugins(GroupProtocol groupProtocol) {
assertTrue(metrics.containsKey(expectedInterceptorMetric));
Review Comment:
This `testMonitorablePlugins` missed to use `GroupProtocol` in the consumer
config, could you also update the test for different protocol
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
