Re: [PR] MINOR: Small refactor in TargetAssignmentBuilder [kafka]

2024-06-03 Thread via GitHub
dajac commented on PR #16174: URL: https://github.com/apache/kafka/pull/16174#issuecomment-2145877229 Merged to trunk and to 3.8. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] MINOR: Small refactor in TargetAssignmentBuilder [kafka]

2024-06-03 Thread via GitHub
dajac merged PR #16174: URL: https://github.com/apache/kafka/pull/16174 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] MINOR: Small refactor in TargetAssignmentBuilder [kafka]

2024-06-03 Thread via GitHub
chia7712 commented on code in PR #16174: URL: https://github.com/apache/kafka/pull/16174#discussion_r1624733788 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilder.java: ## @@ -64,11 +64,11 @@ public static class TargetAssignmen

Re: [PR] MINOR: Small refactor in TargetAssignmentBuilder [kafka]

2024-06-03 Thread via GitHub
dajac commented on code in PR #16174: URL: https://github.com/apache/kafka/pull/16174#discussion_r1624718677 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilder.java: ## @@ -64,11 +64,11 @@ public static class TargetAssignmentRe

Re: [PR] MINOR: Small refactor in TargetAssignmentBuilder [kafka]

2024-06-03 Thread via GitHub
chia7712 commented on code in PR #16174: URL: https://github.com/apache/kafka/pull/16174#discussion_r1624601766 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilder.java: ## @@ -64,11 +64,11 @@ public static class TargetAssignmen

Re: [PR] MINOR: Small refactor in TargetAssignmentBuilder [kafka]

2024-06-03 Thread via GitHub
dajac commented on code in PR #16174: URL: https://github.com/apache/kafka/pull/16174#discussion_r1624578908 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilder.java: ## @@ -64,11 +64,11 @@ public static class TargetAssignmentRe

Re: [PR] MINOR: Small refactor in TargetAssignmentBuilder [kafka]

2024-06-03 Thread via GitHub
dajac commented on code in PR #16174: URL: https://github.com/apache/kafka/pull/16174#discussion_r1624578908 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilder.java: ## @@ -64,11 +64,11 @@ public static class TargetAssignmentRe

Re: [PR] MINOR: Small refactor in TargetAssignmentBuilder [kafka]

2024-06-03 Thread via GitHub
chia7712 commented on code in PR #16174: URL: https://github.com/apache/kafka/pull/16174#discussion_r1624569720 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilder.java: ## @@ -64,11 +64,11 @@ public static class TargetAssignmen

[PR] MINOR: Small refactor in TargetAssignmentBuilder [kafka]

2024-06-03 Thread via GitHub
dajac opened a new pull request, #16174: URL: https://github.com/apache/kafka/pull/16174 This patch is a small refactoring which mainly aims at avoid to construct a copy of the new target assignment in the TargetAssignmentBuilder because the copy is not used by the caller. The change relies