dajac merged PR #19556:
URL: https://github.com/apache/kafka/pull/19556
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
dajac opened a new pull request, #19556:
URL: https://github.com/apache/kafka/pull/19556
This patches moves the static request validations from the
`GroupMetadataManager` to the `GroupCoordinatorService`. We already had static
validation in the service for other requests so it makes sense t
dajac commented on code in PR #19556:
URL: https://github.com/apache/kafka/pull/19556#discussion_r2059776612
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupCoordinatorServiceTest.java:
##
@@ -279,6 +291,162 @@ public void testConsumerGroupHeartbeatWit
dajac commented on code in PR #19556:
URL: https://github.com/apache/kafka/pull/19556#discussion_r2059775996
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupCoordinatorServiceTest.java:
##
@@ -224,7 +226,12 @@ public void testConsumerGroupHeartbeat() t
dajac commented on code in PR #19556:
URL: https://github.com/apache/kafka/pull/19556#discussion_r2059775113
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##
@@ -397,6 +478,65 @@ public
CompletableFuture consumerGroupHeartb
dajac commented on code in PR #19556:
URL: https://github.com/apache/kafka/pull/19556#discussion_r2059774587
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##
@@ -367,6 +389,55 @@ public int partitionFor(
return Utils
