dajac commented on code in PR #19556:
URL: https://github.com/apache/kafka/pull/19556#discussion_r2059775113
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##########
@@ -397,6 +478,65 @@ public
CompletableFuture<ConsumerGroupHeartbeatResponseData> consumerGroupHeartb
));
}
+ private static void throwIfInvalidTopology(
Review Comment:
Those two are also copy of the original methods with any changes.
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##########
@@ -435,6 +589,28 @@ public CompletableFuture<StreamsGroupHeartbeatResult>
streamsGroupHeartbeat(
));
}
+ /**
+ * Validates the ShareGroupHeartbeat request.
+ *
+ * @param request The request to validate.
+ * @throws InvalidRequestException if the request is not valid.
+ */
+ private static void throwIfShareGroupHeartbeatRequestIsInvalid(
Review Comment:
ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
