dajac commented on code in PR #19556:
URL: https://github.com/apache/kafka/pull/19556#discussion_r2059774587


##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##########
@@ -367,6 +389,55 @@ public int partitionFor(
         return Utils.abs(groupId.hashCode()) % numPartitions;
     }
 
+    /**
+     * Validates the request.
+     *
+     * @param request The request to validate.
+     * @param apiVersion The version of ConsumerGroupHeartbeat RPC
+     * @throws InvalidRequestException if the request is not valid.
+     * @throws UnsupportedAssignorException if the assignor is not supported.
+     */
+    private void throwIfConsumerGroupHeartbeatRequestIsInvalid(

Review Comment:
   This is a copy of the method that was in the manager. The only difference is 
`!consumerGroupAssignors.contains(request.serverAssignor())`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to