Re: [PR] MINOR: Fix some Request toString methods [kafka]

cmccabe merged PR #19655: URL: https://github.com/apache/kafka/pull/19655 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] MINOR: Fix some Request toString methods [kafka]

cmccabe commented on PR #19655: URL: https://github.com/apache/kafka/pull/19655#issuecomment-2868119153 I see one test failure that I think is a flake: ``` FAILED ❌ AuthorizerIntegrationTest > "testShareGroupDescribeWithGroupDescribeAndTopicDescribeAcl(String).quorum=kip932" ``` -

Re: [PR] MINOR: Fix some Request toString methods [kafka]

cmccabe commented on PR #19655: URL: https://github.com/apache/kafka/pull/19655#issuecomment-2867818949 lgtm, but there is a checkstyle error -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] MINOR: Fix some Request toString methods [kafka]

ahuang98 commented on code in PR #19655: URL: https://github.com/apache/kafka/pull/19655#discussion_r2082371275 ## clients/src/main/java/org/apache/kafka/common/requests/AlterUserScramCredentialsRequest.java: ## @@ -81,4 +81,23 @@ public AbstractResponse getErrorResponse(int thr

Re: [PR] MINOR: Fix some Request toString methods [kafka]

ahuang98 commented on code in PR #19655: URL: https://github.com/apache/kafka/pull/19655#discussion_r2082371275 ## clients/src/main/java/org/apache/kafka/common/requests/AlterUserScramCredentialsRequest.java: ## @@ -81,4 +81,23 @@ public AbstractResponse getErrorResponse(int thr

Re: [PR] MINOR: Fix some Request toString methods [kafka]

ahuang98 commented on code in PR #19655: URL: https://github.com/apache/kafka/pull/19655#discussion_r2082371275 ## clients/src/main/java/org/apache/kafka/common/requests/AlterUserScramCredentialsRequest.java: ## @@ -81,4 +81,23 @@ public AbstractResponse getErrorResponse(int thr

Re: [PR] MINOR: Fix some Request toString methods [kafka]

ahuang98 commented on code in PR #19655: URL: https://github.com/apache/kafka/pull/19655#discussion_r2082367943 ## clients/src/main/java/org/apache/kafka/common/requests/IncrementalAlterConfigsRequest.java: ## @@ -106,4 +107,35 @@ public AbstractResponse getErrorResponse(final i

Re: [PR] MINOR: Fix some Request toString methods [kafka]

ahuang98 commented on code in PR #19655: URL: https://github.com/apache/kafka/pull/19655#discussion_r2078445956 ## clients/src/main/java/org/apache/kafka/common/requests/IncrementalAlterConfigsRequest.java: ## @@ -106,4 +107,35 @@ public AbstractResponse getErrorResponse(final i

Re: [PR] MINOR: Fix some Request toString methods [kafka]

ahuang98 commented on code in PR #19655: URL: https://github.com/apache/kafka/pull/19655#discussion_r2078444388 ## clients/src/main/java/org/apache/kafka/common/requests/IncrementalAlterConfigsRequest.java: ## @@ -106,4 +107,35 @@ public AbstractResponse getErrorResponse(final i

Re: [PR] MINOR: Fix some Request toString methods [kafka]

cmccabe commented on code in PR #19655: URL: https://github.com/apache/kafka/pull/19655#discussion_r2078392631 ## clients/src/main/java/org/apache/kafka/common/requests/AlterUserScramCredentialsRequest.java: ## @@ -81,4 +81,23 @@ public AbstractResponse getErrorResponse(int thro

Re: [PR] MINOR: Fix some Request toString methods [kafka]

cmccabe commented on code in PR #19655: URL: https://github.com/apache/kafka/pull/19655#discussion_r2078392176 ## clients/src/main/java/org/apache/kafka/common/requests/IncrementalAlterConfigsRequest.java: ## @@ -106,4 +107,35 @@ public AbstractResponse getErrorResponse(final in

[PR] MINOR: Fix some Request toString methods [kafka]

ahuang98 opened a new pull request, #19655: URL: https://github.com/apache/kafka/pull/19655 NetworkClient logs requests and responses on the debug level - we should be careful about what we are logging. -- This is an automated message from the Apache Git Service. To respond to the message