ahuang98 commented on code in PR #19655:
URL: https://github.com/apache/kafka/pull/19655#discussion_r2078444388
##########
clients/src/main/java/org/apache/kafka/common/requests/IncrementalAlterConfigsRequest.java:
##########
@@ -106,4 +107,35 @@ public AbstractResponse getErrorResponse(final int
throttleTimeMs, final Throwab
}
return new IncrementalAlterConfigsResponse(response);
}
+
+ // It is not safe to print all config values
+ @Override
+ public String toString() {
Review Comment:
got it, I see your point about forgetting to update the toString. I had
thought this approach would be a bit more transparent than doing find-replace
on a very generic field name ('value') which may appear in the string multiple
times.
this approach should work well for `AlterUserScramCredentialsRequest` since
`salt` and `saltedPassword` are pretty unique terms.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
