cmccabe commented on code in PR #19655:
URL: https://github.com/apache/kafka/pull/19655#discussion_r2078392176
##########
clients/src/main/java/org/apache/kafka/common/requests/IncrementalAlterConfigsRequest.java:
##########
@@ -106,4 +107,35 @@ public AbstractResponse getErrorResponse(final int
throttleTimeMs, final Throwab
}
return new IncrementalAlterConfigsResponse(response);
}
+
+ // It is not safe to print all config values
+ @Override
+ public String toString() {
Review Comment:
Can we do the "copy the whole object, then replace sensitive fields with
[REDACTED]" approach here?
If we do this by hand, we'll probably forget to update it when someone adds
a new field.
Plus, this will not be efficient anyway, nor does it need to be.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
