Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-03-11 Thread via GitHub
chia7712 commented on code in PR #18961: URL: https://github.com/apache/kafka/pull/18961#discussion_r1984726423 ## docs/toc.html: ## @@ -27,7 +27,8 @@ 1.3 Quick Start 1.4 Ecosystem 1.5 Upgrading -1.6 Docker +

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-03-07 Thread via GitHub
chia7712 commented on code in PR #18961: URL: https://github.com/apache/kafka/pull/18961#discussion_r1984872155 ## docs/toc.html: ## @@ -27,7 +27,8 @@ 1.3 Quick Start 1.4 Ecosystem 1.5 Upgrading -1.6 Docker +

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-03-06 Thread via GitHub
chia7712 commented on code in PR #18961: URL: https://github.com/apache/kafka/pull/18961#discussion_r1984361932 ## docs/toc.html: ## @@ -27,7 +27,8 @@ 1.3 Quick Start 1.4 Ecosystem 1.5 Upgrading -1.6 Docker +

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-03-06 Thread via GitHub
mingdaoy commented on code in PR #18961: URL: https://github.com/apache/kafka/pull/18961#discussion_r1984173122 ## docs/toc.html: ## @@ -27,7 +27,8 @@ 1.3 Quick Start 1.4 Ecosystem 1.5 Upgrading -1.6 Docker +

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-03-06 Thread via GitHub
mingdaoy commented on code in PR #18961: URL: https://github.com/apache/kafka/pull/18961#discussion_r1984173122 ## docs/toc.html: ## @@ -27,7 +27,8 @@ 1.3 Quick Start 1.4 Ecosystem 1.5 Upgrading -1.6 Docker +

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-03-06 Thread via GitHub
mingdaoy commented on code in PR #18961: URL: https://github.com/apache/kafka/pull/18961#discussion_r1984173122 ## docs/toc.html: ## @@ -27,7 +27,8 @@ 1.3 Quick Start 1.4 Ecosystem 1.5 Upgrading -1.6 Docker +

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-03-06 Thread via GitHub
junrao commented on code in PR #18961: URL: https://github.com/apache/kafka/pull/18961#discussion_r1984102183 ## docs/toc.html: ## @@ -27,7 +27,8 @@ 1.3 Quick Start 1.4 Ecosystem 1.5 Upgrading -1.6 Docker +

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-25 Thread via GitHub
chia7712 commented on PR #18961: URL: https://github.com/apache/kafka/pull/18961#issuecomment-2683361926 have checked the PR on 4.0 manually. cherry-pick to 4.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-25 Thread via GitHub
chia7712 merged PR #18961: URL: https://github.com/apache/kafka/pull/18961 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-25 Thread via GitHub
ijuma commented on PR #18961: URL: https://github.com/apache/kafka/pull/18961#issuecomment-2683347392 > I have updated the guidance based on your reminder Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-25 Thread via GitHub
chia7712 commented on PR #18961: URL: https://github.com/apache/kafka/pull/18961#issuecomment-2682694371 > @chia7712 Can we please share this guidance with your group? I have updated the guidance based on your reminder. I apologize for our oversight. -- This is an automated message

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-25 Thread via GitHub
frankvicky commented on code in PR #18961: URL: https://github.com/apache/kafka/pull/18961#discussion_r1970081741 ## docs/upgrade.html: ## @@ -62,7 +62,6 @@ Notable changes in 4 the software and metadata versions must be at least 3.3.x (the first version when KRaft

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-25 Thread via GitHub
frankvicky commented on PR #18961: URL: https://github.com/apache/kafka/pull/18961#issuecomment-2682401786 Sorry @ijuma I will fix it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-25 Thread via GitHub
ijuma commented on PR #18961: URL: https://github.com/apache/kafka/pull/18961#issuecomment-2682396517 The last force push seems to have gone back to an old state. Also, I said this elsewhere, but force pushing PRs that are under review is not good practice. @chia7712 Can we please share thi

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-25 Thread via GitHub
ijuma commented on code in PR #18961: URL: https://github.com/apache/kafka/pull/18961#discussion_r1970023789 ## docs/upgrade.html: ## @@ -62,7 +62,6 @@ Notable changes in 4 the software and metadata versions must be at least 3.3.x (the first version when KRaft mode

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-22 Thread via GitHub
frankvicky commented on PR #18961: URL: https://github.com/apache/kafka/pull/18961#issuecomment-2676573182 Preview: ![Screenshot from 2025-02-23 12-56-26](https://github.com/user-attachments/assets/cd5f06a2-26dd-4872-865c-bed6324da2d4) -- This is an automated message from the A

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-22 Thread via GitHub
ijuma commented on code in PR #18961: URL: https://github.com/apache/kafka/pull/18961#discussion_r1966611062 ## docs/zk2kraft.html: ## @@ -15,14 +15,17 @@ limitations under the License. --> - - - - + + + -Significant Change

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-22 Thread via GitHub
ijuma commented on code in PR #18961: URL: https://github.com/apache/kafka/pull/18961#discussion_r1966538143 ## docs/upgrade.html: ## @@ -61,8 +61,7 @@ Notable changes in 4 Apache Kafka 4.0 only supports KRaft mode - ZooKeeper mode has been removed. As such, broker

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-22 Thread via GitHub
m1a2st commented on code in PR #18961: URL: https://github.com/apache/kafka/pull/18961#discussion_r1966539348 ## docs/toc.html: ## @@ -27,7 +27,8 @@ 1.3 Quick Start 1.4 Ecosystem 1.5 Upgrading -1.6 Docker +

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-22 Thread via GitHub
frankvicky commented on code in PR #18961: URL: https://github.com/apache/kafka/pull/18961#discussion_r1966539300 ## docs/zk2kraft.html: ## @@ -15,14 +15,17 @@ limitations under the License. --> - - - - + + + -Significant C

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-22 Thread via GitHub
frankvicky commented on code in PR #18961: URL: https://github.com/apache/kafka/pull/18961#discussion_r1966539300 ## docs/zk2kraft.html: ## @@ -15,14 +15,17 @@ limitations under the License. --> - - - - + + + -Significant C

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-22 Thread via GitHub
frankvicky commented on code in PR #18961: URL: https://github.com/apache/kafka/pull/18961#discussion_r1966538457 ## docs/upgrade.html: ## @@ -61,8 +61,7 @@ Notable changes in 4 Apache Kafka 4.0 only supports KRaft mode - ZooKeeper mode has been removed. As such, b

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-22 Thread via GitHub
ijuma commented on code in PR #18961: URL: https://github.com/apache/kafka/pull/18961#discussion_r1966538256 ## docs/zk2kraft.html: ## @@ -15,14 +15,17 @@ limitations under the License. --> - - - - + + + -Significant Change

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-22 Thread via GitHub
ijuma commented on code in PR #18961: URL: https://github.com/apache/kafka/pull/18961#discussion_r1966538017 ## docs/upgrade.html: ## @@ -62,7 +62,6 @@ Notable changes in 4 the software and metadata versions must be at least 3.3.x (the first version when KRaft mode

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-22 Thread via GitHub
frankvicky commented on code in PR #18961: URL: https://github.com/apache/kafka/pull/18961#discussion_r1966533946 ## docs/upgrade.html: ## @@ -62,7 +62,6 @@ Notable changes in 4 the software and metadata versions must be at least 3.3.x (the first version when KRaft

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-22 Thread via GitHub
frankvicky commented on PR #18961: URL: https://github.com/apache/kafka/pull/18961#issuecomment-2676263110 Preview: ![image](https://github.com/user-attachments/assets/8656a660-4dd7-4aba-881f-d0c12a472b79) ![Screenshot from 2025-02-22 23-30-22](https://github.com/user-attachments/asse

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-21 Thread via GitHub
ijuma commented on code in PR #18961: URL: https://github.com/apache/kafka/pull/18961#discussion_r1966039052 ## docs/upgrade.html: ## @@ -62,7 +62,6 @@ Notable changes in 4 the software and metadata versions must be at least 3.3.x (the first version when KRaft mode

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-21 Thread via GitHub
ijuma commented on code in PR #18961: URL: https://github.com/apache/kafka/pull/18961#discussion_r1966036719 ## docs/upgrade.html: ## @@ -62,7 +62,6 @@ Notable changes in 4 the software and metadata versions must be at least 3.3.x (the first version when KRaft mode

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-21 Thread via GitHub
chia7712 commented on PR #18961: URL: https://github.com/apache/kafka/pull/18961#issuecomment-2675249040 @frankvicky please update the description (screenshot) after you change the layout -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-21 Thread via GitHub
chia7712 commented on code in PR #18961: URL: https://github.com/apache/kafka/pull/18961#discussion_r1965109724 ## docs/toc.html: ## @@ -27,6 +27,9 @@ 1.3 Quick Start 1.4 Ecosystem 1.5 Upgrading + +

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-21 Thread via GitHub
frankvicky commented on code in PR #18961: URL: https://github.com/apache/kafka/pull/18961#discussion_r1965165305 ## docs/toc.html: ## @@ -27,6 +27,9 @@ 1.3 Quick Start 1.4 Ecosystem 1.5 Upgrading + +

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-21 Thread via GitHub
frankvicky commented on code in PR #18961: URL: https://github.com/apache/kafka/pull/18961#discussion_r1965154499 ## docs/toc.html: ## @@ -27,6 +27,9 @@ 1.3 Quick Start 1.4 Ecosystem 1.5 Upgrading + +

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-21 Thread via GitHub
chia7712 commented on code in PR #18961: URL: https://github.com/apache/kafka/pull/18961#discussion_r1965108766 ## docs/toc.html: ## @@ -27,6 +27,9 @@ 1.3 Quick Start 1.4 Ecosystem 1.5 Upgrading + +

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-19 Thread via GitHub
m1a2st commented on code in PR #18961: URL: https://github.com/apache/kafka/pull/18961#discussion_r1962771254 ## docs/zk2kraft.html: ## @@ -15,14 +15,17 @@ limitations under the License. --> - - - - + + + -Significant Chang

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-19 Thread via GitHub
frankvicky commented on PR #18961: URL: https://github.com/apache/kafka/pull/18961#issuecomment-2670312682 In order to the future section of `Kraft related-features`, I have slightly modified the content of `zk2kraft`: ![Screenshot from 2025-02-20 10-27-52](https://github.com/user-attach

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-19 Thread via GitHub
chia7712 commented on PR #18961: URL: https://github.com/apache/kafka/pull/18961#issuecomment-2670280840 > Create a page with a title: "Differences between kraft mode and zk mode". This page exists in trunk/4.0 and describes the differences between both. This is useful for anyone that is fa

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-19 Thread via GitHub
ijuma commented on PR #18961: URL: https://github.com/apache/kafka/pull/18961#issuecomment-2669547889 I merged a change to `upgrade.html`, it would be good to resolve the conflicts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-19 Thread via GitHub
mingdaoy commented on code in PR #18961: URL: https://github.com/apache/kafka/pull/18961#discussion_r1961901627 ## docs/toc.html: ## @@ -27,6 +27,9 @@ 1.3 Quick Start 1.4 Ecosystem 1.5 Upgrading + +

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-19 Thread via GitHub
ijuma commented on PR #18961: URL: https://github.com/apache/kafka/pull/18961#issuecomment-2668763269 I was thinking that this information is related to the migration from zk to kraft more so than the upgrade to 4.0. We removed the zk to kraft migration docs from trunk and instead, link to

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-19 Thread via GitHub
chia7712 commented on PR #18961: URL: https://github.com/apache/kafka/pull/18961#issuecomment-2669244820 > Create a page with a title: "Differences between kraft mode and zk mode". This page exists in trunk/4.0 and describes the differences between both. This is useful for anyone that is fa

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-19 Thread via GitHub
ijuma commented on PR #18961: URL: https://github.com/apache/kafka/pull/18961#issuecomment-2669081569 > Do you mean the docs should be moved from 4.0 branch to 3.9 branch? If yes, we have to update the kafka-site too as 3.9.0 docs is on board already. Yeah, I was thinking that we woul

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-19 Thread via GitHub
mingdaoy commented on code in PR #18961: URL: https://github.com/apache/kafka/pull/18961#discussion_r1961963740 ## docs/zk2kraft.html: ## @@ -148,7 +145,7 @@ Removal Zookeeper configs -Removal metrics +Removal Zookeeper Metrics Review Comme

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-19 Thread via GitHub
mingdaoy commented on code in PR #18961: URL: https://github.com/apache/kafka/pull/18961#discussion_r1961961956 ## docs/zk2kraft.html: ## @@ -15,14 +15,11 @@ limitations under the License. --> - - - - + + + -Significant Cha

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-19 Thread via GitHub
mingdaoy commented on code in PR #18961: URL: https://github.com/apache/kafka/pull/18961#discussion_r1961963740 ## docs/zk2kraft.html: ## @@ -148,7 +145,7 @@ Removal Zookeeper configs -Removal metrics +Removal Zookeeper Metrics Review Comme

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-19 Thread via GitHub
frankvicky commented on code in PR #18961: URL: https://github.com/apache/kafka/pull/18961#discussion_r1961913572 ## docs/toc.html: ## @@ -27,6 +27,9 @@ 1.3 Quick Start 1.4 Ecosystem 1.5 Upgrading + +

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-19 Thread via GitHub
mingdaoy commented on code in PR #18961: URL: https://github.com/apache/kafka/pull/18961#discussion_r1961903913 ## docs/upgrade.html: ## @@ -45,10 +45,8 @@ Notable changes in 4 https://cwiki.apache.org/confluence/display/KAFKA/KIP-896%3A+Remove+old+client+protocol+A

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-19 Thread via GitHub
chia7712 commented on PR #18961: URL: https://github.com/apache/kafka/pull/18961#issuecomment-2668975804 > Would we want to do the same with this? Do you mean the docs should be moved from 4.0 branch to 3.9 branch? If yes, we have to update the kafka-site too as 3.9.0 docs is on board

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-19 Thread via GitHub
mingdaoy commented on code in PR #18961: URL: https://github.com/apache/kafka/pull/18961#discussion_r1961512459 ## docs/upgrade.html: ## @@ -45,10 +45,8 @@ Notable changes in 4 https://cwiki.apache.org/confluence/display/KAFKA/KIP-896%3A+Remove+old+client+protocol+A

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-19 Thread via GitHub
mingdaoy commented on code in PR #18961: URL: https://github.com/apache/kafka/pull/18961#discussion_r1960998479 ## docs/upgrade.html: ## @@ -48,7 +48,6 @@ Notable changes in 4 Before updating your Kafka cluster which build on Zookeeper to Kafka 4.0, you must unders

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-18 Thread via GitHub
frankvicky commented on code in PR #18961: URL: https://github.com/apache/kafka/pull/18961#discussion_r1961026169 ## docs/upgrade.html: ## @@ -48,7 +48,6 @@ Notable changes in 4 Before updating your Kafka cluster which build on Zookeeper to Kafka 4.0, you must unde

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-18 Thread via GitHub
mingdaoy commented on code in PR #18961: URL: https://github.com/apache/kafka/pull/18961#discussion_r1961009420 ## docs/zk2kraft.html: ## @@ -15,14 +15,13 @@ limitations under the License. --> - + + - + -Significant Cha

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-18 Thread via GitHub
mingdaoy commented on code in PR #18961: URL: https://github.com/apache/kafka/pull/18961#discussion_r1960998479 ## docs/upgrade.html: ## @@ -48,7 +48,6 @@ Notable changes in 4 Before updating your Kafka cluster which build on Zookeeper to Kafka 4.0, you must unders

[PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-18 Thread via GitHub
frankvicky opened a new pull request, #18961: URL: https://github.com/apache/kafka/pull/18961 Reference: https://github.com/apache/kafka/pull/18365/files#r1960092384 The content of `upgrade.html` has become too large. This patch moves the embedded `zk2kraft` content into a separate page