Re: [PR] KAFKA-18982: Allow ClusterTests to ignore specific thread leaks [kafka]

github-actions[bot] closed pull request #19206: KAFKA-18982: Allow ClusterTests to ignore specific thread leaks URL: https://github.com/apache/kafka/pull/19206 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] KAFKA-18982: Allow ClusterTests to ignore specific thread leaks [kafka]

github-actions[bot] commented on PR #19206: URL: https://github.com/apache/kafka/pull/19206#issuecomment-3138473795 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] KAFKA-18982: Allow ClusterTests to ignore specific thread leaks [kafka]

github-actions[bot] commented on PR #19206: URL: https://github.com/apache/kafka/pull/19206#issuecomment-3021653479 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] KAFKA-18982: Allow ClusterTests to ignore specific thread leaks [kafka]

gharris1727 commented on PR #19206: URL: https://github.com/apache/kafka/pull/19206#issuecomment-2770350587 > in short, my thinking is that `@ClusterTestThreadLeakIgnore` is no more "API" than `@ClusterTest` is I agree, the two are very similar: neither should be promoted as public AP

Re: [PR] KAFKA-18982: Allow ClusterTests to ignore specific thread leaks [kafka]

edoardocomar commented on PR #19206: URL: https://github.com/apache/kafka/pull/19206#issuecomment-2768825030 in short, my thinking is that `@ClusterTestThreadLeakIgnore` is no more "API" than `@ClusterTest` is -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] KAFKA-18982: Allow ClusterTests to ignore specific thread leaks [kafka]

edoardocomar commented on PR #19206: URL: https://github.com/apache/kafka/pull/19206#issuecomment-2768787280 this PR is not about proposing a new API to maintain. please try take the Point of view of a Kafka plugin developer. of course using code from another project (i.e. Kafka) th

Re: [PR] KAFKA-18982: Allow ClusterTests to ignore specific thread leaks [kafka]

mimaison commented on PR #19206: URL: https://github.com/apache/kafka/pull/19206#issuecomment-2755034626 I kind of agree with @gharris1727. Kafka is not using this code and this is not a public API, so this is effectively adding code to the Kafka code base just for your use case. Sure the c

Re: [PR] KAFKA-18982: Allow ClusterTests to ignore specific thread leaks [kafka]

edoardocomar commented on PR #19206: URL: https://github.com/apache/kafka/pull/19206#issuecomment-2729369615 for information only - related mini PR in a different repo https://github.com/prometheus/client_java/pull/1307 -- This is an automated message from the Apache Git Service. To respo

Re: [PR] KAFKA-18982: Allow ClusterTests to ignore specific thread leaks [kafka]

edoardocomar commented on code in PR #19206: URL: https://github.com/apache/kafka/pull/19206#discussion_r1995385172 ## test-common/test-common-internal-api/src/main/java/org/apache/kafka/common/test/api/ClusterTestThreadLeakIgnore.java: ## @@ -0,0 +1,31 @@ +/* + * Licensed to th

Re: [PR] KAFKA-18982: Allow ClusterTests to ignore specific thread leaks [kafka]

edoardocomar commented on code in PR #19206: URL: https://github.com/apache/kafka/pull/19206#discussion_r1995387744 ## test-common/test-common-internal-api/src/main/java/org/apache/kafka/common/test/api/ClusterTestThreadLeakIgnore.java: ## @@ -0,0 +1,31 @@ +/* + * Licensed to th

Re: [PR] KAFKA-18982: Allow ClusterTests to ignore specific thread leaks [kafka]

edoardocomar commented on PR #19206: URL: https://github.com/apache/kafka/pull/19206#issuecomment-2724608316 Hi @m1a2st > I would like to ask which existing tests need to ignore thread leak checks. None. This patch does not change any existing tests. The test framework has a h

Re: [PR] KAFKA-18982: Allow ClusterTests to ignore specific thread leaks [kafka]

edoardocomar commented on PR #19206: URL: https://github.com/apache/kafka/pull/19206#issuecomment-2724412970 @gharris1727 I'd like to add that the alternative to this tag for me would be running test with a patched version of the internal test library. Which is a much worse type of coupling

Re: [PR] KAFKA-18982: Allow ClusterTests to ignore specific thread leaks [kafka]

frankvicky commented on code in PR #19206: URL: https://github.com/apache/kafka/pull/19206#discussion_r1994599243 ## test-common/test-common-internal-api/src/main/java/org/apache/kafka/common/test/api/ClusterTestThreadLeakIgnore.java: ## @@ -0,0 +1,31 @@ +/* + * Licensed to the

Re: [PR] KAFKA-18982: Allow ClusterTests to ignore specific thread leaks [kafka]

edoardocomar commented on PR #19206: URL: https://github.com/apache/kafka/pull/19206#issuecomment-2722624059 > This package is an internal API, but this looks like an explicitly downstream-oriented feature. This may incorrectly promote the ClusterTest/Extensions as a public API. > I

Re: [PR] KAFKA-18982: Allow ClusterTests to ignore specific thread leaks [kafka]

edoardocomar commented on PR #19206: URL: https://github.com/apache/kafka/pull/19206#issuecomment-2722480994 @gharris1727 would you be able to take a look ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[PR] KAFKA-18982: Allow ClusterTests to ignore specific thread leaks [kafka]

edoardocomar opened a new pull request, #19206: URL: https://github.com/apache/kafka/pull/19206 Optional annotation @ClusterTestThreadLeakIgnore can be used to ignore specific thread leaks. Can be used when writing ClusterTests for optional Kafka plugins such as metric reporters.