edoardocomar commented on PR #19206: URL: https://github.com/apache/kafka/pull/19206#issuecomment-2724608316
Hi @m1a2st > I would like to ask which existing tests need to ignore thread leak checks. None. This patch does not change any existing tests. The test framework has a hardcoded list of thread prefixes to ignore for leaks see `SKIPPED_THREAD_PREFIX` in `ClusterTestExtensions.java` https://github.com/apache/kafka/blob/trunk/test-common/test-common-runtime/src/main/java/org/apache/kafka/common/test/junit/ClusterTestExtensions.java#L114-L116 Any other thread left around will cause a ClusterTest to fail. This is great, but i have been using the tags to test a metric reporter integration, and a GC notification during the test execution spun a new thread, as I detail in the JIRA associated with this PR https://issues.apache.org/jira/browse/KAFKA-18982 So in such a case, the workaround are - do not test the integration :( - use a patched test library with a larger set pof prefixes that apply to all test - use this PR to allow a specific test to tolerate some extra threads -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
