chia7712 commented on PR #19397:
URL: https://github.com/apache/kafka/pull/19397#issuecomment-2953136986
@Yunyung could you please sync trunk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
Yunyung commented on code in PR #19397:
URL: https://github.com/apache/kafka/pull/19397#discussion_r2046927417
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMakerConfig.java:
##
@@ -269,18 +270,19 @@ List configProviders() {
Map transform(Map props)
Yunyung commented on code in PR #19397:
URL: https://github.com/apache/kafka/pull/19397#discussion_r2046928161
##
clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java:
##
@@ -620,21 +621,22 @@ private Map
instantiateConfigProviders(
}
}
Yunyung commented on code in PR #19397:
URL: https://github.com/apache/kafka/pull/19397#discussion_r2034036959
##
clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java:
##
@@ -620,21 +621,22 @@ private Map
instantiateConfigProviders(
}
}
Yunyung commented on code in PR #19397:
URL: https://github.com/apache/kafka/pull/19397#discussion_r2046923569
##
clients/src/main/java/org/apache/kafka/common/config/provider/ConfigProvider.java:
##
@@ -29,6 +29,10 @@
* Kafka Connect discovers implementations of this interfac
chia7712 commented on code in PR #19397:
URL: https://github.com/apache/kafka/pull/19397#discussion_r2045026988
##
clients/src/main/java/org/apache/kafka/common/config/provider/ConfigProvider.java:
##
@@ -29,6 +29,10 @@
* Kafka Connect discovers implementations of this interfa
m1a2st commented on code in PR #19397:
URL: https://github.com/apache/kafka/pull/19397#discussion_r2033053426
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMakerConfig.java:
##
@@ -269,18 +270,19 @@ List configProviders() {
Map transform(Map props) {
Yunyung commented on code in PR #19397:
URL: https://github.com/apache/kafka/pull/19397#discussion_r2034037635
##
clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java:
##
@@ -587,14 +588,14 @@ private Map
configProviderProperties(String configProviderPrefix
Yunyung commented on code in PR #19397:
URL: https://github.com/apache/kafka/pull/19397#discussion_r2034036959
##
clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java:
##
@@ -620,21 +621,22 @@ private Map
instantiateConfigProviders(
}
}
m1a2st commented on code in PR #19397:
URL: https://github.com/apache/kafka/pull/19397#discussion_r2033040494
##
clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java:
##
@@ -620,21 +621,22 @@ private Map
instantiateConfigProviders(
}
}
m1a2st commented on PR #19397:
URL: https://github.com/apache/kafka/pull/19397#issuecomment-2783653368
Thanks for this patch, please use `./gradlew spotlessApply` fix build error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
Yunyung opened a new pull request, #19397:
URL: https://github.com/apache/kafka/pull/19397
Add [KIP-877](https://cwiki.apache.org/confluence/x/lY3GDQ) support for
ConfigProvider.
Cleanup: Collections.singletonMap() -> Map.of()
Jira: https://issues.apache.org/jira/browse/KAFKA-1
12 matches
Mail list logo
