chia7712 commented on code in PR #19397:
URL: https://github.com/apache/kafka/pull/19397#discussion_r2045026988
##########
clients/src/main/java/org/apache/kafka/common/config/provider/ConfigProvider.java:
##########
@@ -29,6 +29,10 @@
* <p>Kafka Connect discovers implementations of this interface using the Java
{@link java.util.ServiceLoader} mechanism.
* To support this, implementations of this interface should also contain a
service provider configuration file in
* {@code
META-INF/services/org.apache.kafka.common.config.provider.ConfigProvider}.
+ * <p>Implement {@link org.apache.kafka.common.metrics.Monitorable} to enable
the config provider to register metrics.
+ * The following tags are automatically added to all metrics registered:
<code>config</code> set to
Review Comment:
Currently not all config providers can be registered with `PluginMetrics`.
Could you please add docs to remind users?
##########
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMakerConfig.java:
##########
@@ -269,18 +270,19 @@ List<String> configProviders() {
Map<String, String> transform(Map<String, String> props) {
// transform worker config according to config.providers
List<String> providerNames = configProviders();
- Map<String, ConfigProvider> providers = new HashMap<>();
+ Map<String, Plugin<ConfigProvider>> providerPlugins = new HashMap<>();
for (String name : providerNames) {
- ConfigProvider configProvider = plugins.newConfigProvider(
+ Plugin<ConfigProvider> configProviderPlugin =
plugins.newConfigProvider(
this,
- CONFIG_PROVIDERS_CONFIG + "." + name,
- Plugins.ClassLoaderUsage.PLUGINS
+ name,
Review Comment:
`CONFIG_PROVIDERS_CONFIG + "." + name` is changed to `name`. Is it expected?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
