clolov merged PR #18592:
URL: https://github.com/apache/kafka/pull/18592
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o
mimaison commented on PR #18592:
URL: https://github.com/apache/kafka/pull/18592#issuecomment-2631448056
@clolov Yes, go ahead if you want to merge this. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
clolov commented on PR #18592:
URL: https://github.com/apache/kafka/pull/18592#issuecomment-2631095983
Heya @mimaison, has your last query been addressed with the latest changes?
If yes, should I continue with merging this?
--
This is an automated message from the Apache Git Service.
To r
m1a2st commented on code in PR #18592:
URL: https://github.com/apache/kafka/pull/18592#discussion_r1935526035
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -4165,14 +4165,6 @@ class ReplicaManagerTest {
val response = replicaManager.becomeLeader
ijuma commented on code in PR #18592:
URL: https://github.com/apache/kafka/pull/18592#discussion_r1934295669
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -4165,14 +4165,6 @@ class ReplicaManagerTest {
val response = replicaManager.becomeLeaderO
mimaison commented on code in PR #18592:
URL: https://github.com/apache/kafka/pull/18592#discussion_r1934233278
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -4165,14 +4165,6 @@ class ReplicaManagerTest {
val response = replicaManager.becomeLead
m1a2st commented on PR #18592:
URL: https://github.com/apache/kafka/pull/18592#issuecomment-2614013372
> The test failure, ReplicaManagerTest >
testPartitionMetadataFileCreatedWithExistingLog, seems to be related, it's also
failing when I run it locally with this PR.
Since topicId is
chia7712 commented on PR #18592:
URL: https://github.com/apache/kafka/pull/18592#issuecomment-2614001873
It will be great that we remove the optional topic id from `UnifiedLog`. We
can revisit this PR after
[KAFKA-18486](https://issues.apache.org/jira/browse/KAFKA-18486) gets resolved
-
mimaison commented on PR #18592:
URL: https://github.com/apache/kafka/pull/18592#issuecomment-2602089499
The test failure, ReplicaManagerTest >
testPartitionMetadataFileCreatedWithExistingLog, seems to be related, it's also
failing when I run it locally with this PR.
--
This is an automa
m1a2st commented on code in PR #18592:
URL: https://github.com/apache/kafka/pull/18592#discussion_r1921077261
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -1080,11 +1079,7 @@ class LogManager(logDirs: Seq[File],
log
}
- // When running a ZK con
ijuma commented on code in PR #18592:
URL: https://github.com/apache/kafka/pull/18592#discussion_r1921076950
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -1080,11 +1079,7 @@ class LogManager(logDirs: Seq[File],
log
}
- // When running a ZK cont
m1a2st commented on code in PR #18592:
URL: https://github.com/apache/kafka/pull/18592#discussion_r1921077261
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -1080,11 +1079,7 @@ class LogManager(logDirs: Seq[File],
log
}
- // When running a ZK con
ijuma commented on code in PR #18592:
URL: https://github.com/apache/kafka/pull/18592#discussion_r1921076950
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -1080,11 +1079,7 @@ class LogManager(logDirs: Seq[File],
log
}
- // When running a ZK cont
ijuma commented on code in PR #18592:
URL: https://github.com/apache/kafka/pull/18592#discussion_r1921076950
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -1080,11 +1079,7 @@ class LogManager(logDirs: Seq[File],
log
}
- // When running a ZK cont
m1a2st commented on code in PR #18592:
URL: https://github.com/apache/kafka/pull/18592#discussion_r1921073702
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -1080,11 +1079,7 @@ class LogManager(logDirs: Seq[File],
log
}
- // When running a ZK con
ijuma commented on code in PR #18592:
URL: https://github.com/apache/kafka/pull/18592#discussion_r1921067305
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -1080,11 +1079,7 @@ class LogManager(logDirs: Seq[File],
log
}
- // When running a ZK cont
m1a2st commented on code in PR #18592:
URL: https://github.com/apache/kafka/pull/18592#discussion_r1920139725
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -354,8 +354,8 @@ class LogManager(logDirs: Seq[File],
addStrayLog(topicPartition, log)
warn(s"Load
ijuma commented on code in PR #18592:
URL: https://github.com/apache/kafka/pull/18592#discussion_r1920137939
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -354,8 +354,8 @@ class LogManager(logDirs: Seq[File],
addStrayLog(topicPartition, log)
warn(s"Loade
m1a2st commented on code in PR #18592:
URL: https://github.com/apache/kafka/pull/18592#discussion_r1920098079
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -354,7 +354,7 @@ class LogManager(logDirs: Seq[File],
addStrayLog(topicPartition, log)
warn(s"Load
frankvicky commented on code in PR #18592:
URL: https://github.com/apache/kafka/pull/18592#discussion_r1920069080
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -354,7 +354,7 @@ class LogManager(logDirs: Seq[File],
addStrayLog(topicPartition, log)
warn(s"
m1a2st opened a new pull request, #18592:
URL: https://github.com/apache/kafka/pull/18592
Jira: https://issues.apache.org/jira/browse/KAFKA-18545
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build
21 matches
Mail list logo
