m1a2st commented on PR #18592: URL: https://github.com/apache/kafka/pull/18592#issuecomment-2614013372
> The test failure, ReplicaManagerTest > testPartitionMetadataFileCreatedWithExistingLog, seems to be related, it's also failing when I run it locally with this PR. Since topicId is always present in KRaft mode, and `UnifiedLog.assignTopicId` only creates a file when topicId is None, testing the file assertion is unnecessary. The test case verifying None topicId behavior should be removed for KRaft mode -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
